From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.3153.1646983740395802369 for ; Thu, 10 Mar 2022 23:29:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RoyK6KVJ; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646983740; x=1678519740; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UeT6+ytYnwBevaZZp+IlGLVoXS7j6zqx/biveqAFvzM=; b=RoyK6KVJtvX+6LrTEbQBgHyHm4ZxzCOhG3poVRY+60l/Ylt943CEn6tY j9rOVrPmC/0hjB1sSK/RavbI4coivO2WBfv6cNQkXhE/odR4+lMt9ECVv H7xIycdGv9rHymwZiVKw6qtWWDvHqzZN8SqBiBnNfvJRtYZI9n7wQyAKY SCwzX3Rw8/SZbtOhDN4Lh010U8vbxCSCCz6k5g7/vHXgvF4Puf7LBeeXs xHFJLuinXHygDpsxT81momn+zrz+rWuO8OMELata3xK1cyY0uM+CCK312 Ldv2pXg6AOAON6+8ZGWAcNMlhJKYEiZRNGyuSGAuC9uG3frw298vihX4e w==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="242967745" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="242967745" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 23:28:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="538906263" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 10 Mar 2022 23:28:59 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 23:28:59 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 23:28:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 10 Mar 2022 23:28:58 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 10 Mar 2022 23:28:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ni/cdEfBS7KMknzYeE55QfrIOqAAj9jYMrL+8UPqzazBL++6h0iObuvYaGaRGe4qjVFCTOY8/ycu8/4fMsTN+iB2Z5Fx4CaKqXrHlHeAYoA9up43QJMSH4wQdCBggjdlcpBA1X6g6aRjGGzTIlX6r6qyPkpfOLnsOm8RTsWYtYVifVRA7SA62SKMMd+XQmndvjZdxuWWzttrv377cjWZDGSSAmQ/u/rwcxcJTShAitF55MKlUf578uAgkzvHKtGTemx27LRR3U45j4dVSvSTThMI0tt+JO9mB4F8Sp/q1ZDIVW4tIVBP9VsVI9TWxv3iVH43IspPm007H3xu9FSneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ylsz4mdR4LZKqT9Vxl2en7vZ9m3L46jFv6HF3tOg4wI=; b=ZQOPS+ZZkiiQUjTn0w3NlxoVxpdRHdSi7K2gqJyOiNVuQ7rqwUDp2kwcF9ivoOViyU6rqBgEoeZPO6gy4XmfubFW8eluxc11DiQVSrKyfg5AI/Sa1FZTvMAjBvc7zBr7h9i2VKwNaR4WRiGEkJkvb+MPOzRdKJJD8C0zdf4Xjhr9SrtzIMcKo2G1kjLIZL45c/7dt2wRF4/+FsoJB+A1Fus+5N5ebStpf/vtrHsCplD8Jo4r4qLXyk+tEIeB5Np7aoib/3RJ0+gW182LrXnCz2IW6Dha4Wyx5O9AWvesxRKHxSDo/oCTB9C2TuMHbNIb80K2umIpznn6GulAsOg/xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY4PR11MB1496.namprd11.prod.outlook.com (2603:10b6:910:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.19; Fri, 11 Mar 2022 07:28:54 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.024; Fri, 11 Mar 2022 07:28:54 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Jiang, Guomin" CC: "Desimone, Nathaniel L" , "Chiu, Chasel" Subject: Re: [edk2-devel] [edk2-platforms Patch 1/3] PurleyOpenBoardPkg: Remove All UGA support Thread-Topic: [edk2-devel] [edk2-platforms Patch 1/3] PurleyOpenBoardPkg: Remove All UGA support Thread-Index: AQHYNOQl23zXEt/c0E+Dc8fPEbmeV6y5yXZQ Date: Fri, 11 Mar 2022 07:28:54 +0000 Message-ID: References: <20220311010101.56-1-guomin.jiang@intel.com> <20220311010101.56-2-guomin.jiang@intel.com> In-Reply-To: <20220311010101.56-2-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56462a99-50a7-417c-bab9-08da0330cc4a x-ms-traffictypediagnostic: CY4PR11MB1496:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TvGaggnPRsN58MkhwE/AQpAS2kVI9zbdMDRw523BeWvaUnzk9Kh00EqoYhgNIuE5hgWDlrIknNkpulzNhi2LNJP0N6MksTFkaTZM20ZMfmo6c+b2UJnPgN9ZNvfDdfN+8W6WTxxa5I+zmLUtUGM/XN0aZiBw48QjRwOZLdDxRTXD/CTEcKJC+n71yINONIQ3jjISYkN8OX4U29WAhHYogBlAtq16JhkRYWCeSKCG+VEUzffYUH7Y30bf7pXxhHy8IFtORgMdxQtb6yG9r8p6E8BGwYUD9Xf7JaMNRREI3onT3TiOatoOnVHKRSijX5EKzsjCe8sqWGqtmfOBor0e0fpUjDHYmnpJYKcqdGkKA0x30V43+h0fOrWeSTYY0oRL2UPYx/Tcsp2+roLh+ZnbmAmrzXJxTNaUCZ8crbCnM01/NJpncWZ6d5ptmKvryRRIwfBYpbEzP4gVCI0t6/50WSSmwkytl4FUSgg9irVtP6mYE/enTtAw+FKTgiLwdp9t+K2GCzh7s4wfFQOobTB3lE6L7UKeLEsVPq5PxSjVcg23ZciIACCLcDq5kNA4NU/FQra4qVplO/JBKOtsGlZ8eU89bNw441KDd467+Ba+F1fXA4hQbYt4UYUc6drPnuviEMi/n8X/68C5zIR4rJGC8NoYMTg3enswHWxaGIeBsPGbOPhCLpUs9yKzkQC8DUswAtuCCMkXhjedgpEiaYA2Bni12WRnQ0vbvB9xAazZSDxhBdD/j+9l9HVBvekDvjB5m5joGFff/CDmb1hetd1Kog8sd5yyxH/0nUVKancZA3T8iqw//B2FO7DQ5Ihjd5kzHraHBIXRLQ/JoSemoGN5Mg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(8676002)(38070700005)(52536014)(8936002)(71200400001)(33656002)(38100700002)(86362001)(5660300002)(82960400001)(122000001)(2906002)(316002)(966005)(508600001)(83380400001)(110136005)(107886003)(6636002)(54906003)(6506007)(7696005)(53546011)(186003)(9686003)(55016003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F1XHkwoTLYQ8iVbePyAqHAInL+RjvEKnmUVwkG6mr0HINvCCxdlyW4uWXRk3?= =?us-ascii?Q?gqfu5y+jK4RQkfxnhs6rEXsSaBsfM76GwLQonMfF4U6Oa+CnFu81oR07hTe9?= =?us-ascii?Q?igHj6DpFcGRL83zI1CAi+TASbiGjkiX6lsiPPrv0jsmsD/FuV8Lmk+mGKAH3?= =?us-ascii?Q?W68s5c/1Xgkb6j7tiUk/Qkgmc10inRHmfLHc36OYHfF6+fC0D2NPFWLbpEc4?= =?us-ascii?Q?qxlztZscaZE2finGEoVFIq00QPbGf/x5zkO2MY+g+MnNPLO2pG4Atc1USVn6?= =?us-ascii?Q?3fHw+Fe4sNAxIFe26qEjspk/wlgeIR9hCSIwKGLAq1rDRbkefAGzZU85Ehnw?= =?us-ascii?Q?uZBzoNYwEWcnT7A3TSu7SQFKiWfRUruq7/9ANvZBNJKFTn+PJlu2ZJcPp/zL?= =?us-ascii?Q?21IIZ+LTBv4SiFffqWSUmYiKksH641v+S6EAYgVrRKOF6IzqFmsCs3U2yQhT?= =?us-ascii?Q?E2hslR9etJ3FPgQQtNklh886F9n1P8GCIrad6KNolttzdKVGHtgt2Kwo8UT2?= =?us-ascii?Q?tJ3PEZuIvZ0H38vR90lqUCNutzR4wd7wmcGqUnBOnk9DDAamxqdyz2vEkEM6?= =?us-ascii?Q?zZngqBe0p+eYC0kHOpl5uX8xtLqdUB157T6pXJBslpx3VmbuvL5mpRMbQSlt?= =?us-ascii?Q?guJ8m7LdfwRbuIv5kHAGp5HzZ3utBYOFFoPEhqVGZsHR7cPzenD7UY9IVp9K?= =?us-ascii?Q?Rk7Q1Tru5eTIkN3Ws0Xg4yuGbHe4okxMwK3Sc7LA7FeLrIvvy9ez1L/0CSNl?= =?us-ascii?Q?ud52LXoLPzdSBY0moppMsTHqUepuM1nsvTjImN6RZdnM13xZV0874rV0yKxb?= =?us-ascii?Q?H3C6URTmbloZ5vevPBA5w+kEgdfOhL/hK3dGiOVsjm8w1MawKiezjCzx2BNV?= =?us-ascii?Q?rxsZ3tmpsaNLb395pEOFzegmPjiNhrR1W+6P7pS8l7iy5WP7djNwZZjJtXhq?= =?us-ascii?Q?A8bcE0R8vZeTnoFMfRbl3fp9CjA2mzMb569K2MEJjYOJQGS3lg0boNZxCB92?= =?us-ascii?Q?e56CpTsGTUpyThGMJSGCtb5KTLFD4IQKLM+z1odaMXDgqtaY1+7qOHUNdLL5?= =?us-ascii?Q?/HU4TlefeBkFvQZCtGcVXTYjY4o2ysm2HXMkKYa7bocZXQjmfRYxwpVGM4F/?= =?us-ascii?Q?93Mf0nqUsYqO/7jTfaFxE0r87Wxw6INzSCp7zSpGQQgMhuMhgMxfXA2W3gUb?= =?us-ascii?Q?NAd5ZScUZ2/+YMdAOPRHQJPmJ0LBBvlxXQxiPXXSq389z/X40/V5bmQPTz4x?= =?us-ascii?Q?dNKjjH++GgjymcEBL2mF58dH6BkUmhC64f4XuunYSPFaWZeze0p+bI6juPHz?= =?us-ascii?Q?43k2EEpZUORD+rzJUYjUwc+/nqZLXyCBZYfH33fgz3eoPvYZRCwX/wQMtLh8?= =?us-ascii?Q?uSXMDjvHqytSzSM+hISV4qFfBjhWP4g2qUhFkwu6MC5lFmaoI8G4yrT15I5k?= =?us-ascii?Q?TCXR0V6MTr6Eva9Bi9WJ7tzxcsU4NPz2tiykjvWCrMgmTsDh90jDbNnbgldY?= =?us-ascii?Q?CV0giXfI5STQ8aHEyXm+94cJgfSPt5IJvGXAMZtymq8+Eebs47YIhfa3SxUz?= =?us-ascii?Q?8fxWOrgvm0CGU5dwgpUyd/QCiWPrEMzsYSx+8RSkI4qBHXJ5uPbFu/c2FGgG?= =?us-ascii?Q?ww=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56462a99-50a7-417c-bab9-08da0330cc4a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 07:28:54.5390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ysXQgXbMGNzRFxL5CjrxpsBBEmjU7323UQDJ3cS/xOj3ByP0wYdB02obzgQH20vSrMYrdHzH8ud0f3Ma9XC66A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1496 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable can you avoid the unnecessary changes (e.g.: spacing)? -----Original Message----- From: devel@edk2.groups.io On Behalf Of Guomin Jiang Sent: Friday, March 11, 2022 9:01 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms Patch 1/3] PurleyOpenBoardPkg: Remove= All UGA support REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2368 Remove all UGA support in PurleyOpenBoardPkg Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Guomin Jiang --- .../Library/BoardBdsHookLib/BoardBdsHook.h | 70 +++++++++---------- 1 file changed, 33 insertions(+), 37 deletions(-) diff --git a/Platform/Intel/PurleyOpenBoardPkg/Override/Platform/Intel/Boar= dModulePkg/Library/BoardBdsHookLib/BoardBdsHook.h b/Platform/Intel/PurleyOp= enBoardPkg/Override/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/B= oardBdsHook.h index fd943b3ca793..05e0a3f8920f 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/Override/Platform/Intel/BoardModule= Pkg/Library/BoardBdsHookLib/BoardBdsHook.h +++ b/Platform/Intel/PurleyOpenBoardPkg/Override/Platform/Intel/BoardModule= Pkg/Library/BoardBdsHookLib/BoardBdsHook.h @@ -1,7 +1,7 @@ /** @file Header file for BDS Hook Library =20 -Copyright (c) 2020, Intel Corporation. All rights reserved.
+Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -19,7 +19,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include -#include #include #include #include @@ -55,13 +54,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /// /// ConnectType /// -#define CONSOLE_OUT 0x00000001 -#define STD_ERROR 0x00000002 -#define CONSOLE_IN 0x00000004 -#define CONSOLE_ALL (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) +#define CONSOLE_OUT 0x00000001 +#define STD_ERROR 0x00000002 +#define CONSOLE_IN 0x00000004 +#define CONSOLE_ALL (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) =20 -extern EFI_GUID gUefiShellFileGuid; -extern EFI_BOOT_MODE gBootMode; +extern EFI_GUID gUefiShellFileGuid; +extern EFI_BOOT_MODE gBootMode; =20 #define gPciRootBridge \ { \ @@ -83,67 +82,66 @@ extern EFI_BOOT_MODE gBootMode; } =20 typedef struct { - EFI_DEVICE_PATH_PROTOCOL *DevicePath; - UINTN ConnectType; + EFI_DEVICE_PATH_PROTOCOL *DevicePath; + UINTN ConnectType; } BDS_CONSOLE_CONNECT_ENTRY; =20 // // Platform Root Bridge // typedef struct { - ACPI_HID_DEVICE_PATH PciRootBridge; - EFI_DEVICE_PATH_PROTOCOL End; + ACPI_HID_DEVICE_PATH PciRootBridge; + EFI_DEVICE_PATH_PROTOCOL End; } PLATFORM_ROOT_BRIDGE_DEVICE_PATH; =20 // // Below is the platform console device path // typedef struct { - ACPI_HID_DEVICE_PATH PciRootBridge; - PCI_DEVICE_PATH IsaBridge; - ACPI_HID_DEVICE_PATH Keyboard; - EFI_DEVICE_PATH_PROTOCOL End; + ACPI_HID_DEVICE_PATH PciRootBridge; + PCI_DEVICE_PATH IsaBridge; + ACPI_HID_DEVICE_PATH Keyboard; + EFI_DEVICE_PATH_PROTOCOL End; } PLATFORM_KEYBOARD_DEVICE_PATH; =20 typedef struct { - ACPI_HID_DEVICE_PATH PciRootBridge; - PCI_DEVICE_PATH PciDevice; - EFI_DEVICE_PATH_PROTOCOL End; + ACPI_HID_DEVICE_PATH PciRootBridge; + PCI_DEVICE_PATH PciDevice; + EFI_DEVICE_PATH_PROTOCOL End; } PLATFORM_ONBOARD_CONTROLLER_DEVICE_PATH; =20 typedef struct { - ACPI_HID_DEVICE_PATH PciRootBridge; - PCI_DEVICE_PATH Pci0Device; - EFI_DEVICE_PATH_PROTOCOL End; + ACPI_HID_DEVICE_PATH PciRootBridge; + PCI_DEVICE_PATH Pci0Device; + EFI_DEVICE_PATH_PROTOCOL End; } PLATFORM_PEG_ROOT_CONTROLLER_DEVICE_PATH; =20 typedef struct { - ACPI_HID_DEVICE_PATH PciRootBridge; - PCI_DEVICE_PATH PciBridge; - PCI_DEVICE_PATH PciDevice; - EFI_DEVICE_PATH_PROTOCOL End; + ACPI_HID_DEVICE_PATH PciRootBridge; + PCI_DEVICE_PATH PciBridge; + PCI_DEVICE_PATH PciDevice; + EFI_DEVICE_PATH_PROTOCOL End; } PLATFORM_PCI_CONTROLLER_DEVICE_PATH; =20 // // Below is the boot option device path // =20 -#define CLASS_HID 3 -#define SUBCLASS_BOOT 1 -#define PROTOCOL_KEYBOARD 1 +#define CLASS_HID 3 +#define SUBCLASS_BOOT 1 +#define PROTOCOL_KEYBOARD 1 =20 typedef struct { - USB_CLASS_DEVICE_PATH UsbClass; - EFI_DEVICE_PATH_PROTOCOL End; + USB_CLASS_DEVICE_PATH UsbClass; + EFI_DEVICE_PATH_PROTOCOL End; } USB_CLASS_FORMAT_DEVICE_PATH; =20 -extern USB_CLASS_FORMAT_DEVICE_PATH gUsbClassKeyboardDevicePa= th; +extern USB_CLASS_FORMAT_DEVICE_PATH gUsbClassKeyboardDevicePath; =20 // // Platform BDS Functions // =20 - /** Perform the memory test base on the memory test intensive level, and update the memory resource. @@ -156,7 +154,7 @@ extern USB_CLASS_FORMAT_DEVICE_PATH gUsbCl= assKeyboardDevicePath; **/ EFI_STATUS MemoryTest ( - IN EXTENDMEM_COVERAGE_LEVEL Level + IN EXTENDMEM_COVERAGE_LEVEL Level ); =20 /** @@ -167,10 +165,9 @@ MemoryTest ( **/ VOID ConnectSequence ( - IN EFI_BOOT_MODE BootMode + IN EFI_BOOT_MODE BootMode ); =20 - /** Compares boot priorities of two boot options =20 @@ -195,7 +192,6 @@ RegisterStaticHotkey ( VOID ); =20 - /** Registers/Unregisters boot option hotkey =20 --=20 2.35.1.windows.2