From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.67940.1656905653576118748 for ; Sun, 03 Jul 2022 20:34:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RFsozO3f; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656905653; x=1688441653; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PaMC1bU095uyVjfUT3HaYb1Yyo6/JNDl9X8bwNV3uVI=; b=RFsozO3f+UVxM5CJ7wtTiQtkljnXavhEvgYyC/RFKdq3+SHMJiOK624M bnTmNmOBAp1BDi+cqk+dBcOyacH8nFYKv5LKfZQBYqB2xJgpVkUz77R5Z WVvx7mQC9MeDh/M+5IsncRlkh3DKz2uPF3Sr9cyPYqMKGHOBMlDYdwexd 8Rb4OcDup6djiUk+xj9wIbva/zpxLYw/WwU6u5awwLp07gGPGKa6lx0ZT 6Rl7e/C+4+2cUDlEydNNr1jWVcK9N/Gi6obt+KXS8bQmPdiWGG8OrQdkH jixWMRSfNGu+9ADeuv2zbgoGsruHNS4U2xXjgPBxQUgSHaOkGTnA9chR+ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="347003207" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="347003207" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2022 20:34:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="660051040" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 03 Jul 2022 20:34:12 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 3 Jul 2022 20:34:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 3 Jul 2022 20:34:12 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 3 Jul 2022 20:34:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPkXeMsWhOpQt2Gto48SDX+z57cuLbfGO5J0fNKTdgS3kwpqepsFSmWjEgzKrVb8d+vstCkQ++UXVQR6JQ8a4f/ILJ3B71e/qZb9Wk7IGvkSchxOL+f+PlCH6yRkguqpTEPhFtlfjK9Xskl6rpAakCywO4E1ScypYnq0KvqhMJjSHRuMw85PksnZ6RPyIPATEAbuQukuax4YmMNKNkJKYUTXuBZEWk8Npg127aQscQEA2YWKIcVr5G5Qok/NOdENIcaNnR2LDuvtFC6dBKnfGIHzjPrbz79lb9r0SKtEFEHdvdvsWR/WPLfCGnt1zBep9XiWrOPDZGxa7OE9Jgv6KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8dMSp4zGaCyjSjM6ZdQDbNpt/IDE+aC4qonfqdLBw8I=; b=Dzalo0MVrwD65xrwImOLuzORZ20EXxmPuHkS2xnTRkY7jGRFLiAJMfmRaC7W2Qt1vlwAIOwEcurBXempwP5cpqnrzTBaAJXjWtqoX3ZdnA9CUBiNUSZjeogvghHQtmowESkylIgKUucO8Zl86rqPfAmKK35GcmMYBKdYuADMpTvtzwyt3bW170QEbTNao86c0tOlArC7Cdb7IwsY2XhWZsCWieQF9Q8+D0tLPPi0eu6BQm1x4TZeQtHclHJul8rgE7QQceGcSC8RwoB7MOF+27Gt1mdWKIGJI8LFp/cZhlkdA+C8nXwsQ2PxTXcoRDuIRKnVXgEuXQhXdM1QoyqBCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BL0PR11MB3300.namprd11.prod.outlook.com (2603:10b6:208:2e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Mon, 4 Jul 2022 03:34:10 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174%10]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 03:34:09 +0000 From: "Ni, Ray" To: "Lu, James" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Guo, Gua" Subject: Re: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL Thread-Topic: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL Thread-Index: AQHYitrL+co6M1KMxEOAL6lQqoVNHa1tln0g Date: Mon, 4 Jul 2022 03:34:09 +0000 Message-ID: References: <38b574266fdeaa275743eab94caf39acfe71b2bc.1656412190.git.james.lu@intel.com> In-Reply-To: <38b574266fdeaa275743eab94caf39acfe71b2bc.1656412190.git.james.lu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ddf3fbfe-ae87-4768-822f-08da5d6e0e95 x-ms-traffictypediagnostic: BL0PR11MB3300:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gin6p91OH23NBZ4NukEibWtJyfyZwR8t+N2OIl0CzA0eT8qlWj8kvyznP8cLJnyxw6Zx2A6dOKEwOME2c7rETfB2EqO3viSfBLFj/iCzqN2b395l9DZKsZ2jUFRi6Uft2sK46q8Hs15adRGm65hQI6/Kwb/eS/+ySS87IOq4lNLgCBbpY8GtnMCiSJp9d2Kt+LfjpDAABDvcMXgfIrTdRhU4B9KaMwEo/59Dy1nPR/4YI3USLdTVKWPoxV4TnCYiuw/z3GIHUOK9XAflvi1ZwQBiwspo2VDAlSXhdR9Xbx71GeziVO7mmgyC4Wjt9gsL0wC82di2MRFNDN0luOry0+dd/T9FRLxZ0V8M+RkNyg6yF5wFDdIShJB7XRkGiji3l/UwCE1wFR3Q2erbrxc5b4o+GtxBjOvaNOFfk6uosKssf3Wgk31mTExfbw1YZ8DErVbe1WOy/FzSdMHKSHZKZD3+9OY7QWsy/vdQ2E4Qvwx+f5nljbEiGlfuHRA7yNoC7QAIJL3tZ9aSvoUxkx72IvCji21+EAnmLJtqp+GrGwZ3HCC3rKxlSU0GR6swb+tH7meuYyNv+NzgZp/8eaWWOb3wvsYbL1HAPTG14zGiV5uMHNGQh5EKPjh+zMHAeAgBlpy+yy5JUgC843yiXvf/JPGE2q2LS7jC9aJ1MH7BXNpFCs3JE+WPU0RFz8lN2fB5SWBwmP2MgnonntbDwueVO89FkALicVzhFPeTXhb5Zk5mWKXnA/Lv65oMyICjB0iFbC5gEMO48wpOB281Jy9kepLMRNl+UVInHtO93Gey4/5BkS6/AaQZKzA4p9MirbuG x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(376002)(396003)(136003)(366004)(38100700002)(33656002)(66946007)(4326008)(8676002)(64756008)(66446008)(66476007)(76116006)(66556008)(478600001)(55016003)(38070700005)(122000001)(316002)(19627235002)(71200400001)(110136005)(54906003)(26005)(9686003)(82960400001)(86362001)(41300700001)(6506007)(7696005)(8936002)(186003)(2906002)(52536014)(107886003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BuMG+sIxxSbdapLQ5FdU3aO//ZAWLuVz3pPcQ/En4x5XMbQRRRCXyMNwCS25?= =?us-ascii?Q?SWjFl2XjVn90ieuQa9y9g0bMTEqiXEgSwmpH2Fm1k+GB3KoqlDQsZC+Vt1eb?= =?us-ascii?Q?Z/fWMLyT+YexX2lh7PyAdsESp9ENBXACj5fFROPmj/OIUaX7WYIzHpvnyRRz?= =?us-ascii?Q?JekZvY0QdLSfS/TgcQzoKFr/PbxVl/bi7dLMxS1vxJctHqa/p5D3Uz6cPTHL?= =?us-ascii?Q?x2E4jlvrVSmqrFbt3OCuEH2bjFwv3rgPWtMtDFDjPmQHmLFU0kP1F2lxOXFj?= =?us-ascii?Q?qvfzwTC+vnkTvnpz6OvlV0KW8bf6fwuVlDMBNTjzObfacBuoc1QtZytr5gpw?= =?us-ascii?Q?qA44MwQS2jXz9AHGSrN4AGnr+qyweNBTe++69nyOE8IH6uPiAuzUaFhT+HUH?= =?us-ascii?Q?TPVAhqKwR8DhQVvihLjXmHdbiAVqJQX0IoKTgtID/7EN5UoWVeMlHFJM9D6k?= =?us-ascii?Q?Tl/N52ofUESWG5cuNHAOlOjt+szPaLVGRf6fd/HZFwSjme8Y3WoczN7tL+7W?= =?us-ascii?Q?kgyTp3FwqscTMT3oC3H5byYLurpaE+0y6X8quVOR8zTWGPAx5ZnJu0DicIgY?= =?us-ascii?Q?HCaj6HoDBnu7P0mCrbZ6nmyShCkf7TfNgE749YdE+f2V9nqxYrJW8tV2lPBS?= =?us-ascii?Q?xaR6FfgzYbX8/6sH9ZdcD9nqpfMbbG1CbZKjv85JHDq7zMvHgFD6bLnmpguw?= =?us-ascii?Q?fJhy9x2sOl/uYOPxu2bvzUfedSHudqtmH82OpYG4DGyI49npPYpDv2Lg1a6r?= =?us-ascii?Q?vgtscYm11vtC5cRs7+zPiHaJ9LxxuAJhxyWKENIfNth8YIuCHSPlkwHqniLQ?= =?us-ascii?Q?ErXbmRC8HifHl84JHyM6+rmb8U9kVa4ER1WWqJpiIzF4wrOEFAHKrbkQIDVt?= =?us-ascii?Q?86QF4yrOk9x2huS5ogjV9Fg2aMdy8mi4HREoW3tSltPjLTYyx8MauxkYzhrX?= =?us-ascii?Q?PkvfdiNjQ3ggsY+BFFGShliKAPiyRZoZ6kYRiNCkdAayvIZ8FXSvqL+wciWD?= =?us-ascii?Q?lTd9TtRW7HghfCW6GvnRUy4RbxAp1naAadAIE7Y/PcauXrqyrIjDmRPbDdq3?= =?us-ascii?Q?9eVOWSkpcKtT607bs7YlLcvOSKnP9mSo6dVugHQpyvNrKVpxx+2lXdP9qDIh?= =?us-ascii?Q?7FNf/JNOhvOilNvL9k8tKlHY2WrI3k1Sl5pKXGXXlv0UNzfk7A+ql1q2zNK9?= =?us-ascii?Q?DjdMSfR3JAB54aL+wF3+LtUSEs7Y/Uv3KWibpzj4lWKT7iIvJMC3jFfMDa6d?= =?us-ascii?Q?Pt0dytvjGY3JRkeFiVbwS0sNYVwYUgirfT/G1hTnUT/tOVG4BkL+cejRTC0J?= =?us-ascii?Q?CvpwPiq3ZaM3j5YqX7dZwY3oYY893vR1LNeoRCmbl/mir3UudKNbjkRh1TC2?= =?us-ascii?Q?0Mys/8r9Nq1dwH4Dj2D78v2z2YP7J2eym3m+tTybo8EKk7mfF23jKm+HtENm?= =?us-ascii?Q?yF+di0qe1B38BInt1jTGWsOwMA3kIJRQ66Ls4cXuuTB9At+LDTQD1/jvuayV?= =?us-ascii?Q?I1ej63Q+eS3qVrHSPel0Duxrd0tbT6tkIkMDhg84bLXyjzT4rn58J7VqR1FO?= =?us-ascii?Q?j/LRRlO8GSJnmNjo/G0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddf3fbfe-ae87-4768-822f-08da5d6e0e95 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 03:34:09.8186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S43tAt2+B9jImZhUT9osRBOURMoQpUQqRCQSzuDQSfmPnmKqAeRF2Uqi41gH5MwgPxSCp/lrUPZGgz4G3ewiuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3300 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > +!if $(GENERIC_MEMORY_TEST_ENABLE) =3D=3D TRUE >=20 > + > MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/Generic > MemoryTestDxe.inf >=20 > +!endif >=20 > +!if $(NULL_MEMORY_TEST_ENABLE) =3D=3D TRUE >=20 >=20 > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT > estDxe.inf >=20 > +!endif 1. Is there a configuration that both GENERIC and NULL memory test is FALSE= ? If no, can we add a macro like "MEMORY_TEST" and its value could be "GENERIC" or "NULL"? > +!if $(ATA_ENABLE) =3D=3D TRUE >=20 > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf >=20 > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf 2. AtaAtapiPassThru also produces "gEfiExtScsiPassThruProtocolGuid" which i= s used by ScsiBusDxe. So, maybe we need to always include AtaAtapiPassThru driver.=20 >=20 > # >=20 > # Usb Support >=20 > @@ -671,7 +685,9 @@ > !if $(PS2_KEYBOARD_ENABLE) =3D=3D TRUE >=20 > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > !endif >=20 > +!if $(PS2_MOUSE_ENABLE) =3D=3D TRUE >=20 > MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf >=20 > +!endif >=20 >=20 >=20 > # >=20 > # Console Support >=20 > @@ -742,12 +758,14 @@ > # This should be FALSE for compiling the dynamic command. >=20 > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >=20 > } >=20 > +!if $(PERFORMANCE_MEASUREMENT_ENABLE) =3D=3D TRUE 3. Thanks for catching that.