From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.5672.1656062985480306129 for ; Fri, 24 Jun 2022 02:29:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=JF9EvmIf; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656062985; x=1687598985; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=W+GKMJ5DNpR7MNm8/uVjQvgsH5jPQo+GD2wYPFE6bRA=; b=JF9EvmIfEJCUb8hnLdgPsRGbAXHh5Hl5gucs3WxzZzQe1cLvTPMsQj1e ZJICBXu6HAITJ7DrvHOFnvmstBrGC8KZvIFRJ31Scheu0UfVUiT7yw8w8 kI/uTyBfNrjJickybtNrvABkq+EtzM5PYtMUFDY5KvVsilNpjT9tuGUvm pwpQNaZqBaueB6LkG+v/9iEUhcmwlYLAJUXstQOTHg9CHGSSIc7ypQ5LI 0jUx8QrY4jhVwd0mNET97vPNufQncdaVbj3K5m8qruZdtjF/zmifmhqrl QrnhrNJZDHZdpnBjrwFqjZzhNx7HF1OqwiE3SJBg78lPsOlQ3+rFiSaBc Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="306430156" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="306430156" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 02:29:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="656578873" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 24 Jun 2022 02:29:45 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 24 Jun 2022 02:29:44 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 24 Jun 2022 02:29:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 24 Jun 2022 02:29:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4WmHkyXlUVKU4hTp3XWeczGW0WJEnCzS2nhQNH3K121vZJt9FQqRT0LwYAGiFtYR/M8ny5XWNf9IZckkcDPG+h+F5qfZk42nmmtLuPV+BO3m6giGg7jnF9nuHSiC/wASVe4vzao4sFic7ZwDl1G5AoS9qq+n1hHFIQUEd2pjh03Y5exkoy80v4EUFU0afZSN/Vg8kegRLy8EKHeHwHf4/e14LSdpF/FdIlQ/TZrpoHbg17x+yvIvjhjTSr1+gatG8CoRUsGUYmkmeFg52njmqV8TDV7GGupdCCrraAYPvVsJUzgL7U1+HXfL2exNMQR02YnU/OdjeonpTI7PpFAsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqLPAiEVo0kI+7jWB5Uy/t4nSso14OacF8gVAaAXu2A=; b=kQYurBxgkqljemP45GRepIRc0z2M4bSsLSU1l6GBEgiktcOQrfNFAYYH/jyDc/tzO05NnvJKj3RRnTWYWl1TGpmmA5mFXa3N+RUjhUWWo5iV04vpbHYPNVpFMLCZIJpnmXlvUCYuO8kab7S0lDREXuh449X2vXXEGgR8W8HHmNRmD6HvQYvD7QMgLW8Q5oRdbMXSEP2mctphfQKt4/AAWxKQ3GDsfzUDe8YRoidzo8wtae/qxGuRJ/Pp9V9JJDBmLz1pW/xBSfAjfkLtv4T+sNlnogxDLlgdcl3X+7rK4VGa1JI008kvmm9yX5Nj/eJS6DiP0ygE87RlLyCVZn0Ftw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MWHPR11MB1822.namprd11.prod.outlook.com (2603:10b6:300:111::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 24 Jun 2022 09:29:42 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174%10]) with mapi id 15.20.5353.022; Fri, 24 Jun 2022 09:29:42 +0000 From: "Ni, Ray" To: "Liu, KasimX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" , "Guo, Gua" Subject: Re: [PATCH v2] UefiPayloadPkg: Backward support with python 3.6 Thread-Topic: [PATCH v2] UefiPayloadPkg: Backward support with python 3.6 Thread-Index: AQHYh31DVTfNhgZd5kmf8F6S+KM+8q1d+iQQgABQfcA= Date: Fri, 24 Jun 2022 09:29:42 +0000 Message-ID: References: <20220624034749.2978-1-kasimx.liu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85843b72-ea81-4a50-677b-08da55c411b9 x-ms-traffictypediagnostic: MWHPR11MB1822:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RvSbA5KYccAINXa2NC65Q8OToU/i6A5QNcBJGXhqYg2W2TtbDvTM2jMaG333l46pcvbDXMomQxAhgypYyBjE4lN7J4sxic24nRDeO5jMkq/Ei1mdSHnI6Z+fW6l97vDlLO8N+1LNqWH3P4F4AN7dapQioip0QZ+glEY4m3iKZb+9u+fCfjDIdA51o28R7SYmsE6KlR/QApxPV5+LnMn7hXfZPgclr/3OaywUx4bSnrEJms2jK8G6ftnZMhtNPkY0LrQN3By1Ok5g8T+J6R5XdNR+k7WZKGpkjf3O9zgwJoGVrJqCFj1pCT5MuKNU6YnV4BfAc9yigniNFmcP/sALk906Oa3L6QgLvXjBVEOV5GFJMIAzA4sx73THYGvIW0pw1UT+sOutIxJs3bT+fdx2gMU1nDhmopgcCS0qNqFiz9LIQ7d7IJkyL2ZkclygCOaw2H9jXTqc0EMiJdfngE5hn8zI1uQZFtgjBRN/RWYg0q5gw6zVECkTgs3bD4vpltBT774lccPO2Ql+kF4vjVC9KV1zXc/g0v7blegGR61xMjVM/aEin3VfdqCxth9Nry4HEb5uOw0AYKtYG1wyaQ+JAUoaD4FpfxWm9xXBoopPbGmp/QgzmJs4loSAvFUwZKLM0FqOWEqDwSfburdwjlQHNZRXWi5GWXvDXHJJjT8VPPwEXRcKVEz2sAqNLz7p58PaVg8y812aa9tFpYYFH4YvSwYdVkdt690zu7+Dx9/MOj3cwlDhma1onsJsDa+nJwEnIgJ9YoWizuY0ZP7YZMXXF5X4EDMD3lWYsLJjPcR2lwSw3dN71lDt3JxbfPBvB70EUHhzqtzn0dYJrOJmn15+NQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(366004)(376002)(136003)(55016003)(83380400001)(122000001)(38070700005)(82960400001)(33656002)(86362001)(38100700002)(478600001)(107886003)(71200400001)(966005)(186003)(7696005)(53546011)(6506007)(5660300002)(2940100002)(26005)(9686003)(110136005)(316002)(52536014)(8936002)(2906002)(54906003)(66946007)(76116006)(66556008)(66446008)(64756008)(66476007)(8676002)(4326008)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?50zDXj4XgytcS4qEbvNpjVS3s9LCP6yU9iM6Qcite3rmK6wHwou8jfZIRGAm?= =?us-ascii?Q?sTCSQZwpXPkZTw67ONEtnYEgnh1ZQeC+4i3N3e4rYSSlGmh5RB7yFyaBzlW/?= =?us-ascii?Q?fCucIcVF3MKXm2Q1jEIu+d96ufVNW7HYRikqGqfugFrwPKkAhAN8ZbHPQa9d?= =?us-ascii?Q?ZpQbkyUXzvsETQXJvNSYagLptZ3wTH1gahGuoODjMevoX9edrTBKegE6JOzb?= =?us-ascii?Q?U9Xg5YKQfcT509A4RSzgM76bkhPkA8zyX8lrJnspMM44qGOT36wxwiD9xS5Y?= =?us-ascii?Q?kgbM/SEYsB/R3sBMce8WwLZw2jF0KhUyOgGkb2o3zgmvTw587cb+6HMlvhgN?= =?us-ascii?Q?nswH4zsIgcx/Hf/FzutY+kmUVkT/csSs22OcmZV/jGAJL1pk2DUQaqnziaw3?= =?us-ascii?Q?j7emXSsVb+vEMsca7ziFQl+keTAPOb+S6BrZKNh1qBXL9tWdJMZmaAdZ4cG5?= =?us-ascii?Q?vCxX5u6dBs5BrDC2hn5HGM2XiQYf45TT5yd22MuXv97OS+FlLP1H44JFPJ3T?= =?us-ascii?Q?5yjCcZmpHnsid2Dc2LvfzsGgS/wQBRgbnQ0RfrBnYVUinIr+92TZ6beBcIoT?= =?us-ascii?Q?blEkalqBClu64cB8GjP2PmU9OwPPpRMnu9thRCKcmHRJc4yyUwv3jlf7LG28?= =?us-ascii?Q?y+z8vIQ0+32Hqs6YHG6avbwH2kJqm6dylMWF8IR6hUe8M209tk0e447o7Vj3?= =?us-ascii?Q?Xk+Ma+nYhzudvboytlZ9uuXDI3cWaft9L6p2Cqg1tskNrh3tjIgaKxtnBrbp?= =?us-ascii?Q?m1ta6YKMtdYP7HX8TE+YoceKb+KFGOp4A1IAMjqELq/8HWOhYVOzHCtKPzwB?= =?us-ascii?Q?aIVLKexGKdnW4R552sNoX3p+Us4J8M7M/HAVWxsocd4mHQiqisF9PoM7lsU8?= =?us-ascii?Q?HIG1G33hg5I9tgSzzviowob5QpJzFbFghZc2LDKsnlOOJ5r7kVJoTM7eU61z?= =?us-ascii?Q?6Lm2PJhNWDTQ8O7agbEUL8IPAZr2svBgPIlAuod7U3k4fPc6cs6Ws4mTTzgi?= =?us-ascii?Q?/GdDT7nIsxrNdxYQNbISHdivQV4rlO7onIlUxASBkTssSl8Vg0gDWEBounbU?= =?us-ascii?Q?opM6L6ALvhnLI+gjzmsgtRH+MIX5rhmrKgcRbSDbcYrH7Jo/lpad8lYjrvz5?= =?us-ascii?Q?g+9Ks4FTNbpfYKZf+Bfh05vDJqLUrES87+jif+c6QqK9MVmteV4VuDVhdY9/?= =?us-ascii?Q?bqFxs2UNFxBS2Gq6bZlTljC6djZ1GbbSG6npCaJlqXL1Ec0WWJjtWY19cZu9?= =?us-ascii?Q?UlpeBQsthz4fFlWP1fyojPuG6jALte+VL9dkUUgMb5lYWMtf60v1hU5xnBC7?= =?us-ascii?Q?HghLjAU7VMbjzbuuKd6374/jU+n+x212zvD3Zy4+OuvaN8REYJdEuDPjRjae?= =?us-ascii?Q?wOCRWRX/oDfLwDVS1uqCMg72S3Jy5N3wWHpY194JUb9aSXZunp54mGl4w+/7?= =?us-ascii?Q?layMxb9DH/mTo5uQqjQyjtUvWnyuSq70euYjKh+OogtMVg+TN5bGoPZ5C7Lw?= =?us-ascii?Q?iJNOpc9yyHgw6nwpKeG9nCFYulLAc6kkcDrRXx0625GPVQBmrsQuQDp6XKWn?= =?us-ascii?Q?z7o3IYOob7epQz/TqGc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85843b72-ea81-4a50-677b-08da55c411b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2022 09:29:42.5192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A9LvP05BJZ2KsZSksm+Pq1nCwgsbsDoQdgxiTQBekWaQNeHoTtYF4+yr9cEEX9FPWTiMgkEO7GgUGmHd5rEWmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1822 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Offline discussed with patch owner and got to know that it's a change to en= able UefiPayloadPkg build in Ubuntu16 build servers. I am ok with this patch. Reviewed-by: Ray Ni > -----Original Message----- > From: Ni, Ray > Sent: Friday, June 24, 2022 12:41 PM > To: Liu, KasimX ; devel@edk2.groups.io > Cc: Dong, Guo ; Lu, James ; Guo, = Gua > Subject: RE: [PATCH v2] UefiPayloadPkg: Backward support with python 3.6 >=20 > Why use PY 3.6? > Even PY 3.8 is about to be deprecated by Python community. >=20 > > -----Original Message----- > > From: Liu, KasimX > > Sent: Friday, June 24, 2022 11:48 AM > > To: devel@edk2.groups.io > > Cc: Liu, KasimX ; Dong, Guo ;= Ni, Ray ; Lu, James > > ; Guo, Gua > > Subject: [PATCH v2] UefiPayloadPkg: Backward support with python 3.6 > > > > From: KasimX Liu > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3960 > > > > Currently, UniversalPayloadBuild.py don't have support > > python3.6, we use python3.6 will encounter f"" failure > > use the change to fix it to support python3.6/3.7/3.8. > > > > Cc: Guo Dong > > Cc: Ray Ni > > Cc: James Lu > > Reviewed-by: Gua Guo > > Signed-off-by: KasimX Liu > > --- > > UefiPayloadPkg/UniversalPayloadBuild.py | 33 +++++++++++++++----- > > 1 file changed, 25 insertions(+), 8 deletions(-) > > > > diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/U= niversalPayloadBuild.py > > index c71526e0a6..ab4c977ba5 100644 > > --- a/UefiPayloadPkg/UniversalPayloadBuild.py > > +++ b/UefiPayloadPkg/UniversalPayloadBuild.py > > @@ -59,15 +59,15 @@ def BuildUniversalPayload(Args, MacroList): > > if Args.Arch =3D=3D 'X64': > > > > BuildArch =3D "X64" > > > > ObjCopyFlag =3D "elf64-x86-64" > > > > - EntryOutputDir =3D os.path.join(BuildDir, f"{BuildTarget}_{Elf= ToolChain}", > > os.path.normpath("X64/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadE= ntry/DEBUG/UniversalPayloadEntry.dll")) > > > > + EntryOutputDir =3D os.path.join(BuildDir, "{}_{}".format (Buil= dTarget, ElfToolChain), > > os.path.normpath("X64/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadE= ntry/DEBUG/UniversalPayloadEntry.dll")) > > > > else: > > > > BuildArch =3D "IA32 -a X64" > > > > ObjCopyFlag =3D "elf32-i386" > > > > - EntryOutputDir =3D os.path.join(BuildDir, f"{BuildTarget}_{Elf= ToolChain}", > > os.path.normpath("IA32/UefiPayloadPkg/UefiPayloadEntry/UniversalPayload= Entry/DEBUG/UniversalPayloadEntry.dll")) > > > > + EntryOutputDir =3D os.path.join(BuildDir, "{}_{}".format (Buil= dTarget, ElfToolChain), > > os.path.normpath("IA32/UefiPayloadPkg/UefiPayloadEntry/UniversalPayload= Entry/DEBUG/UniversalPayloadEntry.dll")) > > > > > > > > EntryModuleInf =3D os.path.normpath("UefiPayloadPkg/UefiPayloadEnt= ry/UniversalPayloadEntry.inf") > > > > DscPath =3D os.path.normpath("UefiPayloadPkg/UefiPayloadPkg.dsc") > > > > - FvOutputDir =3D os.path.join(BuildDir, f"{BuildTarget}_{ToolChain}= ", os.path.normpath("FV/DXEFV.Fv")) > > > > + FvOutputDir =3D os.path.join(BuildDir, "{}_{}".format (BuildTarget= , ToolChain), os.path.normpath("FV/DXEFV.Fv")) > > > > PayloadReportPath =3D os.path.join(BuildDir, "UefiUniversalPayload= .txt") > > > > ModuleReportPath =3D os.path.join(BuildDir, "UefiUniversalPayloadE= ntry.txt") > > > > UpldInfoFile =3D os.path.join(BuildDir, "UniversalPayloadInfo.bin"= ) > > > > @@ -94,14 +94,14 @@ def BuildUniversalPayload(Args, MacroList): > > # > > > > # Building DXE core and DXE drivers as DXEFV. > > > > # > > > > - BuildPayload =3D f"build -p {DscPath} -b {BuildTarget} -a X64 -t {= ToolChain} -y {PayloadReportPath} {Quiet}" > > > > + BuildPayload =3D "build -p {} -b {} -a X64 -t {} -y {} {}".format = (DscPath, BuildTarget, ToolChain, PayloadReportPath, > Quiet) > > > > BuildPayload +=3D Pcds > > > > BuildPayload +=3D Defines > > > > RunCommand(BuildPayload) > > > > # > > > > # Building Universal Payload entry. > > > > # > > > > - BuildModule =3D f"build -p {DscPath} -b {BuildTarget} -a {BuildArc= h} -m {EntryModuleInf} -t {ElfToolChain} -y > > {ModuleReportPath} {Quiet}" > > > > + BuildModule =3D "build -p {} -b {} -a {} -m {} -t {} -y {} {}".for= mat (DscPath, BuildTarget, BuildArch, EntryModuleInf, > > ElfToolChain, ModuleReportPath, Quiet) > > > > BuildModule +=3D Pcds > > > > BuildModule +=3D Defines > > > > RunCommand(BuildModule) > > > > @@ -118,9 +118,26 @@ def BuildUniversalPayload(Args, MacroList): > > # > > > > # Copy the DXEFV as a section in elf format Universal Payload entr= y. > > > > # > > > > - remove_section =3D f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjC= opyFlag} --remove-section .upld_info --remove- > > section .upld.uefi_fv {EntryOutputDir}' > > > > - add_section =3D f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjC= opyFlag} --add-section .upld_info=3D{UpldInfoFile} -- > add- > > section .upld.uefi_fv=3D{FvOutputDir} {EntryOutputDir}' > > > > - set_section =3D f'"{LlvmObjcopyPath}" -I {ObjCopyFlag} -O {ObjC= opyFlag} --set-section-alignment .upld.upld_info=3D16 > -- > > set-section-alignment .upld.uefi_fv=3D16 {EntryOutputDir}' > > > > + remove_section =3D '"{}" -I {} -O {} --remove-section .upld_info -= -remove-section .upld.uefi_fv {}'.format ( > > > > + LlvmObjcopyPath, > > > > + ObjCopyFlag, > > > > + ObjCopyFlag, > > > > + EntryOutputDir > > > > + ) > > > > + add_section =3D '"{}" -I {} -O {} --add-section .upld_info=3D{}= --add-section .upld.uefi_fv=3D{} {}'.format ( > > > > + LlvmObjcopyPath, > > > > + ObjCopyFlag, > > > > + ObjCopyFlag, > > > > + UpldInfoFile, > > > > + FvOutputDir, > > > > + EntryOutputDir > > > > + ) > > > > + set_section =3D '"{}" -I {} -O {} --set-section-alignment .upld= .upld_info=3D16 --set-section-alignment .upld.uefi_fv=3D16 > > {}'.format ( > > > > + LlvmObjcopyPath, > > > > + ObjCopyFlag, > > > > + ObjCopyFlag, > > > > + EntryOutputDir > > > > + ) > > > > RunCommand(remove_section) > > > > RunCommand(add_section) > > > > RunCommand(set_section) > > > > -- > > 2.32.0.windows.2