From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.22805.1647419796876713672 for ; Wed, 16 Mar 2022 01:36:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NNQlztkt; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647419796; x=1678955796; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=a+5YhPAAbYsD8mJbLfqZrAzcbS2pGLG28LrpKvowAOs=; b=NNQlztktmTG/oym8WhcrWQxOsHySKCkp2MeJldIlytTPBmDcbOtNQ4Wq PUdpp9HdmHuxW/EiKbRNRaWztRLqdsJ9YJ801PrMMS/mNIlwf1iiIUKHC VuqV3m0hK8ViYaK5qj60ealZMI9jBf7uAgo4h/FxZvVMcBVeHcA0VCLn9 ITfev/e/mgswjzzOwUJo47SAHBF316WM5yxfmPo9XsEB5flM2mRVTKQ3J eXBA2Wsksj6On8nwVLN5VjHTXF4uN94Si3MFoRFrfHGsjF3PqgTlDsHrc 1LlA2U6ZYks0SUmLnYcSp5638IY2PyPlRoVmJBEGMEGpc+plBGYcQwGLz Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="237132648" X-IronPort-AV: E=Sophos;i="5.90,186,1643702400"; d="scan'208";a="237132648" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2022 01:36:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,186,1643702400"; d="scan'208";a="646563635" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 16 Mar 2022 01:36:36 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 01:36:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 16 Mar 2022 01:36:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 16 Mar 2022 01:36:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 16 Mar 2022 01:36:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ofy4qjrwJJgtF2x4hNUSaQ4Q5ftp2oViTKZ3qvWtgOLcnd0Kg8BQDA2zGuOJTX6zgBO1UVm/2dWZGS2RkT82W4x34S52dU3dm3t25nSaSC2gJyuNwoyfuFD0/ebYHk3M+IewSjrymzCG24Odxr3oipRN9QdN0EBnsJPugju/xfKMlpSOCvvoXJy1iV+/saRKTZKKlyBjIYzuJt841MZvnTPdJAr7Rob1L6P+YXLxOrC1J1a0ufKjSi0xSDpj5Mi+VdtSE6or0kvP3mMBMgbp56m9x/AcrXAWlGBDzMQDnV2v3U31lzIk12x6q9Ncho09GXELba4IFYi/5t12x/7bwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+5YhPAAbYsD8mJbLfqZrAzcbS2pGLG28LrpKvowAOs=; b=avFgpLTbIrnCgqxNIvHCjMldlI8HtQFqn+O+fnO+DdcYJ/1xDx0DgEUn7lDlJ6977h17C6pZWkh9pX4El2sv0ZSsNQ62vlSTaxZ/ikePzHHGW+IOmPofilr6yH2mxcw2V4VtL0v+mMNwY7YxBP7RhjFfDeVE+Cx19aK0A9STdcIM9A5LwkCl4Umw4c1auq+md3uJNn1mLXNVAXBXYnh2C/FUra9J639Yu25OSZG1evL4Iit+IJSIjDaHC7xPdJyu1RtiSqnrO5t4T/BRRo+kf2V/kmQoPRXcnjJvzMdg0ZfucEkSAE2V04MAeNGQRfEfEPiC0sb+9wNqOWLqk37z+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by PH0PR11MB4967.namprd11.prod.outlook.com (2603:10b6:510:41::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.15; Wed, 16 Mar 2022 08:36:33 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 08:36:32 +0000 From: "Ni, Ray" To: "Xu, Min M" , "devel@edk2.groups.io" CC: Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Kumar, Rahul1" , "Gerd Hoffmann" Subject: Re: [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHYNbRAZyuGRGvzEki5gUg4RZQu4KzAFyHggAGeGICAAAD04A== Date: Wed, 16 Mar 2022 08:36:32 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20d1e33a-8a56-4aa9-1f8f-08da07281313 x-ms-traffictypediagnostic: PH0PR11MB4967:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XZw43YKG+YLIVJRxj2ZvkR1KoQPpEmn8CyUS9oouSvCGFJxCDaN0xVnBoas/iAYDl3CYQQcciiFPgTvVUvb1eqYoxz9DtbWfRjEPkOVFL7aRC7cmqUkWX7+wsYzjtJvByJbTy5tGgV+ZGqWI2oHZEbt2v585ndVojtMZv7NAKdvL3DNDo2cpr6llyc2ahgjTh4S4FzJLj5kmZI/LDQ+IH30IyI1VVHq0sJt5TEa+YYqPoTz7B5Uz2S5jfYRiMpKis8ywiTPE3ZG9vdFG1Pm3gdCYgXjBdDT0fqcKGcE9YK8Om95GZMz4/o3exzahJjqeMLjYhQbYyRdoAN2Y/VdEIUtJK3zA4OJstkeVsiP4mQBOrkbJu20naC6cbhv/IquU14WTHwTbRgDBBZqHGn70Hnlbp1AvB/T/MwSim2AwuEpTlRCKB4/ZwIgnZOZxVS13C58jEIVV4c9yZjASdREezksQdKWJ8YGVq9EKeeoSn5t4FDbt8zeIYtguIRhgCY2oxT9J/tCu0trL7s3NeL5BUH6Z3Fyrfn0FQfJAnotgy2bjrAG3qGCJtZhcF+DiJsMYF1UnuLKldfAKADsQeHDYnADl9V75DSG+IJeyXrQeA0+XVzBgoWHpb/2rkb3Sh5Fi5Rp7i6j03g0/UnfuOho6SmAeKH+jd+8NCA1mjAWl9No8ZtxQTuivfJuJPSmFMbkbs5ZPiRdi3InYCguE9Cma1azSJNKhVj+ZNnRqHtXvKrrgr2M/ZZXEtWSoT2dR0ezR32H/SAV5VOPMU2eEb1rkz2mNusKPLhjY2OUPQ+F65vjAxw6PBML/4Dh5oK/brlmZbFIMhJKLHr/rnDlp5Ln1sQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(8936002)(86362001)(52536014)(33656002)(2906002)(122000001)(38100700002)(82960400001)(5660300002)(38070700005)(9686003)(316002)(6506007)(7696005)(186003)(26005)(966005)(508600001)(71200400001)(54906003)(55016003)(110136005)(83380400001)(64756008)(4326008)(8676002)(76116006)(66946007)(66476007)(66446008)(66556008)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PIaMhWgbuoozkexBk2pDtcZrvEkPSAbkDgzdjxEe1DWmu3jy0GX5sleBjM7/?= =?us-ascii?Q?FCAiy/vHMfUIJgRGZwn6cfeotd0Y8GeOOAKLO5D2LBsEylK3J22Onf9MX0yy?= =?us-ascii?Q?Dq9ecHBe1IAPOyFdOPKbG5IfsLjJOffnZcEd7FU7jZIP5sN/irAlGKVa8lAj?= =?us-ascii?Q?/h3zo67ioS1F+Cq+G2YNd0hXqn4aBNCUmoRpdZe4nBk6jw0HFiVVJsqcgfN7?= =?us-ascii?Q?6DwGpedYWMSZNhtm88dCV/v7b1LWl3plcT8LFImEdBpPKWLHaeNCDjXpcPaA?= =?us-ascii?Q?hsIl2ZQX2osmDBIvndB3JNVnWJ+3Ozc3TfIDKvHyMJC8OJmEVJ9U9H+5TD7G?= =?us-ascii?Q?DvbPola3MoKLFln02PFJsSCTLtNn/vh1Q/KbTi/lY8Ut7zus+a2K8Py1ipAW?= =?us-ascii?Q?O88ei8G6k2LILULhf7Umnnrw5VLin3jFQb/tWL0TJlUnqhMwkOTXNf7or7gL?= =?us-ascii?Q?U6zoesC5IMtPqGbUhS3eLoOoeJBtCz6SmOkGtndHs6angEnhC6KaWDo+Qd2r?= =?us-ascii?Q?Q6U92hWdLpYOPlQLt2bxCicY7qLZC/qVSnx0mLYxHYAWIzZdSEux674+t/FP?= =?us-ascii?Q?sB0voZ9xQiyPeQx92I0zYOjI11P/KYzy2xrVvURbY9FWklAMlUBY3ueV7ZCb?= =?us-ascii?Q?vlW/4YxKqjbQWNd8VHU5mXvP0wsaGcecLffRQYjcyw75Xy9co2qx+oL1+Xpt?= =?us-ascii?Q?1sMLY7waPR3WsBZh9u6CHGS9+bHgyRMjg23pFPgzpQUmZt+sry2VGMtCvsum?= =?us-ascii?Q?FffP8Iwz75t1e1SlRgSG9O2UAlLlxCrPO5UHXMJHg+tZb+nHLkIXVfEMvgWq?= =?us-ascii?Q?PaXDXSIyMAVtNpG5QyD5Y2Lss9A8RD+C3X8jMhaMbg3AjupbEwEIdqiUAoC1?= =?us-ascii?Q?q8SrI/Ryu6Gh24aqF/Ps2vh+ZDHAqfg3h7Q7SU4IaA59zojC1UVURS04rPx5?= =?us-ascii?Q?VgT0/Qktz2RHcBXyuTqBDOvyWzytJvcnhdKFra9FbNBrWYfCR9Q9zaTSEYOf?= =?us-ascii?Q?VdWUswdbc4yCh6SC7bd1KSxrbiny23RcreOhcs79k9jbjxyPZUggnVqkqW0E?= =?us-ascii?Q?aJKFbcIpsFzBPvaZ7RjRys42Cr/AA3ECKsi4mdLWXJe9V5RJVZ6uB4EILgX9?= =?us-ascii?Q?UxqNNk/JJvINd/+EBDzLc5wv0eCdf2l26mQBR0ZlZECIM0sCdeLT9M6EX/TY?= =?us-ascii?Q?RV76KWOIDORVw1Lje+dCFsH7Zo/9R1w70KFKWIxVWx11nuIrfagdbGE7P5kl?= =?us-ascii?Q?KLPwH8Wp/l/QXz1yQdjyQQOYJqs7w5uE5XSHlrsrtgQGGsf4ko+CxfAd4VFz?= =?us-ascii?Q?n1hJf855sRf6lhvny1ru6Bf71rxmcC3rs3YX5ABOd67jGhk1up/jHZLntO/K?= =?us-ascii?Q?5qBnaDw3iDkYsQa9EANl/R8GghL0FTWZNvSQ3aC6Efv0epqdFqBRU6KknYVB?= =?us-ascii?Q?gMdzCuNkdcT+SlSPb/4L2M5bVV0U2T0S?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20d1e33a-8a56-4aa9-1f8f-08da07281313 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 08:36:32.5046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pP0g5naA/13qD2MwOyCgWdntAG8jBxYmY5hDUhU4gFID9s2saqDD/BrXjFLtfTgDLXGtnZX5t50LH2VKN6285A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4967 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable GetProcessorInfo() can return the information for index#0 CPU. Other suggestions look good to me. -----Original Message----- From: Xu, Min M =20 Sent: Wednesday, March 16, 2022 4:32 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Brijesh Singh ; Aktas, Erdem ; James Bottomley ; Yao, Jiewen ; Tom Lendacky ; Dong, Eric ; Kumar, Rahul1 ; Gerd Hoffmann Subject: RE: [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib On March 15, 2022 3:58 PM, Ni Ray wrote: >=20 > Min, > I don't quite understand. >=20 > Of all MP services, the TDX version only supports: > * GetNumberOfProcessors > * GetProcessorInfo >=20 > And even when TDX MP returns 3 or 4 threads from GetNumberOfProcessors(), > StartupAllAPs() is an NOP. > Will that cause any issue? >=20 > Can you avoid running MP driver when TDX is enabled? MP Driver cannot be skipped in td guest. Because there are other drivers de= pend on the protocol (gEfiMpServiceProtocolGuid) which is produced by MP dr= iver. MP service of Td guest is different from the current MP service in EDK2. Td= guest implement the MP service by the mechanism of mailbox. Please see [TD= VF] 4.3 TDVF AP Handling & [GHCI] 4.1 ACPI MADT Multiprocessor Wakeup Table= . [TDVF] https://www.intel.com/content/dam/develop/external/us/en/documents/t= dx-virtual-firmware-design-guide-rev-1.01.pdf [GHCI] https://www.intel.com/content/dam/develop/external/us/en/documents/i= ntel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf So here is my suggestion to this problem. In MpInitLib if it is Td guest, then GetNumberOfProcessors just return (Num= berOfProcessors=3D1, NumberOfEnabledProcessors=3D1). Because only the BSP i= s workable at this moment. GetProcessorInfo returns EFI_UNSUPPORTED. Because in current stage Td guest= doesn't have the MP Service requirement. What's your thought? Thanks Min