* [Patch V2] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
@ 2022-06-15 10:11 Yuanhao Xie
2022-06-15 10:28 ` Ni, Ray
0 siblings, 1 reply; 2+ messages in thread
From: Yuanhao Xie @ 2022-06-15 10:11 UTC (permalink / raw)
To: devel; +Cc: Yuanhao Xie, Guo Dong, Ray Ni, Maurice Ma, Benjamin You
The maximum Unicode string could be as large as 1800000 in certain
platforms when HII code builds the configuration strings.
This causes assertion in PrintLib.
The patch increases the PcdMaximumUnicodeStringLength to 1800000 to
avoid the assertion.
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 4d9bbc80c8..cfcf38578d 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -410,6 +410,7 @@
gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY)
gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
+ gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000
[PcdsPatchableInModule.X64]
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
--
2.36.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch V2] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
2022-06-15 10:11 [Patch V2] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength Yuanhao Xie
@ 2022-06-15 10:28 ` Ni, Ray
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ray @ 2022-06-15 10:28 UTC (permalink / raw)
To: Xie, Yuanhao, devel@edk2.groups.io; +Cc: Dong, Guo, Maurice Ma, You, Benjamin
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Xie, Yuanhao <yuanhao.xie@intel.com>
> Sent: Wednesday, June 15, 2022 6:11 PM
> To: devel@edk2.groups.io
> Cc: Xie, Yuanhao <yuanhao.xie@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Maurice Ma
> <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [Patch V2] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
>
> The maximum Unicode string could be as large as 1800000 in certain
> platforms when HII code builds the configuration strings.
> This causes assertion in PrintLib.
> The patch increases the PcdMaximumUnicodeStringLength to 1800000 to
> avoid the assertion.
>
> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 4d9bbc80c8..cfcf38578d 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -410,6 +410,7 @@
>
> gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY)
> gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
> + gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000
>
> [PcdsPatchableInModule.X64]
> gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
> --
> 2.36.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-15 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-15 10:11 [Patch V2] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength Yuanhao Xie
2022-06-15 10:28 ` Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox