From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.31513.1644827232820424275 for ; Mon, 14 Feb 2022 00:27:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gMswRRm5; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644827232; x=1676363232; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FBExgbl5Gq6JAM74+xS4xc6uL8fukrcU3h+l5LJzAPU=; b=gMswRRm5CaFO/Unrw+hZ1opOCX+ZwfWMhST+J/2j7KuAXaoh+3r2ivK0 HzVm8Okx4Vf6xSDc1rTcbse467hc3i1VeoAEPzCcrXl67CVLYS92h+uT1 nelwKgIRfKhoaOtUA50bl5iIpuKAKk1I/R5cUzPyDVvUMy1Gu3VBVgI6a 2cSen+KmoyBCAIMmvMAWdanqxA/3bC20wZ9VdiwYNzi+YPa3n1TT/SjAA ntMRW50bA1Fo2UCWhcF7LsCNt3XO01CCt2RYRWFsU2Q7m2ppoBgWrG0gP Y4h5nlAC9S0s5vF9W36HvuDUUIACELkSfJ5nXzCJ3FCu/bKr6p6uy/8xm A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="250248257" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="250248257" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 00:27:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="635009293" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 14 Feb 2022 00:27:11 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 00:27:11 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 00:27:10 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 00:27:10 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 00:27:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWLMZoBwet9+k1JSAKtV4P/kgVfl+wH/XQM3Md6jfyN3oG0pXIGfe3m6HTP5TG8Zdp1GLqv8xzHXvqRM05Ma1fPESt67maDy4N4Tn1ZaeVDzeqfpeNP6KL7Wt5Ro/1T1XjbIsDrYfR+XbBPF6cT0fYHLRtFAu6MnkZWXtvAZZBXKxC0RcwDSymROsE6KSEMCl4VCwnEBv461Wwi1NuFdQksG7ppafkTCnCadsf8ZLpHxoNkgmks9gVREFxb/80gmSGBgvnMRqFehBD0og7N3iaZ7VV80OLGlSn7qdnwHi1E0sRcBs6w+uUP4Jf0Aw9qBoKOLMyJBxl/t7E5YEdNkxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fuSaQAJ/tH9F2DVgXR8/R3M1Kc3c1f+pdH2SRTVz+7U=; b=cXeUzKR8Nkl5xLcX57xoeisgymHOFecXz2N3gI2uDBNKaJ9yoz82j0uqbmoMgnhTo8NN8pAYP6UNsPF0ot4fUE+fbRdrDk4fEweUUZAig2i9s0OLaqRPWPV/2sdLzt21EZBQfLITC+tNEg3HocMHd9Hk3tFBl8qn22XakKgFbNHQtXkA8Oj2odQT4LZVVwVFJPnFPsREMO9KeZfsPzqZ37VwIsQlSZFfSkEv5fCljXKaeFABXYW0+y9Ph/IsD8KSX57LET+HDVI8mNcDmhy9MyvbRu3vmuE7ojps8SOVrE5+Rk93NrhPlvEPxSosrUgBdLNpwW7wQC68c2nhc2I7pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by PH0PR11MB5673.namprd11.prod.outlook.com (2603:10b6:510:d6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb 2022 08:27:09 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::e0fb:ec1d:4e67:375f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::e0fb:ec1d:4e67:375f%8]) with mapi id 15.20.4975.018; Mon, 14 Feb 2022 08:27:09 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "S, Ashraf Ali" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Zeng, Star" , "Kuo, Ted" , "Duggapu, Chinni B" , "Chaganty, Rangasai V" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build Thread-Index: AQHYIPb8ndjzqh+PA0OA0hfWD0wWNayStoxA Date: Mon, 14 Feb 2022 08:27:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9816837-4892-4394-09d9-08d9ef93cad5 x-ms-traffictypediagnostic: PH0PR11MB5673:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:262; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N5Y/J/YPsqHDGV8awbD8R4Ji+3KxSoY6d1h02qAAob7P5IsBRqD/XlbRI0DNOEjZWtQ0/lhVAGefx00m5cIYGm8W/xi6+nQ0KTnriXCT48qv3IwW8VsBS6fEBASYaH+5bwUIdHmMc2lAGJKtp9JHbb5pstFSabXIDi8iofvRgpX4o4/rGX4X/IOLr0Z6SmJGcIQhGkGaOqQ5oU1CXLhiBkKi88BwaUpvNDcaaMARO/S+t6Fgm0G/xy11FUc47+q3i1HJSiNUly22q2MPcvXMNRNYVyfR08BtY2JpFDl9ChFdyEvfq12Gustq+DZTNlAYDHEr2JSwyJw1RlIa1mZWi15iGUS09hkJStSq6UYJH3y5WHY1yMAWUeP8e1DDq8bmhZjRy8+4OHSlaADSLiw2HTR7/40Kc69aXyqiosUr4NNoRXVCXhvYXH+6AajapKEUQwlAUfR0rOe1Jf6L2ePrG5Amg2WTlnJesN5REcCnHNYQjCwzhh/ufUWrlxAMhoF7p2Uh8rDAkjmsGKpMAp5Bf30nTL9X5A/pGdrrH14Jy/sgWxiQSaEs6MIBgYovfZRx/dswJP3e/9OXvA1vNt/VX+wdtwf8hf8ZqkK+2bOAn8BpOyqzDdBqztvn1nG+avXDhffFsiKAIAsNuSt1u4u72Y7aKu1w9+kRyrLzDAAfN0dv1XpUAygyaAjG38AQYLAQdUoA1smNR+d3Vw2LvOAIM/yo9+THODCBa2d4bhd8EjeVTfASKIOwUTzPoqW00XdVUicnXWNI+dVb3i6Rj7sk2nXhmvSYbGUnHe6DMEQYZyK8HrG8yEbTEFHMqUZcbc7IwI5h9xQWXIOlMuv4ItHVwfubY81V5OcPxN+57tHb6IA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(19627235002)(54906003)(6636002)(66946007)(38100700002)(316002)(82960400001)(8676002)(4326008)(66446008)(64756008)(122000001)(66476007)(66556008)(76116006)(38070700005)(966005)(7696005)(6506007)(508600001)(53546011)(9686003)(71200400001)(86362001)(83380400001)(186003)(107886003)(26005)(55016003)(8936002)(52536014)(2906002)(5660300002)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AXyXslzCIjnbhFTGhlswXHXl1Xb3eORFDAIXTWkQFeBNq43og1f2eRMahszl?= =?us-ascii?Q?5jdnmFTtYKLt9Rf2WvmYgjFJvIVnP4E1XtgQ124k8kLzH0Ib5WIsir7ovA4z?= =?us-ascii?Q?inXvXwJyMUO502Y3FP+SVF9G0prDvXmoz2rjTlsXF13dL49EY3pSMMo+JBpp?= =?us-ascii?Q?LOp2clBVEVESpwManaslv4sia6iKrVJHAEi73VnQvUiv4xSDZKJX4re0dA9W?= =?us-ascii?Q?NybRewHrNEfHlSCr9YCLpTh7313h22oYD2CsDAi/UAiBzozLXSRFY1Mt2K+3?= =?us-ascii?Q?QyN6b74a/gsw27qHZuqYvrhu7drI6ZoC+8R7I7yIpnEtfnkWrDdlYmYEO68o?= =?us-ascii?Q?vo9Sohns+BR7NAKHGASfZWYgF1MxzDoZe0Tjw6zYxQdI5gj7yJLiuGS4ta8O?= =?us-ascii?Q?MpjZlevTo4YA/JkhmhwOzIWvMmhLaq2vGHakoNnVU+Gz/eyQT8ILlp3+qrvp?= =?us-ascii?Q?pZpwsZaxYwPM4FQraasFk7huRMUFRA09O+IreqQuL63CHg1e3NzRhXQVu/lm?= =?us-ascii?Q?NeRAD2yIC4s39YjvrqfU6klTSl/wfmCB7ccIFxuVR+7iiD9Or69NYXOv5EeV?= =?us-ascii?Q?Ywfr0QE4mD+t1ytXM43mz1k012+DMYRHHcJBlqhWf+ag3+/U/AR15uvMNDlh?= =?us-ascii?Q?Bz0zcYpjVz8odAds6hwk5vrFnxMzKMndTKuYof0ebAsrQeTsaXuW4Izi0wix?= =?us-ascii?Q?1vxyFZtrgPcZ9vx61JglfEJDaIrilNRghY6pfnV0gYVuOSJbNQyUjHc9bE/Z?= =?us-ascii?Q?36vJZe//7o/CC8KjQ/oyRxFV5Uq4AwXHZemU/z87A4msgbwcUA+VE+tQ5i/N?= =?us-ascii?Q?DJ5Q0m9iyPmxcCc2kMUe1lQcZX9bHJuJ+vCSIN89myi3DcuZttbWmf/+obdd?= =?us-ascii?Q?Vef7noKWr4CBp6wcFsooEwrJ9MbBXDVVAKNZ2giY+etHj1wxPd0bzUCeY8E7?= =?us-ascii?Q?VLzP/kT16TVmfCOm8pmiGDHfdb9UkzXshrOrKqD00doqko+oYZ3FD1RfQvIW?= =?us-ascii?Q?DS3NlCYlhGAXaiHujBdWJ/amjfsO95Xpi8b03myiY8Du/IPNV48DCd4NcymZ?= =?us-ascii?Q?wbGUZiLgKuQq0ycRMXKgdpQYFwFM/sfn3KF0C8s0R713xPyLtUX1IOMhXzaA?= =?us-ascii?Q?a7b6lxV5/EYHBNPFSJVipMi0R1GtYx4MuAgpPh9ZmQQbuVKnoohRxVBPwBuB?= =?us-ascii?Q?UhREV7WSwpOpvBRnM0EQPEtrBmrUIesPdG9ifHzDnLYYNz+jwYPBZ67UTekL?= =?us-ascii?Q?t+oGeQiU9JJRSA0C4Kivo6BopvFJhv8qAfo3W9l9j//HTpNbsoLQ8ozW8Ihq?= =?us-ascii?Q?ZzmjKqfR2WnAcC1lEm2hALucdFdTfJzwQlCqmXb0dSYQbZeTX1QeH2ZzSRZU?= =?us-ascii?Q?gpNhzvb/bPJOEFoo3bA6qfCecI1NSniIolf492e+wHbqYUt/ZeTrskbqKUnN?= =?us-ascii?Q?/WGHql+5XR6ppU7w2bvE054FDc/91hrtztPOMHXv6Z4wu6Z7bvWUG5Bl9Ngx?= =?us-ascii?Q?8oUd0k4uzA6ni1Ku0wRKLyQnINVtyLvNXz56VHd4Q636Lf/PNW+1VsKy7B/d?= =?us-ascii?Q?V4K5F5C8J66+TgQwxhK0ZvIB3+IHlm1D85Yrmzv6/0k5jQL+51DZIr8ohEt9?= =?us-ascii?Q?tC+8hM4p3Glhbyplbb3fs/0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9816837-4892-4394-09d9-08d9ef93cad5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 08:27:08.9326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3hjviJbP/zAMAadHK7kB1HI9z8QU+nsdjf0d/Fp9983RzX2D+M+2iZ74ZYKGFNKZjAB4A84PYLgNvzPJ7EHInw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5673 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ashraf, GetStackFramePointer() only returns the lower 32 bits of RBP. Is that expec= ted? -----Original Message----- From: devel@edk2.groups.io On Behalf Of Ashraf Ali S Sent: Monday, February 14, 2022 12:27 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star <= star.zeng@intel.com>; Kuo, Ted ; Duggapu, Chinni B ; Chaganty, Rangasai V ; Solanki, Digant H ; V, Sangeetha Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Suppo= rt for X64 Build REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3833 Move FspDebug to the root of BaseFspDebugLibSerialPort since the current nasm support for both IA32 and X64 Build, remove IA32 from INF file. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Kuo Ted Cc: Duggapu Chinni B Cc: Rangasai V Chaganty Cc: Digant H Solanki Cc: Sangeetha V Signed-off-by: Ashraf Ali S --- .../BaseFspDebugLibSerialPort.inf | 8 ++- .../{Ia32 =3D> }/FspDebug.nasm | 50 +++++++++---------- 2 files changed, 28 insertions(+), 30 deletions(-) rename IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/{Ia32 =3D> }/FspDebu= g.nasm (86%) diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLib= SerialPort.inf b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebu= gLibSerialPort.inf index 14b1899e6c..0024edf2dc 100644 --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP= ort.inf +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialP= ort.inf @@ -1,7 +1,7 @@ ## @file # Instance of BaseFspDebugLib # -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+# Copyright (c) 2014 - 2022, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -16,14 +16,12 @@ LIBRARY_CLASS =3D DebugLib =20 # -# VALID_ARCHITECTURES =3D IA32 +# VALID_ARCHITECTURES =3D IA32 X64 # =20 [Sources] DebugLib.c - -[Sources.Ia32] - Ia32/FspDebug.nasm + FspDebug.nasm =20 [Packages] MdePkg/MdePkg.dec diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.n= asm b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm similarity index 86% rename from IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.na= sm rename to IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm index 997e375c8c..ffacaa239d 100644 --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm @@ -1,25 +1,25 @@ -;-------------------------------------------------------------------------= ----- -; -; Copyright (c) 2016, Intel Corporation. All rights reserved.
-; SPDX-License-Identifier: BSD-2-Clause-Patent -; -; Abstract: -; -; FSP Debug functions -; -;-------------------------------------------------------------------------= ----- - - SECTION .text - -;-------------------------------------------------------------------------= ----- -; UINT32 * -; EFIAPI -; GetStackFramePointer ( -; VOID -; ); -;-------------------------------------------------------------------------= ----- -global ASM_PFX(GetStackFramePointer) -ASM_PFX(GetStackFramePointer): - mov eax, ebp - ret - +;-------------------------------------------------------------------------= ----- +; +; Copyright (c) 2016 - 2022, Intel Corporation. All rights reserved.
+; SPDX-License-Identifier: BSD-2-Clause-Patent +; +; Abstract: +; +; FSP Debug functions +; +;-------------------------------------------------------------------------= ----- + + SECTION .text + +;-------------------------------------------------------------------------= ----- +; UINT32 * +; EFIAPI +; GetStackFramePointer ( +; VOID +; ); +;-------------------------------------------------------------------------= ----- +global ASM_PFX(GetStackFramePointer) +ASM_PFX(GetStackFramePointer): + mov eax, ebp + ret + --=20 2.30.2.windows.1