From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.8955.1644993267949371397 for ; Tue, 15 Feb 2022 22:34:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YgxT712V; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644993267; x=1676529267; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1bp2aXd0gd/0H5XD+Bund01cR3v1p5uTNIA2mPg1thg=; b=YgxT712VUp2ghs4dZOnzT+AnKRnxsbNc0ggHFHt5sAKM1igIffvgD2mb xR+SRBlfr3iUskXyoTaYGGvm0Ei8B0rPtQwo2SJJlCybBbufLoKEDKnkJ BqZr9ZOVtd1gvW6BDCMkIhgIhA4pRJlJghtNDUDtGpATUgZVjjcB88avQ deA8d7jaZICn6icpaW/ZoC9CStgzoLOOrhzNbEUvxPWbL592uPcTEJzh3 nr7q42EvtwquJg1kUoUmHi3YVxz2yr+5zSIhlxddy6Y/9DC+6z75aZHp0 +DAlT2G/PZ7VLyspjQ0VoUyqWa16taXRzAnSBI4WXqVCcq0wH0gfenoQy g==; X-IronPort-AV: E=McAfee;i="6200,9189,10259"; a="275114775" X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="275114775" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 22:34:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="636353620" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 15 Feb 2022 22:34:26 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 22:34:26 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 22:34:26 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 22:34:26 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 22:34:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DM10RlaZDwdnpx0gjHQ5+L50h+ejlZy5vVCBtdwbTWByYdWFZR8cn3tkVKmo5P3ETHtw1wvYEGJylHd8GrgiuHcMSEVcB+SkMyX7t8ZAlZVty/iRy3y6xAVOwE0u5wF+LFfAcak+5s+aOtxB30sPdKKvkvYs6lMjo4ojUAm/rIlpfonNd/bCh8uHf0neiHumN7t+JZK6e8PFtEe5TGaCR33ZO3Z5Q6TqXNuAEyR1hbui6ATqdECHx8QLzsSKaPuTCtBGouV6FH1eRbvTw2NzEMqoFqefHRsER1PPiS/2xfSRufUYNoSGtP1e5tRtGEpcbpHl+SdlaFYjq8p81OG+bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCbMJmhqJBWEhj4QJv/z8G9YxVsqUh9EKMc6pKNkwWM=; b=FhbNxk0KDb4oRKKYbT6KSiFe87jkwmK2j3EZkxh19803qyl2hO+tJRbFafLoRzPh2jXRpJApT/9ZwcXkOQdXOSBWhUMG2qHVtCAfTJ3bYKrmpKClckVfOn3EDiGIbvPQR0uD/gBYlhKUfm96nSBMOH4drxmmAXqAy8JNBTZzQ6cWtf5q+PHnevnGd13/RuaRl4Esi+bQkAosXui6pEj9MjZbms5UCGZ8ZSrffd+OsyAxvNS3bQtm3XpSjNzCMKq8IOX7QBAJgZNUAxTK10xunoWggegqcrue5jSbhzklHaD7joFr/nmkAWZIvTlVNNRXEnukeaXPbO0dJibZxm9k1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BL1PR11MB5446.namprd11.prod.outlook.com (2603:10b6:208:31e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.15; Wed, 16 Feb 2022 06:34:24 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::e0fb:ec1d:4e67:375f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::e0fb:ec1d:4e67:375f%8]) with mapi id 15.20.4975.019; Wed, 16 Feb 2022 06:34:24 +0000 From: "Ni, Ray" To: "Gao, Zhichao" , "Rehan, MohammedX" , "devel@edk2.groups.io" , "Esakkithevar, Kathappan" , "Pethaiyan, Madhan" CC: "Thirupugal, MadhaviX" Subject: Re: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Thread-Topic: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Thread-Index: AQHYIkMWesj6StXxsUGD9DWXKmgyl6yUQjmAgAF3UMA= Date: Wed, 16 Feb 2022 06:34:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ca94522-b6d4-4111-c088-08d9f1165f7d x-ms-traffictypediagnostic: BL1PR11MB5446:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:651; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XTVaDEIZEbLzf1MDsB3GbGIYvvY8kYbpHDKr4bGydVct3jKS/ffUS1BTO66pvLKFbAqVTGok6tTg+uhfZN8SmYj8bDLWSh8GaGMMFCFhVsdg20MB1z170dK5vKlqmZozc1IJtudNc2WmykUQtPLnmz6exXvfzRB6Y2gs/Txpn4S03QRpu3Iuj6Bc2i1YdeVX6oLIbIWYF786z7lgZS6nsFgdbgo0D/O929XL+XKL5SwJu4X7+WgRtptJE0pPlOI6/ZKQcXEUq+Xfmyuup+qT0N8sl8m9rL7XRTiQS+eEYnlWE53ifZx/AVm46UATS3SBVMr4eP61zNw8qVfqox7XLlHR2yMXBb6f6rumriR4oIngE74GunhRioAzVVU53ZF8YzxBkGZRLlSSbyHFCR91VQrYlfqNcAOqV05dN14h3bepsJX0BSZVYB5d7Dvh9tNiRcnI1boEE4xtpE96CmH0zB1+7b8vTwj5oHHb5zUPKZUkf28MkqMQEGgWrTQ4cV4ErOMqfumTsGzJmxkARdaIHq+6pQPxxRa55kFjN5kD+FAj0g1q5Pbc8oMLuy8b8LPPkiweMFNzIK1nBxVtCvUEEESYA5lj99JrYZU5UDZwsxbmTwgNddZhR7KklF5fbkVsE6JXj7pst1gqzjyIbCCNMlZzoiWW9io1QeLJN5w2S/HNWGjm+f3K0PCLr4LLoBl9zRklmGPfYqH+cE6WA5VntdXtx1ysM2DtGvRVKB9i433wz7N2b0yZwWKC51mciJ2jxQ1t9BroDCS/F2mRYZhvr9H34DR1bMlgW/L2ndkmGaI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(9686003)(186003)(82960400001)(966005)(71200400001)(38100700002)(6506007)(53546011)(66946007)(26005)(66446008)(66556008)(2906002)(76116006)(52536014)(66476007)(7696005)(8936002)(64756008)(5660300002)(4326008)(8676002)(33656002)(6636002)(316002)(38070700005)(107886003)(122000001)(55016003)(508600001)(86362001)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1a5wMq/MfgiojHyp/VnNGIhF5lVRpwOrNfe7USLu8+OJzEoWpvHEC9gFNaHU?= =?us-ascii?Q?0dOL8BuR/mXzcHbwYFZPjV+tYEIfSwKRCc5LajBRt1ay2fE2i5H741Hs0ciy?= =?us-ascii?Q?6GppeMrCz+W1Tu1znjGK6RcZX5D0d3povY5x87oaI269fddHH3GDScfgTamj?= =?us-ascii?Q?vDhwVFg1sMXuN9mh2K5CEXE2bs8+L+bqW37qtsn4GaNDWMHhF4nX6V2pGAMv?= =?us-ascii?Q?lSgffqogVUJVPKjkZ1UcgTHDN8Z/lpknEkCCCyTyjymBJN8txJA+POYg80Ou?= =?us-ascii?Q?24nh6Vvb82rfMNdGchs0pPS5MPKd0Vyyz1csucz7nD4vFfJZwl7AorA9fH/4?= =?us-ascii?Q?UYIOTnXc1byfTQdVgaTMMNxGQjSfUAIaZlN4P+06YgzVN3KqR8ObaPlqSOvX?= =?us-ascii?Q?1Cb1AsaxfkoZSpJXJp7ah+LkR+rM0ZqdaGBDZdH/O0VSofN15TrDw7oGVd17?= =?us-ascii?Q?zBi+OtkFezF1MiwpW46afu1UjEl/vmLoT6YBYHugtQmy38j9KX86lukPwTgU?= =?us-ascii?Q?F/lgXyYPtNdzbrHjl4ucQgTAULoiO9yIohXsy5j6mjTfqYp684P9lyuv4+r1?= =?us-ascii?Q?ATSNP9LKCb3GLKs9kEyvinbJRj8pfXgZ0/w1H3+YY3yW2osoXhK4Bkj1AQSH?= =?us-ascii?Q?fGpVFQL0B0dni89622bK3cL5p0G/kPBUgJf9BRibQrShELNU4gtMaS+1mv8w?= =?us-ascii?Q?1+0XrwFiv9rdoVkCvevyDNxycjkcKMTOjKFhjdWAUHkOce8kvrMIZHdtz7mq?= =?us-ascii?Q?5517imY95CFc/VyNy7gGCp5NCb6GzX16ylSf8lsbnUVUGRFE2QUAqb+caUUz?= =?us-ascii?Q?Q62Vu1DtekesIWdQuTjhCNHjd19Iwv56Yhk4vJzl+TrXpWpBtVA9qePaXl+1?= =?us-ascii?Q?c819ZMQYHW5YfILmdEc025jSrtGkux/4iUSrYZZGD+qdH/Ob/R7YgH4FXLm+?= =?us-ascii?Q?oWffrc+c0NwLJYJtLYMpfCrUNKfxsdEzEoIataXFXnZEJOEwuddtzXet1z7F?= =?us-ascii?Q?tw2F6SyhCTng+QT7jiiQ8sjdmsgQGyFN52RAcaDrBnX2QXiWgx0nPTxVdvv9?= =?us-ascii?Q?89egZ1GLoELclTDuO/5w1QKh+lYnBOQs254MfOSffHoK0RZbXUE4fIY+XD3B?= =?us-ascii?Q?XJenlYR/jnpSMmjvVTBIIWMRtpKrRYQjSj+KlJa0CxyvL9w7cW3oqHglp7n7?= =?us-ascii?Q?6aRve7MJidn9zf7ClpPSYEvXiiGwhlxwDoqdBnh7X2xnvy6MrKuFw2Cue/5/?= =?us-ascii?Q?2qY51/qfLQxEaC+CUnqQg8f4Rwtqj6E13m903luvjvIZuS2NVhs9NTsZMnw3?= =?us-ascii?Q?rFuhHwVFrgptJxiSMdN8RK7VGgiEB8Fyi+Yi7/219RAocQntXVnK0VB40Nms?= =?us-ascii?Q?eEz0eCmiwjwzc8rTk3S6BTLRBc/cKMswO/wSJo048Rpaczv4wahd0mJSeUsU?= =?us-ascii?Q?DJvsBTXdrdWgwBwZrifuWWjOmr0NAd2j2ABB6YG7yUaztUv+R5U+LklWtHAc?= =?us-ascii?Q?sB9p+Dq5uARNIUcXwmmoB10mcxy/L1Atc1lEfcQ+W3R5HKHjiaqqwBvC3jwc?= =?us-ascii?Q?uo8L0dxM31JU/D7v5jxXOe9A693WIXEjJ3kM3H7/VMviwhSLB/94OooyrXfy?= =?us-ascii?Q?3YmHa9UM8ZEojumzxqk26QY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca94522-b6d4-4111-c088-08d9f1165f7d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 06:34:24.2349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5vYPQLb4ZhVPy6ddW/Au/aSVIGVWYDl3xXHsgn7cxmplu+6L4Zcdj3O7XnveKx7SwztzXbuEoSrozMwXUzxknw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5446 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Gao, Zhichao =20 Sent: Tuesday, February 15, 2022 4:10 PM To: Rehan, MohammedX ; devel@edk2.groups.io; Esa= kkithevar, Kathappan ; Ni, Ray ; Pethaiyan, Madhan Cc: Thirupugal, MadhaviX Subject: RE: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Rehan, MohammedX > Sent: Tuesday, February 15, 2022 4:07 PM > To: devel@edk2.groups.io; Esakkithevar, Kathappan=20 > ; Gao, Zhichao=20 > ; Ni, Ray ; Pethaiyan, Madhan=20 > > Cc: Thirupugal, MadhaviX ; Rehan,=20 > MohammedX > Subject: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3819 >=20 > Ping GetTimerPeriod API returns sometime zero value when StallCounter=20 > has smaller value than RttTimerTick (divide by zero) which results=20 > some failure at ping UEFI shell command >=20 > Signed-off-by: MohammedX Rehan > --- > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > index ec1e0a188b..6a002b15e5 100644 > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > @@ -259,9 +259,11 @@ GetTimerPeriod ( > EFI_EVENT TimerEvent; UINT32 StallCounter; EFI_TPL OldT= pl;+ > UINT32 TimerPeriod; RttTimerTick =3D 0; StallCounter =3D 0;+ T= imerPeriod =3D > 0; Status =3D gBS->CreateEvent ( EVT_TIMER | > EVT_NOTIFY_SIGNAL,@@ -295,7 +297,12 @@ GetTimerPeriod ( > gBS->SetTimer (TimerEvent, TimerCancel, 0); gBS->CloseEvent > (TimerEvent); - return StallCounter / RttTimerTick;+ TimerPeriod =3D > StallCounter / RttTimerTick;+ if (TimerPeriod !=3D 0) {+ return Timer= Period;+ } > else {+ return 1;+ } } /**-- > 2.30.0.windows.2