From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.8137.1647330113293146708 for ; Tue, 15 Mar 2022 00:41:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C+/GySS9; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647330113; x=1678866113; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IPTTjIu+j2Uss30/8VafT4xKdEnV10u93t0DsRl9AkA=; b=C+/GySS92Ei/knFDiiAh2C27F5Ei3RCFPDbMFohMgJdukeejZf8Pw2EK aaT3jNYfy7xuf74rz/2wGHuZicbf3zrQ8jQyb2iR/7UcmlrzEUitroVkH 5Drp3QCFtYop0mU8zSjyCYptDlZuhBidoP+6uXA+ZSvqT0RvEV+U9Tgpe ZQyvTuvmpfLrWtJgXhluCKLyigMfrrqSEyLjGuvQ2rD+8vs5wm1dAPI+4 1A9Zq2o567h5wFtMxtW4ZUhdZJOQgebLKYOAiRsdw16GG9ihVja3Yjs9q l+avJRTU+Q08umay5KGBAuU7Y0qrxYxZ5/fwQqoj4cfcJpcJEYMjl+9Pk g==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="342664512" X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="342664512" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 00:41:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="714057470" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 15 Mar 2022 00:41:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 00:41:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 00:41:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 00:41:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfR8dgEk0Qo1zIvqxDnOMKvW2EWAsouZ6uTM4Eln7H/hnOQOlYK6rrEDb7MGGigDVIRLhei4ceSRHh41QwcCudSpXf+/6pV3jan5d8IKfgEW1N1+HrkThcgW/PEmjR9FZi/tGAgiu6Oyc6oUf4yYDA4UaAcf/+6NbtFXoJAT7Yva2uOSDNyua9zvzK7rB0gZJyh9x105ihZPHDTozd8UtXwaNRCzD72OrNxPrM1toAk0RrQmUwX0l9QpisA/2wmoeNGRJ4D++Ot6Vs5dhC944J89BiyuMJfPq+ZKk4tyhX/lUxbAzxZAyv7gsI1mgqy8qMOKgYWhNKiNTAi/ROybHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rOGcB/BgWrPa+oAQKK4FuRZ2Y+MYo6WTXmWU1ZKudKo=; b=aUqyvSYC3IANukZkvuwc5VfM/8TpJcWszo6B+YPRrZSmKHNIlIX26m14wjHoeBLyV6L+3vxXLsxmQsHbrEpKwNfo/6PDnL4ie6s42zcoRbSVTdFz+2qsWVgoLpZtBKO7XdDpQZHoCBcdcyvLaxU7WN9BC4iaFKx1FzVzuVvQ6mHoNefuki6AN9p3vGZzKmIcK8dlWL7bDiuJrg2J/mpMAI4UrMH68DTgpJhNbXcwH8F2a4drZRAs0gVD9l1lyPTkAE+NGwUBOAYkg6kRO/zNXrNJtrCuH6L271OIf3FRe0GxN2/imn6IRXYQv3fokxRBUttnik0cjXu8XmY4oUD0XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BY5PR11MB4371.namprd11.prod.outlook.com (2603:10b6:a03:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Tue, 15 Mar 2022 07:41:47 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.028; Tue, 15 Mar 2022 07:41:46 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Xu, Min M" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Topic: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Index: AQHYNbQpNQqpEoTQJ0GnfoI7ybFGGazAE8Zw Date: Tue, 15 Mar 2022 07:41:46 +0000 Message-ID: References: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> In-Reply-To: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e190ca43-5e34-46a9-d3fa-08da0657423d x-ms-traffictypediagnostic: BY5PR11MB4371:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KdMGZSTdv2r5BgYFyXyyv2OQnE3AEHk/ohRNgPjduiVP+WpIB7/dsiq0jfIMMxvm3VZHwld83S6PxB+5NfUzQTCsABnOntpFGQEVqabBmSQrULzwclnOCqYFGRQFjMV0kCCCW4mwShHyhLxfhj0lNwD3eimetQPtSawApO1zyaT7T+jA17oMuhUQF6X0ZH1it/wcaHqJ+UhRTetGQlnbjX39vapnp9kSVwkuhGHP9nPhx/UkoABAkodCvogehqX3uTyG96J9qIfIq2YVYKwcjVr7aso0CCl61kXIlRVvO5MnSgFJ5x2Sz345Rf2+wdlRN8hhzcOB6FMk6hfThNZA2wDpxbejf+Fnvg+s87r28cMRDDsO5aBtjoC1wI/nyoMkYc5upnjdUJnj/hyoigIhy7qjsTY4jOy9vd9d2d0NVBnysTenfNjHnT0GxP5ODWijQqKjC69HhUtQcbVhLflbQy30KsKOlwFTubgXOGMCmlamQMm6Bl6AU4BCLi2uYw+7tAzD/ZNq2t+3D8g9uVi9jCWzVjPEVXGwtyrbqcX5In689WoOIYujY1UamJdpg//EalNdPxmfcy8uKqj68NVRiuXtABUw+OcmslloP4hfEsTn1Zyb6r9WQ4qwyTD1LYNqH8XP04hBIPQr5JseGEPCIFYUxr10N8yGDXq9ePJ2jgB9CtaKgTDjCMmBIfzM4qcqxjfIkyaFnv05dcnZzoj7xQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6506007)(26005)(186003)(122000001)(7696005)(9686003)(82960400001)(55016003)(8936002)(5660300002)(2906002)(4744005)(33656002)(52536014)(66446008)(66946007)(86362001)(66556008)(64756008)(8676002)(66476007)(4326008)(76116006)(508600001)(38100700002)(38070700005)(71200400001)(110136005)(54906003)(6636002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kRkrABhwsd+CJN2nEI/kbWNp6l8UihYtxcVESfSiSElYpCxxqUhRnCFpOzj3?= =?us-ascii?Q?BHWj2b4iJ5StdPMEQ9FYNeLC8gnKjD8qnIcdCYBQeQJxvSXZr9ZF0MIAtdsc?= =?us-ascii?Q?8CA8cr+P5hv9EJiNTZxANdC25ikj8Toweo2/+52mVy/ILmxxWT44fR3Wvyxu?= =?us-ascii?Q?xHtMLVVko+QEIEI88sSyK6UTWMgYEk2wpJX6H30HRzKN0p4wTvqxtoX1Kuq0?= =?us-ascii?Q?qvPep6vLm3vNPdag5sAhPHLFB0tLIf0S9PztD98fH8JzHey0PuMPc7rg3+ia?= =?us-ascii?Q?q7/RYXn52rqSbkfyjFGTioi1mtGwqaYsOFJxlM5kCr+n2jgtTOXDJrT+H1H3?= =?us-ascii?Q?WzGVIVtNwRvhO5/2YBXo9ygEuEdpgZ5ygej4uyUZmMetaH/4rwRG4GgZQT3v?= =?us-ascii?Q?/vPGMGHC3o8OYqqfwmUavvd4KRrzv/rmvgHsdIenowd8LZpS9JmA0WsVFF5N?= =?us-ascii?Q?3SdKrE359LZccjrGsCsWBt/r3vcMS6byTXnfJvdLEkDLI+jty5cNz/MGJi11?= =?us-ascii?Q?/UViOADl1JoZtoTS44jeIKK4o51u1utSPLuiHj7X7BGG72LIy9h8oYUag+mU?= =?us-ascii?Q?1KPOJ5m9CwV5SQ3fhocMpRmObchCf5gWQw5gayVJugCHnYc3zElV5vNVBq65?= =?us-ascii?Q?8WU7PzCyPm/QxlZYs7yrmTBFiYvJgv84edR9+MxthNcdYS9+16J/YDDGpQIV?= =?us-ascii?Q?LOSPC5qV8pJynJz3qJCU5t2gAX7d3WIUfywp5TBCaoKLbljbBWEMMb+f48Wc?= =?us-ascii?Q?P9CLfOR3noR3GozR63RCG8OwqMlwLNAO5GGIdnL3jqNes3XJCW1+gE8RxO4n?= =?us-ascii?Q?el6olRPgdGJMLsnvBL7Fn9jQNU2vF+bAXHrurDbcShAyZ89QMGcUS0uXNUJ6?= =?us-ascii?Q?/Fdtzp5du1qm8JMvgiwFk/3gx9nctS+y7xfBRQnzcp5l0FSIK9NY84y7UeRb?= =?us-ascii?Q?gtgw0fK73RMOJ2l2+voJiJD49+pfoDVlHS/c4HKs7t9IttUYy8hMOR07vfJo?= =?us-ascii?Q?97sYb7R8TtOrk2+yiZ8yXhFeY9gnhuXTk4Im3MFGsZ5mm1SPqARl9+s3IFX+?= =?us-ascii?Q?1lJY53w5f7Q3i0mc++xNqy5DLqsVRBKWLu4xoYyvwxlVkTdc7a843L4a5s0K?= =?us-ascii?Q?Y24Ey0ECNSqXmCcX7N1wmF1djdq4/fz0hgF3BiJvrferMJMjqPcXSlogCwv/?= =?us-ascii?Q?9eQ+uwNxj+Jb/l5Tyha9/wDeJbfN5/zLh2CaEvVtbvcJWlgaUtvQF1y6xirs?= =?us-ascii?Q?fTdOqdT+/DrU8lH8S88wZm8rV7UFLJbul3Sd6tf3QmhII2+MtZJ21xoktQ8F?= =?us-ascii?Q?c2R96ZzNCEXwFJ7/vZ/ewmKfZR2bW82vksp6WcVQjFwFU5ikhgRGhjr/+7Fl?= =?us-ascii?Q?Yw7EPb/h+WvC8jul4V8TDvPV86o4w2CN12PNHyrdmGIdKBDP4fdn6wRHKMO3?= =?us-ascii?Q?3EGNQryoktDynPXTz0DEZb9/3VGWM0u3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e190ca43-5e34-46a9-d3fa-08da0657423d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 07:41:46.8209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CBdfL3vz5UZ8BgKzlBOqxNynkDk0BPbcpVuSpN2VV4C/Fi9kk7TxrknqoE8e3Oxd51GfyVqMOnyj64q//YJUKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4371 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + +%macro tdcall 0 + db 0x66,0x0f,0x01,0xcc +%endmacro 1. can you please check whether the tdcall instruction is supported by late= st NASM compiler? + AsmCpuid (CPUID_VERSION_INFO, NULL, NULL, &Ecx, NULL); + if ((Ecx & BIT31) =3D=3D 0) { 2. Can you please update CPUID_VERSION_INFO_ECX in MdePkg/Include/Regiter/I= ntel/Cpuid.h for the BIT31? + break; + } + + if (LargestEax < 0x21) { + break; + } + + AsmCpuidEx (0x21, 0, &Eax, &Ebx, &Ecx, &Edx); + if ( (Ebx !=3D SIGNATURE_32 ('I', 'n', 't', 'e')) + || (Edx !=3D SIGNATURE_32 ('l', 'T', 'D', 'X')) + || (Ecx !=3D SIGNATURE_32 (' ', ' ', ' ', ' '))) + { + break; + } + 3. Similar comment as #2. +%macro tdcall 0 + db 0x66,0x0f,0x01,0xcc +%endmacro 4. similar comment as #1.