* [PATCH] UefiPayloadPkg: remove the redundant PCD definition. @ 2022-11-10 1:52 Jiading Zhang 2022-11-10 1:58 ` [edk2-devel] " Ni, Ray 0 siblings, 1 reply; 5+ messages in thread From: Jiading Zhang @ 2022-11-10 1:52 UTC (permalink / raw) To: devel [-- Attachment #1: Type: text/plain, Size: 1760 bytes --] The following PCDs have no value in the file of UefiPayloadPkg.dsc, and they are not used in UefiPayloadPkg, so remove them from [PcdsDynamicExDefault] section. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..43768909b3 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,6 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 [-- Attachment #2: Type: text/html, Size: 2382 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. 2022-11-10 1:52 [PATCH] UefiPayloadPkg: remove the redundant PCD definition Jiading Zhang @ 2022-11-10 1:58 ` Ni, Ray 2022-11-10 2:10 ` Jiading Zhang 0 siblings, 1 reply; 5+ messages in thread From: Ni, Ray @ 2022-11-10 1:58 UTC (permalink / raw) To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn; +Cc: Lu, James, Guo, Gua [-- Attachment #1: Type: text/plain, Size: 2157 bytes --] These PCDs are used by PciBus driver and MP init logic which are included in the UefiPayloadPkg. From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang Sent: Thursday, November 10, 2022 9:53 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. The following PCDs have no value in the file of UefiPayloadPkg.dsc, and they are not used in UefiPayloadPkg, so remove them from [PcdsDynamicExDefault] section. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..43768909b3 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,6 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 [-- Attachment #2: Type: text/html, Size: 6569 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. 2022-11-10 1:58 ` [edk2-devel] " Ni, Ray @ 2022-11-10 2:10 ` Jiading Zhang 2022-11-10 2:34 ` Guo, Gua 0 siblings, 1 reply; 5+ messages in thread From: Jiading Zhang @ 2022-11-10 2:10 UTC (permalink / raw) To: Ni, Ray, devel [-- Attachment #1: Type: text/plain, Size: 3200 bytes --] Yes, these pcds is used by PciBus driver, my comment is not correct. My intention is these PCDs have no value in the UefiPaylodPkd.dsc, we can use the default values in MdeModulePkg.dec or override the values in UefiPaylodPkd.dsc. On Thu, Nov 10, 2022 at 09:58 AM, Ni, Ray wrote: > > > > These PCDs are used by PciBus driver and MP init logic which are included > in the UefiPayloadPkg. > > > > > > > > *From:* devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of* Jiading > Zhang > *Sent:* Thursday, November 10, 2022 9:53 AM > *To:* devel@edk2.groups.io > *Subject:* [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD > definition. > > > > > > > > > > > > > > The following PCDs have no value in the file of UefiPayloadPkg.dsc, and > they are not used in UefiPayloadPkg, so remove them from > [PcdsDynamicExDefault] section. > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize > > > > > gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds > > > > > gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode > > > > > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress > > > > > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize > > > > > > > > > > Signed-off-by: jdzhang < jdzhang@kunluntech.com.cn > > > > > > --- > > > > > UefiPayloadPkg/UefiPayloadPkg.dsc | 8 -------- > > > > > 1 file changed, 8 deletions(-) > > > > > > > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > > > > > index 1150be6acd..43768909b3 100644 > > > > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > > > > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > > > > > @@ -530,14 +530,6 @@ > > > > > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) > > > > > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) > > > > > gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) > > > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport > > > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport > > > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport > > > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize > > > > > - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds > > > > > - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode > > > > > - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress > > > > > - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize > > > > > !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > > > > > !else > > > > > -- > > > > > 2.38.1.windows.1 > > > > > > > > > > > > > [-- Attachment #2: Type: text/html, Size: 6172 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. 2022-11-10 2:10 ` Jiading Zhang @ 2022-11-10 2:34 ` Guo, Gua 2022-11-10 2:51 ` Jiading Zhang 0 siblings, 1 reply; 5+ messages in thread From: Guo, Gua @ 2022-11-10 2:34 UTC (permalink / raw) To: devel@edk2.groups.io, jdzhang@kunluntech.com.cn, Ni, Ray [-- Attachment #1: Type: text/plain, Size: 3162 bytes --] In dec file, it have compatibility for [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] In UefiPayloadPkg.dsc, in the same time it only choose one of these attributes, so on UefiPayloadPkg is choosing DynamicEx PCD as its attribute. Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang Sent: Thursday, November 10, 2022 10:11 AM To: Ni; Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. Yes, these pcds is used by PciBus driver, my comment is not correct. My intention is these PCDs have no value in the UefiPaylodPkd.dsc, we can use the default values in MdeModulePkg.dec or override the values in UefiPaylodPkd.dsc. On Thu, Nov 10, 2022 at 09:58 AM, Ni, Ray wrote: These PCDs are used by PciBus driver and MP init logic which are included in the UefiPayloadPkg. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang Sent: Thursday, November 10, 2022 9:53 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. The following PCDs have no value in the file of UefiPayloadPkg.dsc, and they are not used in UefiPayloadPkg, so remove them from [PcdsDynamicExDefault] section. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn<mailto:jdzhang@kunluntech.com.cn>> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..43768909b3 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,6 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 [-- Attachment #2: Type: text/html, Size: 9955 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. 2022-11-10 2:34 ` Guo, Gua @ 2022-11-10 2:51 ` Jiading Zhang 0 siblings, 0 replies; 5+ messages in thread From: Jiading Zhang @ 2022-11-10 2:51 UTC (permalink / raw) To: Guo, Gua, devel [-- Attachment #1: Type: text/plain, Size: 129 bytes --] OK, I got it, thanks! By the way, I don't know whether it is appropriate that the PCDs have no value in UefiPayloadPkg.dsc. [-- Attachment #2: Type: text/html, Size: 149 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-10 2:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-10 1:52 [PATCH] UefiPayloadPkg: remove the redundant PCD definition Jiading Zhang 2022-11-10 1:58 ` [edk2-devel] " Ni, Ray 2022-11-10 2:10 ` Jiading Zhang 2022-11-10 2:34 ` Guo, Gua 2022-11-10 2:51 ` Jiading Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox