From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.255.1665194552283366182 for ; Fri, 07 Oct 2022 19:02:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EWEHOAgt; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665194552; x=1696730552; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7NDs8pitXJLqCk37MxYbBkHxk0ObmmNYvoRDVk4gbbU=; b=EWEHOAgtkTrCOffjL08mxBjzWc/IhuoECR8N5thAqH8CmN3G7dw1QzuY J+QGqdQe1cOj3qMXsWaUy2Em7dguXUDy3Li2wukMPn999DsGcyoaOMNTH czYaxNZ0Bk+LGggLTKPzsonSKpBYfW8QmUkHEMe5HHOBG0DsZXHdH6f6p B3jE8s57RTYKa6VwZ7zNPiMnkZOLduhyVfroBq4p7JIjHEu9ViXU+xJFF q6K7j4Iub2uBBTFR8u7FeYU1gNZiGv0fmbV35fmxdZG2AqWoEdDgU9YIR RQFBGBBraSMyBWPwC+jobR6d5umoRWf0BTrQbYc5JycuDW8n72P4oBVFk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="365828360" X-IronPort-AV: E=Sophos;i="5.95,168,1661842800"; d="scan'208";a="365828360" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 19:02:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="693998601" X-IronPort-AV: E=Sophos;i="5.95,168,1661842800"; d="scan'208";a="693998601" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 07 Oct 2022 19:02:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 19:02:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 19:02:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 19:02:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 19:02:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OO743Ix21eeYjpQ1PviydRRdPNKQQsSaAHGv3p5vABF4hDLL5C2QLO0F693AySuIz4L0YoG2BpqWtJhf5gHpL1R4FfkRW+EyIlGjaaGOiC/uow4UNiI1S1tC1BSTVkfVKILLuJEU/8YYerzqmhhKi29gHpVXZpNpkGOw+OChhBQQ0wc18VR5ct7Dc8DwmhPxGil4mq+tFmN/dKCQY78BUJYzQ5e8J1g7MSfvrYi6pG6Gc/SQ8vF4f9dzj0Zw37k+9DboIzLv/Fl8b/hR5m6TF8jdL/ewJ37VUh97vkVhizT83OHuttL2/IEANWV3zYY7EGgmeG0Z/rWUROecizA2ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=haFONIeSaBLSDSfSGsNhepLTv0pCsdWu8hIWleixTM0=; b=jox5MrIHGFnPDHm7D6NxsUjNhAqZLjUG7NfgvW2/F46Log+Iex+Qw6YdGIXidWhHhxuqF6cbtYATwx5CS/bRPWawfResDsMfUwzp/VF9W3T3mv3EOiE50FlfwyY6VPBV8MKqxLrLojfmBKUt1QU9tNgL6jJW/fhIeiB1MPoSIUHCOdFPNnJ9nzd6FB57mdk+H4lL9SWZe0JBrIMdB/Z+5h5xmwMPcJRYpu0BTxmNHePdd8l+XjI1JSulDloftv3kmVPoN/i0HHRe3zGTOVoPlQnt5DeCtCtGvOXB8uGK1mhRR7C7cJgfqq8cP43XFwMO5e1PXfX7+jX0bsFkiELHJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by IA1PR11MB6099.namprd11.prod.outlook.com (2603:10b6:208:3d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Sat, 8 Oct 2022 02:02:22 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5676.036; Sat, 8 Oct 2022 02:02:21 +0000 From: "Ni, Ray" To: "Rhodes, Sean" , "devel@edk2.groups.io" CC: "Rhodes, Sean" , "Gao, Zhichao" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Thread-Topic: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Thread-Index: AQHY0X9/Qfy++lnrK0W7nyzH/XVbFK4Dy/Lg Date: Sat, 8 Oct 2022 02:02:21 +0000 Message-ID: References: <9c3d2f03a7f021c5044301f7b4d869b70e8990e0.1664179796.git.sean@starlabs.systems> <18575f8eca30cec6eb2fab56b878196925f0dd90.1664179796.git.sean@starlabs.systems> In-Reply-To: <18575f8eca30cec6eb2fab56b878196925f0dd90.1664179796.git.sean@starlabs.systems> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|IA1PR11MB6099:EE_ x-ms-office365-filtering-correlation-id: b171c562-be17-497c-dec6-08daa8d12327 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nxFK7NGSk363I/kee4NsFJevfSilJ+5GqOo89Y9c/XobzcZTD6xhIwDlaVO2WZ1lJ1lib3to684k04uiPQaMP4/PWvwy2/1mXj1nWmFgFa1Fos/qXpmhH18Ogv7QuWsW/l3RiVsJxfcf0zHsLoka3kBDZfRRsEaQ+FtcOmtBOBcei8yqApJ2efWjwVvoeG4IXBP0r9YFZENmWVkdXoHZDWvz9Xh3CuliodqfaelxKiR0mbBpdJfL2/McKay/GY8zotMc/mE2K4+FADE9t884yUYUXII/NEM/RbdNHa56o4POOCcSkn63EgpC0ye/6qq9VzclDAqfa/4mKXJxlYffiizrYGW6wb/l4p6ZX5RlfO00Zi+yQkABqxWGH8tjqadIZj+iG2FMYnw8HmXvj+ftAmw5yPvDclBQrKeFF00jc+4OMmrLd8VnBySpZeOrJ0p5lUdDefglIvIJLxd4m1mc5D+EdwpsBiBrJqbRsIOO6iYkiU3UWBJzojVc9dLDVKZUBLdjionn0CI+LZHowlkHQy7hEY1pz/h6kTaPl8/8XJ7SsH5wKOyywfwmeQwUFPZAG9ujZ9dI2d8GEn7ZkDzrk2ShHQysw/6+RtQKtvjYI1libTuUe8twO5uiveeSLnfZStDw51mdOjcZkbr9P6EEUzptEZN+7A471ww+5QN1HsXd8WP3hAjYtycEkHS0zsruxplYLXnOaC+LaugJOY9+snUw+yieVgPoaLrbaTWUKzTdn9pdGL+T5pgHIhHJxEgMfpK/guGfTBt7c7VV3Nwjmg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(83380400001)(186003)(82960400001)(38070700005)(38100700002)(122000001)(2906002)(8936002)(41300700001)(55016003)(64756008)(52536014)(53546011)(71200400001)(7696005)(6506007)(26005)(8676002)(66556008)(9686003)(478600001)(76116006)(4326008)(54906003)(316002)(5660300002)(66946007)(66446008)(45080400002)(66476007)(33656002)(110136005)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+tuDRyphPROTa09HnTP1I3j0EYdBUPfQxZeJ974hD90Bj2U+G675emycnvTc?= =?us-ascii?Q?FGG0rzytUAleyNLhir1bvwycWzq86YGAz+W/UZ9qSjkNhB/gL3rCSXcWpjzy?= =?us-ascii?Q?U41Kh+UiLci1j4cgdcaU/2DRIS9/nu+UCg2egdiKAkCxMj45U/3N9kc+5ncN?= =?us-ascii?Q?DuOtk55Y4exKov6zqvGECY0fheENlD2cXfwL7tHIkxp6dTl0rsbrHzpXWyT3?= =?us-ascii?Q?RnNChYnThL4agYIrV8xUVMiqfqfaohQy5+PsDvyi+Iq/RFa//VXhpJVyo7k1?= =?us-ascii?Q?fdwKZE+bm6nSGcGJuq8afSz5cRCNKhR4wbtsCzMj/87BJlSIBSzIzwtvGYwv?= =?us-ascii?Q?tH9Pbcvb7Q/+TTr9V2MLDq5hWwBEVkXrBRDDlF04YMc13qhkgNZzuhTKxONj?= =?us-ascii?Q?G/vonBuJYsvGlHIQfyEA4YwN3qsHRVGBe0n8r4KlAaiCiCT6GWlWqY2ZtHzM?= =?us-ascii?Q?UxsyN8BrDTXN0uiDV1SU+lYVJQq4CHhnuHMB2piwf4fABImZ7DYNZbNxhG8Y?= =?us-ascii?Q?rt1Vhwtz8TcXlgQp+hKXSn9xcxHluVTNTtrUG6t9AlQAnyTYC/jnG1b74/SK?= =?us-ascii?Q?cEiOLhbuEL6zOCFV2naNjhXkq9RV4EWzMEeFMIyQNSIWYR9HU37Oo39ONe89?= =?us-ascii?Q?oFb2P8NpVNUmEYLCl+5IE01Ym75eDQAhDI5nKZ+5V98oqvYxZOQ+I9oCH1wd?= =?us-ascii?Q?3kLuC/oN+qAEa8oGqpfFY6ggetyzQmny+WyRHJzfg2tDxYYdlZMrjtnnXq9i?= =?us-ascii?Q?vL8WS7qLlKDrAicdjeYgSaiE5XHgILRaMMhgsdMb+PkmJJm39V1qYIbM+5uo?= =?us-ascii?Q?98aOQFcq7AxxKBxs1Vq46RykgY3zmTa9627bVYI/zy170EBLDnT9V8iX+m/d?= =?us-ascii?Q?0FYsm985uYOgEAHpjKq/8AvxLZ5O2DJJ8NQaoFPlsDJqtmKQG4V629gcCuDX?= =?us-ascii?Q?8z4ZlyKGuKUc+ZPk2PaMTemX79d21AdVyoAO+/Y3gCGQPoSa4I6jNyZx3hc9?= =?us-ascii?Q?vQ1FX/LM61yqu+KpgSPal9QKCPiMm4wJjN1eifxC03HLIWa+axriRAajTiPE?= =?us-ascii?Q?dQAlIr2cgh9FeDcBfG+tN34U2TsfjlJLbIzUtHDa2KRXHfappY+eiYEBVCXr?= =?us-ascii?Q?k+jFO0E3QlNZ3V2xlXQxLhC0RRbokM0Qb5VIh9fxoGImaqHH8lODwlCNnDi/?= =?us-ascii?Q?qa+I/JeBIMDRstAIOk94pC/K6hQqVwJgmizkGiLGK98QLPGsBAVc883k0AYz?= =?us-ascii?Q?hz7+9kcD4dlC5Q4DIdLzNA7WwHq9nDD0oLTLKoceP88PQ7n8sFFS1ms2fyit?= =?us-ascii?Q?bWrr46eL4rvoLvLW2WCgQz+9OJXQk9tqSwHEuG2J5VQChCuLEcZhVotKyt5q?= =?us-ascii?Q?C3wZ2H/61FSRdhvT03wtOugVVJHAPHfwMiqdwHVppGMG/sLpUZ9PDdi4FTUH?= =?us-ascii?Q?vBhFxTuR+yE7yLRNDad6TgGgeNLl7b00oJLmCltsP36x5hkTgHQJwjnbNFsR?= =?us-ascii?Q?6DqIRIR76jREuKQxTD/ZyijOB7VYN0SWGY5X3AcPGsupJncLJTj8huD5UIih?= =?us-ascii?Q?AtphFuwsWGRR1u1eg30=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b171c562-be17-497c-dec6-08daa8d12327 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 02:02:21.7636 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5wS4zyCkCVbmgQU8XU8Ky6WlwEUHCGAmqR33uYLhS5jI5u94er41WorwZuw6vB6D76u+Gjj5W97TCV+7O2ejLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6099 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sean, I remember that I evaluated the BGRT requirement when designing the Platfor= mLogo protocol. So, I went back to got the code I wrote long time ago as below. I didn't try to understand them now. Does it make sense to you? Status =3D gBS->HandleProtocol (gST->ConsoleOutHandle, &gEfiGraphicsOut= putProtocolGuid, (VOID **) &GraphicsOutput); if (!EFI_ERROR (Status)) { // // Center of LOGO is in the vertical position 38.2% when PcdBootLogoO= nlyEnable is TRUE // Y =3D (VerticalResolution - LogoHeight) / 2 // Y' =3D VerticalResolution * 0.382 - LogoHeight * 0.5 // OffsetY + Y =3D Y' // OffsetY =3D Y' - Y =3D -0.118 * VerticalResolution // *Attribute =3D EdkiiPlatformLogoDisplayAttributeCenter; *OffsetX =3D 0; *OffsetY =3D -118 * (INTN) GraphicsOutput->Mode->Info->VerticalReso= lution / 1000; } Thanks, Ray > -----Original Message----- > From: Sean Rhodes > Sent: Monday, September 26, 2022 4:10 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Gao, Zhichao > ; Ni, Ray ; Wang, Jian J > ; Gao, Liming > Subject: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the > position of the Logo >=20 > When set to true, the Logo is positioned according to the BGRT > specification, 38.2% from the top of the screen. When set to false, > no behaviour is changed and the logo is positioned centrally. >=20 > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Signed-off-by: Sean Rhodes > --- > MdeModulePkg/Logo/Logo.c | 5 +++++ > MdeModulePkg/Logo/LogoDxe.inf | 4 ++++ > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > 4 files changed, 21 insertions(+) >=20 > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > index 8ab874d2da..1638d0f984 100644 > --- a/MdeModulePkg/Logo/Logo.c > +++ b/MdeModulePkg/Logo/Logo.c > @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 > #include >=20 > +#include >=20 >=20 >=20 > typedef struct { >=20 > EFI_IMAGE_ID ImageId; >=20 > @@ -69,6 +70,10 @@ GetImage ( > return EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > + if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) { >=20 > + mLogos[Current].Attribute =3D > EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended; >=20 > + } >=20 > + >=20 > (*Instance)++; >=20 > *Attribute =3D mLogos[Current].Attribute; >=20 > *OffsetX =3D mLogos[Current].OffsetX; >=20 > diff --git a/MdeModulePkg/Logo/LogoDxe.inf > b/MdeModulePkg/Logo/LogoDxe.inf > index 41215d25d8..ce29950089 100644 > --- a/MdeModulePkg/Logo/LogoDxe.inf > +++ b/MdeModulePkg/Logo/LogoDxe.inf > @@ -41,6 +41,7 @@ > UefiBootServicesTableLib >=20 > UefiDriverEntryPoint >=20 > DebugLib >=20 > + PcdLib >=20 >=20 >=20 > [Protocols] >=20 > gEfiHiiDatabaseProtocolGuid ## CONSUMES >=20 > @@ -48,6 +49,9 @@ > gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES >=20 > gEdkiiPlatformLogoProtocolGuid ## PRODUCES >=20 >=20 >=20 > +[Pcd] >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended > ## CONSUMES >=20 > + >=20 > [Depex] >=20 > gEfiHiiDatabaseProtocolGuid AND >=20 > gEfiHiiImageExProtocolGuid >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 58e6ab0048..ac437990f1 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2102,6 +2102,12 @@ > # @Prompt The shared bit mask when Intel Tdx is enabled. >=20 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x > 10000025 >=20 >=20 >=20 > + ## This PCD sets the position of the Boot Logo. >=20 > + # TRUE - The Logo is positioned following the recommendations from > Microsoft. >=20 > + # FALSE - The logo is positioned in the center of the screen. >=20 > + # @ Prompt This position of the boot logo >=20 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FA > LSE|BOOLEAN|0x10000026 >=20 > + >=20 > [PcdsPatchableInModule] >=20 > ## Specify memory size with page number for PEI code when >=20 > # Loading Module at Fixed Address feature is enabled. >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index 33ce9f6198..09c1ac1cc1 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1338,3 +1338,9 @@ > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HEL > P #language en-US "Indicates if the PCIe Resizable BAR Capability > Supported.

\n" >=20 > = "TRUE - PCIe Resizable BAR > Capability is supported.
\n" >=20 > = "FALSE - PCIe Resizable BAR > Capability is not supported.
" >=20 > + >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommende > d_PROMPT #language en-US "The position of the Boot Logo" >=20 > + >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommend_ > HELP #language en-US "Sets the position of the Logo. When set to true, = the > Logo is positioned following the recommendations" >=20 > + = " from Microsoft, 38.2% from > the top of the screen." >=20 > + >=20 > -- > 2.34.1