public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation
Date: Mon, 5 Dec 2022 05:37:56 +0000	[thread overview]
Message-ID: <MWHPR11MB1631E18D7813C4346101256C8C189@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <088e01d90633$29296de0$7b7c49a0$@byosoft.com.cn>

Liming,
We are running some code that requires MSR access (e.g.: MtrrLib) in EmulatorPkg.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming via groups.io
> Sent: Friday, December 2, 2022 5:48 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: 回复: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove
> HOST_APPLICATION limitation
> 
> Zhiguang:
>   Can you explain more about the emulator usage model for this library?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zhiguang Liu
> > 发送时间: 2022年12月2日 14:25
> > 收件人: devel@edk2.groups.io
> > 抄送: Zhiguang Liu <zhiguang.liu@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Ray Ni <ray.ni@intel.com>
> > 主题: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove
> > HOST_APPLICATION limitation
> >
> > Remove HOST_APPLICATION limitation for UnitTestHostBaseLib, so that
> > this library can be used as BaseLib by Emulator.
> > Also, add some missing files
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > ---
> >  MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > index 09a610c31c..fefa2e79f6 100644
> > --- a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > +++ b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > @@ -1,7 +1,7 @@
> >  ## @file
> >  #  Base Library implementation for use with host based unit tests.
> >  #
> > -#  Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> > +#  Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR>
> >  #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights
> reserved.<BR>
> >  #  Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.<BR>
> >  #  Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All
> > rights reserved.<BR>
> > @@ -18,7 +18,7 @@
> >    FILE_GUID                      =
> > 9555A0D3-09BA-46C4-A51A-45198E3C765E
> >    MODULE_TYPE                    = BASE
> >    VERSION_STRING                 = 1.1
> > -  LIBRARY_CLASS                  = BaseLib|HOST_APPLICATION
> > +  LIBRARY_CLASS                  = BaseLib
> >    LIBRARY_CLASS                  =
> > UnitTestHostBaseLib|HOST_APPLICATION
> >
> >  #
> > @@ -128,6 +128,7 @@
> >    X86RdRand.c
> >    X86SpeculationBarrier.c
> >    X86UnitTestHost.c
> > +  IntelTdxNull.c
> >
> >  [Sources.X64]
> >    X64/LongJump.nasm
> > @@ -168,6 +169,7 @@
> >    X64/RdRand.nasm
> >    ChkStkGcc.c  | GCC
> >    X86UnitTestHost.c
> > +  IntelTdxNull.c
> >
> >  [Sources.EBC]
> >    Ebc/CpuBreakpoint.c
> > --
> > 2.31.1.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 


  reply	other threads:[~2022-12-05  5:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  6:25 [PATCH] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb Zhiguang Liu
2022-12-02  6:25 ` [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation Zhiguang Liu
2022-12-02  9:47   ` 回复: [edk2-devel] " gaoliming
2022-12-05  5:37     ` Ni, Ray [this message]
2022-12-05  5:53       ` Zhiguang Liu
2022-12-07  1:02         ` 回复: " gaoliming
2022-12-07  1:21           ` Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1631E18D7813C4346101256C8C189@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox