From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.68938.1670922295293054008 for ; Tue, 13 Dec 2022 01:04:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Uw6i62c6; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670922295; x=1702458295; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=6Ua0fpks2bfct4Q2i2kOWrT6DFenvg5ICitOG7yjPXY=; b=Uw6i62c6NLX/83JxbvVKfAF7z21hauwU6WAAwzq+yfeYNed+WEjuKv6Z YE+BiUmtLqMyduBVFO2xCYWq2kBB8yTQUdtZDcvehfuV8Tswvk+vAGdwi 0X/TodmsuCOVhajWcSBxUPtsmNWthcR22TmQ0+0vTsJDNEkzt05oNRH5S NNOGzl+rOz6Fq+f7pVR5bvVwNKeFzUgMefAoWGeLOw++ggwxMl7XlwUWO jBzSMWkbK6DoOHFhiRxNP+s6uz0IC5WgmG0jQca2GUa8YV3CoKMFe1yVw PB3uAvcmkLZw2D3LYAk+ErkHn2vMPoX2So5mRudYuHYZJ1iK8tNxApCN/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="315721346" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="315721346" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 01:04:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="712009314" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="712009314" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 13 Dec 2022 01:04:51 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 01:04:50 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 01:04:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 13 Dec 2022 01:04:50 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 13 Dec 2022 01:04:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSYXdtP0cXOVg4nqTMfxu2qRLzuv5d3PHhFJaE/t23gGJQdrRYopN7gjxtf0Gb6HoYx60FaTvugBg0RnEBScUJTCk5czytHacC1KBGY2YmmtjGhNH1bQokQcoLOP3s+C0DzxKvy50z2U0UX3k2DgEyNn2pZ1YxvIy+EresU4T65zLGcFI2+vGAQAdiJsrKjuwGJoT2HwW8SeVAa+FafkLHvhxRbTu78u76Veg2Ph9HsiO9948fsmdoy0WkK5C0mBEPbwAKOlctSxylQ65DsFbK/sducAzFOYLfytHT72VzqlAuLoPH3D53eDNJe1cXqHhh0VSfAfD2vAbHz1IBVBkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OmkbHHwecZp1Smr+B3nDCJYI96heMrIJgoYMUHSHVm0=; b=L0WBnkpOQQUWpxsU3KL9DfS8TmTGP0E+ajVIagw4WnXIHGjLioTMtg1COkgraXJVdjpwwDKjV2F4Vplrh8GdhsPN42ZtB0nnPFsxGaS/2YBxktQoQOieRdixksRcQgRnoqnC7iPYMlb4Q9dO26KiQUwKepNWfVrx1JuMz1QLhGg9BiGMSlpGMVyCVNEV3vYBBpw8w95EidbeVJAkON9ZglW9iDFRCnQ7HtCVlqTeuMJ4cbQ2tysUaQQMm5T12xxJoFnS4qRccRa0/xQU3OnFq+3Jl0kpyfxsywaJPkeqJh8zxjwozOuf5pyPE9UN/52lc2N/iKcwkThteQcg9VocvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by PH7PR11MB6700.namprd11.prod.outlook.com (2603:10b6:510:1ae::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 09:04:48 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e%12]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 09:04:48 +0000 From: "Ni, Ray" To: "Zeng, Star" , "devel@edk2.groups.io" , "Wu, Jiaxin" , "Guenzel, Robert" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling Thread-Index: Adj1CvpW46tAdlIWQQ+9dW0j49U6vQES0p3wAr+ld9ACnmhssAAA26rg Date: Tue, 13 Dec 2022 09:04:47 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|PH7PR11MB6700:EE_ x-ms-office365-filtering-correlation-id: 4b6be0e7-3d97-4cb4-c12f-08dadce915f5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: glmWkQ6E0hC12+Koj4oor2lgGwdK23e9Lpqx+QsfMbKZbTNqnvgB0mwZC48B+3PxhRW173jLWq5BESMWhK/eLj7uA4kkZLljQAHMpWgn+EparBAfNRQibx8cAWEqZjYlhTicIS+/8/5U1PHXItBJMqdj+TvpTlZtVBe449kPQWmthwPq2VIytCcwe99by6WqyMoDG8ZvrhkkOfvVuHyEeOblfjMP9jXjjEUEoN4HNhaQrecPDQrroWyu2IyaWof2Yw6HSoylKTraBxaZwXYzYagdI8to0qQ3I3e2Rsy9Q8eyN5LKB3dy17v1nNveBNwoY0W9bt5vYdVYR4EFApo6Ww4TlR0QX37FWweL/11nsMhJE80A6QrJwj5SazFOcENGKbsgohkeCwWSVRYlBWPIBL6wJ6MWPQB81H9PdWo1IDsd0C+J6iEJ70D8exlHPlpDW2nDJPVm7vWmkA/L1RDaTwNHG800hSDVQ1gA6/4iu6EbCtXqY4iaeBavPhjh1cjZ+dtuVDk6M81ym5GnM/m7C9HGowE8im3ImQsRYOv2mhFN7deCYrHG/TjChAgmPW/BdMLHy5OIEWHzDr4MQItBwvmTp+xX/c3lvCQnzSKfIxLpFfROLXPulSGUCc6+oSwO8NrEox1OFNOMCdIz7jIxfZUudDLEOGIzdjHCGuZ7HohUaTkOGGHJzFnlbLylBWbJF5U4AXDlLKTsnvW/sIRRhXP7i/ksk72n01Ph2rgdS+4SjBFg6+oP6cFhjqk/fT3LX+PBh1u+NAFvak9ICjSNBQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199015)(7696005)(53546011)(6506007)(5660300002)(316002)(6636002)(15974865002)(26005)(66556008)(52536014)(41300700001)(9686003)(8676002)(8936002)(66446008)(122000001)(66946007)(110136005)(83380400001)(82960400001)(38070700005)(38100700002)(2906002)(64756008)(55016003)(86362001)(186003)(33656002)(66476007)(76116006)(66899015)(966005)(71200400001)(478600001)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z6RDl4zBCXJlwuxKOBqo5bhME5Q9qY6KHACdmKthkeVf9Gi/gPKbsu5nfbfk?= =?us-ascii?Q?OGxN43UxoObpolRkMvMvQGU4Cg7lNn2wKbGvp0qPALLVRr6Mg0v+Mx+svJYm?= =?us-ascii?Q?WE3dK/XJCC+Xo3jRk4oko4owWqh6iWndetxjh0JspCxhFg1x1rsS4Tk+CmzC?= =?us-ascii?Q?LnrvGFKKmbKRsN4mCGiEYgJ/6U/JTVSj+MGOU7aWM1EcFw97gjOToIspcYGZ?= =?us-ascii?Q?W3FcHdaPThVfucRxmN40Vyhdjh1J0yllJsb0WUCnHoOgQ/V+IFI+FBCeE+Rb?= =?us-ascii?Q?pT4loxUBCKo2Zg2MGFLMa8QQ/4vy2Knm/FvhHEwbmQIEKJra7qWFypqqZE6u?= =?us-ascii?Q?T3kOzRwfmJsmosFBSztyH3fDIl13sIXmGHB360Ai2XERBRWF30YxGndnTLxN?= =?us-ascii?Q?ffUqxHj00ZFTc322W4jaCVMTDRTS6PFzs4w2p2dPMRyrajY8e04EqQw5Z2Sq?= =?us-ascii?Q?MebV8FheM2sy6l7uBF/viW3TSLYnuzd0BgY/8jC8tnnQ3jV7PHHDrjv+VdDF?= =?us-ascii?Q?qWIxDmStj5eSjzlUr+EA1qawk9HQn3ZBGEVylbT69PZDkkluAl+wksOvkRP1?= =?us-ascii?Q?ZdYQZV3Tzm7n74c0t5QkIJRdWOvMiVMapfSRBRLe2e0sKJxT0+zgjIgMm1Se?= =?us-ascii?Q?iteU6RzI5OW4xsoiBDD1bptsUiTp+LlgDytIikmdG1mpZ4LZba5ECyg1+eza?= =?us-ascii?Q?CmQFjCQreeyp72q0xHzFJLSSEAecqueqYuisX5XJCxjW5utsYudTI8gSban8?= =?us-ascii?Q?OeHtjCrDvJKAmYZY2ACUZzUnAug+1cGvdLspemBHHiyFcpFWO5C7HqthBDWq?= =?us-ascii?Q?whmPFoZEf5DWLKKl8+SVUhJFd369+G4XjVooYu4CimI0cEUV9FAYqly/B03+?= =?us-ascii?Q?CnM+SxpcQmbChqMTV+juDfrgilwjwLRPGzlVHnWelTh6ajsXgGn4yPUdHH/9?= =?us-ascii?Q?wlhKtWPEJpeEdXpVxgG42fT8qp7B+nizjoKqHY6Eyl6q9N+fr+j+p0np7z12?= =?us-ascii?Q?ksq7hrx6kUmrQ1klTrv8k6MyR6yHiVI/V883A3FCkO3kKzDI37ANFYEhriVy?= =?us-ascii?Q?GXUMis7P3qdEfevprD4EeFmJwV/q0PfdWCfzEuAaeg1j1u6E7RVLuVGoDiTt?= =?us-ascii?Q?zMic6gSd7/vuH1RYouHrh1juCzKYRca3YM0tiGRqJadRH/z/YwRqPyqOriVC?= =?us-ascii?Q?0FgWLzmKyp7+hlMTcACLIeuZUlEg3s34lPrrEl2x3d8s1KYux6AfhMXhryXs?= =?us-ascii?Q?6xuCfqrSs8hBP1JZz1UnImJuvb1+1/WDR0WIzppmXMKZAv5bAtn3mBvbohog?= =?us-ascii?Q?f7D+4kLpoBCUUFRkec80zF2/jMxmVf6FaGYCSomJgABMM5GaDdLWENu8N6yL?= =?us-ascii?Q?FaPPNwY6s1DR5WoXNT067fgd6P8jCJSzxNx7XLa2WnHGvF4xs4sZLISlfY8f?= =?us-ascii?Q?MSk9v+W7HKXVq6qzdot+5Jz+X+ndyYJBr1/leZ79pqFYVYo57102TuGOq/n6?= =?us-ascii?Q?t7L+w25dj4c26vvcrl+nSgX/ebrkbbr8ilmLV1J2azlJUKqXpDAoxb07La6J?= =?us-ascii?Q?4eQ7uqsK66WUhpTRRAyvVf6MKKjC0MBkzHE58UaY?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b6be0e7-3d97-4cb4-c12f-08dadce915f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 09:04:47.9952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KOzEOz4Tvw4siV2EX5uqFKWRL9xIMNdq+mWCwfWtWHtQNmfkMROlVDasge55+iYYfEJA0SYxLeRP1dmWqs0oRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6700 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, It has been merged last week. > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, December 13, 2022 4:41 PM > To: devel@edk2.groups.io; Wu, Jiaxin ; Ni, Ray ; Guenzel, Robert > > Cc: Zeng, Star > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling >=20 > Hi, >=20 > When could the patch be merged ? >=20 > Thanks, > Star > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Wednesday, November 30, 2022 8:47 AM > To: devel@edk2.groups.io; Ni, Ray ; Guenzel, Robert > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling >=20 > Glad to see this fix, could you add/include the existing Bugzilla in the = comment? >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4168 >=20 > Thanks, > Jiaxin >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Wednesday, November 16, 2022 8:57 AM > > To: devel@edk2.groups.io; Guenzel, Robert > > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage > > handling > > > > Reviewed-by: Ray Ni > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > Guenzel, Robert > > > Sent: Thursday, November 10, 2022 9:51 PM > > > To: devel@edk2.groups.io > > > Subject: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling > > > > > > When build in DEBUG, the code asserts that 5LPage support is there > > > when the physical address width is larger than 48. > > > In a RELEASE build it will just force LA57 to 1 in CR4 even if > > > CPUID(7).ECX[16] says it is not supported. > > > > > > The hang (in the ASSERT) in DEBUG is not warranted as there are > > > legal configurations with CPUID(7).ECX[16](=3D=3DLA57)=3D0 and with a > > > physical address width of larger than 48 (like 52). > > > > > > This is also supported by this code: > > > > > https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/PiSmmCpuDx > > eSmm/X64/PageTbl.c#L221 > > > There (as long as physical address width is smaller or equal to 52) > > > any address width above 48 will be reduced to 48 and the system can > > > and will work without 5LPaging. > > > > > > The forced setting of LA57 in CR4 (in the absence of LA57 in > > > CPUID(7).ECX) is a spec violation and should not happen. > > > > > > Hence the proposed fix > > > a) removes the assert. > > > b) only returns TRUE from Is5LevelPagingNeeded if 5LPaging is actuall= y > > > supported by HW. > > > > > > Signed-off-by: Robert Guenzel mailto:robert.guenzel@intel.com > > > --- > > > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > > > index 6587212f4e..f8b1ac31f1 100644 > > > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > > > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > > > @@ -104,8 +104,8 @@ Is5LevelPagingNeeded ( > > > ExtFeatureEcx.Bits.FiveLevelPage > > > )); > > > > > > - if (VirPhyAddressSize.Bits.PhysicalAddressBits > 4 * 9 + 12) { > > > - ASSERT (ExtFeatureEcx.Bits.FiveLevelPage =3D=3D 1); > > > + if ((VirPhyAddressSize.Bits.PhysicalAddressBits > 4 * 9 + 12) && > > > + (ExtFeatureEcx.Bits.FiveLevelPage =3D=3D 1)) { > > > return TRUE; > > > } else { > > > return FALSE; > > > -- > > > 2.34.1 > > > Intel Deutschland GmbH > > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > > Tel: +49 89 99 8853-0, www.intel.de Managing > > > Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > > > Chairperson of the Supervisory Board: Nicole Lau Registered Office: > > > Munich Commercial Register: Amtsgericht Muenchen HRB 186928 > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20