public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"xiewenyi2@huawei.com" <xiewenyi2@huawei.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Cc: "songdongkuang@huawei.com" <songdongkuang@huawei.com>
Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration
Date: Mon, 14 Mar 2022 03:34:12 +0000	[thread overview]
Message-ID: <MWHPR11MB1631E9E5E093742DA7FAACEA8C0F9@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220310080625.2934989-2-xiewenyi2@huawei.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
Sent: Thursday, March 10, 2022 4:06 PM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
Subject: [edk2-devel] [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration

To keep the declaration same with definition, remove the last optional in declaration of WakeUpAP.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 7d84a56fbc51..f8c52426dd5f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -477,7 +477,7 @@ WakeUpAP (
   IN UINTN             ProcessorNumber,
   IN EFI_AP_PROCEDURE  Procedure               OPTIONAL,
   IN VOID              *ProcedureArgument      OPTIONAL,
-  IN BOOLEAN           WakeUpDisabledAps       OPTIONAL
+  IN BOOLEAN           WakeUpDisabledAps
   );
 
 /**
--
2.20.1.windows.1







      reply	other threads:[~2022-03-14  3:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10  8:06 [PATCH EDK2 v1 0/1] UefiCpuPkg/MpInitLib:remove optional in declaration wenyi,xie
2022-03-10  8:06 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-03-14  3:34   ` Ni, Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1631E9E5E093742DA7FAACEA8C0F9@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox