From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.48405.1658278128301408770 for ; Tue, 19 Jul 2022 17:48:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=fUVK1p1l; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658278128; x=1689814128; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=RfuHcmePDrMk1oTwuf1tSvXl1zF+NmZyMEC6lpKOqoU=; b=fUVK1p1lAVDSkZypdJ7bMc5W8G9qCxC6JrOPzN0v5m/lBO4Xm0OszpF4 jkAprIo3TCMEJz+AfxizSV/+59judAuQWXOhxxu4J63qe6OLz56JR3ZRi WOxFSDz6qLgYjrHKGSf/4Z8YWPyMj+08/qse6rEkDkRGlPEkzU2bssKwD fKrwUTFCw0iJpE8DrrwoPoHZT9ocr0zfbht80ojkl8+pgo1CVYCidCV2W R6d95ClI595dhppqFAhABvqWGDyQjmv0Nr6jSnmLA/V4o50PvTz5bNQXe oB9ZpP8HwYm4WMJrxXGWdlO5aclwu/GwZUIPEqVTDoh0y4xutE36QxDvh Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="266421064" X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208,217";a="266421064" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 17:48:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208,217";a="843855044" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 19 Jul 2022 17:48:47 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 17:48:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 19 Jul 2022 17:48:47 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 17:48:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/55HY75eHY2y9N5jl+5YPsk+He4kko8TCyRivF/DiM6IsCYMl+ki3ohAVycnm54ZR0xY0d15j+eiqbRGhD3xrYgdoKWzPfK8BtLz0hThDcX4DzgozpBk9ZU628mUmskAs7vcLrsN8PNlNirfu5NMebNRuAfsNUJ3lGrbTmHf+IaL0gV2I/2kpTNPpyqskM8K3wqZRq+6MnHC+LXK09xA8UJdkMcW8y6PRuJnZdnACL8/mreslsAuD86qEGh2SRGFF6//K8EKeIMtRz9NwZyow1oBVUjZWSNXUdYandUEmBStUuHVNfskJFSW5X/clZLQQ3XGI63zwfhoKk6foS/5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUAfRhMq3v7vlua8PmytHq97vj79fETbfUdUe74CQm4=; b=EH0wyqlepZbjH0kNqFnDVxC35XBVK8otfmw/azlgtlmM1MWNyFm0jpV0s2Pe6ZrGyAzOfesUOAmWhY5AyiMxtBMfGCcBcSw5wW72Rjp6IkcU3rH9zTgYNZWBlq0YXati18j0YNzCpfXvYfGUlwUnFC2UvlnbLgS3/1yTrpgK9dExbC/00KgDlSGO0vcaI+Y9o2/zTq/7p8njJ7Nl4tQTe7kF+lkmUYJQvlCAfbGPdOX8zx2pd0Og4Y/YSpRx++3ry3qICwHgHKQoSx6U88izvA8ci5SLo7ImhzB/1FQUIGopnkuad+zRDoKU1zG57gbdnl71FlZbEKUzM3XqQFGmwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BN7PR11MB2802.namprd11.prod.outlook.com (2603:10b6:406:b7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 20 Jul 2022 00:48:44 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174%10]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 00:48:44 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Chen, Christine" CC: "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly calling for gcc command Thread-Topic: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly calling for gcc command Thread-Index: AQHYm87I5xiCfKIqy0OueVgY/5z+xq2GbTn5 Date: Wed, 20 Jul 2022 00:48:44 +0000 Message-ID: References: <20220720002145.972-1-yuwei.chen@intel.com> In-Reply-To: <20220720002145.972-1-yuwei.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d205569-3598-44ee-e253-08da69e99945 x-ms-traffictypediagnostic: BN7PR11MB2802:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JZLA/RrdqS0Tj8wSDItpf20EYeudtI1WAGJ0SAPE5cblT/LZp+FUfaBGyJx85TxVTl1by1aS6QgJ+9dq5lTK5Nymbed9GubgBJzzj26y+C9PE2hXRQb9YL5LkOM2HZBGTsl9N3uECqkKCH6OSjrmN5xpe849ahuJ21jXPTbpyTy2/8Pz3FDS8FYUW18lWXRiuXmShIP5PZ6ZPARvXuvlWA8C2sm/5v5/0sxUrYJNKQG581pXxlFLNt+v8OWF9IiBCe6HTe/sJXgZlpNUQxlh83Ss7Lk//jKJ1NcuubSzUBQ9i97UtTJ5FzW3403Jh9G6dpobIkDztiX7F0qcPbnSYX1ZWJj5FqsmPqx/Q0ITMqBHyJhZbMVYLuZJVnJQePkiK4c86gKAQ/uRoEhFN+jHGuPirwMfeLG7XDVPjCIhu8qd1njyBOji82Sf43ghyoTQT38s4fgfQ2cmT6MpN4BsGrV5VRaVXgZD093NbesZ7f2Ak4yfWCAqHAYA0cyvGpAJL/khoQ1eDg8Lqi2klP0WqEwz8AElO2m1RBGwIb/52AxBABrCkvjcyLHpmgxrG5fBu6c1dEDWbXsELPHEZmuo+NjaoqK23bRirQXia8bJ8N9fWuRuz9Dqz4W/vCOzUfthGSsLWvDY8+C1rMvVnQZ/dTCzWQ0NiKOvROKzlp15rlDoQDy9M8HNRFx7dlxi0bPr+jyVPlCin2mxBXih04/VnHEAtijr0MjTKqUlrMs8/1fWm3JXZa3kTg+1a4oEdeCh433ebN46ykyEernR1ZyXCPS0EyDIfSWzpKsNnKecQKH8vxD4FwojSKZd/VY5ebLBksq0L4G271ZArOHqh/h1vp+1A8J8F8CeZDmpehiw31ejsiRddxvQ40qOouaUCTpu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(346002)(396003)(39860400002)(136003)(186003)(8676002)(316002)(82960400001)(110136005)(54906003)(6636002)(55016003)(4326008)(64756008)(86362001)(33656002)(2906002)(5660300002)(9686003)(26005)(966005)(478600001)(8936002)(53546011)(38070700005)(6506007)(122000001)(166002)(71200400001)(41300700001)(83380400001)(66946007)(76116006)(66446008)(91956017)(66476007)(66556008)(52536014)(38100700002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RnXIv4KBa2vJi53coihUpq/1qvgqEj9ooItP413nWJIQgjBcUsmrk/g77u8X?= =?us-ascii?Q?KFAid+tpDDiaXaG4PBHAn857tE8pOFksxjlXGdSAYGXMywARDRlwfLGcxatN?= =?us-ascii?Q?vV9l0K0s/m1dsvW/RsSCafyMkT1aiDacPx+H+X+P1KyvClX0/HyNRFpdhxnB?= =?us-ascii?Q?grO/ES/qn37k79bTWY81Qdt2xl4o8moy4LYpCM5KukzqUbyb0j3+eKrTs2E0?= =?us-ascii?Q?Q/0uLVZ0o505lScX1dRDplk7nZ2R1GVBcnBR/G3JIzJrIaiB4BIkYZrv/X2M?= =?us-ascii?Q?NSZY52/ge+LbdVKWm65B9ri4RbaeIb+9renaSLcO19wq0WC8OV70OoZEPOjA?= =?us-ascii?Q?mTSO01ZFcls+lpkc5LpPH77x6mpB8uNbE1soi7rpUb7EsVNN7w3e1fckS43l?= =?us-ascii?Q?564GN3MdUj7kt6quwVJPyyOhJC7Hs136poTOAaQ+GZgYTwvonFI6i3qhHKEA?= =?us-ascii?Q?dNJDKhM6S5SfVhTg0BLFndj167LGsf6RURG/ReR/jgqagksm0RryQU7GAj/3?= =?us-ascii?Q?IK3Xl/SltPuGRzN3jzDTZoQsiLrUImRdiubaYu/f3YFCWHli2+0w5KUmYhKM?= =?us-ascii?Q?oggYQWl1z4jR1MpeByzch8p3lXPF2lpB6Mk2/yimmrWrisSvPvVlfDagYHzm?= =?us-ascii?Q?LSOEI4vBTEzGO55sqDMCSwlqTQMOm/x06oYfs50hIr1ZJLg6i53Y16BnlENO?= =?us-ascii?Q?FX/2lmVevmksHKefs1dBM3yODBhAcBCpiL9PfKEn06IPOCxuB05gA66dp9Kg?= =?us-ascii?Q?SzpzBg46YTwBHN2KUp3kW0xGF1GeikR2nvNgsvovAmQ7CB7UEHjG+nNCkuza?= =?us-ascii?Q?J5xAer1VWo+QKq8KrcQzvQ/5GaNeYJtNQ6VfXFpWZa9juCMosUbi+JmwQcVJ?= =?us-ascii?Q?9rKVWu1VqGS9Kusky8ewEMAzGUlZBmHOie5jkxjeoZ4PbqT7iJMEb8NRx2+7?= =?us-ascii?Q?RZ5fjJSwxTBqbDxCu4cA34clz60U0UFZ0J2ViSVBXNXcXIQMrTFFo2E2OwI6?= =?us-ascii?Q?8jWSICVMkjt5JdnxMopqupICmTVPIqepppiaEri7Jce6WKUOia7Ug74KXQw2?= =?us-ascii?Q?aVdEWeHAyY247oU9ml5X5jLa0E8KyWnrY6KRWyNxE20NRb24cU3Q39CApZfI?= =?us-ascii?Q?lGeOVf8+aWElOBfjewRxjtrfm099+SEe4IHnfScI1SJZ2ZYsFcrKSvbRmO+p?= =?us-ascii?Q?ZvFPVgQ/YCwNPNknHDP/KY+g1+0lxdBumuEcCXbTQg0SjPq4POZN2yzV0biv?= =?us-ascii?Q?aXZmC5OUtHbbS7DK2EZY2zcDO7dBAVd40+e8+EO99clyiXLF3yLyy+M9KrIU?= =?us-ascii?Q?6Qfsc9GBnOJ73tn6kyIAXeGVOBaAqCo+d8f5UlisYGsA8Pbazs/7jdjFnSRt?= =?us-ascii?Q?nzu5yLx746iVRd13TngULll8mdmtuDxNNPfLobuNMDoL780Ar0ykum/iZxD8?= =?us-ascii?Q?rULyDUQzxNTLrTmXug7dggJS912QpYudNmdeYnCGYFyRBjPjuNlzwbShS1lP?= =?us-ascii?Q?z7OoFAQE1swS7FCoCsk27x7dN5dCDehbRjv0YNdrBDCvpTbzSF2DlCsXK3Z1?= =?us-ascii?Q?YWdwAgUljcYiXwaju+w9qgetFnij+G4Ab8emnn8FoY9cRkf79iWG7KgvuGlP?= =?us-ascii?Q?Dw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d205569-3598-44ee-e253-08da69e99945 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 00:48:44.5824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UbfxiekTYU6/aa7G7AMUmtHrQN3zNC2NtUg4BXSNStxr9KfEn5JOMiHt7Y6ZyLOXo5mmAVnS2D5uRVgtu9sbNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2802 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR11MB1631EA7DB0CA61511DD3775A8C8E9MWHPR11MB1631namp_" --_000_MWHPR11MB1631EA7DB0CA61511DD3775A8C8E9MWHPR11MB1631namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Does every cc support dumpversion? thanks, ray ________________________________ From: devel@edk2.groups.io on behalf of Yuwei Chen <= yuwei.chen@intel.com> Sent: Wednesday, July 20, 2022 8:21:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly calling for= gcc command In some environment, the directly calling for gcc is not supported. This patch fixes the issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/C/DevicePath/GNUmakefile | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C= /DevicePath/GNUmakefile old mode 100644 new mode 100755 index c217674345b1..5944e80bd2b4 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -13,12 +13,15 @@ OBJECTS =3D DevicePath.o UefiDevicePathLib.o DevicePath= FromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile -GCCVERSION =3D $(shell gcc -dumpversion | awk -F'.' '{print $$1}') +GCCVERSION=3D0 +ifneq ($(CXX), gcc) + GCCVERSION =3D $(shell $(CXX) -dumpversion | awk -F'.' '{print $$1}') +endif ifneq ("$(GCCVERSION)", "5") -ifneq ($(CXX), llvm) -# gcc 12 trips over device path handling -BUILD_CFLAGS +=3D -Wno-error=3Dstringop-overflow -endif + ifneq ($(CXX), llvm) + # gcc 12 trips over device path handling + BUILD_CFLAGS +=3D -Wno-error=3Dstringop-overflow + endif endif LIBS =3D -lCommon -- 2.27.0.windows.1 --_000_MWHPR11MB1631EA7DB0CA61511DD3775A8C8E9MWHPR11MB1631namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Does every cc support dumpversion?

thanks,
ray
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Yuwei Chen <yuwei.chen@intel.c= om>
Sent: Wednesday, July 20, 2022 8:21:45 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaolim= ing@byosoft.com.cn>
Subject: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly call= ing for gcc command
 
In some environment, the directly calling for gcc = is not supported.
This patch fixes the issue.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Source/C/DevicePath/GNUmakefile | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C= /DevicePath/GNUmakefile
old mode 100644
new mode 100755
index c217674345b1..5944e80bd2b4
--- a/BaseTools/Source/C/DevicePath/GNUmakefile
+++ b/BaseTools/Source/C/DevicePath/GNUmakefile
@@ -13,12 +13,15 @@ OBJECTS =3D DevicePath.o UefiDevicePathLib.o DevicePath= FromText.o  DevicePathUtili
 
 include $(MAKEROOT)/Makefiles/app.makefile
 
-GCCVERSION =3D $(shell gcc -dumpversion | awk -F'.' '{print $$1}')
+GCCVERSION=3D0
+ifneq ($(CXX), gcc)
+  GCCVERSION =3D $(shell $(CXX) -dumpversion | awk -F'.' '{print $$1}= ')
+endif
 ifneq ("$(GCCVERSION)", "5")
-ifneq ($(CXX), llvm)
-# gcc 12 trips over device path handling
-BUILD_CFLAGS +=3D -Wno-error=3Dstringop-overflow
-endif
+  ifneq ($(CXX), llvm)
+    # gcc 12 trips over device path handling
+    BUILD_CFLAGS +=3D -Wno-error=3Dstringop-overflow
+  endif
 endif
 
 LIBS =3D -lCommon
--
2.27.0.windows.1






--_000_MWHPR11MB1631EA7DB0CA61511DD3775A8C8E9MWHPR11MB1631namp_--