From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.8099.1647330268858178443 for ; Tue, 15 Mar 2022 00:44:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RQ0Z3kpj; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647330268; x=1678866268; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iHlLYEyz4lMKmZ8SiqBwyUdITz+3GgBKyQ/+0cjeSIs=; b=RQ0Z3kpjAu0QTeL0P0vbQDzm/wMKjDjC11YZc5DL0ATOMnX4MvqUb8cf hv6Ah01BaygSaRxnPkO5ZyoRcBoy1/TNwjkdbX6GIF5IXYZTC4AxicL6u GB8kT9+vWdGNwOCDm2Fal6snIR2sG+vHcEC0LpA1AFwQDZ4dj+bAhmwhU 9rMy+lwk3biBDPsMA7N4Oh7CFgvHAVecT/Tg8XArGQULUAue/Ko1YKtCK SNx/fGo4fKi/ajkeisLcvfgb/+5jCmF86zNbhZuqumyTUrit6qM5Ob+hl Ly42+II4V24oTAV9SM1vax7tLjN3+7WvGJoLewLGwakimihTHdTPcg0kx g==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="236183625" X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="236183625" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 00:44:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,182,1643702400"; d="scan'208";a="690107280" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2022 00:44:18 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 00:44:17 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 00:44:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 00:44:17 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 00:44:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bt8vMwgadnDjs0NMa4VwaZM18+aPsVcNQnW1p2+GKrherl2RP393LSIN+VMu/S25fgN+0sIL7/fnQLRdtagR4mEa6MjRFT668xEAIXc2997XKgNy5+4l0ytXtec9V9xrCCO79IPKw1Xww/FT2xFaYNNry1cESCBG9YIk/nfF2Pm64fL6waV6aKc/CDdlvc7f44H+ik8Z2JjiI4yar/P0IOwXhz1/7o9tHjxUYjBk0uyz0TsjICbEW1hzh1r5oiNiM3/PeQCK1e73bHRFzJzZQdnvQ43TW0NTy2h3mtt5y9KY773mnEG6nysobBwCf5hRbgJkDLJ3L32F5wsrFnJ6Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=loW4U9dd7TDbZ0vQKgRPs/kGqwc+ZF3qP/muntCMeAk=; b=OVVpYDTFxaK1RiRjPZwLzEsEEfIQ8/+yCfy6l1s9uIhCxI9vtLHElbzGMovWybg2b8UWhbRPm3cgKRusfjnKCLjHl77EMGC/DEQCOLJawQgYqQRCEiqkYlxqSy2rz+/TtgidsjRLimAXm6qZKQKeWVopyEYaaNI7bQJWBd4giOlbMY5O74X96UvFoh/FRhfRaAoRoFGCC3wbu0qWuFaoTXjXyCG6hLWfiaWD+EPTTdXjylf1UQnyM7sMcWnPzUUYZDR9tVmsWFLOpF8PdZcU0xI8qH9/MCT09uqkZak9zEWZjY2EZhEr/xr8l8llZDFUhvvNjbDQ9Hnv/f/9t72gqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BY5PR11MB4371.namprd11.prod.outlook.com (2603:10b6:a03:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Tue, 15 Mar 2022 07:44:14 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.028; Tue, 15 Mar 2022 07:44:13 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Xu, Min M" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Brijesh Singh" , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Topic: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Index: AQHYNbQpNQqpEoTQJ0GnfoI7ybFGGazAFRtQ Date: Tue, 15 Mar 2022 07:44:13 +0000 Message-ID: References: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> In-Reply-To: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92ef278c-2846-4021-3829-08da065799d8 x-ms-traffictypediagnostic: BY5PR11MB4371:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rNvh+qa9XHEzguB5FjnC3VxZdvbdhkyr63nrfd2nodljXk0fDY1a5H75ZgBB4Rn0QzAjRMXBNZetVbgXJQ3Q3Dz6RFqIgxnMeVHnRigRchHbyGUIBZZ7iyU1QdxDmzDR2rULx/Zu6XINte1XNRIVJoO4BQJA78tiL/FOniofaaLYT63fPJ8QXlgvwyzOj9L2/JzHBJUHKtBBdYUjDiXRvdwGcPjLn6zMMqnkV2wGgpke7KNCyILUwCA0kL3x+f8PHnhyZihhTS+t7zNAHNcv8NRL+fGcIvW5TKxy6Cc6UYKj0TBde6Y8SciRbCk1HYlIn1ci4CIgkpkoSqQ5oeJLNcTJypv8A4nQI8ESXncfg5tCSiripkvk9jkJHJiqDLuSeVBhHKOO1hvLxrkgFg3VcawTRVhpE2KALptJbwYGkIQO2eJTuBL6FJYFej719EZZkjw8UX9q6rtoJfca3U2a0eBeyku1ALFt6QGcLD1WCwphI4uhEN5XYZTiheTT14qyQap5A9yN6ALxJC5iL9x8NRlaAqaoxELg5xOlTjluN9yLygDYq8aUdSZyFFlnR0Ngl2QVyCk6thE/gL0JB4mjXwQ3izpQrxg7krWosV9GaO1wl0jHXGmeNbzOPcUM2+sDYICYwpJzjmO/8c+THalY/+TKdcCmJDa3kQMPgp1chrgq++pHqQnvvZK8uyAnG48XPb/xWyVvXujA7OzhtJ8Beg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(71200400001)(38070700005)(38100700002)(66446008)(66946007)(86362001)(66556008)(66476007)(4326008)(76116006)(8676002)(64756008)(54906003)(6636002)(110136005)(316002)(26005)(186003)(82960400001)(122000001)(7696005)(9686003)(6506007)(52536014)(8936002)(5660300002)(55016003)(33656002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C4nHN8wRVZwNGtZ6vKd3KQ8qfvLikykmjJcAoNLwTQbFHp7b6lOs6Dbv4rqp?= =?us-ascii?Q?Wo4eW/boIx7NNfdGpX6Co3IVC1qFtm9hDvvu7r55Zw0ealRsJhjZK9/Ydb8d?= =?us-ascii?Q?JYKz0JQY7Te15McBPSDR9brQ3S0pw3JpUS1xFXkPHgGGUbYnoLG7wWoQAezS?= =?us-ascii?Q?df7/vHUJtSbydsUPZf0ZsITZ0hcjKTCR7PXe3QzRIRGLny3Ev93EdfnYdunU?= =?us-ascii?Q?AK8sfW0zAhqWAKMOApatTsb3IWJ4k7ZsyAicYoi7tZ0q3KP2xbNQs/dPphp8?= =?us-ascii?Q?bleQ1iZEmgq3LZwQUB7d8xfcudOdPePbhULwMQCXBq+N7uMHHTZbdHuDUzlX?= =?us-ascii?Q?fru0N9GzYEL11AIPQtS/7aS3mTGlmCwo8bysNTzsmRXRCeBdRigR+flTEuV1?= =?us-ascii?Q?sh7aksx2gS2K4dyBdmRFm0TOgm1Q4t+A9Ij2eFRpYMKIfNu1TbSyxf5Qzev2?= =?us-ascii?Q?p83Q9BNU5g7vdXZ38NTYNs5uvxTr3PM+mskzknokxC37yJPd+N3B4zhmrh7p?= =?us-ascii?Q?l637Tt2Pctrj5Y9sdAnGfxWvJg+ubiAIk5ec360qL5rpzsf0ovXr3twa3y/L?= =?us-ascii?Q?u5Z8QpLtn9NoLQI3pm+7XOufB7EYBalPR2TnV57qhpDZ76aB88FJBQJ/Kgxu?= =?us-ascii?Q?NnrCUMEKNCeVjVkZ8IAobCcnean9kAFI+dLXsLpv5fJSQrpALNST/3E1eN1y?= =?us-ascii?Q?MtqViSLxaPrTnZ0dGiou2zAeu7t1U6DUZ4j0nlLxut4ksZT7mHKizHkz3UwP?= =?us-ascii?Q?70mRlj/Kij2EWdJPLhE27DD9tTP2+rSRJMIPOldvWbCkx727LritYifUSOZR?= =?us-ascii?Q?GCnYagwLRE3nAGDmI4HewfIJB4ugeFlBeIEzGm9KA5NnS9P5cu1JtZW3fOKy?= =?us-ascii?Q?ihwgK57O+BsbnoPzl39SeB9mdqHS679ORHET/hlcmQCPLqRbKRjw4WvhP4W+?= =?us-ascii?Q?3j4kVWhDxHS4guZ+LqerNei6Ui4AbVwsXIgMRI8SwXG8kG+8pwpnH5m9BHgp?= =?us-ascii?Q?WUn5FrxiO+KBrXP1DKSTdlSowy+zXR9t3J/5mSLdDnMBdnZQvR2fm4jp6ciR?= =?us-ascii?Q?wQhDLv5lMdMKzX/UiFGoTLDxI3W0/HI3hfN044gsx/UKEXt7PaUdfkbi5c/I?= =?us-ascii?Q?WwITwU0lhf8CC1+WjRT53SfXa6lYmK7wBn98QQLd/papL81C3/UrouTsFk9F?= =?us-ascii?Q?GhKfEJcJ5rIcFD0XFmcRTPOTF9RqA3hYVRQ6qeevReQfTQ3DSSKdHmxVxGJp?= =?us-ascii?Q?6cJ/nnL/XsE6rb0R+YWqoWB1JndTdtAx+G2dfLMQE6LI8HqAsCCuCHtXQoT0?= =?us-ascii?Q?N5W9vIZzgHoSl0zZIGlpb49bB9+LZw5KrR4IRGo9K8B1Tf8awojZVzwuW2H4?= =?us-ascii?Q?LboRR1I7Ag8hBFSvwyERgQ9UWIdRyOtjjG9SnQopeU+HoDns9EEpunw9Eokl?= =?us-ascii?Q?mBnJ4js4aBDKyvdvdxhZXRFoQguwkWix?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92ef278c-2846-4021-3829-08da065799d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 07:44:13.7789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r6vSYEvbBtCkqA/RqSRkvYddrd6/IHb6aRM5Sv4C8IXy19Y1oOPAvhYwkkiotD9SAMYgsCtzPu35NtU5WvkULA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4371 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable one more comment: the functions headers say "@return EFI_SUCCESS". Should we say "@retval 0" = for a successful call? + to the host VMM, as selected by Leaf. + + @param[in] Leaf Leaf number of TDCALL instruction + @param[in] Arg1 Arg1 + @param[in] Arg2 Arg2 + @param[in] Arg3 Arg3 + @param[in,out] Results Returned result of the Leaf function + + @return EFI_SUCCESS + @return Other See individual leaf functions +**/ +UINTN +EFIAPI +TdCall ( + IN UINT64 Leaf, + IN UINT64 Arg1, + IN UINT64 Arg2, + IN UINT64 Arg3, + IN OUT VOID *Results + ); + +/** + TDVMALL is a leaf function 0 for TDCALL. It helps invoke services=20 +from the + host VMM to pass/receive information. + + @param[in] Leaf Number of sub-functions + @param[in] Arg1 Arg1 + @param[in] Arg2 Arg2 + @param[in] Arg3 Arg3 + @param[in] Arg4 Arg4 + @param[in,out] Results Returned result of the sub-function + + @return EFI_SUCCESS + @return Other See individual sub-functions + +**/ +UINTN +EFIAPI +TdVmCall ( + IN UINT64 Leaf, + IN UINT64 Arg1, + IN UINT64 Arg2, + IN UINT64 Arg3, + IN UINT64 Arg4, + IN OUT VOID *Results + ); +