From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.4117.1665726850142071190 for ; Thu, 13 Oct 2022 22:54:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nr5asygW; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665726850; x=1697262850; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ljlm2gOm/XjeJYWE29K1W4vczHBfrD3cePklNLp1tjY=; b=nr5asygWgudl8Z+Um3JiBhirwi/F3mxdZBGwGgLKXoKcR6WW98xYvwx3 8AnGKMEb21fysDskGxHY2nn5tZ1Q5ltqYGMgXlUWfQ+zZXDhmeIx8vXwJ pUx3oVBRz+ed7Zj4ZCcN1HU1pcSlqHgIjEzwu/H1wV6CPqU5xdUEScOUz pjHe/OZIymGfQVXGBc6FaBd4s6xuJoB72hatrJokClKCbbtixBxNs1lxL F3KLha0DaQ5/02eWhiWyTAiIXNUqJuHDXLhzqPXB9WXGvxPrcXf2l3WSE WtKJMkAKmxEllPP/a0iTxZ9fQ4nTm/lNjtgp3ZH2pU0UoAc9JPV00hgQy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="285678900" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="285678900" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 22:54:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="752806011" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="752806011" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 13 Oct 2022 22:54:09 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 22:54:08 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 22:54:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 22:54:08 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 22:54:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5WazpD2Ld7pNSdzdl9Sp4WEXxzHdodJfY5EkTNYS8iYJt/2ulmwZY3Jqyz+4nke5o+yC+ji7k9DU7r6mQLULKrBVQtGzQLYHPz0q4Z7W45eKPmFeU3qtP++sktuzYy9s5fKeo/hb6SM8sUOTZXrolOz/iRxII8QFRt0019xn5oBKVhuPuR+96dTxhVYj1lYMPWcUY8enExb5xQv9f3NHhpNw41w7akqS1daPlhsDzFaenhFHpUWYxfAmdb1Sqx2i7kLAKSgBCFpKoKFlI8y/d/OuPb65vQdU6jC7+8pl1dCMqC1Gq86IP6yw9lqKJvJhRIjqGT29ESEPOCpFHEcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmahhOsDLSxOF8K8j2fYTYi7bRwTNM+vQakhkbksuno=; b=RK1hBd4n90eaChcbi4cR8CZw8ZR/kR9WaCXgjNsPIS3VNeJMU1UjPvtICoABoMrTkatTjCH3PEcsZIP1VcWF23Pgbrw3efEZgTqsixeEdrBwKqmX7lDCogeUgF0sLv8CtAzaaNS5+JbW9l/mtCo0XO8dk0tiaQZluJxFqCVoWj+x8ACi3JTeTKsJ74B/z4ETQYE+Rux30OlZefNAy4F+4QSs+jOndgeT6X1Px57XsHPbXbQg4kV4f/IMrP88TUmTam6B0SgmT+mie11zJ8L0R9pJQIDD4FaSBqNzbt63etq5z0mpFJ6i2MWLdNS+oSfJeU3SLevYfaxXfe0kmuJwhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by PH0PR11MB5595.namprd11.prod.outlook.com (2603:10b6:510:e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 14 Oct 2022 05:54:05 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 05:54:06 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib Thread-Topic: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib Thread-Index: AQHY33DLt+GBCX56SUyoSmPYqRwTYa4NYmoQ Date: Fri, 14 Oct 2022 05:54:06 +0000 Message-ID: References: <20221014015400.440-1-dun.tan@intel.com> <20221014015400.440-3-dun.tan@intel.com> In-Reply-To: <20221014015400.440-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|PH0PR11MB5595:EE_ x-ms-office365-filtering-correlation-id: 9af02aac-da53-42b5-ab46-08daada8814b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: manGRRc762mVP/xs4QzAddCrMbvkBiAiUfqA+rq22V7FdZD+610z7Zv3+mbyAJU3tglVijmoYFDcgplO1xk4csXy1mcIJSK+eNQomBKCEoIsPIxif1ngI/Vkb/qyj2azQIBP2rV+U5q6aCfLYA3GlEnSfeVEKm38IJFzHHWicGcNaayxrNITiFI7kLNaqbcwJZEJL5iZ8z7hcSSM3nJMqsebrM8cuHnUzU5AyM90gf9/2f+tLELUCHapc6qDZK3mcXwOrgLUK+mPe5x3cKsvQU9bywAekCIbEbZyIikwxvyDw19kms90vcNDyY3MuY279EStRyn8c20XeC9zz7qu+CRFujeT9VSTTAI5+7426GI3s991ueqEV0HHDCDxtEg6e5APq4ANZ6wshaaBMkAXFgL+jbIABulyPRLxBAdiwHruKjJ2yorBKuvuJwTDkEyYvp/8dcX8JEg72Ocq9kAP9bkdWikn/2Yb+a2wox5SjUluBrZ2E4zO1hZp2sFLH9mhhSscbbP9wZXKlTx7QU+C+MtQ3pi+1/N0IkaLKTvEfHAjrln9Mey3MqbYkCpKg7zb6WBozvBaDVcKip6Zt4lVGp3EYj/pg6ZEG+4+FmFinlvrCrgS+dp1dLwHbDeC48IoI8J6iHxuWXHftw2TCeMR1dkPLLVQpO7BYNNBYEgbMWA5Bz8r9YRNShhaZ14AA/ygeyZ/qZ3vWjsYS4zBb4eLk3Y+BbDVZghKjC5i/1fZVsbT71TK+ebYU/bepRB11h8DIKaMxuRgar/pIlnHs7OFMTuJFEpJvIAAzu6xwv2x/0Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199015)(5660300002)(8936002)(4744005)(2906002)(186003)(41300700001)(6506007)(7696005)(26005)(9686003)(52536014)(82960400001)(122000001)(33656002)(38100700002)(86362001)(38070700005)(55016003)(83380400001)(316002)(54906003)(110136005)(71200400001)(478600001)(107886003)(66946007)(76116006)(66556008)(8676002)(64756008)(66476007)(4326008)(66446008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JRLT/7aeCngb92T5eau73tt2K5ApnspPnm9RBiZ8fMf933hfaLwaI9C1GpX6?= =?us-ascii?Q?432Xief+DXbHQ4jF4vzCG45wDtJ9b+hWeVdWTbYOE3ThBXv3PoSjd5Utrzf8?= =?us-ascii?Q?1Ww8HceNaPf+1P3FC28V9hXl9V0oUHnUcSDs27mTYeSXVRznrhF1uZJTppfq?= =?us-ascii?Q?DQd9lIg0njyzt7+cbppmEddhQ0RKQC0tbPal8BDQQv8yTyT50zQdXqhCIKjL?= =?us-ascii?Q?gityhy5E1vWZEcY1VAbpHlCkBLjzLiaw0eo2r2bQQmQUZW6NWBG3nu9B8jF7?= =?us-ascii?Q?MoGgqSwgjz3H7ESw0jP8hTDsLKNvRjH1WIV9b59in6Wm83dJjp897VO7U0Yn?= =?us-ascii?Q?IV76ZrYHTezO08drdcvXUOp84CiZAqyTfwxwvlyTbSb8iff3GW37yLC3PgWe?= =?us-ascii?Q?bfWrtHQatuG1Lm6zGFK9LzPVzKc6cn2H47b0ZMQv0PrpVymwk/Gyp2MpHCKR?= =?us-ascii?Q?aex5J0NDnFDNyqWyqa9NGxg0mYBDYnx0k1mHyEM+uzHsDLxNv/ig0FCmP/G8?= =?us-ascii?Q?pWaeV1qtp9K80PEWEu13WXQTdj7N6wQRplRdAeBp21eM5kWXzayO/HQjoOS3?= =?us-ascii?Q?/pyO+nBo67id9nc3eLV7x4HyiAPAZb/0FnlPfvPISqoxiSJJ78PR1UToR/eq?= =?us-ascii?Q?f+wx30w6daR6zHI9nOChpbWM8mTzUI2OOky66PmXA6qolwrRiYCcFsIUs+9n?= =?us-ascii?Q?dSohnyObs0PY1Uq/zjTIbVOLqoVzaMGdrQ19x/Wdr/LaHD+VCD92wO4XDJ0G?= =?us-ascii?Q?xmTtSMXo6dGOQZofI5g1APnu0syEp/zA1/Dt5kOZlAL9mRUKgXD32tb8SwSK?= =?us-ascii?Q?RjT1jzFByB1Lxk98ylulKvqjXb/cN5Str/se6qx8EsEc2zKkzah5OB/RB49K?= =?us-ascii?Q?HgSEWpcs9eU27lIHf7mJBKp3ET1ab+YnUuucnG8lPVsHsN32Hg3E/5Q10Tfs?= =?us-ascii?Q?0IDnLmxOo64BsJB2RoOZX7L93Ej22iVQsOyj9PLoxU12U9gbNJFdoFXW9rDQ?= =?us-ascii?Q?mk2cRkpCC8yqL1JvEGhdbnV/89KRDXqdLv/QZZVQoHAJK2cZNI3zDEvLuZx1?= =?us-ascii?Q?Ef+E/n9o4WrqBi4adpvOcEn3cJVWSSUqYICktXuuw9lI4UOMEMTYa5kMntGw?= =?us-ascii?Q?dFhLfXzYiGXBcRnDNnWct7UJ3s5+KrqPe7m9Ao5FWvzh2jlsYxp0llpk7DxM?= =?us-ascii?Q?wzC8oA7kYwgOxTXDLQWI/p+jv9IusuxiMqo5eENt6gnXe0KxdLmWVi/sAHCL?= =?us-ascii?Q?Rgsdm9aDBzjlEmmnH41JpSycvTqr7fbv3xF5zVMIlrbUq/pbBFkSigf/ycw5?= =?us-ascii?Q?flchOkizkwfiXzTNlpYX+yswBgchdyIhS32cbvnIuAGXdaiWfxbYs3/XeL85?= =?us-ascii?Q?yT0A1yRtv3PcStPZwUIrpF4B9/5JHNlukEUa/3q9nUrqoldNaIr/0pVWnoBo?= =?us-ascii?Q?7dif9katel6MzoSEOWAWiK5XkL8ixkBbqA4CX6XziEYXhbRcvSES0fMeS2L8?= =?us-ascii?Q?iHSjCtNLjhI8JVsVm+uf6zxPwqCmnyc7NOqHNkLMChHDhfewRbejpNZj174Y?= =?us-ascii?Q?oKSgwHuJ+I8PKKeWO/4nMFWcCPRndkSrGjvg48Vv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9af02aac-da53-42b5-ab46-08daada8814b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 05:54:06.1364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yyp7i4L7GQIPn374X7cUBGpuUhOdDiVTr3eUqLmxEm+BkcYIZLEHXlUSIJQqMQHH3NQiKi1IQOsNl1FcRXiPWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5595 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The commit message is the same as the last patch, right? Maybe you could say: The previous change adds unit test for DxeCpuExeptionHandlerLib in 64bit mo= de. This change adds unit test for PeiCpuExceptionHandlerLib based on previous = change. It can run in both 32bit and 64bit modes. > +extern GENERAL_REGISTER_IA32 mIa32ExpectedContextInHandler; > +extern GENERAL_REGISTER_IA32 mIa32ActualContextAfterException; Can you use the same variable name for IA32? The variable name is the same but the structure definitions are different.