From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.6271.1646126447260832728 for ; Tue, 01 Mar 2022 01:20:47 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YgMec+R/; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646126447; x=1677662447; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xl8qYhT0pUXV6MRatRxam4rdbwad+G8pd6fD8rXcueg=; b=YgMec+R/JqBRwJG+b/MGyWTi2r0DozI5kVcrDKMP+ozSpVQHyneS4pQV FrUgn/kE9nxLniYXc+hf12o9gsAS+oFlaP14BSDg8KSGcuuM/iZYWeJvI w/g7X+JrrhdSx3gLbVWfkU7ESrBLvgyf83RUPu2xzTOy2+QvVd3zRIJxB Z5Sq+r4Ilws2Y6em8jcoZ8DOp2xMjd4Db0CFFFUyOEKiW8S1kWckUwJSq AlwkWF08qdOsi+szTzje4Epep6l+vMujrNK1plW1iyjXWF0oaDclCOfX7 9U2UZoUCgPc7VbDH2FnWamQK68K5exYPJFJjNWckqlVvS6L1WJWT7JGBh w==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="252828620" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="252828620" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 01:20:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="493040245" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 01 Mar 2022 01:20:46 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 01:20:45 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 01:20:45 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 01:20:45 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 01:20:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUCXvOkTBlOpaqJFfCKOiRNJi7kBMDh+8cGCkyYub5ibdpMA0MTcHawNfSgEwIW7p0Y0Lk+Fw3hlbwYSX4B9q4plObV+K3VAW9aWDRyeRUPeHeTKg4VxllDjlt0qayOc7/T68ZU6L0FH8Cvn3CAxRVX7BEbprDH4JydBw9toIqCajzQNSHEIemGAqSCoCuCUKXRH+fC5I3ZfD6RId/g5FrX+pUgXzLfwV+PmU5wHzW0Uf8CTmuNjtwAIPbJqWVbJ4oeZ4FeHb4wU7fmD3PZQ1NFIM3Y3pT8+26XYECEj8SeUE71bfQcqm4pIDxdTF2fNANGfqhiyv+rqHMyZABQWmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bEeCaScG0Djg0LgoJAbCUU/iUzRGUjj4jkfFn/gp5ps=; b=aIdMbRXhHAeNtixOIeVJcWtCXQtsXsgB6DvgAQ+eNgR5OYVVn7DcICGPFVdbKVecqC+OSljoDRXA62G20805zCdtpGubDUn2/z0nR0CNwqsne3oeJqvl+8znvQXRveYVYotR0pojbOs+xLRXp334PuwDXR1gF9lxKbevQbygeX8oRn2Y079ufSsbRkgx0c2qo9PGl/jpXns5L0rJgSF+41wQ2bK7MakTlyBizp8FWrn9vsGyz11zGcMUG1S1GIjhl6GrVJPnKO4vU/e0JzXLLESMlqXAAjRhj67jOQ5j3XUjmtqKJQXOQW8PuluJ3IfCcAqf7Kicuik28H8yXJ9eBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY4PR1101MB2200.namprd11.prod.outlook.com (2603:10b6:910:19::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 09:20:43 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 09:20:43 +0000 From: "Ni, Ray" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: Andrew Fish Subject: Re: [PATCH v2 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Topic: [PATCH v2 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Index: AQHYLU2DRw4YrS9/pUS88n0BmRe0kqyqQJkQ Date: Tue, 1 Mar 2022 09:20:43 +0000 Message-ID: References: <20220301091850.828-1-guomin.jiang@intel.com> <20220301091850.828-3-guomin.jiang@intel.com> In-Reply-To: <20220301091850.828-3-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4446383d-b961-4940-3343-08d9fb64c2e5 x-ms-traffictypediagnostic: CY4PR1101MB2200:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wHY1WKwREVWVoSU3qzqKSvolnRI/6V+JS//DHs+z6Ke1JxIelq1+HTid4NoxM0WX9L/F1AEgKeev87jyr6Cpf8PGxdQj2rXOLi3xj4+YD9An0abcy6dA2hbDWxjzyRUGXr284tayelas5LffWvk0SDc2d/QwQu00VZqr4mQHb3JtcSs7q2pQcVo/CV54ISWDW5T5kQ0k+Ngh+lIr/1b9+6+fQJJGKJemP7vjoom6e/fxH1uT6jLBWzx8SLWBOuAyTgkBjDuzfDKFnLpuaB8DB1ZJ06nha35RTvbzq7hIF396siQrozNPOnBqSWh2+JDp3HiK+s943978nKkMN8FuUjUmXCRVxU8xX6E9mn/QvBnu3EKneCKc/FbOC03qIyLnKSm6NegmhUyWV15467/ZNWaEmbqzyAZ0iWBK10FLe3kzBvamxdS8vGajRkj4sZ5cFL4JIGI5z9ISu3f+ymuGTjgeIfUEbpkwiVSxR45plAkoyQxmVQ2xLSUZ9IHmBAdtJTr6o1oMsTNpvKjyQ94WK1kgR431hoolLF/XQyCPWwKj9BXDC19M8fjPz+4hcCgNyYtO+vsQqz9r0Kv1EtgIaYCHZL7PP2jWjYLV1sIBa5amKVFqj7ciL0TUJUmc7YdLfaPBFxeI7Mq6335a8A7nYeM0/kDfkXUReuczK6bbbdMMepPvPNGQuWxYR+PrN2EjTW906ww1XqFod6gsDzPrUmLRiWNobxk01AoVC4wof2e708Kx2kXFrwrWJnAUsJmbyMVk+tWubGRnwx68NGy461qzIgtPB3V58nF0atkB580= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(8936002)(55016003)(9686003)(52536014)(6506007)(5660300002)(82960400001)(7696005)(38070700005)(38100700002)(2906002)(316002)(110136005)(86362001)(508600001)(26005)(66476007)(966005)(186003)(66946007)(66556008)(66446008)(64756008)(71200400001)(33656002)(4326008)(122000001)(8676002)(83380400001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6RPptKOhliZrHz3EZHD5S+9Kcjii3D1B4LBwJElvtPuGvT1a1FT8ETD8ETfx?= =?us-ascii?Q?q17dMJn1YnUN8stK0JZELUPrLufKaDun1sYFBr4i33OdQq8YtRfThVbDEHKy?= =?us-ascii?Q?lxWk+6txUpJLLDsm5QhNGrMqDCgq3ReKAk05+l7OutNf16cXOvjxvRIbkEfh?= =?us-ascii?Q?DkmZwPWxei6g4ddkJ+0EjIoFxUiim5aOHKFXWeSPgzSBXsvvo7c9tEIRUNxs?= =?us-ascii?Q?id72sNbxhpTtON7Wlnk5I6cTPJgWJp1mEaAe/PUm3Dj5lemEybsrIsEyZTlK?= =?us-ascii?Q?Ju1wAsTOch7c2UFD3IRxzDIqALGX+EIEY82oEEWddRFRF/GorRRixOyUgJZw?= =?us-ascii?Q?t7gj+4uInVQxSxMNiCdCdrWSGbnz9BdBQznor0GZTeqBS4hLLnUTnQQEXPw2?= =?us-ascii?Q?BYSBl+09gEY0y33T3eJp/Z2ATIpbGegGgPx3OqghM5OEqI72kf/HQJ88zUuV?= =?us-ascii?Q?6lG+CYjuUu4ct1vsKyd7xpc1NEncEZS1ay+nH13dtNOE1QJb6pXqf78NkLNK?= =?us-ascii?Q?vo63MhsjdqqF6kwchbxYYta/af+eg3yHblGwBsKYvy1Z005DiSq3v9diJw31?= =?us-ascii?Q?46q+mLGknozot3Pq2gbLAJrYkMMjsJBU0o7DW9rXpljYCd9J7vord5g90A+F?= =?us-ascii?Q?t+n7dC4lLd/zWB9VUr8hsEUVh2CR6XGaGuwtWUPDHmLat30vAYKok/M7hTNj?= =?us-ascii?Q?VSHPesIUVtSgozYElTDXTAhPWkv/lgnghsOzKHdCUAkBoumXJ4ljdTtgOuEu?= =?us-ascii?Q?+f80dgI+homudl7zLMrRtR7IUSAlq22lACL53WsZa/rSmEWXIGIpS0qGKuxx?= =?us-ascii?Q?WUrOM1IrhC7WGoQXWgfvPJ2aTXtPWZC2vf9hvCISk/GockluIHI6xTvkVMwz?= =?us-ascii?Q?J+s5UCvyCP8brHyk9NsU0NoEUH30QaTJSbBKh5Zw0hlP1Isi5a0ZubZHP/Cm?= =?us-ascii?Q?HTE/DMIJC2qXAi/eMgH6IU5jcgdGpuuCNNwaDnBong1mnESsI/jEf7tpxDQu?= =?us-ascii?Q?P+XysAec476ojhP7lHVSDOGvKgNWDu35X6w24EF/c25fu81yw/YGv42PJkw/?= =?us-ascii?Q?n6ZQJW0hCiUbTILS7vYcVLPfXL/7PB0GXUS4sBlyKaqKr1qzDOTD7nhmQFTV?= =?us-ascii?Q?A16biYavHome3uWcJ7r+9OJesScGwtxKVZaxNhaMWPfyYyuRp50t+XuZm8gC?= =?us-ascii?Q?sbGWB6h+DVvJBCLes+c8ckyJ0574OaPF2f+YPyO0UI/OO5d8TdzeSRriqZ5i?= =?us-ascii?Q?Yf6AgIXzgo4B8dIPB+9E2F/NoSTOvnCCkTrFcKzvyOBj9zuayxr18Uk2qaMW?= =?us-ascii?Q?8HhpYjt24gHyw3XX37NoZ91tBFSPmlQCQnXubqY8zmewq06+u0UrU/pBIp5u?= =?us-ascii?Q?C8IRbyrJAEXf1YN3beFGzyuE7NsKq2Elc/uJRs2YqhajjZuJiivA/0PJouYY?= =?us-ascii?Q?WXnPm/h4zPVp7sLe+KGSiTo+MAS/9+98qMwRheZ2JYJgwKr1GDqqBhFA3mkk?= =?us-ascii?Q?qq5ty6qyXiD1SExOgZODyRKcUlWdPrZKX70nvqLvSo1HGLvwhc/0eHb//JuJ?= =?us-ascii?Q?tUetNmxneLGpyYSESaX2CHb1yEalRlbI5xqlGkcwHBgSK/Knw0ZYHdL5uRwA?= =?us-ascii?Q?VPMsDpw3PWCi71htt9LOIoY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4446383d-b961-4940-3343-08d9fb64c2e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 09:20:43.3956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LAfCUvVkgHD+0FAUq8hEcj9NDJVFGEzpClUU7gGWJ2iex3EwXz+ZBRHu/rMCvg3U++BFg8wd6EDKrhUVkkgn0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2200 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Jiang, Guomin =20 Sent: Tuesday, March 1, 2022 5:19 PM To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray Subject: [PATCH v2 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open succ= essfully REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2668 WindowOpen will fail in some case. for example, without XServer. Shouldn't set ModeInfo in this case to avoid the caller use it incorrectly Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/EmuGopDxe/GopScreen.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/EmuGopDxe/GopScreen.c b/EmulatorPkg/EmuGopDxe/GopS= creen.c index 41f748bc6402..9249eca1dd03 100644 --- a/EmulatorPkg/EmuGopDxe/GopScreen.c +++ b/EmulatorPkg/EmuGopDxe/GopScreen.c @@ -1,6 +1,6 @@ /*++ @file =20 -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.
Portions copyright (c) 2010 - 2011, Apple Inc. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -108,10 +108,6 @@ EmuGopSetMode ( } =20 ModeData =3D &Private->M= odeData[ModeNumber]; - This->Mode->Mode =3D ModeNumber; - Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData->H= orizontalResolution; - Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData->V= erticalResolution; - Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData->H= orizontalResolution; =20 if (Private->HardwareNeedsStarting) { Status =3D EmuGopStartWindow ( @@ -128,6 +124,11 @@ EmuGopSetMode ( Private->HardwareNeedsStarting =3D FALSE; } =20 + This->Mode->Mode =3D ModeNumber; + Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData->H= orizontalResolution; + Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData->V= erticalResolution; + Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData->H= orizontalResolution; + Status =3D Private->EmuGraphicsWindow->Size ( Private->EmuGraphicsWindow, ModeData->HorizontalResolution, -- 2.35.1.windows.2