From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [PATCH] UefiCpuPkg/MpInitLib: Simplify logic in SwitchBsp
Date: Thu, 25 Aug 2022 09:18:16 +0000 [thread overview]
Message-ID: <MWHPR11MB1631F2B4CABC88D6BF45DA268C729@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220825025506.2323-3-zhiguang.liu@intel.com>
>
> ;Store EFLAGS, GDTR and IDTR register to stack
> pushfd
Can you update the comments?
> - mov eax, cr4
> - push eax ; push cr4 firstly
> - mov eax, cr0
> - push eax
> -
> - sgdt [esi + CPU_EXCHANGE_ROLE_INFO.Gdtr]
> - sidt [esi + CPU_EXCHANGE_ROLE_INFO.Idtr]
>
>
next prev parent reply other threads:[~2022-08-25 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 2:55 [PATCH] UefiCpuPkg: Enhance logic in InitializeMpExceptionStackSwitchHandlers Zhiguang Liu
2022-08-25 2:55 ` [PATCH] UefiCpuPkg/MpInitLib: Fix potential issue when IDT table is at above 4G Zhiguang Liu
2022-08-25 9:32 ` Ni, Ray
2022-08-25 2:55 ` [PATCH] UefiCpuPkg/MpInitLib: Simplify logic in SwitchBsp Zhiguang Liu
2022-08-25 9:18 ` Ni, Ray [this message]
2022-08-25 2:55 ` [PATCH] UefiCpuPkg: Simplify the implementation when separate exception stacks Zhiguang Liu
2022-08-25 9:32 ` [edk2-devel] [PATCH] UefiCpuPkg: Enhance logic in InitializeMpExceptionStackSwitchHandlers Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1631F2B4CABC88D6BF45DA268C729@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox