From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.22563.1647227558523118449 for ; Sun, 13 Mar 2022 20:12:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YGE5TExI; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647227558; x=1678763558; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d27krpUoJTDuagB9RAvDH6EMdmgxcNm6OV0cSVmjRgc=; b=YGE5TExIFrsBBuqwzGejxdG5/ZQe+Njke28GjgOFBGdvA1wh2tp0ku0n vIpO2YoCdnfM/VovBTdjTw9aQyyjH6yqEZGcg4TtHKZjnVs5DkP3y4GcS vh38Ul05KNeP+4aczWFUJlNJxtCLyDQ5PosWroRMVV3tJFPQK2F7XevgJ chk3k6I5xCQ8iOJm1hymVS8NV5Qxyv1SZHWlvxtQZ4mWf0ye3Zuu+M88b 3BBadCHhKuVoEy/BtKlMhoE22mHwBlvHVNoqfU4kVkiWZJg/OVV3k11tv m/huTi2SsJtB9WR3+Yj+GjOvCd1jetV1wsjeB8lXKe+W22ypwbena4Xna Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10285"; a="238095566" X-IronPort-AV: E=Sophos;i="5.90,179,1643702400"; d="scan'208";a="238095566" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2022 20:12:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,179,1643702400"; d="scan'208";a="556191542" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 13 Mar 2022 20:12:37 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 13 Mar 2022 20:12:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 13 Mar 2022 20:12:37 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 13 Mar 2022 20:12:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDVW+DV3kkKrjKCXQ6SFtE7xpdVw+kcfqWwvyW6ZJxAhjbT9aYqFKpormFouD1KEo9MD2HE4+sZ7JRDqFaCut/d+5ZU9y2V+fnryYceVogoVzBM8tTKqUcGPdn4YALROVgcOZGsxgTJnkx6p1xFbZDCcbIqcixOwR9l3HgqmUc573IrirZzPnVOMY3BVolfBFN8JEcggSfiv2OZ2LbMbJ4XGaISauo+l10PLZZeupO9UGcitQC1g4ch6tN6nFNYiHtDdPePhPc9dGur+sIa/GoJZzPuKjoiR3jb/X8k+NpfQtzWYnLusSG5fECPDvhlWt8Jv70D9o/6mRvt6Os6MVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lJwV1ABlTCawouQ8qZOQEl/Vky/Uw3tRpxsTgRzN79s=; b=EX1+oUNFEn0bjX0ITkyDpnTkYee0fk0csu97q1OPZZ+Ex1dhFIrA2+pSbM64WsA7MaHnbEgvBXPE7H83p7pz/2cxz184vvUpSpwNtdoZqkexcEsttNY6D5RiIwblVf1bhIbeHb0OQiFe+cPlKO7wCuBJ+xevCtq6ViaUnSM5Z78pEnZowXcxUI6slJUhWXyXRicjnea4YWB6YDmgO52mPr5niW8ljpiPCJf5VMlWl/8fpUnK29cATKSnXlXBNNBTIafjbOt5kfznTmj6jd+L3/8C8zfKtqzdRwmjp7XN3zgD16P8fz/PqpJsI0MKBXbc6RAwmWIeBVJoQ0FhALeS4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by DM5PR11MB1596.namprd11.prod.outlook.com (2603:10b6:4:b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Mon, 14 Mar 2022 03:12:35 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.028; Mon, 14 Mar 2022 03:12:35 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Rhodes, Sean" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error Thread-Index: AQHYNU2+0OTRUgwqHUCwTfJPTnq2jay+OAWw Date: Mon, 14 Mar 2022 03:12:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee9afa99-7477-47c5-7d24-08da05687cfd x-ms-traffictypediagnostic: DM5PR11MB1596:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oBYdCK2eAZ3JkHlmHTqivkGejs035YL2OHdIGKC+byBdoq34TxI4UQ/Q8GOVVtt766B6ohVPnvgg3wSXFTMBUZhfnNFAgBiZR3ClNGDM5YrBZx5dcSBjCfZYBCF9yi1dqOS/S3TNl4Tvzdmevg0O3zli6/RWWa3FawK+XQjGINOCdr8fjj/0bsOEZlxNQanfCUGkhhek2t9Gy7wod9YyoX3zhBSJciMQ29aqA55GZHss7t2EdL9V0FzCPnFzp8LA4iiQ6r3TomMgxmRk6jOlpkTIsQkZEXjBDQwSotCd8nGkEpAO7yWC4DPnHACofWMNa1DIre6ELo2HNgEMwPb4Jgy3OVQMaTEFf9IM9evquien5ooCdMQMXCGPl5dS8J2rdbxex60DeXOtlTRFdJ2ga5b7eOCP8SHemEWBsBcT88btcOp4N6vahF/j549PMwEIi+Fc6s1S/bxG28e7n9Vd3SrtVaW67SABYcEB0IWqGuvlrp+XHjwAnAaXVQBBmqfd/gyQDjGmMZA51PrI9LDjsh2NabCRXv/jez4EFmCpsxzZL/fg6nSlNQQ0KhAAyKhh8xX3CWEcPxzSpC0GRMnjFjqqnOtr/syyDsQgs1/OoEjU51Sqeycs8k3sS0jSKitlHc2ILVp9rj8Eb+ue5+kUYBg5lOvy8Z6ZFMmUKLOQYa8sEIqrU8MUdMYV2jHkgj9aXNWkOBBEaFAmPY9HqSj0gV52RjzfEXz9IiLkjbzoiic0fhWFXFoyWrYSdbKBilQ6uUPIP1xd75drw0cNUwFVCAOfcYs6gSaM3Hj3WnPylGLZMeK2K7eScZPP+ws6jK0qBULOkQSuyODE8FNxUvf2Fw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(64756008)(66446008)(4326008)(8676002)(66556008)(122000001)(38100700002)(26005)(186003)(83380400001)(53546011)(86362001)(9686003)(7696005)(6506007)(107886003)(66946007)(55016003)(508600001)(38070700005)(316002)(54906003)(82960400001)(110136005)(33656002)(76116006)(966005)(8936002)(66476007)(52536014)(2906002)(5660300002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+HG9qA5psgtb2I/OslEL4fK5KCTVYPvB0McegxJ4G+gEdjnTfexPHvnd/Ski?= =?us-ascii?Q?VGs+kybfZoCdp2ZZcIDtvM+zc/4BKri2d3qyeOFmbMVsr9jr/yyfQ1xUHFwQ?= =?us-ascii?Q?JRCZ8DlSix1wDbgpczRUcUHQbtAZ9kUt1F8rXRUSZ+wFF+zmMPUCRWOo1bVs?= =?us-ascii?Q?CbJH1hQUbWZ+5PxMs25pjpBHyOhisE71G6ut7+TbCkhwKL5XCgdQMKw8F1do?= =?us-ascii?Q?rzunbntzDxn66GsMc652msuATS2bHWpiuClr2HxMbk+5u0+F+dP/Vd2llSgZ?= =?us-ascii?Q?eH8dkiLSgD3K7jkjTpoJYSoz5WkNDad9VVkxUmCk1ijjlA7584e/+W58eLie?= =?us-ascii?Q?k2ntHL99HyebE2s8UEvo2dg6ItE0/e717J/s3gkdmjXALZyibV2L3f2J1QVt?= =?us-ascii?Q?idfrXcKsUG++fhbjmmnBw72zUjY66z9mB6RP2S07jWzvsf5ViJeSP+vw2dSb?= =?us-ascii?Q?RQm72r4L3mF7yYqEor0y5ybL0Asf1943z8IE7Gyh3kdue9mJwYSq/PPMFX/j?= =?us-ascii?Q?Src91944iw+TGbasRj49RHwjKXZ6P36fRuRJITH4eSCEEV+IzAI+hZnt5aOP?= =?us-ascii?Q?UqwOcDKVUyWJvnG9H2OQ4wjjdF2jlNV7HkP4uc35jshPNddBXWlHKM/9L9cP?= =?us-ascii?Q?VMRSzBT9b35uAaEIePbw8BlCB+XXF2dDHFyoAQH+DBybkAtSs0BdpyA8lvfx?= =?us-ascii?Q?o86Z3BycOaLzCkxJH3e06pqSbJp6JmCx0FlGh6XxfrQtUNS9yyBDdLhs8mck?= =?us-ascii?Q?rUZvbWB3yGthvVDZCQGDium69W1Tnb8Y6ukYbQqF3Hyi1enIPKSHv976Bv+z?= =?us-ascii?Q?jKnOUvDQZcX6sFJh09SvW6BPGPoaxiRkrjR4m4dQcQ5xUJvFVYdpyj2gsDG9?= =?us-ascii?Q?CPmueRIM3+pC8A/A9QKQn2imxH8m0WmgxBWEBDBAO7FQeAalzal/Ho/zgvod?= =?us-ascii?Q?xhn0fpOeLbobaLYZ/BM2EGb2iiCNRzR+fqoRpYtO7zHH2WaCVAzZHXzHh7Wi?= =?us-ascii?Q?mm6bG9/h5qawaXiYT+hJD26f9sKQJ8m0I85cVw/sRxC85DYcbmtf1+yYOq/l?= =?us-ascii?Q?wmB6AshX+89zAn94ac1jHD/7Y7/vJ3YZ/fp49whnMdH2Ep9P73tl58jC/DsF?= =?us-ascii?Q?KsQkW/BG1CttVCV1VHambMgGU1lOGcSyAlL8tlePDNCn9hnREI0cJHB5kAYK?= =?us-ascii?Q?WZQXA3C7/+IAkKjVXkkVhxsGhKHa1m3GsIWRJJ+FFa3Wy52QAWtErMTKtBDp?= =?us-ascii?Q?NjrY3fLt4073es7AL6l+T0qwvSzj9EkeOhLFsRYUlzKOpWNxpPy1NMf06OK6?= =?us-ascii?Q?qH2lGRNzmcY0Lo6ibIfXjQc6YYTLdD0etm+33o87U4yo1+2S+T4A8XKBB/Qs?= =?us-ascii?Q?0CL/SggUu3BY2YXuMN7ev1iPolzbEUTVnR+W5iC5TrBDjvB9jzOU5a5+B7Gg?= =?us-ascii?Q?XihEWog2uW2BNwZ1R4jZny87j1UIYyPe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee9afa99-7477-47c5-7d24-08da05687cfd X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2022 03:12:35.6196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z9xyWGG35Rsu5NSsZwJqNI7NMsig+f3811aD5q1BTSYzP7Oe773uqlp6TDe+uT89oRCc38uubU4WWTku+sjvIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1596 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE =3D TRUE". -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Friday, March 11, 2022 9:41 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice= ; You, Benjamin Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error From: Guo Dong On windows build, need add -DPLATFORMX64_ENABLE=3DTRUE in the build command line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features. So set PLATFORMX64_ENABLE to TRUE when need build network feature. On Linux build, DSC file should not have PcdAllowHttpConnections when network feature is not built, else would cause build error. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 558513baf1..f3806a8ebc 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -407,7 +407,9 @@ [PcdsPatchableInModule.X64] gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER) gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER= ) +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE +!endif =20 [PcdsPatchableInModule.common] gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 } @@ -530,6 +532,8 @@ # UEFI network modules # !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE +[Defines] + DEFINE PLATFORMX64_ENABLE =3D TRUE !include NetworkPkg/Network.dsc.inc !endif =20 --=20 2.32.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87463): https://edk2.groups.io/g/devel/message/87463 Mute This Topic: https://groups.io/mt/89710183/1712937 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D