public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Rebecca Cran <rebecca@nuviainc.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
Date: Tue, 6 Apr 2021 02:04:17 +0000	[thread overview]
Message-ID: <MWHPR11MB164713E4EF14D52D3757F7BDF6769@MWHPR11MB1647.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210331015432.18015-1-rebecca@nuviainc.com>

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, March 31, 2021 9:55 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
> 
> The SystemEnclosureTypeTable in QueryTable.c contained a couple of errors:
> value 0x10 is "Lunch Box" not "Main Server Chassis", and the Sub Notebook
> value was repeated as 0x13 when that entry is for "SubChassis". The entries
> in-between needed adjusted.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index d0796a0e5141..39a3e3c0895b 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -188,20 +188,20 @@ TABLE_ITEM  SystemEnclosureTypeTable[] = {
>    },
>    {
>      0x10,
> +    L"  Lunch Box"
> +  },
> +  {
> +    0x11,
>      L"  Main Server Chassis"
>    },
>    {
> -    0x11,
> +    0x12,
>      L"  Expansion Chassis"
>    },
>    {
> -    0x12,
> +    0x13,
>      L"  SubChassis"
>    },
> -  {
> -    0x13,
> -    L"  Sub Notebook"
> -  },
>    {
>      0x14,
>      L"  Bus Expansion Chassis"
> --
> 2.26.2


      reply	other threads:[~2021-04-06  2:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  1:54 [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table Rebecca Cran
2021-04-06  2:04 ` Gao, Zhichao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB164713E4EF14D52D3757F7BDF6769@MWHPR11MB1647.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox