* [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
@ 2021-03-31 1:54 Rebecca Cran
2021-04-06 2:04 ` Gao, Zhichao
0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2021-03-31 1:54 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Ray Ni, Zhichao Gao
The SystemEnclosureTypeTable in QueryTable.c contained a couple
of errors: value 0x10 is "Lunch Box" not "Main Server Chassis", and
the Sub Notebook value was repeated as 0x13 when that entry is for
"SubChassis". The entries in-between needed adjusted.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index d0796a0e5141..39a3e3c0895b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -188,20 +188,20 @@ TABLE_ITEM SystemEnclosureTypeTable[] = {
},
{
0x10,
+ L" Lunch Box"
+ },
+ {
+ 0x11,
L" Main Server Chassis"
},
{
- 0x11,
+ 0x12,
L" Expansion Chassis"
},
{
- 0x12,
+ 0x13,
L" SubChassis"
},
- {
- 0x13,
- L" Sub Notebook"
- },
{
0x14,
L" Bus Expansion Chassis"
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
2021-03-31 1:54 [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table Rebecca Cran
@ 2021-04-06 2:04 ` Gao, Zhichao
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Zhichao @ 2021-04-06 2:04 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io; +Cc: Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, March 31, 2021 9:55 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
>
> The SystemEnclosureTypeTable in QueryTable.c contained a couple of errors:
> value 0x10 is "Lunch Box" not "Main Server Chassis", and the Sub Notebook
> value was repeated as 0x13 when that entry is for "SubChassis". The entries
> in-between needed adjusted.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index d0796a0e5141..39a3e3c0895b 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -188,20 +188,20 @@ TABLE_ITEM SystemEnclosureTypeTable[] = {
> },
> {
> 0x10,
> + L" Lunch Box"
> + },
> + {
> + 0x11,
> L" Main Server Chassis"
> },
> {
> - 0x11,
> + 0x12,
> L" Expansion Chassis"
> },
> {
> - 0x12,
> + 0x13,
> L" SubChassis"
> },
> - {
> - 0x13,
> - L" Sub Notebook"
> - },
> {
> 0x14,
> L" Bus Expansion Chassis"
> --
> 2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-31 1:54 [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table Rebecca Cran
2021-04-06 2:04 ` Gao, Zhichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox