From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.6461.1617674664026621991 for ; Mon, 05 Apr 2021 19:04:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=zFO999L8; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhichao.gao@intel.com) IronPort-SDR: MB2ny1f6jcbOSp37SWYOIiT4bYFZJeKXKWCnMoA3DQXK3BeQeUp5UQwkIdh3+XYIeLI1Bbp1Q4 FQS2VBDEHC0Q== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="192490742" X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="192490742" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2021 19:04:22 -0700 IronPort-SDR: C4iGGW9vPxVUXIrtHawNfRjBfVP5njb3Fdwm+X8pA0LJkRFqWlzERZiPsaDzg4L3zS78ivYNMz 8x6hQALgoEFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,308,1610438400"; d="scan'208";a="420984529" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 05 Apr 2021 19:04:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 5 Apr 2021 19:04:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 5 Apr 2021 19:04:22 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 5 Apr 2021 19:04:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fykDTC0wrNGMkl03S7HUXdnUy/oBJNgWYI5ZdXuACq0+YXIzggn3iC/odyrh/2UZdrsZ45bX+BOKvaOHmaZa0UIxQAvKASy/lx13j4bCNlnDZENhuXqVvHpOw4s5OZNIQhxVK2EdFOcSAMHPvNxJuJuogOQrsEbXJvIzwtcMZgZElYOYQgH+4XX4CVFMVfm6v69eduYyKqswjnbZcPvT5HshUkufOO6kS1a9IV84UvAK2TH9s1BkTMBFgLV8DHZnUaFJJDhGZ5ZJhNyJtWDHS5jSnTpJGWEX2QFKwDZP9hpXK1N27caakskaIIiYfy3vhBtyMus40lGBIW58VGW/pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5NlZua1JznczIuezOO5tzu5Swn6cta/99z2K1zSeso=; b=merXD71SKzOkeqwwUYfhW3Opjuehy5I1xhL8Sfs80iS/JLpf9YBKp1pCGChCP3ScpDUwNHg61M2yxHmuNbSTB0xqWQAM5iV9OvXEt4UtmGMITdJWXzS7HIwjHwrAlj5CRNvvzit4ZkxC1Jp50GLcJ+qZF7z1WeDqfddtZ1OSRYJcmTdb4WQyCzLPYq3CwZEhFDql0LVT89e5SKYn2Xpxqwh5/+mxxMLPEeOK4RH9HkCvARq0wuQl/JfihXT4LBAt+5EmMeiigvltfiYKTa5ZmxQpwzSIpwIhCRv267EkGdwjrZUJ3v1CKJ5AIdlusBiMVgQ8ZqTnSNz/xRGBYKLgzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5NlZua1JznczIuezOO5tzu5Swn6cta/99z2K1zSeso=; b=zFO999L8gEtZy4SHkjrZaLmb0GlaYxI2/PccS9VKUPX7BR0seD7OUGFuIi0ijNo595WV9s8/dsgER75oAeh1kbHJquDsdx6m6vHeRsHsExK0xADxHnXGsT/9a4WQvoK3servAl0HxlM1xU5A1ZkrdGUZlyZgXzqe4eejNFt6wXw= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR11MB1919.namprd11.prod.outlook.com (2603:10b6:300:106::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 02:04:17 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c%11]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 02:04:17 +0000 From: "Gao, Zhichao" To: Rebecca Cran , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table Thread-Topic: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table Thread-Index: AQHXJdEBJW4f1a6MyE2sTdNm59DlzKqmxeGg Date: Tue, 6 Apr 2021 02:04:17 +0000 Message-ID: References: <20210331015432.18015-1-rebecca@nuviainc.com> In-Reply-To: <20210331015432.18015-1-rebecca@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: edb8d3e0-141a-4c8a-a8e7-08d8f8a048c2 x-ms-traffictypediagnostic: MWHPR11MB1919: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nR0AuIeP6WdS2YxRPDkr6XzdanbsJs46QotKs91zG12EAyXPMps0KnNQMKxHtHnu5CVcSo+3yw315NDvm9TDIM2EecpzB7jGT+wFA8Olf/vloa2aVx+eTqC1ICMYFf4AUVPu8Z3qiJns7LPG5OT5+akzARPKBwZSt2TxeeLe6qzcD0g4YMjnaIrxVK0iTfhYkSEh3trehjcJOJn4EWFoFY67+gMyGgx0/Glo3doFLdQj6Zq64P86K2CjBVQkdra8idG96oKKzk0gtH3JS71Xsmj2fkj4+uS/Jdiqaj5ABMFxHCL1/wcCM0KU35BarKUU9trbAvEr8l0w25OXB88oRq9M/BSgp+tQDmOGic0SFk5MlwnIfLnnwTpg1O6ijnusx7Uc6uQZ6KWQRpkrRH/M+o/Upg9BuAErV5kVtzf8jZXz71OyHRvBD5yD8aybk8J0p/6pj+qu6qODmnTowNYNVAymabc3fnrsz/kG5H+nnE7GjLnvYruGflEjSM+8RRIJKZL89L834lSmUTufuIczKaHKZfivZnwHaAW3eRs27hNovXaN2j9s9pvkq0xFA63OcXQAFRXnFt+UKqa8EhzFisPoht6RpVTmeV0sW10w56zHP59WTe5WzXYPJd4nT7WbmFI16gbvivrwOvznWPmHrTmlMvxMOLzlPYX3sYXu7uQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(396003)(376002)(39860400002)(6506007)(66556008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(33656002)(53546011)(478600001)(38100700001)(8676002)(8936002)(71200400001)(7696005)(186003)(26005)(4326008)(83380400001)(107886003)(86362001)(5660300002)(110136005)(52536014)(316002)(55016002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AFepjIgkFPZo5qSaWuBmYsCz0iTBmLiFVelxnZcuZr1L1aUSaYVc6A0ilWBC?= =?us-ascii?Q?JhIxOID08WViXO4CB3dc28+zlwWYVInLuz1OLxCPc3auk/UP1+DoJzMlJQgg?= =?us-ascii?Q?DpoZk1XU2/U3ufhPotvy2Ol/CylJeYjIunMPUBVWAEmylW9NX7DA0+81K/n+?= =?us-ascii?Q?feeMSLWOIKlWuN5eNbvn2g91dZmCDJHTlg0S5U96G0gxxrFFo5Zil1u3c8Sx?= =?us-ascii?Q?b8QoibHZjSPEmvoOpHoNp/rZr2hiPyAnWn8lfGcLH7uLnh4+iK5qf3WOpO6G?= =?us-ascii?Q?C0d6T3FcrBI5eszsroOX5ZTnAe9HOa74LCSPP/X/rSdSCZllLglf9xHOXwCe?= =?us-ascii?Q?wbxwQpx7pGGDO4ob1Sv801uj6qWrwK/knu0U8wxwseeeV8lvx7ldarxtWbFD?= =?us-ascii?Q?ZiXizElfe2TzNxixZYouQqwRhxJGyF2/MuIOS7csKUwZ6cafKe7Uu2MK6UBc?= =?us-ascii?Q?qs3aYfeL8yQIqaF/IWIvqSnNUWFJ2vhOLdL7BTyDwNen93/gZY/GzoWyiXv0?= =?us-ascii?Q?lheAIJYaPYvVWfRaojw72xwEoRE5oL9HwJYoQKbB9sgnMhh0piEbPUrHFxXy?= =?us-ascii?Q?MvhUNmuvUMT5LrA14k2s7mBilS6P0ju2Zehxm5HrmC4e+qEz71aNzamWQK+X?= =?us-ascii?Q?Rie18V+CAYuLxVs0yYE5W3PweVYugT7daiLg6oa5eEzp8T6ml2HqyABlSdQJ?= =?us-ascii?Q?F2b9YE+W/S/+fd5mMvXEa+wHQeriRKJZ6PF3yNqE9/UPbI/aiPHyG6n0XfJ1?= =?us-ascii?Q?2pw5tiF9EaZ0nKdE+/j3ccmNL1bbPRjVdRYbQUJi91eb/Fgp4IE3jMarO3qr?= =?us-ascii?Q?2et6aNFghI79hhbcG6axYWMlt6QpifYwo2okW66FFCBUhqYxE+pG/IMW7a1f?= =?us-ascii?Q?khrXukXpe/W/fWxtSIx/embmux0kHBN1ywW3T19CglpxRxn2pYbCuT4yS2Gt?= =?us-ascii?Q?iF4wjYSbD5lK9SJ5cleSccYcI4pb71iNrAPHhNK4O2EIPg1K5uTqh3+CFzUC?= =?us-ascii?Q?deWgs0Twr9Pwac+dcpdDJjON6M2KnKiKcx8wiBAcrO6asYW88+HXb1mMjIYo?= =?us-ascii?Q?3qTv0IDBAxrAwidJ1bQwKji6ZeNJmOcxlFQoyB7MIqToIKywPS8xM4o3ckHK?= =?us-ascii?Q?YDBlV7kQgBcvWtBql1v/fubyG7gYu6lNmsItjpwh5xovPlg8BOGTLC/Dr8Jj?= =?us-ascii?Q?llmv0EUvCOLxIH7GBHS8WkbzE0KPXNfaLtO91N3T9VUAATNLQXrNxSQmNWM+?= =?us-ascii?Q?EPTJlRMf/a2326Ogx/Cigr8VcXrM25YagpQciKJU8YE0tpfN+6ynOtZlAyU/?= =?us-ascii?Q?ssUI8NAW6ras2nkApjXorGVO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: edb8d3e0-141a-4c8a-a8e7-08d8f8a048c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 02:04:17.1048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xSZCAJpUMFC54c5vGO/HYtldcSC2fYz1nRiUx2NH9q2vF9owhGnKnYBIOz7RpFq1C7hR36CnsRSEc15S1TylDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1919 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Rebecca Cran > Sent: Wednesday, March 31, 2021 9:55 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Ni, Ray ; Gao, > Zhichao > Subject: [PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table >=20 > The SystemEnclosureTypeTable in QueryTable.c contained a couple of errors= : > value 0x10 is "Lunch Box" not "Main Server Chassis", and the Sub Notebook > value was repeated as 0x13 when that entry is for "SubChassis". The entri= es > in-between needed adjusted. >=20 > Signed-off-by: Rebecca Cran > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index d0796a0e5141..39a3e3c0895b 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -188,20 +188,20 @@ TABLE_ITEM SystemEnclosureTypeTable[] =3D { > }, > { > 0x10, > + L" Lunch Box" > + }, > + { > + 0x11, > L" Main Server Chassis" > }, > { > - 0x11, > + 0x12, > L" Expansion Chassis" > }, > { > - 0x12, > + 0x13, > L" SubChassis" > }, > - { > - 0x13, > - L" Sub Notebook" > - }, > { > 0x14, > L" Bus Expansion Chassis" > -- > 2.26.2