Re: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY

["Gao, Zhichao" <zhichao.gao@intel.com>]

I agree the EFI_MAGENTA is not a good choose. But this may be a different issue. Many platforms would set serial port as ConOut and ErrOut. The different colors for them can differ the origin. I don't think change them to the same color is a good idea.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Wednesday, November 25, 2020 7:30 AM
> To: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard
> Biesheuvel <Ard.Biesheuvel@arm.com>; Andy Lutomirski <luto@kernel.org>
> Subject: Re: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change
> StdErr color to EFI_LIGHTGRAY
> 
> On 11/24/20 20:15, Samer El-Haj-Mahmoud wrote:
> > ConSplitter was using EFI_LIGHTGRAY foreground color for ConOut and
> > EFI_MAGENTA for StdErr.
> >
> > This does not work all the time, and StdErr ends up showing parts in
> > MAGENTA and other parts in LIGHTGRAY. Changing StdErr to LIGHTGRAY
> > looks better and is more consistent.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>
> > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> > ---
> >  MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > index b090de288517..e8cd4ce120a0 100644
> > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> > @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart (
> >    // their MaxMode and QueryData should be the intersection of both.
> >    //
> >    Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL,
> > NULL);
> > -  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> > (EFI_MAGENTA, EFI_BLACK));
> > +  ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> > + (EFI_LIGHTGRAY, EFI_BLACK));
> >
> >    return Status;
> >  }
> >
> 
> I am very curious as to how this patch is going to fare, as Andy Lutomirski (CC'd)
> reported the same symptom in a Fedora bugzilla ticket
> 4+ years ago:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1355913
> 
> As you can see in that BZ, I found the same code location, I just didn't feel up to
> starting another crusade on edk2-devel -- about colors even!... So I'll be watching
> this one now. :)
> 
> Thanks
> Laszlo
> 
> 
> 
> 
>