Re: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview

["Gao, Zhichao" <zhichao.gao@intel.com>]

Hi Rebecca,

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 21, 2020 12:17 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
> 
> Fix a couple of typos in SmbiosViewStrings.uni:
> "Boot form CD" should be "Boot from CD", and "plugged from the wall"
> should be "plugged into the wall".
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .../SmbiosView/SmbiosViewStrings.uni                          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> index 7fbcc9a31afb..4160ca40a988 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> @@ -128,7 +128,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING                 #language
> en-US "BIOS shadowing is allowed\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED                 #language
> en-US "VL-VESA is supported\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT                   #language en-
> US "ESCD support is available\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot form CD is supported\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot from CD is supported\r\n"

The string ID is also incorrect. See 'FORM'. I think we should change it as well.

Thanks,
Zhichao

>  #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED
> #language en-US "Selectable Boot is supported\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED              #language
> en-US "BIOS ROM is socketed\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD
> #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
> @@ -373,7 +373,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE                 #language en-
> US " Not applicable\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3                     #language en-US
> " Reserved  \r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED
> #language en-US "Power supply is unplugged from the wall\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged from the wall\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged into the wall\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT
> #language en-US "Power supply is present\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT
> #language en-US "Power supply is not present\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE
> #language en-US "Power supply is hot replaceable\r\n"
> --
> 2.26.2