From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.5179.1603244007992629248 for ; Tue, 20 Oct 2020 18:33:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=APDxEKIh; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhichao.gao@intel.com) IronPort-SDR: mj2go/QS2NfV+swvO7e+vynHph2pSKWTCWL2G7TY2d6V0uuV1SUgHsCagNO1HPC3qT2VHc06mx 2IzOP7Q1heFA== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="166523435" X-IronPort-AV: E=Sophos;i="5.77,399,1596524400"; d="scan'208";a="166523435" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 18:33:27 -0700 IronPort-SDR: aOs2mWqeVYuEO71q/fCN85IrK3KFKcSOrle/BKp++d/NCaibZpbamWGA3mv3qbjOLhffvtsBR+ i3+/LKfsrM/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,399,1596524400"; d="scan'208";a="359350886" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 20 Oct 2020 18:33:27 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 18:33:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 18:33:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 18:33:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DKEjBGvtETd4gMSH26SQP6GWpNvH039ncOqnQlF9e3/7rxDzdvwiJHHgdUL2aw2Tji1k/P7Y4T4a6zwsL0R7IDTU9sLUov2bKCLfNlj8pDH/mQE+QRhI+DfrMnBxPfWGA9566cJ6hIpHhTx0wXVNmbwu3Hkov68ZOaxhzvO9147zRUX3iEfeTUQ1/T3VHVUFznEz2QjSgKaKhAU99eb2Leq6tudXyjKDAs0aPFajkyFqVzfNrJpY61H6ef4ZrctUtvvWTX07kAutJnF3CilSeyPS1JECmdqhY04bZeMxVaPduytFWHGJdzeRbiJcJpzi7/xj6nWwjvMz4+dJ5u/huQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QVnNgJ+MB1VD6uDVoNOWxFgin0uhJXCNeYUoTmVqPiU=; b=U1okLgqSZAiJ+q0wdVumFhtrm/UVk8pC+5lsK60YXgQwkSAwTYflbPGoZKcystetArLTGjwDVzWUrXug0kOpQmfrcGILOeHcvHqQd0Brw05duMY1o1KbXM4kQo++UXm9bl4XsSsD39MBa1l45uKuSoX9kPmOvQ91K8RYrJHMN2Ik+pYsNAhC9G0viCbTlwZIwW8Qf8S4K6ftsD+asgT526VQx8DgoLCDUTLydlWhicQCcaFWJL4VcejD9ACEzQs+6Y5wkZ18MWucpUu7l0kmVF7ULn8p1uaWOB1ZcEeFyIgDImcxS5dan7SrKy2r3zN+naBFffzR1WOchUynioCgwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QVnNgJ+MB1VD6uDVoNOWxFgin0uhJXCNeYUoTmVqPiU=; b=APDxEKIh/l8fWG3p84w9su4TNLbGjxe2+LuBD6TBwJ3JQYkppbMRdVVYERVdEgO3WVvt83oCSF8/Gca+nDLRl3ofrw/cCIkP/M+GDg9gs1Q4KqUmV1J70OUHUjMu/L/VPjQVTbqceph2fpATnFuRMbEFmZwiYNPHWT5OFnOul+w= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by CO1PR11MB5121.namprd11.prod.outlook.com (2603:10b6:303:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 21 Oct 2020 01:33:19 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea%8]) with mapi id 15.20.3477.028; Wed, 21 Oct 2020 01:33:19 +0000 From: "Gao, Zhichao" To: Rebecca Cran , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Thread-Topic: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Thread-Index: AQHWpvx8sbEhyCQkXECL35Fy19mG8qmhQJhg Date: Wed, 21 Oct 2020 01:33:19 +0000 Message-ID: References: <20201020161643.20293-1-rebecca@nuviainc.com> In-Reply-To: <20201020161643.20293-1-rebecca@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d594507-25c0-4164-60bd-08d875614a6d x-ms-traffictypediagnostic: CO1PR11MB5121: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:565; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lCEcPbZ8gEX2FLeiyovSYoGNqZxpth5s3L9q68gkmphImMvfK71NYmMZhZr855v82PrTKwlmUolLThy9pL882+/jg3SQ2foGkhK19NWyE+e2woTjsdGQJDJRMqDXxd4took1RwbL23iMdLXLWtKUYFwtPlHCLer1iNsinUElza2LPDZbSSQIhEVqK+8oGP+WmjzkOnImI/Vjt+GpIgGFq/X/1ZU7j3e1S7uPV/2XerUr8NA9Wne/kRDuFpejmHM30ZP9wqjHhgneu7iE7IdMQrjnx0a1FXU2Wb1fj+Ivp557pEn/dVinsw3IhH8H+zJHuMfzLrXA6IDjDAreQ83GWg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(66476007)(86362001)(52536014)(107886003)(7696005)(186003)(8936002)(4326008)(316002)(110136005)(8676002)(478600001)(33656002)(55016002)(53546011)(76116006)(66946007)(5660300002)(64756008)(71200400001)(83380400001)(9686003)(66556008)(26005)(6506007)(2906002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: WRB/jMm+odM5/gjK+K1HwqAs7wgkHadeI6Y0ENNXYSSJCYZglZVyPiNzyNSk4UP0UR/dJlREfY7EKJiUkTOvRYOcIoPuaAB3lsFtBIzhr12g5D9osaQt5QTbnrLzLxU/8oM3mw8aMnHoZybQaVmiQXlMiJ4MamEvDOr7sGRXZOSkEJHVqgm8YeL+dpkTFpQXiGzkxdQg5z0DihYfazTxlVeEMFb44HaEWdn2QLh2KoJiolawJpWMnwiVU4zK3UlcJDOkMZpoNLGsQCSYE7XDpWYdk+8RWd/wvAsfZ6z/aYIxSBP05d1DtslgCGsNu9u/CfTU930kDjAXK5d6e56BCCxzIJv1zivgomEfkF2VTawMCOA3m7hytm9DonoYMX3mpz0I1OaN9EqHK8NvYIBTWHuZ8mHenEgJR5TOK7hVh6BwDBK2cwAkZXtXE0KPgg4XCJQJZk/UmwN4/MalEMCj1SOPxAh+DI2ho7BGJSXnpTODq9Q6AF1EIZpPdsP2+eaVyXQOtehLiMCR92QcFFFCWOVRbkcyCqxoz8SwZhOKtuoROA/UNEDz1EzdMi0xsuj6HvXfAGK+nIFWlpVHMrRAu1We5jdOG2pbSzZL+L6MJNymAwGQw01HvytKAEgOG0nK3xU2mtBlcrNIGqQevDCxoQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d594507-25c0-4164-60bd-08d875614a6d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2020 01:33:19.1935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yZ9rj6fZ4b2QodK/8RQiLMP7K5nDGr0fP/VgPIZQWqCvmF0sLkoczGwh+68QQF9CGtJGQtAPQVYsVqJlgkIiLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5121 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, > -----Original Message----- > From: Rebecca Cran > Sent: Wednesday, October 21, 2020 12:17 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Ni, Ray ; Gao, > Zhichao > Subject: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview >=20 > Fix a couple of typos in SmbiosViewStrings.uni: > "Boot form CD" should be "Boot from CD", and "plugged from the wall" > should be "plugged into the wall". >=20 > Signed-off-by: Rebecca Cran > --- > .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > index 7fbcc9a31afb..4160ca40a988 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > @@ -128,7 +128,7 @@ > #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING #languag= e > en-US "BIOS shadowing is allowed\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED #languag= e > en-US "VL-VESA is supported\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #languag= e en- > US "ESCD support is available\r\n" > -#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED > #language en-US "Boot form CD is supported\r\n" > +#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED > #language en-US "Boot from CD is supported\r\n" The string ID is also incorrect. See 'FORM'. I think we should change it as= well. Thanks, Zhichao > #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED > #language en-US "Selectable Boot is supported\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED #languag= e > en-US "BIOS ROM is socketed\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD > #language en-US "Boot From PC Card(PCMCIA)is supported\r\n" > @@ -373,7 +373,7 @@ > #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE #languag= e en- > US " Not applicable\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3 #languag= e en-US > " Reserved \r\n" > #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED > #language en-US "Power supply is unplugged from the wall\r\n" > -#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED > #language en-US "Power supply is plugged from the wall\r\n" > +#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED > #language en-US "Power supply is plugged into the wall\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT > #language en-US "Power supply is present\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT > #language en-US "Power supply is not present\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE > #language en-US "Power supply is hot replaceable\r\n" > -- > 2.26.2