From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.6102.1616719838353092193 for ; Thu, 25 Mar 2021 17:50:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=hKFo74pl; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 8A/S7BM0srAxWrAbXJQPreI57l5UnpTWFcTu/PYV/YdBcXDJ11ZIkVgBc4va2KQsMf/iJ/5qwM c5vVw98C1Osw== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="252406917" X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="252406917" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 17:50:37 -0700 IronPort-SDR: E/lCZS5FVzFhcoMrCfKyh7wDh7VT/coe0buat2C7MCvy3g8GAN+SEM8UCyOgZPdi2NLCE8esCn MCBC1wRlbSlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="453298755" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 25 Mar 2021 17:50:36 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 17:50:36 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 17:50:36 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 17:49:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwJBXuAJgjcEbLqNUaDK0ypuzdGpiOhdzpV9FxnpFW6eglmPr+YFnlDUFQDz3iSxfQmqXI7ddqHmU64gZfxKQNyMzLZdRuib8O8XPcLIWCNeJ8H65V7WV3dWBoD1I5qJPJvHCS7Xkkcn63UmTtMq0JibKYyxQuWwhRfx7shnE4L2ZxsdVvzGavcUNupI1mHghmaJsjKq4AT74pJwWYbfD3RO/l93GV7VZMD0KyAw5+my1FzjJEUWOxPAn92hRaXOMPaehDTbKpDcF1gqEantS4VFyK/FV/70czx1bx9VD25BbdYHYxTD1YHOu9W8Ke2Exd4/UQ6nGuP1EORuU5jlpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H2F9pozyaUOrruj02vns47GWtnBeX0YzRhC6Z2Ekmrs=; b=Bkvkc+UG4WFJ16SzM3VC22yNp0R+KT0zBC4flG3t6KQUe8XXa/jvmkuem5quR7910wAZNa6nvmL4IfQ0fiOBPSG4tGi0I8RHmDO29p4Wm0vy4BClPPYmegbHRIs5FEN5ycSvzTVAdgAoCFXwEDn9aBPP4z/qjp6zbQ3ule5OLQbdO8NgNUVSe3q8kod6alLV6Us3A6fH3bqQwW08erqo8b9E2kdUKOLymxD0nRIPGVBBpsG8BuUoYdj96J0plM4TCflvSLjyMR4M6EoXMfbhrnAYJe0Wlelb+P2+5xnfLAvBMf+YJzB2X3OA+VtOMDDX2qezljXX6N+0T80cH8Kgzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H2F9pozyaUOrruj02vns47GWtnBeX0YzRhC6Z2Ekmrs=; b=hKFo74plMym+kj0VZ32WGkjZMTBbInJCuWEbA1PXSSen+qMNoPFRZzvJyFh/K9rCqhGC6GC1tiojxMaVkABuHL2MPnIQsM3NuHxsUVWPKNF2Utw6SQUGvXCTMlRsPC9l88EbzWaDltG1qwtxnepmBoOrFzW8dQmontTKzFhw9eo= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR1101MB2159.namprd11.prod.outlook.com (2603:10b6:301:53::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Fri, 26 Mar 2021 00:49:33 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c%11]) with mapi id 15.20.3977.025; Fri, 26 Mar 2021 00:49:33 +0000 From: "Gao, Zhichao" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Wang, Nickle (HPS SW)" , "O'Hanley, Peter (EXL)" , Liming Gao Subject: Re: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Topic: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Index: AQHXITnZv6DhdOSedEi8BecKFHm5DaqUX6vwgAAy1eCAAN5KUA== Date: Fri, 26 Mar 2021 00:49:33 +0000 Message-ID: References: <20210325045236.344-1-abner.chang@hpe.com> <20210325045236.344-3-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43ceec49-3d94-47b8-55b0-08d8eff10591 x-ms-traffictypediagnostic: MWHPR1101MB2159: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YXQX4n7jsbTdOiWp3wNhg/xMhmdL8P4Do9NqEvaV6zf8E/SwkL0sBs0HweBQmEnHvJMnUlO0w4kTnQGlXbFpOC5j76A0ODnN/fxhWqLH0y2aPU3uOXbzWk6g3LFDpZIdOam/NbxgTRFGxBqSw0qseyng05+QAmMolCWqc7PhG8kZCYzZI2+LxFsfTyK6D57PobfVFIHZCyZBhrc/LsMUDmSsvPV8Fml/1mz7Vk+z1lrg3PDdqyvTUy0FzEEvxds7u5x8suPZPJIeBvNsKkVKZ+a+VR2ZBCbPPuFAazCWImOhM+WOCCdKIv8Yx3vquM5j56UExffNOwe9R/uxfjg4NN/pWqixjMoP28BEk+13cS0d+Zns7oMXkjt4eghXPGKr3leDND5DMgUeRSB4jaCP/ud7f5NUd6zHQUalBtEVTMDIEUFZk1zg230aMKryCd0aGmMhReRo4Mhkm81pNCiyjkCyZaDKwYB9JCNgVd5fL33xS8wFUC+XvctLfB8kv30p/azCWCm63MXn1l7GIVmViAMt8kjsMIOF0acQRJ0XVntizqMNP644wQQkn2zeD1XxXIIcaPQpRfYetdMUNlZRd9cESYs4FIZV7fp/qUQ0O/W3+gbyk8zOg6JbtCLo02Tj9gjlVmewNYa3gLOj4kr+vZx98thbkBp8RPzFbP0gjJI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(366004)(346002)(136003)(39860400002)(54906003)(83380400001)(478600001)(186003)(4326008)(110136005)(86362001)(26005)(55016002)(316002)(296002)(9686003)(66476007)(66946007)(33656002)(6506007)(38100700001)(7696005)(5660300002)(52536014)(53546011)(8936002)(64756008)(71200400001)(66446008)(66556008)(8676002)(76116006)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?eMvfaVUpI4S+cLLnqjiSn+cFeG+c0GexHqNLZePZ6BQu7vr+QaSCV+aDan/s?= =?us-ascii?Q?+Fvxp7/3GaanK+YGrUGWzfR3XrDnDL/kL5E9f2HsyK6sSmRaK+Rd/x+aFStk?= =?us-ascii?Q?3BMwYDA5BFa92VFiH+tyNwNUF9orRNwUnUlsVyK9MofvBQus97pTIGPWdq6J?= =?us-ascii?Q?waLdcZ5ieCxdx+ECKxHIkVp10z9hGqrvvGbjHwLS3JBAtI0xmaLLr7BmnVQd?= =?us-ascii?Q?HEhkEwEjRFiMRbrnWkoouBsN7MkhB67ziftlbZ4G1NxTMagZRq99/6/gmrqo?= =?us-ascii?Q?6wxpJ+HeX16IKKZmv+djgVaf+cM5dMgC6Yw4Bzh3xf9c8SOUHzdmE0lGzOwi?= =?us-ascii?Q?crkkNnbEr90q+0Irwtzm6wu/TZB6uHQ949HHtS2nAC7rCWAyRatQi9vJj0Kn?= =?us-ascii?Q?c+ue5mSE+PseAeRkvGxR0+7uXrMkV9PaolOUxVjhjfCcqUEa7XH13QQQhDcj?= =?us-ascii?Q?0C0H1pxcS9DxzWWwbjnWg1RZ1ToUDon/4R5DTVytBy4XgAxPe3rByOPcCVCJ?= =?us-ascii?Q?QVuxFWbs6eh3a8Z05Ytxa63AGduLEDM/VAEKAEb0oq8sOSrF1lOmpP5FaUHO?= =?us-ascii?Q?4D5/+4ZwhoW0xARdhkcyUEiTaPS8jE9ZzOtH50fQogweCY81GVxEtZARbrmJ?= =?us-ascii?Q?/Rodaut4YQU7TMxmwjhRqLD0r9ebMbXyTuf/LXkHyykU92prPjttzY9gnZbO?= =?us-ascii?Q?BZoV9hHZcsBMT0xX2HMoWOAORmg2uwA3HKfEYB/bnhcrv1eNYSatGsko7hFO?= =?us-ascii?Q?Y7S7QHPf6sMzZ+Z4lrywpj656mn8peSG0iZSRJs2YZfUZLHs8fAHGYwc3yjj?= =?us-ascii?Q?zFfjwr/9Amc9AsuMj9emTSLbYFzF1HJ9wSrK3DQkaxKnen47dYUtGfBYx5cC?= =?us-ascii?Q?tuEITJqQyfbriBqDYbOX6LMJenbKGlCIVJ2TpoGmANxXd1H75D6soz+mZPxG?= =?us-ascii?Q?3Lb2pXYGRvTK2b7mSe6TsXBeBoItSVrvdNw1thLodhZlutxL/Pj38uxWE8PV?= =?us-ascii?Q?hfIVydLUndns7PlzN6Dm61CaIZv1NzW8dD6UGwuXQzwb/jAsPGg/zI7rG80+?= =?us-ascii?Q?Y8lZefV0unQPkM373CDsCHd55NQK8YyN97av+mOvV1H206Qek2lNWOBuufPM?= =?us-ascii?Q?hls64mbDNuQw1VO8Zh+lfBrIVxQo4xyaEIwcwvoZmXwjGNPK7uuFatI4Mopk?= =?us-ascii?Q?ZivHcJ1pQ8Ppi5beCZZ/NTvfeVYe5zdMaYGYyRVvnhR27DRNpl1d6ogcdYXl?= =?us-ascii?Q?QmpaU6NreVAeBzPt+3duBypn8wHWcGkdUfyRBhfQRIee+bI9Uvv55RBUYW1+?= =?us-ascii?Q?LE++lG7wfLRHkgzrKhXAJ9vA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43ceec49-3d94-47b8-55b0-08d8eff10591 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 00:49:33.1353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fgvkIcI6LmNCdaG6DxrV7TFjk6l8ELyfcViQLG5TWckGwQavFJko+bKq4s/v+FZaCXEIv9lnKrK1js1ZMIkCfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2159 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable You can push with the correction and add my R-B. No need to send V5 if ther= e is no more comment for your patch set. Thanks, Zhichao > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, March 25, 2021 7:36 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) ; > Liming Gao > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > Redfish protocols >=20 > Hi Zhichao, > I resend v4 patch, in which your R-B to the previous patch is removed and > Liming is added to CC list. No others changes were made in this patches. > I will send v5 with the correction on copyright. Or can I just push to ma= ster > with the correction and your R-B? >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: Gao, Zhichao [mailto:zhichao.gao@intel.com] > > Sent: Thursday, March 25, 2021 5:09 PM > > To: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io > > Cc: Ni, Ray ; Wang, Nickle (HPS SW) > > ; O'Hanley, Peter (EXL) > ; > > Liming Gao > > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > Redfish protocols > > > > First, thanks Liming's catch. > > > > Abner, > > > > The patch has been updated, you should remove my R-B for the V4 version= . > > Otherwise the reviewers/maintainers may treated it as reviewed one. > > And please add the one who already gave the comment for your patch to > > the Cc list. They care about the about the change and this would help > > them to know the update and have a chance to view your patch in an earl= y > time. > > > > For this patch, the copyright should be updated to 2021. With this > > updated, > > Reviewed-by: Zhichao Gao > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Abner Chang > > > Sent: Thursday, March 25, 2021 12:53 PM > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray ; Gao, Zhichao > > > ; Nickle Wang ; Peter > > > O'Hanley > > > Subject: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > Redfish > > > protocols > > > > > > Add handle parsing for EFI Redfish Discover protocol. > > > Add handle parsing for EFI RestEx protocol. > > > > > > Signed-off-by: Abner Chang > > > Cc: Ray Ni > > > Cc: Zhichao Gao > > > Cc: Nickle Wang > > > Cc: Peter O'Hanley > > > Reviewed-by: Zhichao Gao > > > --- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 ++++++= +- > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- > > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > index 93b69cd8e9..446cd8d609 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > @@ -2,7 +2,7 @@ > > > # Provides interface to advanced shell functionality for parsing > > > both > > handle > > > and protocol database. > > > # Copyright (c) 2010 - 2018, Intel Corporation. All rights > > > reserved.
# > > (C) > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
- > # > > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> > > +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > +LP
> > > # > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 +269,8 > @@ > > > gEfiHttpProtocolGuid ## UNDEFIN= ED > > > gEfiHttpUtilitiesProtocolGuid ## UNDEFIN= ED > > > gEfiRestProtocolGuid ## UNDEFIN= ED > > > + gEfiRestExProtocolGuid ## UNDEFIN= ED > > > + gEfiRedfishDiscoverProtocolGuid ## UNDEFIN= ED > > > gEfiMmEndOfDxeProtocolGuid ## UNDEFIN= ED > > > gEfiMmIoTrapDispatchProtocolGuid ## UNDEFIN= ED > > > gEfiMmPowerButtonDispatchProtocolGuid ## UNDEFIN= ED > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > index 500a95a89a..e34cefd7b4 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > @@ -3,7 +3,7 @@ > > > > > > Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.=
> > > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > > L.P.
> > > - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > LP
> > > + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > LP
> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -2250,6 +2250,12 @@ STATIC CONST GUID_INFO_BLOCK > > > mGuidStringList[] =3D { > > > {STRING_TOKEN(STR_PARTITION_INFO), > > > &gEfiPartitionInfoProtocolGuid, > > > PartitionInfoProtocolDumpInformation}, > > > {STRING_TOKEN(STR_HII_POPUP), &gEfiHiiPopupProtocolGui= d, > > > NULL}, > > > > > > +// > > > +// UEFI 2.8 > > > +// > > > + {STRING_TOKEN(STR_REST_EX), &gEfiRestExProtocolGuid, > > > NULL}, > > > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > > > &gEfiRedfishDiscoverProtocolGuid, NULL}, > > > + > > > // > > > // PI Spec ones > > > // > > > diff --git > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > index 9c8028d0d5..69fcbdfe0e 100644 > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > @@ -2,7 +2,7 @@ > > > // > > > // Copyright (c) 2010 - 2017, Intel Corporation. All rights > > > reserved.
// > > (C) > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> > > -// > > > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > > LP
> > > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > +LP
> > > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > > @@ -308,6 +308,8 @@ > > > #string STR_NET_HTTP #language en-US "Http" > > > #string STR_NET_HTTP_U #language en-US "HttpUtilities" > > > #string STR_REST #language en-US "Rest" > > > +#string STR_REST_EX #language en-US "RestEx" > > > +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" > > > > > > #string STR_MM_EOD #language en-US "MmEndOfDxe" > > > #string STR_MM_ITD #language en-US "MmIoTrapDispatch" > > > -- > > > 2.17.1 >=20