From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Rebecca Cran <rebecca@nuviainc.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
Date: Thu, 22 Oct 2020 02:57:48 +0000 [thread overview]
Message-ID: <MWHPR11MB164745364A49CA410D1D5435F61D0@MWHPR11MB1647.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b5aa06f0-a773-2b96-b1f1-8efa8e713ead@nuviainc.com>
Agree. Hope it can be fixed in the future.
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 21, 2020 12:07 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in
> smbiosview
>
> On 10/20/20 7:33 PM, Gao, Zhichao wrote:
>
> > The string ID is also incorrect. See 'FORM'. I think we should change it as well.
>
> I noticed that, but wasn't sure if I should fix it. I think I should fix it in a separate
> patch - do you agree?
>
>
> --
>
> Rebecca Cran
next prev parent reply other threads:[~2020-10-22 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-20 17:27 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-10-21 1:33 ` Gao, Zhichao
2020-10-21 4:07 ` [EXTERNAL] " Rebecca Cran
2020-10-22 2:57 ` Gao, Zhichao [this message]
2020-10-21 20:51 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB164745364A49CA410D1D5435F61D0@MWHPR11MB1647.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox