* [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
@ 2020-10-20 16:16 Rebecca Cran
2020-10-20 17:27 ` [edk2-devel] " Samer El-Haj-Mahmoud
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rebecca Cran @ 2020-10-20 16:16 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, ray.ni, zhichao.gao
Fix a couple of typos in SmbiosViewStrings.uni:
"Boot form CD" should be "Boot from CD", and "plugged from the wall"
should be "plugged into the wall".
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
.../SmbiosView/SmbiosViewStrings.uni | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 7fbcc9a31afb..4160ca40a988 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -128,7 +128,7 @@
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING #language en-US "BIOS shadowing is allowed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED #language en-US "VL-VESA is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #language en-US "ESCD support is available\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED #language en-US "Boot form CD is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED #language en-US "Boot from CD is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED #language en-US "Selectable Boot is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED #language en-US "BIOS ROM is socketed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
@@ -373,7 +373,7 @@
#string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE #language en-US " Not applicable\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3 #language en-US " Reserved \r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED #language en-US "Power supply is unplugged from the wall\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED #language en-US "Power supply is plugged from the wall\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED #language en-US "Power supply is plugged into the wall\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT #language en-US "Power supply is present\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT #language en-US "Power supply is not present\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE #language en-US "Power supply is hot replaceable\r\n"
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
@ 2020-10-20 17:27 ` Samer El-Haj-Mahmoud
2020-10-21 1:33 ` Gao, Zhichao
2020-10-21 20:51 ` Rebecca Cran
2 siblings, 0 replies; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-10-20 17:27 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@nuviainc.com
Cc: ray.ni@intel.com, zhichao.gao@intel.com, Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Tuesday, October 20, 2020 12:17 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; ray.ni@intel.com;
> zhichao.gao@intel.com
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Fix a couple of typos in
> smbiosview
>
> Fix a couple of typos in SmbiosViewStrings.uni:
> "Boot form CD" should be "Boot from CD", and "plugged from the wall"
> should be "plugged into the wall".
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> index 7fbcc9a31afb..4160ca40a988 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> @@ -128,7 +128,7 @@
> #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING
> #language en-US "BIOS shadowing is allowed\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED
> #language en-US "VL-VESA is supported\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #language
> en-US "ESCD support is available\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot form CD is supported\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot from CD is supported\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED
> #language en-US "Selectable Boot is supported\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED
> #language en-US "BIOS ROM is socketed\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD
> #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
> @@ -373,7 +373,7 @@
> #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE #language
> en-US " Not applicable\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3 #language
> en-US " Reserved \r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED
> #language en-US "Power supply is unplugged from the wall\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged from the wall\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged into the wall\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT
> #language en-US "Power supply is present\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT
> #language en-US "Power supply is not present\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE
> #language en-US "Power supply is hot replaceable\r\n"
> --
> 2.26.2
>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-20 17:27 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2020-10-21 1:33 ` Gao, Zhichao
2020-10-21 4:07 ` [EXTERNAL] " Rebecca Cran
2020-10-21 20:51 ` Rebecca Cran
2 siblings, 1 reply; 6+ messages in thread
From: Gao, Zhichao @ 2020-10-21 1:33 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io; +Cc: Ni, Ray
Hi Rebecca,
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 21, 2020 12:17 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
>
> Fix a couple of typos in SmbiosViewStrings.uni:
> "Boot form CD" should be "Boot from CD", and "plugged from the wall"
> should be "plugged into the wall".
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> index 7fbcc9a31afb..4160ca40a988 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> @@ -128,7 +128,7 @@
> #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING #language
> en-US "BIOS shadowing is allowed\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED #language
> en-US "VL-VESA is supported\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #language en-
> US "ESCD support is available\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot form CD is supported\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot from CD is supported\r\n"
The string ID is also incorrect. See 'FORM'. I think we should change it as well.
Thanks,
Zhichao
> #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED
> #language en-US "Selectable Boot is supported\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED #language
> en-US "BIOS ROM is socketed\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD
> #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
> @@ -373,7 +373,7 @@
> #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE #language en-
> US " Not applicable\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3 #language en-US
> " Reserved \r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED
> #language en-US "Power supply is unplugged from the wall\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged from the wall\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged into the wall\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT
> #language en-US "Power supply is present\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT
> #language en-US "Power supply is not present\r\n"
> #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE
> #language en-US "Power supply is hot replaceable\r\n"
> --
> 2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
2020-10-21 1:33 ` Gao, Zhichao
@ 2020-10-21 4:07 ` Rebecca Cran
2020-10-22 2:57 ` Gao, Zhichao
0 siblings, 1 reply; 6+ messages in thread
From: Rebecca Cran @ 2020-10-21 4:07 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ni, Ray
On 10/20/20 7:33 PM, Gao, Zhichao wrote:
> The string ID is also incorrect. See 'FORM'. I think we should change it as well.
I noticed that, but wasn't sure if I should fix it. I think I should fix
it in a separate patch - do you agree?
--
Rebecca Cran
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
2020-10-21 4:07 ` [EXTERNAL] " Rebecca Cran
@ 2020-10-22 2:57 ` Gao, Zhichao
0 siblings, 0 replies; 6+ messages in thread
From: Gao, Zhichao @ 2020-10-22 2:57 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io; +Cc: Ni, Ray
Agree. Hope it can be fixed in the future.
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 21, 2020 12:07 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in
> smbiosview
>
> On 10/20/20 7:33 PM, Gao, Zhichao wrote:
>
> > The string ID is also incorrect. See 'FORM'. I think we should change it as well.
>
> I noticed that, but wasn't sure if I should fix it. I think I should fix it in a separate
> patch - do you agree?
>
>
> --
>
> Rebecca Cran
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-20 17:27 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-10-21 1:33 ` Gao, Zhichao
@ 2020-10-21 20:51 ` Rebecca Cran
2 siblings, 0 replies; 6+ messages in thread
From: Rebecca Cran @ 2020-10-21 20:51 UTC (permalink / raw)
To: devel; +Cc: ray.ni, zhichao.gao
On 10/20/20 10:16 AM, Rebecca Cran wrote:
> Fix a couple of typos in SmbiosViewStrings.uni:
> "Boot form CD" should be "Boot from CD", and "plugged from the wall"
> should be "plugged into the wall".
I've superseded this patch with the series "[PATCH 0/6] smbiosview and
SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition".
--
Rebecca Cran
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-22 2:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-20 17:27 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-10-21 1:33 ` Gao, Zhichao
2020-10-21 4:07 ` [EXTERNAL] " Rebecca Cran
2020-10-22 2:57 ` Gao, Zhichao
2020-10-21 20:51 ` Rebecca Cran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox