From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
Rebecca Cran <rebecca@nuviainc.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Sami Mujawar" <Sami.Mujawar@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@arm.com>,
Rebecca Cran <rebecca@bsdio.com>,
Peter Grehan <grehan@freebsd.org>,
David Woodhouse <dwmw2@infradead.org>,
Abner Chang <abner.chang@hpe.com>,
Nickle Wang <nickle.wang@hpe.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH 1/1] Rename SmBios.h to Smbios.h in MdePkg/Include
Date: Wed, 13 Jan 2021 05:34:49 +0000 [thread overview]
Message-ID: <MWHPR11MB16474D7D620C76DEDB0E8544F6A90@MWHPR11MB1647.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9389c9ce-f3c8-8c56-7bc3-7274f9e51a2a@redhat.com>
This is a incompatible change and it requires the platforms to change related usage as well.
Thanks,
Zhichao
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Monday, January 11, 2021 3:42 PM
> To: Rebecca Cran <rebecca@nuviainc.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Sami
> Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov
> <Alexei.Fedorov@arm.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Rebecca
> Cran <rebecca@bsdio.com>; Peter Grehan <grehan@freebsd.org>; David
> Woodhouse <dwmw2@infradead.org>; Abner Chang <abner.chang@hpe.com>;
> Nickle Wang <nickle.wang@hpe.com>; Ma, Maurice <maurice.ma@intel.com>;
> Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: Re: [PATCH 1/1] Rename SmBios.h to Smbios.h in MdePkg/Include
>
> On 01/11/21 04:19, Rebecca Cran wrote:
> > Rename SmBios.h to Smbios.h in MdePkg/Include/IndustryStandard and
> > MdePkg/Include/Guid, and update references in all other places through
> > the edk2 tree.
> >
> > Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> > ---
> > MdePkg/MdePkg.dec | 4 ++--
> > DynamicTablesPkg/Include/SmbiosTableGenerator.h | 2
> +-
> > EmulatorPkg/CpuRuntimeDxe/CpuDriver.h | 2 +-
> > EmulatorPkg/Include/Library/SmbiosLib.h | 2 +-
> > MdeModulePkg/Application/UiApp/Ui.h | 2 +-
> > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h |
> 4 ++--
> > MdePkg/Include/Guid/{SmBios.h => Smbios.h} | 0
> > MdePkg/Include/IndustryStandard/{SmBios.h => Smbios.h}
> | 0
> > MdePkg/Include/Protocol/Smbios.h | 2 +-
> > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.h | 4 ++--
> > OvmfPkg/Bhyve/SmbiosPlatformDxe/SmbiosPlatformDxe.h
> | 2 +-
> > OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h |
> 4 ++--
> > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> | 4 ++--
> > OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.h
> | 4 ++--
> > OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
> | 4 ++--
> > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h |
> 2 +-
> > RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h
> | 2 +-
> > RedfishPkg/Include/Library/RedfishHostInterfaceLib.h | 2
> +-
> >
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/LibSmbiosView.h
> | 2 +-
> > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
> | 2 +-
> > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.h
> | 2 +-
> > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | 2 +-
> >
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/Smbi
> osTableFactory.c | 2 +-
> > EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> | 2 +-
> > EmulatorPkg/PlatformSmbiosDxe/SmbiosTable.c | 2
> +-
> >
> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
> | 4 ++--
> > NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 4 ++-
> -
> > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 2 +-
> > OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c
> | 2 +-
> > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> | 2 +-
> >
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/LibSmbiosView.c
> | 2 +-
> > 31 files changed, 38 insertions(+), 38 deletions(-)
>
> For the OvmfPkg hunks:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
prev parent reply other threads:[~2021-01-13 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 3:19 [PATCH 0/1] Various packages: rename SmBios.h to Smbios.h in MdePkg and update references through edk2 tree Rebecca Cran
2021-01-11 3:19 ` [PATCH 1/1] Rename SmBios.h to Smbios.h in MdePkg/Include Rebecca Cran
2021-01-11 7:41 ` Laszlo Ersek
2021-01-13 5:34 ` Gao, Zhichao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB16474D7D620C76DEDB0E8544F6A90@MWHPR11MB1647.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox