From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.2659.1605265352003922585 for ; Fri, 13 Nov 2020 03:02:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SKsI4XVN; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) IronPort-SDR: MpI6Qh62rNMzk04YPicdsDHuHrmGaB4Uuuh24wsEQ7fLAhcjbuPBPEIxFVrDJ0n6bJHQToz5SF 6CjERxEpvSWg== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="234615640" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="234615640" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 03:02:30 -0800 IronPort-SDR: HJIG0co01SFfb7WsHoEMszURu7FmygeINMaE0PI+4dSnuqx1YXMsrRj1CZoADQ7A666jsQ3jga s4bq2b2IqFLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="328841443" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 13 Nov 2020 03:02:30 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Nov 2020 03:02:29 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Nov 2020 03:02:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Nov 2020 03:02:29 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 13 Nov 2020 03:02:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oeMYfwGNusLtzDa4rx5dtS1gWfcSpmgJxo4tCnKD5ewoAXkGM7/2r2YpHvoItzxO3CAW+8dv7CL51Svoel5udfv0yQzc/9EqaqlVDW8BgKiF8MGf8PE0gFeqgCpw9E7tnnezITZm8KNEUcNJCOLhYcXRH/fwr3IM5/HuDQgkvaNi8wxqVPhESwqTQCdyDiIggo8hbCeLA6oWZZ9AX+37IOTtIkVQl6VNC6peT4rQZGTF7dUGclj6xrGUiKSWgK2lVXhdkn0QMniviQYblT5/hNrZwRj+3yx3k1oqb+RBkCUm5GR2jK6pODdjBzWYt7+TgYA0sOF3bAci+JBsMGaBVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQkVCj2BLJDPusLCw7iGbf/fZWNx5+h4RqQdeCUyUeY=; b=TB+Z3Kjxr9HAKsB6H0vDTbkzgSfa+4Ksc5TU7CReWzYqVNJsYXJW3oeNWGyjU0/Iwxv3Tdr1ISeYOQv1IRUXw3DQ3+j6of9paYr4MYKEGdrSD/9PZ9tnTJVtEcpU0hLlpYvo2XEWF2P8rSuOlJTdgepJJijj81Imn6Jt2AIhPoOf0JsnLpAx0H0u+1T46F74Tk0BGNZ88bj6sh8zU7i+jpt9JpnCMz3JbZlsFs4IttpssdNSZBcGi115vsHKyOlPJcNP29altOEW/gEKS1IssnNCIZ7R0IL+jBI9jZ3Apn152ZUxXS0b9hIptSXUaCIqqOyHMauCBwBDN/tzXD6Zxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQkVCj2BLJDPusLCw7iGbf/fZWNx5+h4RqQdeCUyUeY=; b=SKsI4XVNw79qLn4RbqnE6UeREgdMk74SirdJbwCQJabKIHqp+4aVD5HPalq+9fvQUJAjbERjGm731U8etOPCs81zEoz+nskgef3X7RU9I+PXTbZdczxMssd87H57V8xVH6oom0BMI/6x5JPwoXplo5O8x4SzmjoSPR1ZJ3IpIGI= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by CO1PR11MB5025.namprd11.prod.outlook.com (2603:10b6:303:9e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 13 Nov 2020 11:02:28 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::419:ff51:cce7:b9d8]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::419:ff51:cce7:b9d8%11]) with mapi id 15.20.3541.026; Fri, 13 Nov 2020 11:02:28 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH V4 04/13] NetworkPkg: Enable MD5 while enable iSCSI Thread-Topic: [edk2-devel] [PATCH V4 04/13] NetworkPkg: Enable MD5 while enable iSCSI Thread-Index: AQHWuLiVfkug7GBcx0uRnUO5OkCva6nF5pXA Date: Fri, 13 Nov 2020 11:02:28 +0000 Message-ID: References: <20201112055558.2348-1-zhichao.gao@intel.com> <1646AD0BC52F0534.414@groups.io> In-Reply-To: <1646AD0BC52F0534.414@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98cc54b9-4808-44de-1f42-08d887c39c6a x-ms-traffictypediagnostic: CO1PR11MB5025: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OU8uaMdwVqE7o6dW5PWikqL06clZXCEHALd+Wexs2uUTDhpdwZRS0byfQDBwfttzxQzoCFwgk2WL1SEZj6FFx3mBSv6MwioiYZU++CuG3cHIwMDHs4kPlN5jnSBMfyIZuFLLmevoXWACk0FfYb5c4XDv4kaLpAC77zalU4lHHa9xl7PJoohagF0VdBXS1tDCMfiv/8j3f8QfJ5KMY4ORfeYIZgBZkBgwac86y3/Mf1Z7mvWHNOSnFaapYaST5Fiz5eFDvcgi7X1ozLcUSWFUSUJ/eUP1A68sPDkSdJHT+X+B2Ptyvz+0Ensr7gnLMgBv+YNDHQ1CSoBkLFkd9E3luLOtuqxz4gGAOYj1WvulKc7fb08fGsfSXxjSakQqJ3CTA0zG2PS1kAj/KtNPyIuSHQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(7696005)(66446008)(52536014)(53546011)(4326008)(110136005)(478600001)(54906003)(66946007)(64756008)(66556008)(186003)(2906002)(66476007)(6506007)(76116006)(26005)(33656002)(55016002)(316002)(83380400001)(8936002)(5660300002)(86362001)(966005)(71200400001)(8676002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: w/HijXZntoJKQXTXXNA3BNS36QdvciNJdIoL7JoF8UjmBvJ2P/oHoI8whj+7Neey7mdmxUkOq+MQ+3MG/rggXSogoapIT4JWyfdrQLijPQ14yg8onbvQwaOOENKmCM1BceBnO+UnVC/9j+2xJj3ajHxiOKYlWYEX3/0B3xd1EzbcjufAWavW2LjE7GHDt3VtGmcVwJjPCaDJRBqWa4ax3o+L1gghhoJDAQXeuCXFCLO57n5eQ2nMRRmj/iavZYNLErSz+zerJjDCP73YX0cJATolJO+gNK81W3qO4n5aiqEawpEWP0wy/B4cD78xtp548xB3BpQKq+AhYfTuL23vUa8MkiTx7qsYjxjnuATrpYIQnLxAolHl0h5H3FOaD7JNVZ0mJgrFGACnaGaD65NKOIUsiGe+hiYJMd2DM29oCg9gUQMaqa7oo2VBeRWSl59lfDX1N+SD6OL5CQO28YRdVZrshV/sNoECOCqJLiEgrF5p7CGfHb4plW9F/VVfehiDePn48Ba6yY5QpBe93rCdQcIN9CcdATb9kVMmms9VsmH4TQFBUMmZn8LxOKVRx8/oQn9l0jd/Uyur6E3vii/tN77kkHi/NZkdBy4RNOj0NfMvX061yLZ24UmwKOt2O9wSUSY8ENrGp/FSbVhfJ/ZWvQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98cc54b9-4808-44de-1f42-08d887c39c6a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 11:02:28.4138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IhsE+fKs4L0EUbEI1zQWLFo6aH1f5a2HIln8GNOuyvDonNXTRxQNNO3v/3ejQJDL5tEx4ocenASjDEtJJ9/A0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5025 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I just notice many platforms (such as the platform dsc file in edk2Platform= s) are using the inc file incorrectly. I would adjust the [BuildOptions] se= ction above [Components] section to unblock their build. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Thursday, November 12, 2020 1:56 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: [edk2-devel] [PATCH V4 04/13] NetworkPkg: Enable MD5 while enab= le > iSCSI >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 >=20 > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced > to enable MD5. Make the definition ahead of the change to avoid build er= ror > after the MACRO changed. > 1. Add the NetworkBuildOptions.dsc.inc to define the MACRO for build (su= pport: > GCC, INTEL, MSFT and > RVCT) > 2. Add the BuildOption file to Network.dsc.inc >=20 > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Zhichao Gao > --- > NetworkPkg/Network.dsc.inc | 5 ++++- > NetworkPkg/NetworkBuildOptions.dsc.inc | 22 ++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 > NetworkPkg/NetworkBuildOptions.dsc.inc >=20 > diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc ind= ex > 16f090a187..6cd0c005fc 100644 > --- a/NetworkPkg/Network.dsc.inc > +++ b/NetworkPkg/Network.dsc.inc > @@ -7,7 +7,7 @@ > # This file defines one build flag PLATFORMX64_ENABLE to support # IA3= 2 PEI > and X64 DXE platform. Its default value is FALSE. > # > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020, Intel Corporation. All rights > +reserved.
> # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
# > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -39,3 +39,6 @@ > !include NetworkPkg/NetworkComponents.dsc.inc >=20 > !endif > + > +[BuildOptions] > +!include NetworkPkg/NetworkBuildOptions.dsc.inc > diff --git a/NetworkPkg/NetworkBuildOptions.dsc.inc > b/NetworkPkg/NetworkBuildOptions.dsc.inc > new file mode 100644 > index 0000000000..ce3460d472 > --- /dev/null > +++ b/NetworkPkg/NetworkBuildOptions.dsc.inc > @@ -0,0 +1,22 @@ > +## @file > +# Network DSC include file for [BuildOptions] sections of all Architect= ures. > +# > +# This file can be included in the [BuildOptions*] section(s) of a > +platform # DSC file # by using "!include > +NetworkPkg/NetworkBuildOptions.dsc.inc", to specify the C language # > +feature test macros (eg., API deprecation macros) according to the flag= s > described # in "NetworkDefines.dsc.inc". > +# > +# Supported tool chain: "GCC:", "INTEL:", "MSFT:", "RVCT". > +# > +# Copyright (c) 2020, Intel Corporation. All rights reserved.
# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE > + MSFT:*_*_*_CC_FLAGS =3D /D ENABLE_MD5_DEPRECATED_INTERFACES > + INTEL:*_*_*_CC_FLAGS =3D /D ENABLE_MD5_DEPRECATED_INTERFACES > + GCC:*_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES > + RVCT:*_*_*_CC_FLAGS =3D -DENABLE_MD5_DEPRECATED_INTERFACES > +!endif > -- > 2.21.0.windows.1 >=20 >=20 >=20 >=20 >=20