Re: [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings.

["Gao, Zhichao" <zhichao.gao@intel.com>]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Tuesday, December 29, 2020 7:17 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview
> strings.
> 
> Neither of the "CPU Socket Unpopulated" or "Do not reboot" messages should
> contain the word "Bits".
> 
> Remove them and update the identifier for the "Do not reboot" message to
> remove the word "BITS".
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c           | 2
> +-
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.
> uni | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index be8ae13c17d1..a3dc7b68c4d3 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -3025,7 +3025,7 @@ DisplaySystemResetCapabilities (
>      break;
> 
>    case 3:
> -    ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN
> (STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT_BITS),
> gShellDebug1HiiHandle);
> +    ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN
> + (STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT), gShellDebug1HiiHandle);
>      break;
>    }
>    //
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> index b14d1cb6dac8..8bcba7ccf768 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString
> s.uni
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewS
> +++ trings.uni
> @@ -269,7 +269,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_BIT15_NOT_ZERO                 #language
> en-US "Error, reserved BIT 15 must be zero\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_PROC_STATUS                    #language en-
> US "Processor Status:\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_POPULATED
> #language en-US "CPU Socket Populated\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED
> #language en-US "CPU Socket Unpopulated Bits\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED
> #language en-US "CPU Socket Unpopulated\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_CPU_ENABLED                    #language en-
> US "CPU Enabled\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_CPU_DISABLED_BY_USER
> #language en-US "CPU Disabled by User via BIOS Setup\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_CPU_DIABLED_BY_BIOS            #language
> en-US "CPU Disabled By BIOS (POST Error)\r\n"
> @@ -333,7 +333,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION_LIMIT              #language
> en-US "Boot Option on Limit: "
>  #string STR_SMBIOSVIEW_PRINTINFO_OP_SYSTEM_2                    #language en-
> US "Operating system\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_SYSTEM_UTIL                    #language en-US
> "System utilities\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT_BITS
> #language en-US "Do not reboot Bits\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT                  #language
> en-US "Do not reboot\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION                    #language en-
> US "Boot Option :"
>  #string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT                  #language
> en-US "Do not reboot\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_HARDWARE_SECURITY_SET
> #language en-US "Hardware Security Settings: \r\n"
> --
> 2.26.2