From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.15139.1609374190160915660 for ; Wed, 30 Dec 2020 16:23:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kpO4/zcU; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) IronPort-SDR: R2XDDrd//8PvpbXjnYG3oLX7PtFq2s+5B8ax/nGx2Mur6o9w25SDW6FvcUnhDchgp0ohzayBey LIJppJXqqOxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9850"; a="155852874" X-IronPort-AV: E=Sophos;i="5.78,462,1599548400"; d="scan'208";a="155852874" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2020 16:23:09 -0800 IronPort-SDR: 0o1e2y0LNAskk+94lVnKohDHWa1CKfaKY0pJd+b4fcmXODSE47UwzGJ68PuDre1WAnRUc1Uctd Xeyx40dU+lCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,462,1599548400"; d="scan'208";a="396026117" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 30 Dec 2020 16:23:09 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 30 Dec 2020 16:23:08 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 30 Dec 2020 16:23:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 30 Dec 2020 16:23:08 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 30 Dec 2020 16:23:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/++KJ/ESafNs3Gs+B6PajU7BtnwM0zrOqsY9jC3BsoQqKplPiRVtEOOHpM8pRVDFfHEjRe1V4pcyyDkAz2/BHOvvcbpa8CJMhge4A6tC6+8mM+m9GRCmBMdmRi9wQlFp4P9fmG0jKfGRWDK4/Kh8ECaUXaW3QErALJ8hwBx4354CQD2875/nrVk90PEKO0820rOumwqoOkb4ua1J7Q3Mt9y3aPeWTxRAPGi1RCu/nN5fksMZH0niUniHMngiWGoY77cEMfg+4brpB93OzEj8RU44Xyb1lgB0PnlibCl1x5mqj4Ga0KuUa6BtwSYI1Vl9QrgZkUfap3zxdpz4HPhzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oLSVU4bYyRLAR6Iz10xJSlVsywlOO9wnL+SYEZO7YQ=; b=Alfi/jkEE8l+bQ3kuHQiKbKfeuPp25FsIm3RJf36woSPzM5Dbxo6zEknEhea1wZR/l9hA1AhvNQxQcbrKf7wFpCl1cqr83y6BGxbEyQI6Sx8ur7oq3AiYt47GmHTYWvJjfshBVENvB4Nb9SI8AZ1I0j0oGS1dudh8rePMmilEYzwFnS6A1RZtXtt4bBLqaLSw96/vk/njElduQwvIhK4/tHvI+FTPrGzMSiD2RsPvPhfH+i3AvF0kUK/iZZRHP7WyVHEXHaPIcJCDJ/LCZXr210yCO84fwY+Bt87bABoyVkv1UsSJRwH9gUQuH69f0ghg+yLxxjfqLzMRjFl1iHbLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oLSVU4bYyRLAR6Iz10xJSlVsywlOO9wnL+SYEZO7YQ=; b=kpO4/zcU0SybB6mtNRolSVF0FrmSU8hLgTdUJef6CaoT8XZz6ny0IUEbud27V88pEH1G0aHnd21X8cFEKBlcyTdXEwQZZ0L5c0oVAywVfuVbF1dVpZF1m1UkVUVgxZYH7QdIF9QtPEj/2TE8EU/LVaE5rhi5rJCUVtwAmneUvKA= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR11MB0013.namprd11.prod.outlook.com (2603:10b6:301:67::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19; Thu, 31 Dec 2020 00:23:07 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77%8]) with mapi id 15.20.3700.031; Thu, 31 Dec 2020 00:23:06 +0000 From: "Gao, Zhichao" To: Rebecca Cran , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings. Thread-Topic: [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings. Thread-Index: AQHW3W+OOtFzjQyLFkGsTpRFlXx2laoPVeLg Date: Thu, 31 Dec 2020 00:23:06 +0000 Message-ID: References: <20201228231637.17266-1-rebecca@nuviainc.com> <20201228231637.17266-2-rebecca@nuviainc.com> In-Reply-To: <20201228231637.17266-2-rebecca@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [112.64.62.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6976659d-3613-4016-309e-08d8ad223eb6 x-ms-traffictypediagnostic: MWHPR11MB0013: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:459; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RaAvCMCtcKBkDS9GMGxHRaOcvrQzxDJfZ9uPFTBKLQBVt59OU/7I25KtOhE/eO/b4VqTKtpfQWu6TfgWvGAWFdQyX3mEvrOUh1el3Am8JmXfLtxBpBHF0Fcqm7fib4sTAJKwwu0KyICtynbZJ3EOcFygS5vb6Va0D+bqPj7SEU4PYCM9oiBwyvsc9as0ULwAF6biNjC0mYtP52CqYs72KGyMtPXNVVDFsuuTtpHO1nS9K+LoIaEF1z2iGIhTlcVhsmnw0HYrU1w9OIA33p+rICCRmjd3IKGMwxk5IUqmubLMiJMrd3egSuckLpiVNXaL8Wc1FWKi3nItzK7fYbGZdlm7bdwqRMdW0roN6RpOqQVvfR70giPP18WSlOoTN761gUAttzJYyCiFoJfnqVHJIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(66946007)(76116006)(316002)(186003)(71200400001)(66446008)(66476007)(64756008)(66556008)(26005)(53546011)(6506007)(2906002)(8676002)(83380400001)(86362001)(110136005)(52536014)(478600001)(55016002)(9686003)(107886003)(7696005)(4326008)(8936002)(5660300002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tfNG8CKKk9GCjZMFBTiPgK58PkBFJvNVysLxX9RW4LOsl+HUGncb5/OFQ7r6?= =?us-ascii?Q?y7CTwLdsmV0nXTzaLP3siErPiegEdJE6+7bAfFwbcf46sxlZGlRbH4zXaTvM?= =?us-ascii?Q?iTXHxu3A0Y86V/GWi5NBGMOsl7p6sNn7Zd2DLGKGqRhgnPkWElvlX6oCK4df?= =?us-ascii?Q?SzL/um3d7HT9/Yny8quN4D3qsi9lFpSR03SkvygNiFs1h61/ClLtWWs4i5Dw?= =?us-ascii?Q?SDG40MhLLl5p9cFMFhdznGnen9uJGTNR1xF1faNpn044unqQEoH0yuFi/V3G?= =?us-ascii?Q?jqN8iURd4OqtUzx/duPcUlffIX922iIi2oBk+mI7zWmR5fcTb2eBbQZrw+cZ?= =?us-ascii?Q?8DhofPk+BTXc39MxchhH+WxGyPa9QrZT7WBa6wSUM8hWQLnXGadTMZ7GLnc4?= =?us-ascii?Q?rUMGnR/W6j3cH3n226cbCQmfHCUxnGQ5vZ7GjrrNm4OHn/aC03T+YMXGkthZ?= =?us-ascii?Q?E8xjd5n08hmYfD1um3/j8OUQmtpnF+eHKUxzEJ2VEbbaNwd817WWLVihDNGs?= =?us-ascii?Q?uKFp/h2bkvfcDaS1oYo2RJzf+5dNoprXD8FyPcg6+Ezi0cScwGvB5tKKb3FQ?= =?us-ascii?Q?ZXW5u/8A21oo4tXaB0KO4+opzb9N4JDGRg+FDvk3L3FU3F6NVO5RwCB2Sdde?= =?us-ascii?Q?L4sspMr77xEDJq16RiM6+Jhq2vdXddIJJ7k87gIMSuE3BbaG7E77Rqv87DNh?= =?us-ascii?Q?JtrzuL3IXgsR0pO3TgyZ6Z9XwYY4jyZXAI8jz/EE0UzqI20U7zzZaBP4siOZ?= =?us-ascii?Q?My2mftGUxN4c3nZSFj1TS1dr74/vbm11B2wiz+Q2WZtWrFun7mkSWsBcUFiv?= =?us-ascii?Q?fHkyXm9jHdjWin7sRjI9uxXe7pwOQjgPG2x8GqTurmUb4fpijLYjmIdXqcAX?= =?us-ascii?Q?TgaNMYvE/CCeNp1zfDksIotWpExeLVYr4jGhm8UhvM5YEr7yemO/3R8PV8aL?= =?us-ascii?Q?vBXE2QevgXtEaq45Uu5BJ1I64QVuKn+/T6uYA9rp6/A=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6976659d-3613-4016-309e-08d8ad223eb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2020 00:23:06.3526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pS6+z5P5/d/X/5QsPFagQLLFBOcjevxqe2aNicuXvM85s1EUlb+4lGC/soBdDYhjK2Nn+zOu/QfZd7uejCQs+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0013 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Rebecca Cran > Sent: Tuesday, December 29, 2020 7:17 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Ni, Ray ; Gao, > Zhichao > Subject: [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosv= iew > strings. >=20 > Neither of the "CPU Socket Unpopulated" or "Do not reboot" messages shoul= d > contain the word "Bits". >=20 > Remove them and update the identifier for the "Do not reboot" message to > remove the word "BITS". >=20 > Signed-off-by: Rebecca Cran > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c = | 2 > +- >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings. > uni | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index be8ae13c17d1..a3dc7b68c4d3 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3025,7 +3025,7 @@ DisplaySystemResetCapabilities ( > break; >=20 > case 3: > - ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT_BITS), > gShellDebug1HiiHandle); > + ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > + (STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT), gShellDebug1HiiHandle); > break; > } > // > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > index b14d1cb6dac8..8bcba7ccf768 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewString > s.uni > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewS > +++ trings.uni > @@ -269,7 +269,7 @@ > #string STR_SMBIOSVIEW_PRINTINFO_BIT15_NOT_ZERO #languag= e > en-US "Error, reserved BIT 15 must be zero\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_PROC_STATUS #languag= e en- > US "Processor Status:\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_POPULATED > #language en-US "CPU Socket Populated\r\n" > -#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED > #language en-US "CPU Socket Unpopulated Bits\r\n" > +#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED > #language en-US "CPU Socket Unpopulated\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_CPU_ENABLED #languag= e en- > US "CPU Enabled\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_CPU_DISABLED_BY_USER > #language en-US "CPU Disabled by User via BIOS Setup\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_CPU_DIABLED_BY_BIOS #languag= e > en-US "CPU Disabled By BIOS (POST Error)\r\n" > @@ -333,7 +333,7 @@ > #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION_LIMIT #languag= e > en-US "Boot Option on Limit: " > #string STR_SMBIOSVIEW_PRINTINFO_OP_SYSTEM_2 #languag= e en- > US "Operating system\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_SYSTEM_UTIL #languag= e en-US > "System utilities\r\n" > -#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT_BITS > #language en-US "Do not reboot Bits\r\n" > +#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT #languag= e > en-US "Do not reboot\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION #languag= e en- > US "Boot Option :" > #string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT #languag= e > en-US "Do not reboot\r\n" > #string STR_SMBIOSVIEW_PRINTINFO_HARDWARE_SECURITY_SET > #language en-US "Hardware Security Settings: \r\n" > -- > 2.26.2