From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@nuviainc.com" <rebecca@nuviainc.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
Date: Fri, 23 Oct 2020 06:49:29 +0000 [thread overview]
Message-ID: <MWHPR11MB16476F0890FC8765AE1DA1CAF61A0@MWHPR11MB1647.namprd11.prod.outlook.com> (raw)
In-Reply-To: <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com>
For 1 - 3, 5 - 6, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Thursday, October 22, 2020 10:21 AM
> To: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and
> SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
>
> On 10/21/20 7:46 PM, gaoliming wrote:
> > They are the good change. But for patch 4/6, it changes the
> > structure field name. It may bring the impact to the platform code. I
> > don't suggest to do the renaming field only for typo purpose. Other
> changes are good to me.
>
> From looking at the code in edk2-platforms, it seems the common pattern is
> to use positional arguments instead of designated initializers. Of course
> there could be platforms outside of TianoCore which use the field names,
> but it looks like a relatively safe change.
>
>
> --
> Rebecca Cran
>
>
>
>
>
next prev parent reply other threads:[~2020-10-23 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:41 [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-21 18:41 ` [PATCH 1/6] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-21 18:41 ` [PATCH 2/6] ShellPkg: Add ARM64 SoC ID to Processor Characteristics " Rebecca Cran
2020-10-21 18:41 ` [PATCH 3/6] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
2020-10-21 18:41 ` [PATCH 4/6] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct Rebecca Cran
2020-10-21 18:41 ` [PATCH 5/6] MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS Rebecca Cran
2020-10-21 18:41 ` [PATCH 6/6] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
2020-10-22 1:46 ` 回复: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
2020-10-22 2:21 ` [EXTERNAL] [edk2-devel] " Rebecca Cran
2020-10-23 6:49 ` Gao, Zhichao [this message]
2020-10-26 1:24 ` 回复: " gaoliming
2020-10-26 17:47 ` 回复: " Leif Lindholm
2020-10-27 6:32 ` 回复: " gaoliming
2020-10-27 7:40 ` Gao, Zhichao
2020-10-27 14:33 ` 回复: " Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB16476F0890FC8765AE1DA1CAF61A0@MWHPR11MB1647.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox