From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.6231.1603075562060426707 for ; Sun, 18 Oct 2020 19:46:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UVF6Y4CA; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 5C90OecTgy8aL0f+nRIA9xYmqn5vr0uodquiODavudjebmeh1dUlURqvDVZ2x3yP2I0+JmFn0+ m0dB2LzdAJJA== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="146815848" X-IronPort-AV: E=Sophos;i="5.77,393,1596524400"; d="scan'208";a="146815848" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2020 19:46:01 -0700 IronPort-SDR: zcTPdSodpBhD2aFNo16BW/F0ZUTAFvw1jtujjipCCiC7h23C68WHQHWaAYwchxSm+ZD0/Pu+YQ XTE7C7mcdIIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,393,1596524400"; d="scan'208";a="532460226" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2020 19:46:00 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 18 Oct 2020 19:45:59 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 18 Oct 2020 19:45:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 18 Oct 2020 19:45:59 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 18 Oct 2020 19:45:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jhDidF4qtmANtq/OgtHkse4od/jST6KsRramnVv+nPkEA8Nffq5PL9bvze7f1IJPmNIvOmLcb55jnCwZhqHw3OFcQ1hYjv6PXAbpBv7P5m9iEc4+rxtaoYaDfDxWrsYa2Kkj9rAwyb+XnRtGHKBydF7jiQwDkVPDxWLED7wIJ633o9b7N6KdzOc9poGhuJVD+dWTORYY0CS/UJTQwMKGyc6oK/qGu9Y4lcTVC93cxbGpi7ieMe5HxXkj06tGaWimsHWZV+qDsuqZizN2i6HCwu/uLe3AF9vFi+AMdLSMOAOEi7L/xV1qtLXtJZDyP+0cv0K0FJxgsO9MmwRkED3T/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g96CWy2dreALAnPecZ1trDqZ/xpySbiUCwY9dsM0AdY=; b=Hf3vt5Te72zDca3zB9MAGmDnBDw/8OM7Cz609LzdmQxBTUnnPjRVsLNKu27koGwjoeDFddZwaZG12kikeKgKxF/1Y17H9MztRjKmW0pm/uQydqmpfU2MwNDeOMrlyPTgP//c0ds9fyWA6+VDB1PRwwfH0qEsa8O89chCQpy8Rd0R/+9n2ta96qv2aJvQLHaS6irg+TJwfvy+ZaPbKCjoiu6/CXMmlbnmnBfKSycjW8CN0LfgnU6+HOl4IQmLkmXZ2B/IOi9c/l1hnJxCpBPCJ/LiSMBTkMM0KRe6wRBDOZgHE55iZmZembEInEmYm/GQGbFGjQPTd9ZelJj2KOgQ3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g96CWy2dreALAnPecZ1trDqZ/xpySbiUCwY9dsM0AdY=; b=UVF6Y4CAsh9uQ7Hyi+seK3QPtpkIV0fUJ8FtnB+PrthXdyD2evc0zDyE8SzY1pgy9f/f4u7NZkKPCm+x7WoaiDYGuJ2JW/PMSLLXufQsNsEivvqiGzTIp+VYudo6O90aJnXhJqFCtJzHNuv6ZSQ2EflxQwPI/KHWsO2ZQE0ZF3A= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by CO1PR11MB4866.namprd11.prod.outlook.com (2603:10b6:303:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 19 Oct 2020 02:45:55 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea%8]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 02:45:55 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "glin@suse.com" , Laszlo Ersek CC: "Ni, Ray" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Index: AQHWotxvCXf9EMfMvUaKOPLqN2LlJamZyTOAgARzt0A= Date: Mon, 19 Oct 2020 02:45:55 +0000 Message-ID: References: <20201012072230.46152-1-zhichao.gao@intel.com> <4f20aa01-793a-8477-53c1-56a5899caa14@redhat.com> <20201016064205.GI19552@GaryWorkstation> In-Reply-To: <20201016064205.GI19552@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0d0fabe-fe22-4b5f-cce2-08d873d91a40 x-ms-traffictypediagnostic: CO1PR11MB4866: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /HldqINLz3hqEMfKfy5xLzKmF59TsCvFHjhOhGRWNPXsRwck+1GQS9RDPZjUms3Yc8jwTS5hNC538xgGEuo4yQ1FQ6tRzQ/zoYJTpoOxJqNIBplBCBUs4D8Nwuah8eXfQ69aWbQihkgvKBDemH26Xo/ngjb4DtEifr7NQbHc4a0pZGuOjdv9ZXFtMN7Su+YD/Q82VRCVNVOs8y/9kJnHaWEZ2RsksVuwtrAdimSVJK05div/14oeIdXe2Ww9Y8pi+AkxVW+vlfz62z9pe2ixmjVGsjnZKP4SRD9IhDX5zpcfzyiON8k4sluU3VkHU1vFS2VGWBMh/gAV001DQWMjeXtS4p4qnti9yLwSdcI3A8FRNYUvmli1DA+HmNm9TZlStvYb8adC+xWFHRlXU8Srpw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(8676002)(71200400001)(5660300002)(2906002)(110136005)(8936002)(33656002)(186003)(52536014)(966005)(54906003)(478600001)(66446008)(64756008)(76116006)(83380400001)(7696005)(316002)(107886003)(6506007)(53546011)(66946007)(55016002)(66476007)(9686003)(26005)(4326008)(86362001)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: wy2QRKAiFWWwHoeAbB4UQhpM3vUiSVNOn3Ve/iY5TYOAQ9E0LxKltfa07IM5mh/QCRezF3i6m0o4Dt+jKJoaAJ12C3/GJaMBId6zh8Qu3Csi15LKVGTXSlsvD6N02GF7d7QrYhIg0goESCLZO66Ow45Pgf7VrsS6J89KgUe91xDNporOqVxLnYpXLpNTHWBbGnvghp6PrITpLsBdcxgEqoDLTFPz7BRrLN3lZ/9Iu5uQflnT9B7YOAelgs6hYf683/unukkEcopWCF7NFzifayyfbAPFk2oJn8Dep1EQ0Aa8KGCbxoJFzZKSJPdvB2SQih3tFdngV7qa6WnJtV8FJW1/qkrszPGOg98e/ww7GCPhheYCkGwEyVeKMljjViEKGx9AdhmXTRWQPOdOzROEdTdPVaZFfFAsLeNg9LUA6t6DsHj1Ipg3mW24tum9XnDcViq5jWftUSP5RYKlsqbifzgZMVUriH54ltKrqyWz/a0+3S4zD1RfwDxjKkGzglsM+lkTJNT3cpzXjU2W+/nUI07KBXNpaSUQukFlytInZerDjVeDbf7fQ1tz1kiZGZHlZnzRjPnsG33RXbhNHWOdZslT/T26HPgbKcCsMRcqo1iUiRD7CLk+BUc4cl/pmrBJjxmZok0WC6j60wn/PtadCw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d0fabe-fe22-4b5f-cce2-08d873d91a40 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 02:45:55.7927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h02ZNsL4eI5m3VIrh6/UaM6voINPSyQUP5QK56p22SrzRHtaf6H/rlpz9oCrPXDGkn2mjRecDI6cxNgYCnWxUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4866 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Gary for your test. I have give my comments base on Laszlo's reply. = I don't think the regression would affect Linux ISO image except there is o= ne Linux image with boot catalog media type not NO_EMULATOR. Anyway, thanks= for your test and your quickly response. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gary Lin > Sent: Friday, October 16, 2020 2:42 PM > To: Laszlo Ersek > Cc: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > ; Wu, Hao A > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the = child > handler blocksize change >=20 > On Thu, Oct 15, 2020 at 12:17:50PM +0200, Laszlo Ersek wrote: > > On 10/12/20 09:22, Gao, Zhichao wrote: > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2843 > > > > > > Revert the patch to change the block size in child handler. It would > > > block the CD (Eltorito) Hard disk media type's sub partition being > > > observed. > > > The blocksize patch used to fix the CD image's MBR table issue. The > > > CD MBR table would always be ignored because it would be handled by > > > the Eltorito partition handler first and never go into the MBR > > > handler. So directly revert it. > > > > > > Cc: Ray Ni > > > Cc: Hao A Wu > > > Signed-off-by: Zhichao Gao > > > --- > > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 12 > > > +++++++++--- > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > index f10ce7c65b..473e091320 100644 > > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > > @@ -1149,8 +1149,8 @@ PartitionInstallChildHandle ( > > > > > > Private->Signature =3D PARTITION_PRIVATE_DATA_SIGNATURE; > > > > > > - Private->Start =3D MultU64x32 (Start, BlockSize); > > > - Private->End =3D MultU64x32 (End + 1, BlockSize); > > > + Private->Start =3D MultU64x32 (Start, ParentBlockIo->M= edia- > >BlockSize); > > > + Private->End =3D MultU64x32 (End + 1, ParentBlockIo-= >Media- > >BlockSize); > > > > > > Private->BlockSize =3D BlockSize; > > > Private->ParentBlockIo =3D ParentBlockIo; > > > @@ -1187,7 +1187,13 @@ PartitionInstallChildHandle ( > > > > > > Private->Media.IoAlign =3D 0; > > > Private->Media.LogicalPartition =3D TRUE; > > > - Private->Media.LastBlock =3D End - Start; > > > + Private->Media.LastBlock =3D DivU64x32 ( > > > + MultU64x32 ( > > > + End - Start + 1, > > > + ParentBlockIo->Media->BlockSize > > > + ), > > > + BlockSize > > > + ) - 1; > > > > > > Private->Media.BlockSize =3D (UINT32) BlockSize; > > > > > > > > > Hi Laszlo, >=20 > > (1) Adding Gary Lin to the CC list. > > > Thanks for noticing me :) >=20 > > > > (2) I can see that the TianoCore bugzilla ticket, namely > > , has been reop= ened. > > > > That's wrong. > > > > TianoCore#2843 was about calculating the starting and ending LBAs with > > incorrect block sizes. It was fixed by commit e0eacd7daa6f. Therefore > > TianoCore#2843 should stay in RESOLVED|FIXED status. > > > > Now that we have realized that commit e0eacd7daa6f caused a > > regression, a *new BZ* should be filed, stating the particular > > compatibility issue (regression). It is a different symptom from the > > symptom originally reported under TianoCore#2843, so it belongs in a > different ticket. > > > > In particular, the statement in > > that the > > original commit (which now should be reverted) "doesn't fix any > > specific issue", is *completely wrong*. If you look at commit > > e0eacd7daa6f, it contains the tag > > > > Tested-by: Gary Lin > > > > Furthermore, if you look at the mailing list archive, you will find > > the following confirmation from Gary: > > > > After applying this patch series, the firmware recognizes > > openSUSE/SUSE iso images again. > > > > In the v1 thread at > > > > [edk2-devel] [PATCH 0/3] > > MdeModulePkg/PartitionDxe: Make the parition driver match the spec > > > > https://edk2.groups.io/g/devel/message/63972 > > http://mid.mail-archive.com/20200811075443.GG21538@GaryWorkstation > > > > And then, in the v2 thread, Gary wrote > > > > I've tested the following ISO images and all booted as expected. > > [...] > > > > again giving a Tested-by: > > > > [edk2-devel] [PATCH V2 0/3] > > MdeModulePkg/PartitionDxe: Make the parition driver match the spec > > > > https://edk2.groups.io/g/devel/message/64047 > > http://mid.mail-archive.com/20200812062652.GL21538@GaryWorkstation > > > > > > Now that you are proposing a revert, you have missed all of the above > > feedback from Gary. That's because you never bothered to link the v1 > > and > > v2 mailing list threads into the bugzilla ticket. > > > > So this patch risks reintroducing the issue that Gary reported origina= lly. > > > > (Of course, the original bug report from Gary is *also* not linked > > into > > TianoCore#2843: > > > > https://edk2.groups.io/g/devel/message/62648 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823#c6 > > http://mid.mail-archive.com/20200716033255.GL6058@GaryWorkstation > > > > so it's no wonder we have no idea whose use case we could regress with > > a > > revert!) > > > > This patch should *NOT* be merged until Gary confirms it's OK. > > > > (And if it's not OK, then a solution is needed that fixes both Gary's > > use case, and the compatibility regression. It might even need a PCD, > > if there is media out there that needs one kind of logic, and other > > media that needs the other kind of logic.) > > > I just tested the patch with the ISO files with SLE15-SP2, openSUSE Leap= 15.2, > Fedora 32, and ubuntu 20.04, and the VM loads them without any problem, = so > there is no regression I had before. >=20 > I'd give it my Tested-by. >=20 > Tested-by: Gary Lin >=20 > Gary Lin >=20 > > > > (3) If this patch is a revert of commit e0eacd7daa6f, then the revert > > should be prepared with the "git revert" command. In particular, the > > commit message should very clearly state that this patch reverts > > commit e0eacd7daa6f. > > > > > > Thanks > > Laszlo > > >=20 >=20 >=20 >=20 >=20