From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.3076.1606783526122738869 for ; Mon, 30 Nov 2020 16:45:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jLUArhOf; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) IronPort-SDR: sDDdBdo9TRNP6StrPRzJdLXr6Sv6aYD+qmiNk8JG17uqmCjWJS5iaQJMKetHGDDfqE2uM81c3s ena4DojOb4Jw== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="236865802" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="236865802" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 16:45:22 -0800 IronPort-SDR: Z+ppmD7fiNtso4KQFeHXLW0eUAGAxbmwUg7oEw67GicppPx9mvYyRcIUM7u29t91XrG3BtCHf8 67miTvep1rQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="329767216" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 30 Nov 2020 16:45:21 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 16:45:21 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 16:45:20 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 30 Nov 2020 16:45:19 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 30 Nov 2020 16:45:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyJXwsNL1/dgcfCQ/cIIpIpAt19OOuc80R6DfIWlFy22HViMEIWEFLmc6EYQPMbRfDwt9FqQg5cL3X0HTvkHAKYo7rrdZhduJlcV6ipDdx8uyn62GG4/H1hWDbTF0QipUw53NFyDTWnU5F4VQdlb2gOZQaUbdCPl95FC7n1uyrv+IuEJlaIfl8LQd1Xp10yXbzfDSki7jxSyWqOToC2DCiTNBUPsbtg/QntI6ZBZIan02QEup9bEtrmJ9/3B4FAAv2Pp1CzSiO99fRq6vTsxDfR22juJFIbluLS5jfFJSsCC4//LNONSyLbrkEvwajfN3Lt/TKYApuyhGm3b8VsVuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQwfZeBb8SCwmG3EskDbPJDztNT99ECi9gWlCOz+cdk=; b=EKt/WsIGj9/bBoBTVoMU4koTq7t+3j1lVJANCq8110dtvP3nPIQ7JbPp2usG6bvwKzqvxEBRnEUnCzSETlxsfcp7YcFjuo/wpfdv41UqBOZrBDtexfYC1pPHLvQVNhUVVKkU0BzJ7sXpeYvLv3G8SdRhnB25OipFNheoWjvgZ/SKGSH25A4wq4dTbhJSnzAMyk1yQSEouGIrqNloKuJj5/E2+61asbysmGFdBu1Xv3Hf5TvRCNqxWeA2SqUWmOtoQ+xX0mBWMK3nOTYkUWrQgC7zxeyg2Z1yyI/o8MCp9a8xXL0zggJRevWHO6bN/rcKlVVXTMXxfgLhWRG3Mg41dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQwfZeBb8SCwmG3EskDbPJDztNT99ECi9gWlCOz+cdk=; b=jLUArhOfDksEAPAHhADp8nxYp09pDPu5eH4+2USr34L0CwOOsEA05EjJy5FUkCk3w1x6DFoqcYXa7p5Lm+eaxZatYIJWlPbyDvpt4Ytd8bPGCVw7OZfGyGux2i3Hpg8KZcqQE7tqzgEYf/mD5RD/MuKO8aPlVQjtwbbxyNjfJsI= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR1101MB2094.namprd11.prod.outlook.com (2603:10b6:301:4e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22; Tue, 1 Dec 2020 00:45:16 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77%8]) with mapi id 15.20.3611.023; Tue, 1 Dec 2020 00:45:16 +0000 From: "Gao, Zhichao" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , Ard Biesheuvel , "Pete Batard" Subject: Re: [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Thread-Topic: [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Thread-Index: AQHWwpZCZMP6vhJ3r02s2X+SGw4t5angUB0g Date: Tue, 1 Dec 2020 00:45:16 +0000 Message-ID: References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> <20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6838b810-46bc-493e-807f-08d895925f2c x-ms-traffictypediagnostic: MWHPR1101MB2094: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z90kV5Xxz7QcjWESCTwQmtBzBhjSWkSEVnqUrT8g597t3LavSLqo8gvQYZLYPnvxODODYlHgHya3NKnewzFTDHPA31cyA2LhwiSna5FiaFTVd7p299IEzZsq1mfs0ik5IPgsCzSBXjO5IUEfiT71ctnb0yZ66SZdk2phBsYDo5SsUtm5XTgcv6QUthZPiLojRzrEY+dyFyxnaUYuiDm3FOfU/x9I62ZpNJ9vmx+O4Al6mPqlnENx8m3kKa4gJGBSTE1SjZPg4Yaoh3MirEUfvwAHbDoPeo3y0c2EmQgFAzt1y3aSxx4EHaWctJrLv+AOblKcqvKr4iPvCaR6uz7D0QHNe6zrgyy0cz7Ig8igd6LwgPg4VmXMHJsFQO9gHYAWnopEd/UY+Jr2oLOqak2Krw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(376002)(39860400002)(346002)(71200400001)(8936002)(316002)(53546011)(83380400001)(6506007)(478600001)(966005)(52536014)(8676002)(5660300002)(9686003)(66476007)(7696005)(64756008)(186003)(66946007)(86362001)(33656002)(4326008)(55016002)(76116006)(26005)(2906002)(66446008)(54906003)(66556008)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?NJpDj1V4CULpyyOLtUsf+8W25JfOumQMzrmj72UzhQDkHgU0sACnXC4l//PT?= =?us-ascii?Q?iW4yYebOgz1Z9nroWvOvfEFmZrEmqxQMi4quqxZUc8jOWo9zCfKgeYX9B8Aq?= =?us-ascii?Q?eHtywejCs8jeuQpHTDNV2t6Iq0rdizMFrfuuw85YbDeKoRKOPc+1j+xe9+pd?= =?us-ascii?Q?9MKlIsXB5TsqavHHv19z0BypUc5ver2U90/J2qECpj2rMVVfof5IM2pCWBGj?= =?us-ascii?Q?tjYh/OzjUhO02B7QLjVVLOae1wdG8E+GTxN1Y1BlOgVthWwvqTK8KSQn9coS?= =?us-ascii?Q?/jlM035Lm4MvjAxxPSEdNTAksSI3Z29j9AAyapfsJw3FqGtl0A4LEuYEme/7?= =?us-ascii?Q?yLk7IPjpyLoqggPMXxcEsWRqbH6Q/NdSIKEcZQoGFkFIEAxngLO0ZLfLX65k?= =?us-ascii?Q?NN2qFoTCzVxehJVjv72AYK0xL3C+POCmVKJ5GOu7+ihEL96Zpf6VouhGDH1k?= =?us-ascii?Q?83wtOL5FnI4ejIQ+D5RvkdeoTNL6Ft4NnDdH/dN1WicAU1Eu8+J+qNfdaAPI?= =?us-ascii?Q?OGJOztqa1VB4Zuv7WxoP+NYXOQvHb1TCGCNE/r5SriAtrBbM3RkdzvJO3pSd?= =?us-ascii?Q?+2OGqnqmtXTaiEaaR0qb3Kljbtk0LuAGIOhECudLnSFjIwcR7w9x0bJrCuG3?= =?us-ascii?Q?Ll5CuzG4xBoWPggT86WGTG9j+DL7pRRY0GiIwqNJkVy+oApQ52lzVK1RbOaQ?= =?us-ascii?Q?2E/3pjwyGw916DtEqotih6daAez1yLV+7eddiPtpslK4nlQV+aZJXEzx9uO0?= =?us-ascii?Q?AH62NWL0hKN83UeH47n2EG7NAbNBYCsggxrWTpZnaLQKrczA04glpJlfEgCC?= =?us-ascii?Q?MOhzHKdz+OmDtk5aaEtz/zoSGBFM6Smr3SErTr40cEqD0zDJLW+vFpv9/Juw?= =?us-ascii?Q?o30PtmtxO0n8DF546aYNROsGAwdQtX7a1F0fv5x8i+Db5HDIZ5C3r5bznRLp?= =?us-ascii?Q?JaUwg3h/9MDatUqnnAC6qmt1HbM7cHyGAEf8l3l8HA8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6838b810-46bc-493e-807f-08d895925f2c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2020 00:45:16.6121 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k/zqupRcrvV0s4H+ezp1FDTaF4jEIE9eYxcYFrDIgr5qu/RMyadq/lc0O28z/lDp4l6+Ao4t/V0w/6WhMSmyBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2094 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: Samer El-Haj-Mahmoud > Sent: Wednesday, November 25, 2020 3:16 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Zhichao ; Ni, Ray ; Ard > Biesheuvel ; Pete Batard > Subject: [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default > CursorVisible to FALSE >=20 > REF: https://github.com/pftf/RPi4/issues/115 >=20 > GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. > However, the driver never draws the cursor during init. This results in t= he first > call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actuall= y draw > the cursor on the screen, as the logic in FlushCursor depends on the > Mode.CursorVisible state to determine if it should draw or erase the curs= or. >=20 > Fix by changing the default CursorVisible in this driver to FALSE. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Zhichao Gao > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Pete Batard > Signed-off-by: Samer El-Haj-Mahmoud > --- > MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > index c042451a9b52..6b8d11d587d1 100644 > --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c > +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole. > +++ c > @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV > mGraphicsConsoleDevTemplate =3D { > EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), 0, 0,- TRUE+ = FALSE }, > (GRAPHICS_CONSOLE_MODE_DATA *) NULL, > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL-- > 2.25.1