public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Rebecca Cran <rebecca@nuviainc.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
Date: Fri, 30 Oct 2020 01:08:02 +0000	[thread overview]
Message-ID: <MWHPR11MB164779EBDE1783E852B8F915F6150@MWHPR11MB1647.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201027172931.27297-1-rebecca@nuviainc.com>

The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:29 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
> 
> Fix some typos in smbiosview.
> 
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
> smbiosview.
> 
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
> 
> Pull request: https://github.com/tianocore/edk2/pull/1052
> 
> Rebecca Cran (5):
>   ShellPkg: Fix a couple of typos in smbiosview
>   ShellPkg: Fix smbiosview string definition name for "boot from CD"
>   ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>   MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>   MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 21 ++++++++++---------
>  .../SmbiosView/PrintInfo.c                    |  2 +-
>  .../SmbiosView/QueryTable.c                   |  4 ++++
>  .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>  4 files changed, 18 insertions(+), 13 deletions(-)
> 
> --
> 2.26.2


  parent reply	other threads:[~2020-10-30  1:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
2020-10-28  5:05   ` Zhiguang Liu
2020-10-27 17:29 ` [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 Rebecca Cran
2020-10-28  5:05   ` Zhiguang Liu
2020-10-28  0:56 ` 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
2020-10-28  1:27   ` [edk2-devel] " Rebecca Cran
2020-10-30  1:08 ` Gao, Zhichao [this message]
2020-10-30  1:14   ` gaoliming
2020-10-30 13:28   ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB164779EBDE1783E852B8F915F6150@MWHPR11MB1647.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox