From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4717.1603432403141328933 for ; Thu, 22 Oct 2020 22:53:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=hZB0mai2; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zhichao.gao@intel.com) IronPort-SDR: TiMDrlz7nFukZQwvcePoH4ul0vX2naHnanzTg7n9FpZ+FaHiGuxn9yrsr+0vvwWk1GYAwPxSVK yPDe6CprgKxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="154590225" X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="154590225" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 22:53:14 -0700 IronPort-SDR: LvGDGfAfnkMTmfJgXFd0wDJP5qPn/NiJ7ahbB//3BX+goRoNN8U99Dmo3q54ZJzuw3I1GMN8cN H93/vvpMm9UA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="524567905" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 22 Oct 2020 22:53:13 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 22 Oct 2020 22:53:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 22 Oct 2020 22:53:13 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 22 Oct 2020 22:53:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYnDKgLfZQVwYDqMFhwOf6VYEKAQb18zzy9T5tb+d1AeMRW93rSoU0I7Xt+qsBocn0EddHBCYr8AzI7NkNScYAtnFQZ6pbqQvt/f0Xw1QLxBvvUkQexN3xEcmTUdzXyL+WUVGv/2Qtf8S3CqndCZjgXmISqgJSkvhw+z89mg6J0YhpuAtJT67EqFl7HktwfO98/NuqtVnxrDPGsmfpcfxpr96pLJyUgpTyC8yYXBzhrSxwc7RbUXXYSIA9RLPh0TL82uCBurshACiVU5VTsaBzBH3RjOkU9+bytTXeGNl5AZml+ESJA0fZfIqjfMRrID5T0qzlCs8WzXOiMmlJH1+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yb0ZiaQerxKozuou4zQ+u2XET6TOhohmDRcVdSQH1Ws=; b=bzF9InSHXlOER/191vcBOuReoWFFJ7whwwUHuvvLDazZ6pgVfQ+5NlncuFJ95gcZMPquaBaQcEDZHNwZ0miKj5FTnn2l+vWWyIKIN0EbPCCj7cWZ3QkfjZbISszkc4Tio5e+DPtvdx34epUMrHkn2YJKHD0HnFXpy+vZa/h00gGRUS7WlPwkt8tD3uwW+Qrj/S4d4Kld00Hclo1Bi/JMW/QUXyrC1S51jXsbH27KynUxS+qPl367pYUAT+37RZ75dOWxLV3kJhPoaZQCzh1NWvN34WifJUYtS7SRm1y0qNNIEWcJP1mxHXy3YVfc/sdMnXQp8xzOov7wuOSO6a3rDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yb0ZiaQerxKozuou4zQ+u2XET6TOhohmDRcVdSQH1Ws=; b=hZB0mai2G1W/Wri4erZFhpMHYniV4fdS4iAPyVgoXewmdOtbwSByTxnx2jumkadEcQU+TMNpzc24bCA5sYR09lsQgxJLjHQZGPT2z8BY/EIs6KG0QkK83iq/haxSVOaYs7jwVpFCp1Kem3Wa8NkILHrBxlOtKpLNdNhPtF2lWZU= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR11MB0061.namprd11.prod.outlook.com (2603:10b6:301:65::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Fri, 23 Oct 2020 05:53:12 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea%8]) with mapi id 15.20.3477.028; Fri, 23 Oct 2020 05:53:12 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "sami.mujawar@arm.com" CC: "Ni, Ray" , Matteo Carlini , Ben Adderson , nd Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser Thread-Topic: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser Thread-Index: AQHWkmjJp1ChdJh1ZU6nQdBJopR0+qmiP7KAgAKWBTA= Date: Fri, 23 Oct 2020 05:53:12 +0000 Message-ID: References: <20200924114913.109188-1-sami.mujawar@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cbee39fd-b991-4a4e-1ae5-08d87717ed84 x-ms-traffictypediagnostic: MWHPR11MB0061: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eAxXf3VNqqziLKmt+UnOW5PQb3VqAy3vqRRDwtgMe2nhSdRdCRoOtB1RE1k/y7zVl7KmdLoPrj0fTJIPfwsVFD8kKcbJECU9eZX9aSkXJ1/H0fYHviFL3THoD0pSqcea+biwoD13DfkJRsyBcghlvYNEJi5iiCBZfK9SkBD+Ft55lKZ2G97HBnnDRViJL6I8cgrXRlcjY2Qw+vTShQiZ3ytZL6yUSCu89bSCHZSX8Y2p+64voCFkM6lwond90iTPBZjJzDYlpmWwx7IwgwPuHWc4x6lcD1+NlS/AAdTJLiM2enOFUeVhAW3SK2B2ah7j+NXTdkOb4B7v/2xabvAs0dZWMN9AR9R+B4ae+qWehwuwCfx2IvbgsC6VivMjM7gJNNpY72WSkDTEtn1GxsZaRQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(346002)(396003)(39860400002)(966005)(4326008)(2906002)(7696005)(83380400001)(33656002)(55016002)(8676002)(8936002)(52536014)(110136005)(54906003)(71200400001)(76116006)(66946007)(66476007)(66446008)(64756008)(66556008)(26005)(186003)(478600001)(86362001)(53546011)(6506007)(9686003)(5660300002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: lN3uO5cczZUWm4T09Vxbjg6Xu8loOA37r0cOgw0CEyurI4KNsQ8kFFrfco0SYbxyBtr/lYgwgeQB5swkl7cf59dCLZWwnsy4QFMZovhgpAaZ02B7zGukmq7Kycy0uDoRg3/Gz+o+igXCG98rjZvHAKJcN4fMCS8P9eyb2iLcOfB+3Yc8iqc0i9T9zMdU5jj/EMkrZ0Bio2DuaWJhxGwNdaJWaKzLpyYyLcX2ZOakYhhu/7EMDa9aVBbO6127jDBkax01DSQig10KBpHVwmYtIHE11GqNurTyowBb94Qy6xSpyw74njWfzOIXaCiPiuSNpu7KMHhxDZQRw7gy+0c76abmBO++Ptr9Gdh8TcbA6KrLKP/r9BsUIoknnrXy38xJvYGHLwrjAV0sxedKU1h6nuPFWHsYZU+4wzeYVLIjv8G5bRhrmIcYh2W2IiANuYiuLWm6wxqM58eM3R1J33wDxPtlBeGLgDZWC4t6OgIPGvdtJlViAxrgQaHrHAONfbkyA8vugyXNOsGKL5EAjCxQlGuCESrzgXncpOl3tayGEenxpX8onV1rrZjf04qWyaQB+iSmxJkEjS2QeBNRkVWDM7LlRv65+GlbQ+VyRTmFY1UEEHw8Fa85ICdHjLLktM/gBgiKxVGu60iAhAVwgeabJA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbee39fd-b991-4a4e-1ae5-08d87717ed84 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 05:53:12.4566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KnFgZH7dzYXcNmyVZ8MeTsE9WxqPZSA8BbKgtg5ZSrSC8hNnn+Q2crUHg9uAsK8F2NbRe107NZyRPZLBBWCBhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0061 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sami, I am OK with the patch #1 and #2. I hope you already tested the patch, did= you? Patch #2 is a bug fix and not related to the PCCT parser. You can put it i= n this patch set but it should be put before the first one. Because its fix= also benefit patch #1. And remind as I said before, it is highly suggested to file a BZ for a pat= ch. For this patch set, BZ is required indeed because you put two different= patches into one patch set. Two different BZ ID clearly descript that. I have no other comments. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Wednesday, October 21, 2020 9:59 PM > To: Sami Mujawar ; devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Ma= tteo > Carlini ; Ben Adderson ; > nd > Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/Acpiview: Add support = for PCCT > parser >=20 > Hi Zhichao, >=20 > Can you let me know anything is needed for this patch series, please? >=20 > Regards, >=20 > Sami Mujawar >=20 > -----Original Message----- > From: Sami Mujawar > Sent: 24 September 2020 12:49 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; ray.ni@intel.com; > zhichao.gao@intel.com; Matteo Carlini ; Ben > Adderson ; nd > Subject: [PATCH v2 0/2] ShellPkg/Acpiview: Add support for PCCT parser >=20 > This patch series: > - Addresses the feedback for v1 patch for PCCT parser. > - Fixes an issue wherein the field validation is not > invoked when a print formatter is present. >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/840_pcct_parser_v2 >=20 > Marc Moisson-Franckhauser (1): > ShellPkg/AcpiView: PCCT Parser >=20 > Sami Mujawar (1): > ShellPkg/AcpiView: Fix field validator invocation >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 15 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 24 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.h = | 4 > +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c = | > 615 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h = | > 33 ++ >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib= .c > | 4 +- >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib= .i > nf | 4 +- > 7 files changed, 686 insertions(+), 13 deletions(-) create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c > create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.h >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 >=20 >=20