From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.5354.1616663347349231661 for ; Thu, 25 Mar 2021 02:09:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RNDqKuNg; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 20zdJfcUi8HGuCGwiRObyI6rNDzg2RYM75vGdTzU5NT5U1n/zKynAMgGRPaXsJwe4nMI44G3rT lVzh1Ju509fw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="170866597" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="170866597" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 02:09:06 -0700 IronPort-SDR: jfqjxvhYGFnzL8m16KrGYkBA34G3ttdNaO7LsNHyDiPDdfNuV0l2p3Wpyg6p6dPVsuRfbihjTL 0aUoZ+JS7ihw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="525572505" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 25 Mar 2021 02:09:05 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 02:09:04 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 02:09:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 02:09:03 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 02:09:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glLuDKa3jSARWqur8+wBI5lEuMYQT7UvKeCQ3jTUFhtF/+M/Q4okd2SQVFQXl0SM2gdY9OMHJ0IkC+KJNB5cWBrCsF4rSNnX6ZP3+u+2xozp49E89bpVlcXuwEILJqllK+vjazafZinJOScFEd6tDYWZIpyEi4ljtfJ0ZyY9JJIc9wRaN2MXtHlC78DUyz2FAagYsAXQQLjEtK73JabfBdDGz1Z2VaV4tZsz8pyjoyPjeKuFUJ6PB1VlQ/6+3YaG+9rviI9+747gUQqpgu6crkDZ3bYZSxBLsdC0+SuEy+DxE6VVEVlGWl39NooiKqJJDcQdRRaSdZcgjn27Vb4ooA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBtcxTEqsoTLn1KLY4hLJzSfErzCeJqFmMyutsl6zAc=; b=Do9oLz7mxuNAU+vnsd5Xj4OASKR1E1IH/IqHNCEpIEWKKCnyJ1J3eKIuQ70GykhXVyz7X1oz0N4o8WXQx/Zuz1P2qFedi5z++YxzazZqPaM4Z41uFZVDhe/QwEuA4lh53y7HOKj/luSqXzGLWFfkVQnJ1UjEt3/w22ppXW9ZL0q1r62F22DoCo5Ys5t9EY99yf2YUS5sIV4nkYUIRfKya/sR5o0vr9jeCc5MD9rE1CnhnIIOw0u7ODJze4j3X7Krbadm0d66PEotJ6BB1AryPw4uFZ7V7InGcroJaVDizCdelseMhrS/NgPJyY2Bc57cUbuORNJpbUUip64yyuVgYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBtcxTEqsoTLn1KLY4hLJzSfErzCeJqFmMyutsl6zAc=; b=RNDqKuNgN6HgWuvKnzzap23GUklYPzdLC8oDRRv/Mxp0GKlc5UTVDyLvUuhhNE70XEvOOzI6j4PCvL6q6yqroLZp8wfstnCPf99DyUUeISuPluTx5+nuImm4LBCKNFk0DEXk/sfpIIpazKM+aZUa1MpaU5qtel8XJiTb8NPkY+0= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Thu, 25 Mar 2021 09:09:02 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::61a2:3dbd:d98b:595c%11]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 09:09:02 +0000 From: "Gao, Zhichao" To: Abner Chang , "devel@edk2.groups.io" CC: "Ni, Ray" , Nickle Wang , "Peter O'Hanley" , Liming Gao Subject: Re: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Topic: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Index: AQHXITnZv6DhdOSedEi8BecKFHm5DaqUX6vw Date: Thu, 25 Mar 2021 09:09:02 +0000 Message-ID: References: <20210325045236.344-1-abner.chang@hpe.com> <20210325045236.344-3-abner.chang@hpe.com> In-Reply-To: <20210325045236.344-3-abner.chang@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a53bba23-b408-4439-107a-08d8ef6da207 x-ms-traffictypediagnostic: CO1PR11MB4929: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pceujBasNNgqkkWfZk/8ZnhHgxsOKYkwrpiVQ2jDzlaGqFU3Ib1PtR8MnFRZaARihvGMH5VTfJpJKRdhzIB1TzrM5c5yNk5+sDVY3/Vy0flU8H7D0Su8wGnyTGElZn4MR2Gq+XAX6fY3CcHYFnMgS8Yspj2+BdWazrgyPHY0z4DO/e6EI3djy0jF6/NEjLzia9GWCyClvIwU3CPWRVb0mAUm9hivPRGlQKHhvqHdYQq+8dbAv4XC+5f0BMTmZQVuyqimaEWiAiL3jt1HfMmBCtSzRj1mQLdVOQeN8kPTThyh/nfOS8IE3PjeFWE3r0q6aM1difmbzu2SU95UNUmamavr3Ji2k4Vmh3w8uI6EStgXq17ZPjTmJ+Aeb+ZSu8x4rtyAFoPrJZQMq8/S3k1QkJXK/D/YxPcNVaQgAXgpACLqQyOoNNmY6iRzjcPv6/MJfu7ExkUtapsJdaLvjqj9HEirvrYx4FBwXgmoHGNCgH+9SiT0bx4Fkc81kpc2YfNFispvlXA13b1rYJw58Sy572MovClC5NkKvASnYsr+M/nkiFpowCRrsyoppQ8dVL3OrS5FRh2H6Q/UFE/FTwSqFpw/O5FMUw1vDAD3Icj0nsjTm04U/+OBFqcq1mRsWphBBXzPlFOqMr/CJS2BKOMqtTdN1XgIumJKwnG2AKGrcUo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(376002)(346002)(6506007)(52536014)(316002)(296002)(66476007)(53546011)(33656002)(9686003)(55016002)(2906002)(66556008)(8936002)(83380400001)(8676002)(478600001)(54906003)(110136005)(5660300002)(86362001)(76116006)(4326008)(7696005)(26005)(66946007)(71200400001)(38100700001)(66446008)(64756008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?PAhcIfgabWbjy2VMhWf6pBQPNGh/rfS3Gv3swh3ebQVC7gtqlkCPa+/EkQyn?= =?us-ascii?Q?3piifnS8d6EPz1hjZMuzK0ph852jUJYip/dGqCBDsCns4A7DCKitDePFav/p?= =?us-ascii?Q?oWfYJb2IYGNql+5u6/qqHyAg/GXEdhRyZ2whOlfCiOi/xQb9pUo6CjQqhQ6Y?= =?us-ascii?Q?GVkToJBBIdovew3hvA0Dk648ucxPvwEyuwmsdel8s8sIouV7p9ZFvSrBLRDl?= =?us-ascii?Q?CZ+IlXsP2K2qtibUOU4yrZcmfat6gq4rHJ+Qzm8yon+llDWCdpYgXFBExntw?= =?us-ascii?Q?dwmKmOQX1zWcLGMM5g+VGIsFzo9aaPNlR+AEHhhsStJmlR2FfMyFrKU2EZCg?= =?us-ascii?Q?UwC8RhAAYyhANeQyrlrn20SixlDQW/8Lq0zEZNdRxnn9QY9WVLlg9SaPg8IV?= =?us-ascii?Q?lRqnbWK1oDlaXvIvC/l3t29/9l0CJ1Z6IMB0EfOe6gDD9/+GQsfigTpMFhiK?= =?us-ascii?Q?mVVtkNUcgz4PXD0sPZhzCfSewSJ1kKZDV9xFFhci50FfACacutEjX/gDgCEv?= =?us-ascii?Q?aorB69X5VTqkPEnR9Tosc0qVKOU+NwpTIY40x2s3L5HsDkuTC7qwPnJWFtiD?= =?us-ascii?Q?mlZhsDVy+FkcsVsz0Xrax6iciAtAiNrjp3/xknn9+Lw1KzkfbKKfyCpMThSb?= =?us-ascii?Q?GyWTSOf5RE21Ilx2HRcIBsJ7ShAXQ6YC+GlwhvT4huVo3lE5w0UNy3+VdP0C?= =?us-ascii?Q?FOaMKUZdUB4qCZtYzabWNEi1IWlZ6wHn+Xkf6VBucA71QsGTZK82sDYbAeHu?= =?us-ascii?Q?k3UtJIJ3CF0x+GdoUPejeUscm7Hz8KZ5iAvMGR/hrByvKmQJi75r5VIm2NFp?= =?us-ascii?Q?5NUroBy1jMnX0WEebbUcGD3G0E8kakaOuEoJN9DjQ2zjgUD/ymvMWHtMKlno?= =?us-ascii?Q?KwMaqyGjMaQHEYac0JetVsYGHyHjU28/Tz4oSqibMDnupywMkSNCHBIn/MiY?= =?us-ascii?Q?nDu4VHF06plnshjQQDX0SK+UFcep6Yg5wmvF6w/a8fb5mGy5hKte19qciZwp?= =?us-ascii?Q?K7/PYKghZU8MIptw8JG0u3i8Mx7c8RVSClVZT/VqxUpnU6TjjRUVq/ppseRK?= =?us-ascii?Q?QglMYonNtv9pFe7vT0KWeO9UZn88/Z/fi10Cg4jXhzcw1SbXj9DQxwuuOAtN?= =?us-ascii?Q?n6E0k3e7esAW5yLVHCFkyKBOqHFhuBhn3Xu/U6vi9uGUYb78YPaRVq48a/+P?= =?us-ascii?Q?KAhG6k+1nNcGHQOH1K5yaGoF+VV9nzDGULgQ1pH9y6RjOLgpfFsP3GAq1B0A?= =?us-ascii?Q?WE6i6G+5YgZC2dUh/LXJGkwoDBAThR7fWK5LD7BnUjbMLx1iZDWCeZg7kV9b?= =?us-ascii?Q?If0mxUwT+VVVt3XmXZk9H4X/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a53bba23-b408-4439-107a-08d8ef6da207 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:09:02.0551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BKqA573s+Fp5D2HLZaM3eFzUTOPe17cYcmq3DdQ7oQV2mTZ0rOkX44hF7P2QRYxb9PpQ0KzBgrS8JZ7kvvCNAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4929 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable First, thanks Liming's catch. Abner, The patch has been updated, you should remove my R-B for the V4 version. Ot= herwise the reviewers/maintainers may treated it as reviewed one. And please add the one who already gave the comment for your patch to the C= c list. They care about the about the change and this would help them to kn= ow the update and have a chance to view your patch in an early time. For this patch, the copyright should be updated to 2021. With this updated,= Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Abner Chang > Sent: Thursday, March 25, 2021 12:53 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Nickle Wang ; Peter O'Hanley > > Subject: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfis= h > protocols >=20 > Add handle parsing for EFI Redfish Discover protocol. > Add handle parsing for EFI RestEx protocol. >=20 > Signed-off-by: Abner Chang > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Nickle Wang > Cc: Peter O'Hanley > Reviewed-by: Zhichao Gao > --- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 +++++++- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i= nf > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > index 93b69cd8e9..446cd8d609 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > @@ -2,7 +2,7 @@ > # Provides interface to advanced shell functionality for parsing both h= andle > and protocol database. > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. # (C) > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
-# > (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > +LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 +269,8 @@ > gEfiHttpProtocolGuid ## UNDEFINED > gEfiHttpUtilitiesProtocolGuid ## UNDEFINED > gEfiRestProtocolGuid ## UNDEFINED > + gEfiRestExProtocolGuid ## UNDEFINED > + gEfiRedfishDiscoverProtocolGuid ## UNDEFINED > gEfiMmEndOfDxeProtocolGuid ## UNDEFINED > gEfiMmIoTrapDispatchProtocolGuid ## UNDEFINED > gEfiMmPowerButtonDispatchProtocolGuid ## UNDEFINED > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > index 500a95a89a..e34cefd7b4 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > @@ -3,7 +3,7 @@ >=20 > Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -2250,6 +2250,12 @@ STATIC CONST GUID_INFO_BLOCK > mGuidStringList[] =3D { > {STRING_TOKEN(STR_PARTITION_INFO), > &gEfiPartitionInfoProtocolGuid, > PartitionInfoProtocolDumpInformation}, > {STRING_TOKEN(STR_HII_POPUP), &gEfiHiiPopupProtocolGuid, > NULL}, >=20 > +// > +// UEFI 2.8 > +// > + {STRING_TOKEN(STR_REST_EX), &gEfiRestExProtocolGuid, > NULL}, > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > &gEfiRedfishDiscoverProtocolGuid, NULL}, > + > // > // PI Spec ones > // > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.u= ni > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > index 9c8028d0d5..69fcbdfe0e 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > @@ -2,7 +2,7 @@ > // > // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. // (C) > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
-// > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP
> +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > +LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > @@ -308,6 +308,8 @@ > #string STR_NET_HTTP #language en-US "Http" > #string STR_NET_HTTP_U #language en-US "HttpUtilities" > #string STR_REST #language en-US "Rest" > +#string STR_REST_EX #language en-US "RestEx" > +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" >=20 > #string STR_MM_EOD #language en-US "MmEndOfDxe" > #string STR_MM_ITD #language en-US "MmIoTrapDispatch" > -- > 2.17.1