From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.4875.1603433931719607230 for ; Thu, 22 Oct 2020 23:18:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jIYO/K2G; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) IronPort-SDR: bu2EqOClFbaEts9SlLoqwIVteeFk3vgfaIT43qvb0oPVi4dEX93Rvsx85n3EiAoW1gEi+m6Vow sR/8A5O8Bwzw== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="146926024" X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="146926024" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 23:18:44 -0700 IronPort-SDR: 0il4lN/ZEH1rb3LMjY5T8R1jfwShI0x4uidOGAC5MJsojDruvavDRNWwasLass+nkOiaZX43Sl Yj2oX80AeurQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="349082594" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2020 23:18:44 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 22 Oct 2020 23:18:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 22 Oct 2020 23:18:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 22 Oct 2020 23:18:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gd0FyNTYdSwJT1YD30Prk+kNwgSDM2njvYBOmPHa4ROCckDev+o1E9U4yHhdZuHzV9jtLgxSlEGL3DVsYa6aOSIp+uuYnzehDkC7qkAWJUaiO3SxXcouSfxuwMFRRHdoxb7/CVNk5TybnTIEBOUB7ttLEGEPVkN3afk/Y3m7ejFZ/nBzjvrbwPi5TDlEf/fuXOWpqdkhqqkt/ApOeXROJLJXB31r6aVK3vEFEWft+LuXowPciMaBgqPhC9WJyTmcoBtoAfJf2KVQm0CnJqFZ/pwivYsOA7TKR0yD7kDzaFImI0XBxHUN8/xjmrzVIfibSoXuRNKJgwiPuE7jslBglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9dhV984vTHMsTnvbzxPKAZeiq7Tphq/gh1OqBPEwns=; b=fub5YjQVqW7hMAvldcwNL5DKpa9KEX3XJE9EuWMeo66U30R7hjPxfkA7tcC9iVwMr6id0dl9FefKpB/YSF6uTpzD0BvHlAY8zhryIrsUN7Z44Ljs/9OSboWQfL3z7eG1AfjPYk1Xxe3wOHSLGumgQBiKKmvR6EQjRN3V4sxcBunzfr2xPWnrC7V639TA2KEKXUx4CrLz7a4igX1+r5l8ZOrpFGLamUmSIbYOuo/ilsL8xL1z5JdK02KEksGwxU+mNpZRlMQ+yr2kurhxXdPMioDdbhpGJsTNWrwfmH+D/V+HUae5zGesIlwf/2SVpM1b0Xotr1F3Y2KFhAr2kWgiug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9dhV984vTHMsTnvbzxPKAZeiq7Tphq/gh1OqBPEwns=; b=jIYO/K2G7n8tjl7PhZgXvi0lP0uEy8ixLGxMX/a2hNqy/ew4ZTyAhxJ8LIXN+y+NJZv36/OROYWaJkJ6i1QsAgiGb5/UGc6+QhjALl/s8asj08PcErm0yysVlM711wKcYnJtmCD1DD4aNhuJXrZMHYXtbL0BHt+ZSm0ASbEeb6I= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR1101MB2207.namprd11.prod.outlook.com (2603:10b6:301:58::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 23 Oct 2020 06:18:42 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::b96a:621b:54b6:c8ea%8]) with mapi id 15.20.3477.028; Fri, 23 Oct 2020 06:18:42 +0000 From: "Gao, Zhichao" To: Leif Lindholm , "shashi.mallela@linaro.org" CC: "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT Thread-Index: AQHWnjQlDTQv03pCF0aFi8FYTS2DNqmPg6wAgAATr4CABcSeAIAPamxw Date: Fri, 23 Oct 2020 06:18:42 +0000 Message-ID: References: <20201009171718.GG5623@vanye> <6304.1602268065672852204@groups.io> <20201013103246.GI5623@vanye> In-Reply-To: <20201013103246.GI5623@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ecda6863-4472-479c-9dd9-08d8771b7d54 x-ms-traffictypediagnostic: MWHPR1101MB2207: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0Q2CuAW1ZVIYfAqQ9UDMBScMpFogFJekVwj1Azsnj3ot3AViJVuUIPM/JbWN8G+w7Xd1CcilfWSKY0DNtvBGD7W32FUVgvcLI+hGyEb/t66CeNxx0UHa53EUvd+nfpb8hVDhV24DnSLmVmfadPiM6pB4pekuGy6R8ZkNCyuUbmEbGrp1zWRcmLKVBXagXSQfeY0bLH2dL1T6zuOZ8aezmkk32+TSeTg4qgK7RY05dMs6rXp7dPJ7W5U49/o7XDbMDeSB0UgV7MILrmYwC7l6MbTzPbKHkEWO4i85e+L/XCEWvO5Usy99tRJT63R50gQmaFYyQZbAkwtI4YcMDmdTKqJ/g97umrtd2Q+ef39Iy8lQiE3sm9HGDd4rp1hnLAWx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(76116006)(66476007)(66946007)(66556008)(316002)(66446008)(7696005)(64756008)(52536014)(5660300002)(33656002)(83380400001)(9686003)(8676002)(6506007)(53546011)(54906003)(26005)(110136005)(186003)(71200400001)(86362001)(107886003)(2906002)(55016002)(478600001)(15650500001)(8936002)(4326008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NNUS29Hl/zscvjeHN2n5EnFMCThE1IvoqPMXdJOOjQskCrq10cOqncDTaMmQ9aj14RQFafRRjKLB0vAz59aAbKUhUz1yTJxSK1rl/OXyfhUNQs4afixmG1SvuBZyx3OPc8c84fl9Vjz7MmNGbCPoGe2/J+j8rxn6k0x/p2a6ksdZf6dsBuNGxHblkBzIo9PYCbJWYHlHeMtQrBuKxTv7PYfgHbKoSzyJsw4Q4bVZp1zpX/u13meTqKCnXvAwQcdU2FBDCiYXAUORqnn2bOrdO2bifAHHHRLsolg9RnvTItR+lpMXCAvk0QRhzrJ93PEgqzxT3nV+9/oztIPn/j53yvVDfxWGvAZkpETUN4F2cVy54C1YO5Q4ThioCACYCTvRm66Fb6Q0OKl5BlryXXjOpLMnoe/Gqxt7YtLdn2bctNMH3Pi07Y8js3MK2brzNTton3jk2vl+s2SG4NTgBfr2XH6/oYSIMO3fugV0/lz04AZJJv8SVkbkAOtIrx6L8DyVkshSoh5CPVNjpNauTm4Ni+lbl62S9JLrt+9uEKeuEBgt+mJBdyQe1o7UHj2gwwGXlSgr4mFigfdXaNI47ZP3v4WnpfakZqDNUxSubjz0u54z5cr4VY7CLXlk3DyqlsAA4FxdfUf/d6NbfeXFvM4Z6w== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecda6863-4472-479c-9dd9-08d8771b7d54 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 06:18:42.2375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 49xyPnvqbtXz9FNMOxWv9taONc5pQLv9flSvYuSe3fsGWQCEg77VxMtFVqL74rhXXgKdgzGW8ujMHaJzayRPzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2207 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree with you, Leif. I assume the ACPI header file to keep the table signa= ture to every version to indicate the supported table with specific ACPI ve= rsion. That's my thought, maybe the maintainer can give a formal interpreta= tion. But there is not benefit to update it in the tool because the tool is not o= nly support ACPI 6.3. We can know such table is supported since the specific version of ACPI. But= with this update, we loss the info. Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, October 13, 2020 6:33 PM > To: shashi.mallela@linaro.org > Cc: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewComman= dLib: > acpi version update for GTDT >=20 > On Fri, Oct 09, 2020 at 11:27:45 -0700, shashi.mallela@linaro.org wrote: > > Hi Lief, > > > > The macro has only been updated to reflect the latest ACPI version > > 6.3 and stay in sync with the edk2-platform gtdt updates made for sbsa > > platform > > > > based on the same ACPI version 6.3. >=20 > Which is based on 6.2, which is based on 6.1, which is based on 6.0 as pe= r my > previous email. There is no benefit to changing to a different macro that= expands > to exactly the same value. >=20 > Yes, it is a bit confusing that we apparently keep adding aliases for suc= h basic > things as signatures of standard tabled for each new release of ACPI, but= it > doesn't mean we have to add to the churn by changing unaffected code simp= ly to > "keep up". >=20 > This patch has no functional changes, and does not improve the code, so I= would > recommend the ShellPkg maintainers ignore it. >=20 > / > Leif