From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.1456.1610700555308495369 for ; Fri, 15 Jan 2021 00:49:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nkxkBQxK; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) IronPort-SDR: dsRVP0tLBpTcrfTma1qWyqcSNoUsdOQXXWZaLZDHCghvoSYIX61lwzkO3A8XnmAfrlvPBPcm/Q YZL6rpsC1tkA== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="240064932" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="240064932" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 00:49:08 -0800 IronPort-SDR: 3AXesoH8wgF1Wj0ZxUNAzyNoz8M9TKhIWxtkgxHNDaQNlR+zvYTUaaYR3B8XsOszdsCy8PGUQG L7YVd4fuon/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="352750759" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 15 Jan 2021 00:49:08 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 15 Jan 2021 00:49:08 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 15 Jan 2021 00:49:08 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 15 Jan 2021 00:49:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXCxbToND3/ANE63Wu5pU6HJr434ACjFhmd65YcmWNIx1nKyr2ee9p60Zp8yhTbJbGrdvFq21EfiQsnSgJb40CoIAZBehLPmzXRcq4MQKAqiLfR1a+dhmspvZKs1qKoA7y4DQQIym4jbx12LCtSiwVjkBRwpS1xj3WVgjpmI8TUlaoVfmWZPlv5FUz/r4iFo3VkIdkW1ziH/aU8HbkfPbhfTvVAF8uOESwOdQRQz2dMYUUpmPYFUCEjIMXourNrhZP+9WxrYNdjdV8fEsx8W7iQXd12XzdKHKLV+t2aMX5iI6f93ZpWAQTZHudJgu0pwQyXNrj6fCsdxLrlOnMZwuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y1tj9UPGujzNHfjjC5F5XN1xTP3cqoMQDg2TcnJDw18=; b=DO63BulP8i4ZqReL00fJnuYrKcr9vYjYIJ9OmBrUEnbpl6onazA4onjgKSWmWmZnOszNz8Mj5HJe//4Z5vbxB1NgFMEo7B6RxfPkecjDoNGEW+aHYXmA+6ZMiNQPdRwY5jrPrnBJbasv92+J78+B2R95RH7fKaFZ3a//9SSTwa4rTS5Px73tlu3iHY8Tmv9Ui/o0Z0jsRoVrqO/ZkBYVj6WKFDx9xajMtXGYipcHMd/7XhtbrUepT80rvDLcAY79PY1x62LFdqRqQkJzEgN4dLq1ikblA8HehPn6a54YriUVkJ65iZNUjSTZjNg8wRAuybWvCX2xJFC5sekow2i+tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y1tj9UPGujzNHfjjC5F5XN1xTP3cqoMQDg2TcnJDw18=; b=nkxkBQxK8mG3b7CZDZjerHyhSYf5bEBs0kwl/XBIKxpkI1PPJWPBW+Zz3FgD1lLFI4WVdPPcZ4lXKeAnUoNry7E/WlLCAK+xCWucRKLhmASEOpmp3frsxm1E5xBU8XxUqENXDr0ux0o8tKYt8MgGbvxIT99AlrNzzV+gy8Fa9Rs= Received: from MWHPR11MB1647.namprd11.prod.outlook.com (2603:10b6:301:d::12) by MWHPR11MB1693.namprd11.prod.outlook.com (2603:10b6:300:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 15 Jan 2021 08:49:06 +0000 Received: from MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77]) by MWHPR11MB1647.namprd11.prod.outlook.com ([fe80::c861:b9c1:b082:7c77%8]) with mapi id 15.20.3742.012; Fri, 15 Jan 2021 08:49:06 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "gechao@greatwall.com.cn" , "Wu, Hao A" , "Wang, Jian J" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow. Thread-Index: AQHW6iSitki2de4wAkWCJ8AqJv/MTaomqRNwgAG4oQA= Date: Fri, 15 Jan 2021 08:49:06 +0000 Message-ID: References: <165A05B49BF7F07B.12403@groups.io> In-Reply-To: <165A05B49BF7F07B.12403@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4aea0b06-2b20-4f66-82b2-08d8b9326ae9 x-ms-traffictypediagnostic: MWHPR11MB1693: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mKswUq3IEVNSBa9mcoD7I0kVEVL5Xg5Emp/9a6+3VN0OcxC9N4MeigKhDKr7vwttrSBOLLE0DS3PqVUbpN7USX0l4ZUv4fju00RICBBox9z7ERdDwF2KrPZOROWQr9a8XKeeaCK7mKqkFWggiDQfkxwU49WRFVsKByptm/rL+H/Bfe2panaR4+nSbqiVWy9tbBuOgqxhEcQSGYJHT8b/ZMA5/WJsw4okt50/KY5KUd4r2iG4QXuQuml8FjfpGyhqztE9T+43mRPaeMBb0T7YVDYf3sb/IPFZupoQ6gDzdYcvdPrYYHvl/yj+CbVGb8XE6sCwWAIIg846/s1y3e8sArX6wGoaQNr6mcbc97uqpv0UcwhFk1q8PWswKPSGJaUqAhJPEq9Kf/Q2UiFEEQ1Rkl89RzHF36qeIJyOg6FCm+sOWAMyZCCOSMNg2XHOD3Xn/CgM+Cnc64C/U4ADPglssA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1647.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(478600001)(53546011)(6506007)(52536014)(71200400001)(7696005)(966005)(66556008)(8936002)(64756008)(66446008)(186003)(5660300002)(66476007)(83380400001)(86362001)(9686003)(6636002)(107886003)(8676002)(66946007)(110136005)(55016002)(33656002)(76116006)(26005)(316002)(2906002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?MNTfpZd1TX+G/jPBjqTaEjGXtWWOWjpvQORIUuM/1NDMsdiwgkU38HpBiI3o?= =?us-ascii?Q?ztzBH+aPwfL5IRoEATHl/2y4yHKnLtnjnQaRy565j54pjZ/vmHaR5UxNb5UC?= =?us-ascii?Q?9TZikjcdVCQC88PLpPX8lJHkw0mfteGFRmQCXLAHChA9osiihmUf7F2ofsv5?= =?us-ascii?Q?CH6l/RvYBQXvjfWPMLJ7iphWvMjXoTjrybxSuXUZjteYcNYetAkeLsts1o9/?= =?us-ascii?Q?2Styti1IAb3vJQKfUDGvwc8IRhyVPP6vgaxAQDcg3ONOUhsifRtuM476mMYU?= =?us-ascii?Q?a/LDpdVm0YCnbo5sCc9BaM9nXG4rMkcglpRJu9rxE4ndGWoKluO2EC5zZsCm?= =?us-ascii?Q?N6uSVMS502145wpIrCaRdhstOR81Hgt3ah81J83LlHR4ZELRvJWaHSX1mWaY?= =?us-ascii?Q?Kzd6QRbp9Q9wZpFSa2EIiqORJXs75hPEMdfaVnirJorUF7pVyBJXpgdQdcPr?= =?us-ascii?Q?dJ7uUew2bFGMToPmWyj01os0f/RNvWmqY/1m8oOh81OYRdNeMvWRFOVT7/SM?= =?us-ascii?Q?fECNmxHwbxw4TP+YqdbVu4weHjdX9NJGLN/QYdXT7RVCeAYCMJPgwZTBiVw2?= =?us-ascii?Q?4YbPFt9XqDNDa6N66wsjoNeY03NgTFKnCWJj/qWGisnR+z4U+pkXrIo7ZE+Q?= =?us-ascii?Q?iRb4lP8UdL3gYRTqchtzvgkwbk/Qma/6JHHPalaJOFyV8CwCtI3NefCYEZUm?= =?us-ascii?Q?DDkFSrQzHo3CGtXtr1c6oO1LJxWZfUP8ri5Hp8MFx9J0DJvrorrap77NItAE?= =?us-ascii?Q?DlU7Uec5lq5fgjyonEKWERGMxbMB/UOcKIaa24UXg7M3UCetSUxfkzvpOhJB?= =?us-ascii?Q?Xrlj3RWRsDFURauMRiTG2JoL+vpYEpOGLeH5JbIA2fNgWuez/FC0BuAIrjq6?= =?us-ascii?Q?tB9dfMd0RLUiASJj+I7UCUTiDs604Fw74CnNHOQKWpddqfVg3OGM6nR0/j5E?= =?us-ascii?Q?m2S+yXE9gSwsTt0zqj+o+Cv4rl8FJCGyCM2OpsQXihQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1647.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aea0b06-2b20-4f66-82b2-08d8b9326ae9 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2021 08:49:06.5107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g7SjERKzcRNANkU+4n3d+gaYXNx7Q4XgBdBIQgS7lWq3cY90NGwxHTPoYXdDE3S5Y1rHfwqSlZAB/riI3q6Kkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1693 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add Hao and Jian, who have the permission to merge the patch. CI result: ht= tps://github.com/tianocore/edk2/pull/1358 Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, Zhic= hao > Sent: Thursday, January 14, 2021 2:35 PM > To: gechao@greatwall.com.cn > Cc: devel@edk2.groups.io; Ni, Ray > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe [BUG]: Termin= al > fifo buffer overflow. >=20 > There is no need to add [BUG] in the title. I would remove it when I cre= ate the PR. > If you want to have a record for this bug, you can edit a Bugzilla and a= dd the link > in the commit message. > Beside of that, Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: gechao@greatwall.com.cn > > Sent: Thursday, January 14, 2021 11:23 AM > > To: Gao, Zhichao > > Cc: devel@edk2.groups.io; Ni, Ray ; gechao > > > > Subject: [PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer > > overflow. > > > > From: gechao > > > > Fix the bug of terminal fifo buffer overflow with UINT8 type. > > > > typedef struct { > > UINT8 Head; > > UINT8 Tail; > > UINT8 Data[RAW_FIFO_MAX_NUMBER + 1]; } RAW_DATA_FIFO; > > RAW_FIFO_MAX_NUMBER is 256. > > the data buffer size is 257 (Index from 0 to 256), but the max value > > of the index, Head or Tail (UINT8), is 255. That means the last data > > of the data buffer would be always empty if we use Head/Tail to > > output/input the data correctly. And because of the incorrect buffer > > size the FIFO full check "((Tail + 1) % (RAW_FIFO_MAX_NUMBER + 1)) =3D= = =3D Head" > would never meet. > > > > Signed-off-by: gechao > > --- > > MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > index 378ace13ce..360e58e847 100644 > > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > > @@ -37,7 +37,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include -#define RAW_FIFO_MAX_NUMBER 256+#define > > RAW_FIFO_MAX_NUMBER 255 #define FIFO_MAX_NUMBER 128 typedef > > struct {-- > > 2.25.1 >=20 >=20 >=20 >=20 >=20