From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.796.1577175343962650576 for ; Tue, 24 Dec 2019 00:15:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XDc3A9On; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ethan.tsao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2019 00:15:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,350,1571727600"; d="scan'208";a="299893644" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 24 Dec 2019 00:15:43 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 00:15:42 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 00:15:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 00:15:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qq0o5tQwlxjWpxAVEj3FVwYhXpo/tqmLGRK4ZbGsAD4iCbG5D5mbix42Q4nb66opoxa0g/8KrsEL6TV9/z9JxfHYze1+ugctXcjtWgzXn48e0rDRZdtNzT4JbbdZxF14erg09KVaBu+5c4rRmRBzn4kTGgGl9CCdU1h1zybKVPWI32Iwd152Oy+KjvezWgkL+0/MfyVv1OdbNddzxc49B2VGE9FHZ8+z3qqgSHCu8jqohBzkSNxtZD/YiZRfNmrvh+eI2VBEkb+6349vSf3DWg/q6dzVSXC2hKsPKdpzz6aNxQyzokDCNhEM4UF5OXonGVxmQla9+SC3hcxd+v+fTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LN8UinslSaTq2/TS3dilcKKDEKkZ7Q51sWPZg9S1pp4=; b=gIJVTFlif/ZJaGH/lJcjkHdEhrQh1bPxGmmn3WVEb/y0hYX5YSo8e5xvK7NSz3SFLKujtf5aWvNOvQVxJVbXm01QiyleLdznDroqmdwck9CEDvfrAYYBtzoITHhDs7NfbAe5y4qjGADwaXPbY/6oZcOfL2oMvB8GWxAM2KXvflbowJFqq9awhXCK4xgNaBi+WaZF1egAH5PcfyewzeGfs7fwgh1LNNVc3F9m4bTLpKuWsKX5gYvzKb++Pb0dD2cIsJS2VyKG9vv1qsS+mfatd3Y3gZ2LiHZ4WXU8AJtAvoQGVmVZ4EbyKLlTILEKEOFVZfM68eKRQV61J+eWLEqD0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LN8UinslSaTq2/TS3dilcKKDEKkZ7Q51sWPZg9S1pp4=; b=XDc3A9OnLoD+OZgWZVJashxuJdA9xz+yt+SCYO78pAwY+abfHe/abRmlUweUw3L4PjejnsnooqaIvg7OmmPCy3BG2HI9/SkVqXLPyxmIprDfKJekmniHZ+yhNBt/wb1h+DFiGSkDd+YCzdWQpXr8KFqgoviRjsSrdUx7hVtIr/E= Received: from MWHPR11MB1662.namprd11.prod.outlook.com (10.172.55.15) by MWHPR11MB2013.namprd11.prod.outlook.com (10.169.234.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.14; Tue, 24 Dec 2019 08:15:27 +0000 Received: from MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::4125:6819:8819:2f1e]) by MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::4125:6819:8819:2f1e%7]) with mapi id 15.20.2559.017; Tue, 24 Dec 2019 08:15:26 +0000 From: "Ethan Tsao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [Patch v2] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h Thread-Topic: [Patch v2] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h Thread-Index: AQHVuWp4hbHv2czQVk2u4Pb975noGKfIhOtwgABr4hA= Date: Tue, 24 Dec 2019 08:15:26 +0000 Message-ID: References: <20191223082449.23912-1-ethan.tsao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3A9C88@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3A9C88@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODRmM2NiZjktZWNmYS00ZjdiLWFmNjAtZjcyMDc5ZWNmZmRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1AwOVNQYkl0ZUpISnBEemEwbHpZOEEzV2F2XC9pdU95R1JqU041bkk2VzJ3KzF3NXN1RHd6NCtIbllMWjVlN0oifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=ethan.tsao@intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae32b6e7-8aa5-4a5d-3408-08d788496ed9 x-ms-traffictypediagnostic: MWHPR11MB2013: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0261CCEEDF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39860400002)(136003)(366004)(376002)(346002)(199004)(189003)(13464003)(110136005)(4326008)(8676002)(81156014)(33656002)(55016002)(9686003)(478600001)(8936002)(107886003)(81166006)(316002)(86362001)(5660300002)(64756008)(66446008)(52536014)(71200400001)(2906002)(76116006)(186003)(26005)(7696005)(66476007)(66946007)(66556008)(53546011)(6506007);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB2013;H:MWHPR11MB1662.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1UshRNeR9tmdT2fsetyVYJMgm0tq0m49UU8IEMY7DK7S+1KZxN8kbCSTfg0nkkcy1KR8CDWI7nv48WC5X+lr4oNeV4672DPZVYyjhaK2nHWfQW0n5OCR+z6o2Ufze9Rov7zD5xMZWzKLSUeji7pDLvGg09LKYy9TYVAblPNQZIpmatp7q4P5NEWMmiVk/qKSBniyriKCgH/gexvG5XGFreX/iRCMJw3JQxKYOazFxU5LXgbYQFVINw4naeI9mPxlDrw8q+hJOmLK1OlobuUWbiSgQNIxcbrNwdAgLWmFGQaun34TLIXHedyHztoOH3dYA2MSXgS6yjjEkwvcvH/qjvhRpL16apz3WnR5BGKaWH11X5G1ZPcbWbU1Ii5/yIKn2KbViyXJR2qEkkYOCicuT0hPZ7GEv2mBrKih1Bsxxc9563Z0aTB5JXGnbC2l+CHmAbHTM21RIOjXsId3Zbgaj4L9jrn7MIFTuAGl1MFZReXJmmxBV1RdUnTC0d8tvupSK7Lat/2Bhj59BNDTHB/b3E1eTSg5xiMqocT7Lbwnvnc= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ae32b6e7-8aa5-4a5d-3408-08d788496ed9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2019 08:15:26.7274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dYt/1X86Sz51KbAAIyr9EMKnV2POLUeIHk7UvQ5TjgGO7EzQmSQkuN6kUrBo2w9fxBfhrOcSSSZHiYhLLof5mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2013 Return-Path: ethan.tsao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, ConfigBlockLib consume the data structure from ConfigBlock.h. Which is loca= ted in KabylakeSiliconPkg and CoffeelakeSiliconPkg. Should we copy them to = IntelSiliconPkg as well and delete? Best Regards, Ethan > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, December 24, 2019 10:04 AM > To: Tsao, Ethan ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [Patch v2] IntelSiliconPkg/Include/Library:Add ConfigBlockLi= b.h >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Tsao, Ethan > > Sent: Monday, December 23, 2019 4:25 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Chaganty, Rangasai V > > > > Subject: [Patch v2] IntelSiliconPkg/Include/Library:Add > > ConfigBlockLib.h > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2318 > > > > Create header for BaseConfigBlockLib in InstelSiliconPkg and remove > > all other ConfigBlock.h > > > > Signed-off-by: Ethan Tsao > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > --- > > Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc = | > > 2 +- > > Silicon/Intel/{CoffeelakeSiliconPkg =3D> > > IntelSiliconPkg}/Include/Library/ConfigBlockLib.h | 0 > > Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > > | 64 ---------------------------------------------------------------- > > 3 files changed, 1 insertion(+), 65 deletions(-) > > > > diff --git > > a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > > b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > > index 37c77d8f63..702a833cc4 100644 > > --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > > @@ -147,7 +147,7 @@ > > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0 > > # Silicon Init Common Library > > # > > !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc > > - > > ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > ConfigBlockLib|lock > > Lib.inf > > +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > +ConfigBlockLib|lock > > Lib.inf > > > > PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/Bas > > PchTraceHubInitLib|ePc > > hTraceHubInitLib.inf > > > > [LibraryClasses.IA32] > > diff --git > > a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > similarity index 100% > > rename from > > Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/ConfigBlockLib.h > > rename to > > Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > > deleted file mode 100644 > > index 04c8ec5cca..0000000000 > > --- > > a/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ /dev/null > > @@ -1,64 +0,0 @@ > > -/** @file > > - Header file for Config Block Lib implementation > > - > > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#ifndef _CONFIG_BLOCK_LIB_H_ > > -#define _CONFIG_BLOCK_LIB_H_ > > - > > -/** > > - Create config block table > > - > > - @param[in] TotalSize - Max size to be allocat= ed for the Config > > Block Table > > - @param[out] ConfigBlockTableAddress - On return, points to a= pointer > > to the beginning of Config Block Table Address > > - > > - @retval EFI_INVALID_PARAMETER - Invalid Parameter > > - @retval EFI_OUT_OF_RESOURCES - Out of resources > > - @retval EFI_SUCCESS - Successfully created Config Block Ta= ble at > > ConfigBlockTableAddress > > -**/ > > -EFI_STATUS > > -EFIAPI > > -CreateConfigBlockTable ( > > - IN UINT16 TotalSize, > > - OUT VOID **ConfigBlockTableAddress > > - ); > > - > > -/** > > - Add config block into config block table structure > > - > > - @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > > Config Block Table Address > > - @param[out] ConfigBlockAddress - On return, points to a= pointer to > > the beginning of Config Block Address > > - > > - @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and > > cannot add new Config Block or > > - Config Block Offset Table is full and= cannot add new Config > > Block. > > - @retval EFI_SUCCESS - Successfully added Config Block > > -**/ > > -EFI_STATUS > > -EFIAPI > > -AddConfigBlock ( > > - IN VOID *ConfigBlockTableAddress, > > - OUT VOID **ConfigBlockAddress > > - ); > > - > > -/** > > - Retrieve a specific Config Block data by GUID > > - > > - @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > - @param[in] ConfigBlockGuid - A pointer to the GUID= uses to > > search specific Config Block > > - @param[out] ConfigBlockAddress - On return, points to = a pointer to > > the beginning of Config Block Address > > - > > - @retval EFI_NOT_FOUND - Could not find the Config Block > > - @retval EFI_SUCCESS - Config Block found and return > > -**/ > > -EFI_STATUS > > -EFIAPI > > -GetConfigBlock ( > > - IN VOID *ConfigBlockTableAddress, > > - IN EFI_GUID *ConfigBlockGuid, > > - OUT VOID **ConfigBlockAddress > > - ); > > - > > -#endif // _CONFIG_BLOCK_LIB_H_ > > -- > > 2.16.2.windows.1 >=20