From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.1492.1573114456818755455 for ; Thu, 07 Nov 2019 00:14:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=zTD010En; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ethan.tsao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 00:14:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,277,1569308400"; d="scan'208";a="206085718" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 07 Nov 2019 00:14:15 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 00:14:15 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 00:14:14 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 00:14:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HE69bdYpwNMmwqg1waNYDjH/B8URvCljFXN4YpfFE9m5xvK7M6vIZuRmoE/gwD/G7PHwccspqJFZmMDaju/ovk5DEnP4OoTM7LR6wgRtKiTKH2c2drRVar/56bPk1NGYhQqPUzIJPCVzwgGnEWM6KM0Q/9ZOW4EgE6Nu8BWiI8CaeJ6Kkj1ISft/27FfIJkWifbxMELfePLJoFHsCw0oPoHfvoA1Tk1RNF3uvVnAG6deCEkBQRDYJClidtw6KYZgrqXNAavjyv/Iw21IG0f/wny7LbaUxrsOP7b9jiCEOSKkwVDBtNaoYqa3vm61B6ZfXNSsC5lejiQy8qh2vuFFnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=abCoLEMBi00w6NcGSA5URJbpCZgVF3f3vrZ97zFhpmk=; b=QIShT4AxyyT8KLSEdvhHf7qnw1ziaxqqzLpIayyeXqptEbghQk6rACfoP/XrnkYWY3Gbahns4n1U1vxp68FgoSGhT7BBfQMKnYti5imECYdt10j6Nv6d04lZYAQdRJiL445aaKwuvqrn0zRG+fYjBoeRzzBT6Io5UckLtAzQXFpj5ozoPYOxBKOBzIkri2ZYcZJ4yzhxDwX4D6Yeutm4kz05EzN9A3RtywKDw3TFi7pzugt4KW9zLoFyR0au991uKVqWUx9Py3pxzc2wbRtx5nTpLG4EnGS0wOgSyAnJC7fFU8eC8Ys8NjwmG0xE0zY0EmJGfyRlLqISSrEDR3rfag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=abCoLEMBi00w6NcGSA5URJbpCZgVF3f3vrZ97zFhpmk=; b=zTD010EnWWYamVx/dg6XOyytMU01zOosRDxWGWUqenW/utbCVgeSBPfyGj6voXPTTYz78mln5lmxex0vIQIOHVDIwf0Tk8dJwz60bddFNMZsQXe1rWMV/KrQh6IWdgfQqmham/xw182iSxx5u0XjZ4TxXkTLkUI9rMDVrHIZnSM= Received: from MWHPR11MB1662.namprd11.prod.outlook.com (10.172.55.15) by MWHPR11MB1872.namprd11.prod.outlook.com (10.175.54.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 08:14:13 +0000 Received: from MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::c3:2ae9:b8a4:e407]) by MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::c3:2ae9:b8a4:e407%9]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 08:14:13 +0000 From: "Ethan Tsao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Library Thread-Topic: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Library Thread-Index: AQHVlRvJrFzkKZUq1EqIXhOFe7+FQKd/SHjggAATvAA= Date: Thu, 7 Nov 2019 08:14:13 +0000 Message-ID: References: <20191107033058.180-1-ethan.tsao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C352F1D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C352F1D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTZjZDA1N2UtMjYzNC00ZWEwLWE1YmItMWVkNmNmY2RmYzhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQURWaFlySkZMdzBqRGRpZWVuYTY5T1BRVHd0aGlXbGI2cHUzZDdJcmlLMENJMFwvSWw0SGtCUnNqOXJYZDlrdnkifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=ethan.tsao@intel.com; x-originating-ip: [192.55.79.116] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c410a568-f658-4934-5c3d-08d7635a7998 x-ms-traffictypediagnostic: MWHPR11MB1872: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(136003)(39860400002)(376002)(396003)(189003)(199004)(13464003)(71200400001)(6306002)(6116002)(52536014)(3846002)(446003)(186003)(102836004)(2906002)(5660300002)(256004)(11346002)(229853002)(66066001)(26005)(71190400001)(66946007)(74316002)(9686003)(6246003)(305945005)(486006)(476003)(33656002)(7736002)(76116006)(64756008)(110136005)(55016002)(14454004)(107886003)(316002)(6436002)(86362001)(66476007)(14444005)(81156014)(81166006)(76176011)(8936002)(99286004)(53546011)(2501003)(25786009)(4326008)(66556008)(7696005)(30864003)(66446008)(8676002)(6506007)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB1872;H:MWHPR11MB1662.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OYaOkzLTLG+0890QMO8O5NrC/XSUXgplaikp21CWG71qRjhneGGPvK0USRHhd83e3TgIydAz4SyRngP21XirWDNt9iuapT5X1vBNgId3QS6AD5amfScOHdyLTHQriMJjbiJPRi6Ta/r3W8y3EVtTGCwPdoe34CGz/LPkFhykvTsSKoiWIMz2pVfH2icTAS82TPXpwea4oCQ6SlbbF981lGjFqxuGLZREu1ZZ7SN/N5SZ4tF/3ptytVhrdjbOcTLDV4EJsKmAfss4ArH2u6oJccSDusBrxvugyOdU2tqgV7L2hwMbm5q1MqX1le0d3514uZ4rktthSpt2ND/ehAZtujc/Wgzh9d7/gYxUzg+OkvahaBIfJFGb7ySZeV0qxdf/sv5RgGabatDOKqLGvdUuxlqfPLmyql1bYd+IoYhU7dzWWqA/0QUl6yBLaUw/siq6 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c410a568-f658-4934-5c3d-08d7635a7998 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 08:14:13.3689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lZz0Xl1cCs+1kpeg5qDTvRH+4mywLYiD51MG31EdD9qITstlde7iLILEt8kJVwDzfx3yI3BQqckfTQ75UTWnqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1872 Return-Path: ethan.tsao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Thanks your good input. I just review all debug message and most print is f= or error report purpose, such as allocate memory failure,...etc. >>From my opinion, this kind debug message is useful for BIOS when unexpected= error happen. In normal case, it will not be print. Best Regards, Ethan > -----Original Message----- > From: Ni, Ray > Sent: Thursday, November 7, 2019 3:15 PM > To: Tsao, Ethan ; edk2-devel@lists.01.org > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Libra= ry >=20 > Given the patch only moves the code from one place to another, I am ok wi= th > that. >=20 > By the way, is it still valuable to have so many debug messages everywher= e in > this library? > If no, can we remove them or at least some of them? >=20 > Debug messages are valuable I agree. But we also need to think about prod= ucing > helpful debug messages, not treated by platform developers as noise : ) >=20 >=20 > > -----Original Message----- > > From: Tsao, Ethan > > Sent: Thursday, November 7, 2019 11:31 AM > > To: edk2-devel@lists.01.org > > Cc: Chaganty, Rangasai V ; Ni, Ray > > > > Subject: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib > > Library > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2318 > > > > Establish one copy of Config blocks library class and instance in > > IntelSiliconPkg and remove copies from other silicon packages , like > > KabyLakeSiliconPkg, CoffelakeSiliconPkg. > > > > Signed-off-by: Ethan Tsao > > Cc: Sai Chaganty > > Cc: Ray Ni > > --- > > > > Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseConfi= gBlo > > ckLib.c | 146 ------------------------------------= ----------------------------- > - > > ---------------------------------------------------------------------- > > ---------- > > > > Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseConfi= gBlo > > ckLib.inf | 29 ----------------------------- > > Silicon/Intel/{KabylakeSiliconPkg =3D> > > IntelSiliconPkg}/Library/BaseConfigBlockLib/BaseConfigBlockLib.c | = 0 > > Silicon/Intel/{KabylakeSiliconPkg =3D> > > IntelSiliconPkg}/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf | = 0 > > 4 files changed, 175 deletions(-) > > > > diff --git > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfigB > > lockLib.c > > b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfig > > BlockLib.c > > deleted file mode 100644 > > index 369dab97ee..0000000000 > > --- > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfigB > > lockLib.c > > +++ /dev/null > > @@ -1,146 +0,0 @@ > > -/** @file > > - Library functions for Config Block management. > > - > > - Copyright (c) 2019 Intel Corporation. All rights reserved.
> > - > > - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ > > - > > -#include > > -#include > > -#include > > -#include -#include > > > > - > > -/** > > - Create config block table > > - > > - @param[in] TotalSize - Max size to be allocat= ed for the Config > > Block Table > > - @param[out] ConfigBlockTableAddress - On return, points to a= pointer > > to the beginning of Config Block Table Address > > - > > - @retval EFI_INVALID_PARAMETER - Invalid Parameter > > - @retval EFI_OUT_OF_RESOURCES - Out of resources > > - @retval EFI_SUCCESS - Successfully created Config Block Ta= ble at > > ConfigBlockTableAddress > > -**/ > > -EFI_STATUS > > -EFIAPI > > -CreateConfigBlockTable ( > > - IN UINT16 TotalSize, > > - OUT VOID **ConfigBlockTableAddress > > - ) > > -{ > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > - UINT32 ConfigBlkTblHdrSize; > > - > > - ConfigBlkTblHdrSize =3D (UINT32)(sizeof (CONFIG_BLOCK_TABLE_HEADER))= ; > > - > > - if (TotalSize <=3D (ConfigBlkTblHdrSize + sizeof (CONFIG_BLOCK_HEADE= R))) { > > - DEBUG ((DEBUG_ERROR, "Invalid Parameter\n")); > > - return EFI_INVALID_PARAMETER; > > - } > > - > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER *)AllocateZeroPoo= l > > (TotalSize); > > - if (ConfigBlkTblAddrPtr =3D=3D NULL) { > > - DEBUG ((DEBUG_ERROR, "Could not allocate memory.\n")); > > - return EFI_OUT_OF_RESOURCES; > > - } > > - ConfigBlkTblAddrPtr->NumberOfBlocks =3D 0; > > - ConfigBlkTblAddrPtr->Header.GuidHob.Header.HobLength =3D TotalSize; > > - ConfigBlkTblAddrPtr->AvailableSize =3D TotalSize - > > ConfigBlkTblHdrSize; > > - > > - *ConfigBlockTableAddress =3D (VOID *)ConfigBlkTblAddrPtr; > > - > > - return EFI_SUCCESS; > > -} > > - > > -/** > > - Add config block into config block table structure > > - > > - @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > > Config Block Table Address > > - @param[out] ConfigBlockAddress - On return, points to a= pointer to > > the beginning of Config Block Address > > - > > - @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and > > cannot add new Config Block or > > - Config Block Offset Table is full and= cannot add new Config > > Block. > > - @retval EFI_SUCCESS - Successfully added Config Block > > -**/ > > -EFI_STATUS > > -EFIAPI > > -AddConfigBlock ( > > - IN VOID *ConfigBlockTableAddress, > > - OUT VOID **ConfigBlockAddress > > - ) > > -{ > > - CONFIG_BLOCK *TempConfigBlk; > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > - CONFIG_BLOCK *ConfigBlkAddrPtr; > > - UINT16 ConfigBlkSize; > > - > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER > > *)ConfigBlockTableAddress; > > - ConfigBlkAddrPtr =3D (CONFIG_BLOCK *)(*ConfigBlockAddress); > > - ConfigBlkSize =3D ConfigBlkAddrPtr->Header.GuidHob.Header.HobLength; > > - DEBUG ((DEBUG_INFO, "Config Block GUID: %g / Config Block Size: > > 0x%x bytes\n", &(ConfigBlkAddrPtr->Header.GuidHob.Name), > > ConfigBlkSize)); > > - if ((ConfigBlkSize % 4) !=3D 0) { > > - DEBUG ((DEBUG_ERROR, "Config Block must be multiples of 4 bytes\n"= )); > > - return EFI_INVALID_PARAMETER; > > - } > > - if (ConfigBlkTblAddrPtr->AvailableSize < ConfigBlkSize) { > > - DEBUG ((DEBUG_ERROR, "Config Block Table is full and cannot add ne= w > > Config Block.\n")); > > - DEBUG ((DEBUG_ERROR, "Available Config Block Size: 0x%x bytes / > > Requested Config Block Size: 0x%x bytes\n", ConfigBlkTblAddrPtr- > > >AvailableSize, ConfigBlkSize)); > > - return EFI_OUT_OF_RESOURCES; > > - } > > - > > - TempConfigBlk =3D (CONFIG_BLOCK *)((UINTN)ConfigBlkTblAddrPtr + > > (UINTN)(ConfigBlkTblAddrPtr->Header.GuidHob.Header.HobLength - > > ConfigBlkTblAddrPtr->AvailableSize)); > > - CopyMem (&TempConfigBlk->Header, &ConfigBlkAddrPtr->Header, > > sizeof(CONFIG_BLOCK_HEADER)); > > - > > - ConfigBlkTblAddrPtr->NumberOfBlocks++; > > - ConfigBlkTblAddrPtr->AvailableSize =3D > > ConfigBlkTblAddrPtr->AvailableSize - ConfigBlkSize; > > - > > - *ConfigBlockAddress =3D (VOID *) TempConfigBlk; > > - DEBUG ((DEBUG_INFO, "Config Block Address: 0x%x / Available Config > > Block Size: 0x%x bytes\n", (UINT32)(UINTN)*ConfigBlockAddress, > > ConfigBlkTblAddrPtr->AvailableSize)); > > - return EFI_SUCCESS; > > -} > > - > > -/** > > - Retrieve a specific Config Block data by GUID > > - > > - @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > - @param[in] ConfigBlockGuid - A pointer to the GUID= uses to > > search specific Config Block > > - @param[out] ConfigBlockAddress - On return, points to = a pointer to > > the beginning of Config Block Address > > - > > - @retval EFI_NOT_FOUND - Could not find the Config Block > > - @retval EFI_SUCCESS - Config Block found and return > > -**/ > > -EFI_STATUS > > -EFIAPI > > -GetConfigBlock ( > > - IN VOID *ConfigBlockTableAddress, > > - IN EFI_GUID *ConfigBlockGuid, > > - OUT VOID **ConfigBlockAddress > > - ) > > -{ > > - UINT16 OffsetIndex; > > - CONFIG_BLOCK *TempConfigBlk; > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > - UINT32 ConfigBlkTblHdrSize; > > - UINT32 ConfigBlkOffset; > > - UINT16 NumOfBlocks; > > - > > - ConfigBlkTblHdrSize =3D (UINT32)(sizeof (CONFIG_BLOCK_TABLE_HEADER))= ; > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER > > *)ConfigBlockTableAddress; > > - NumOfBlocks =3D ConfigBlkTblAddrPtr->NumberOfBlocks; > > - > > - ConfigBlkOffset =3D 0; > > - for (OffsetIndex =3D 0; OffsetIndex < NumOfBlocks; OffsetIndex++) { > > - if ((ConfigBlkTblHdrSize + ConfigBlkOffset) > (ConfigBlkTblAddrPtr= - > > >Header.GuidHob.Header.HobLength)) { > > - break; > > - } > > - TempConfigBlk =3D (CONFIG_BLOCK *)((UINTN)ConfigBlkTblAddrPtr + > > (UINTN)ConfigBlkTblHdrSize + (UINTN)ConfigBlkOffset); > > - if (CompareGuid (&(TempConfigBlk->Header.GuidHob.Name), > > ConfigBlockGuid)) { > > - *ConfigBlockAddress =3D (VOID *)TempConfigBlk; > > - return EFI_SUCCESS; > > - } > > - ConfigBlkOffset =3D ConfigBlkOffset + TempConfigBlk- > > >Header.GuidHob.Header.HobLength; > > - } > > - DEBUG ((DEBUG_ERROR, "Could not find the config block.\n")); > > - return EFI_NOT_FOUND; > > -} > > diff --git > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfigB > > lockLib.inf > > b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfig > > BlockLib.inf > > deleted file mode 100644 > > index a7def2481d..0000000000 > > --- > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > nfigB > > lockLib.inf > > +++ /dev/null > > @@ -1,29 +0,0 @@ > > -## @file > > -# Component INF file for the BaseConfigBlock library. > > -# > > -# Copyright (c) 2019 Intel Corporation. All rights reserved.
-# > > -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -## > > - > > -[Defines] > > -INF_VERSION =3D 0x00010017 > > -BASE_NAME =3D BaseConfigBlockLib > > -FILE_GUID =3D 1EC07EA8-7808-4e06-9D79-309AE331D2D5 > > -VERSION_STRING =3D 1.0 > > -MODULE_TYPE =3D BASE > > -LIBRARY_CLASS =3D ConfigBlockLib > > - > > - > > -[Packages] > > -MdePkg/MdePkg.dec > > -CoffeelakeSiliconPkg/SiPkg.dec > > - > > -[Sources] > > -BaseConfigBlockLib.c > > - > > -[LibraryClasses] > > -DebugLib > > -BaseMemoryLib > > -MemoryAllocationLib > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseConf > > igBlo > > ckLib.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > similarity index 100% > > rename from > > Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseConfig > > Block > > Lib.c > > rename to > > Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo > > ckLib.c > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseConf > > igBlo > > ckLib.inf > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.inf > > similarity index 100% > > rename from > > Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseConfig > > Block > > Lib.inf > > rename to > > Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo > > ckLib.i > > nf > > -- > > 2.16.2.windows.1 >=20