From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.6543.1573197436003694219 for ; Thu, 07 Nov 2019 23:17:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=PKyen5Fr; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ethan.tsao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 23:17:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,280,1569308400"; d="scan'208";a="201629238" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga007.fm.intel.com with ESMTP; 07 Nov 2019 23:17:15 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 23:17:14 -0800 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 23:17:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOP04Y0BFLNvln49fXUhydZHqGKDnLQNcnPa9yT+7yPZV2ErrFEeMExVhzs9pUrOnPD/IJuLHgdB/W3KkNgZnDvVNioXo15cGNEdtQQS0wvJtyE72gK2WSde5CmzC1RfF+nljRoHjOqiFO73sZMruReBF1/BP8z779bRanSJte8/i9kqPGt46XDmMCcZ5dQJohtR729cz9MUAc8BikWtUaQDQCyDNlrViqXqn2UUrjcfSlRNxlTp5FZ8UMGHZCR1iCddy5qQ4GTdWsSsYg5HEkpBn8yhTx3TlH9z+xhYgjxOP1XoUaF5mkwC/ZbX1rbiwqKJPq1MLVW8ynBXeYZVsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIUvNIJe9tOaKFhAOmqDfWh0/n8CSGdbwXYTDGt92BU=; b=ASE96428/GZycsCIOGc8iWYHfnRmm6REvOVkXcj2EzSeBuN4wMK+Q6Ie/5G1/qM4hnuj9BwfrowLv2n/z40rqIK1gQetGzfYa0m6vSZ3UaE0UA0aJizub1LE/UtUbxaypcDmiWnrqaxuPDfeskDnJgnzTs3sV8EClXtOBbkWiAsQ6b6nwCtS4lPItcfYCqcMF5Pmffs52jKKKcy5Kv0v8lLL/EPSGpJFkUW2VLv5esil3tRMgEZNcprCLNipMnPkWCrM8HboivkesEUTEk/2FR4cTTVTJIqb5PwsrQ3BRg9tDLL1rlTypHg1vVZrxEMApC+scaqVD+4Nsl0dJWd9RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIUvNIJe9tOaKFhAOmqDfWh0/n8CSGdbwXYTDGt92BU=; b=PKyen5Frlm2JA0YT+hFzkAqMN87V8/UaLGtv8vtyRyWgLCdqdtOVO2/A/NksfuDesJEmfGjPqLiKWRtk2m7Wj+LJaPwQSeri1TP0L9GodW+kbvNTtu+KiaKNCbbtPRQYVAHuQSBxd+CF2M0dgyTJUrx/Tv1SDGhbsL0JNuu4eRU= Received: from MWHPR11MB1662.namprd11.prod.outlook.com (10.172.55.15) by MWHPR11MB0029.namprd11.prod.outlook.com (10.164.204.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.24; Fri, 8 Nov 2019 07:17:12 +0000 Received: from MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::c3:2ae9:b8a4:e407]) by MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::c3:2ae9:b8a4:e407%9]) with mapi id 15.20.2430.020; Fri, 8 Nov 2019 07:17:12 +0000 From: "Ethan Tsao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Library Thread-Topic: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Library Thread-Index: AQHVlRvJrFzkKZUq1EqIXhOFe7+FQKd/SHjggAATvACAAXHBIIAADxbQ Date: Fri, 8 Nov 2019 07:17:11 +0000 Message-ID: References: <20191107033058.180-1-ethan.tsao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C352F1D@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C354EC3@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C354EC3@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODBlMTk2MmUtZjU5Yi00YzMxLWE2ZGMtNjZkYjA1NGVlOWI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaURhK0Y4ekJcL3pJZW5lSzFmMHNEeHRVdXFoZmQ0VUNQZ0F4bUlrT3FZUGVTXC9nR241eW5UaVhiMDFMMFYyRnBhIn0= dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=ethan.tsao@intel.com; x-originating-ip: [192.55.79.113] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff89dca9-15fc-4a12-ef9f-08d7641bacca x-ms-traffictypediagnostic: MWHPR11MB0029: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0215D7173F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(39860400002)(376002)(396003)(136003)(366004)(13464003)(199004)(189003)(186003)(30864003)(6246003)(446003)(7696005)(107886003)(6506007)(26005)(33656002)(478600001)(11346002)(74316002)(476003)(66066001)(486006)(2906002)(8936002)(102836004)(53546011)(14454004)(2501003)(8676002)(81156014)(81166006)(66476007)(6116002)(25786009)(229853002)(99286004)(66556008)(64756008)(66446008)(76116006)(71190400001)(71200400001)(76176011)(7736002)(52536014)(256004)(14444005)(3846002)(6436002)(9686003)(110136005)(305945005)(66946007)(316002)(55016002)(4326008)(86362001)(6306002)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB0029;H:MWHPR11MB1662.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MHNhDmlkhFJeuHV27ovHM6BBVrFI7QXHm0v+Y7SYNK1NwuKJ28jCHEbvfj50Z1OVXjXvWGjCC9ypNFwI/Q/bLeMPF28zj3cm54XB7opKEtvyRnmVmeVZNFSFpU9S/X2jc9pwnIiekH/r1n0kPn+byvqmk0q3FL1imwWNpL8PrmUJsNahvLRRAKbZN1IUqR87CmXomntfb0ZOZWoujC0w8ZgeUqp8Lchwi8Dwc50zhrGF6J8FbgMBPLMrDYis96TgSPtMru33EQOw8gkFf0946lNsb++c0b/ArHXlTHelyjCb/xLnTqOBUMjHXMg4ipDobu4iUUdmjfVYKCRRKlsm1AJ+A19c74aK8iy/aaKid1wDkuOsGoaW2KcFltJ5oa6AnEQ8OjTXOUQVqdRW2CBgme7pqnc0aVDx7h9oiQ104mPmEW/AriRcU5WN3uUBS2og MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ff89dca9-15fc-4a12-ef9f-08d7641bacca X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 07:17:12.0270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 12kULZN0vqJhwX37u9voI3mPXmzHoeNWsz6Wz6rzT/wAk94X/YKE426I6D/y3maVuoReu57T+CLVnlIEKPKfzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 Return-Path: ethan.tsao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, I do agree with you. I will remove all debug message since all error scenar= io can be cover by return status. Caller can understanding through return status. Best Regards, Ethan > -----Original Message----- > From: Ni, Ray > Sent: Friday, November 8, 2019 2:25 PM > To: Tsao, Ethan ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib Libra= ry >=20 > Ethan, > What if all of the debug message are removed? > Library especially very fundamental like ConfigBlock is better to be quit= e. > It's the ConfigBlock API designer's responsibility to ensure the error is= returned > properly to caller, otherwise it's the API's bug. > When the API can return correct status out, it's caller's responsibility = to check > the status and do proper handling of the errors. >=20 > With the debug message added in this fundamental library, it may give cal= lers > wrong impression that the library itself can handle the error and callers= don't > need to check the error status. >=20 > If we search code in MdePkg, quite few debug messages are printed out fro= m > library code. >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: Tsao, Ethan > > Sent: Thursday, November 7, 2019 4:14 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Chaganty, Rangasai V > > Subject: RE: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib > > Library > > > > Hi Ray, > > Thanks your good input. I just review all debug message and most print > > is for error report purpose, such as allocate memory failure,...etc. > > From my opinion, this kind debug message is useful for BIOS when > > unexpected error happen. In normal case, it will not be print. > > > > Best Regards, > > Ethan > > > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Thursday, November 7, 2019 3:15 PM > > > To: Tsao, Ethan ; edk2-devel@lists.01.org > > > Cc: Chaganty, Rangasai V > > > Subject: RE: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib > > > Library > > > > > > Given the patch only moves the code from one place to another, I am > > > ok > > with > > > that. > > > > > > By the way, is it still valuable to have so many debug messages > > > everywhere > > in > > > this library? > > > If no, can we remove them or at least some of them? > > > > > > Debug messages are valuable I agree. But we also need to think about > > producing > > > helpful debug messages, not treated by platform developers as noise > > > : ) > > > > > > > > > > -----Original Message----- > > > > From: Tsao, Ethan > > > > Sent: Thursday, November 7, 2019 11:31 AM > > > > To: edk2-devel@lists.01.org > > > > Cc: Chaganty, Rangasai V ; Ni, Ray > > > > > > > > Subject: [PATCH] IntelSiliconPkg/Library:Add BaseConfigBlockLib > > > > Library > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2318 > > > > > > > > Establish one copy of Config blocks library class and instance in > > > > IntelSiliconPkg and remove copies from other silicon packages , > > > > like KabyLakeSiliconPkg, CoffelakeSiliconPkg. > > > > > > > > Signed-off-by: Ethan Tsao > > > > Cc: Sai Chaganty > > > > Cc: Ray Ni > > > > --- > > > > > > > > > > Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseConf > > igBlo > > > > ckLib.c | 146 --------------------------------= ----------------------------- > > ---- > > > - > > > > ------------------------------------------------------------------ > > > > ---- > > > > ---------- > > > > > > > > > > Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/BaseConf > > igBlo > > > > ckLib.inf | 29 ----------------------------- > > > > Silicon/Intel/{KabylakeSiliconPkg =3D> > > > > IntelSiliconPkg}/Library/BaseConfigBlockLib/BaseConfigBlockLib.c = | 0 > > > > Silicon/Intel/{KabylakeSiliconPkg =3D> > > > > IntelSiliconPkg}/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf = | 0 > > > > 4 files changed, 175 deletions(-) > > > > > > > > diff --git > > > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfigB > > > > lockLib.c > > > > b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfig > > > > BlockLib.c > > > > deleted file mode 100644 > > > > index 369dab97ee..0000000000 > > > > --- > > > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfigB > > > > lockLib.c > > > > +++ /dev/null > > > > @@ -1,146 +0,0 @@ > > > > -/** @file > > > > - Library functions for Config Block management. > > > > - > > > > - Copyright (c) 2019 Intel Corporation. All rights reserved.
> > > > - > > > > - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ > > > > - > > > > -#include > > > > -#include -#include > > > > -#include > > > > -#include > > > > - > > > > -/** > > > > - Create config block table > > > > - > > > > - @param[in] TotalSize - Max size to be all= ocated for the > > Config > > > > Block Table > > > > - @param[out] ConfigBlockTableAddress - On return, points = to a > > pointer > > > > to the beginning of Config Block Table Address > > > > - > > > > - @retval EFI_INVALID_PARAMETER - Invalid Parameter > > > > - @retval EFI_OUT_OF_RESOURCES - Out of resources > > > > - @retval EFI_SUCCESS - Successfully created Config Bloc= k Table at > > > > ConfigBlockTableAddress > > > > -**/ > > > > -EFI_STATUS > > > > -EFIAPI > > > > -CreateConfigBlockTable ( > > > > - IN UINT16 TotalSize, > > > > - OUT VOID **ConfigBlockTableAddress > > > > - ) > > > > -{ > > > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > > > - UINT32 ConfigBlkTblHdrSize; > > > > - > > > > - ConfigBlkTblHdrSize =3D (UINT32)(sizeof > > (CONFIG_BLOCK_TABLE_HEADER)); > > > > - > > > > - if (TotalSize <=3D (ConfigBlkTblHdrSize + sizeof > > (CONFIG_BLOCK_HEADER))) { > > > > - DEBUG ((DEBUG_ERROR, "Invalid Parameter\n")); > > > > - return EFI_INVALID_PARAMETER; > > > > - } > > > > - > > > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER > > *)AllocateZeroPool > > > > (TotalSize); > > > > - if (ConfigBlkTblAddrPtr =3D=3D NULL) { > > > > - DEBUG ((DEBUG_ERROR, "Could not allocate memory.\n")); > > > > - return EFI_OUT_OF_RESOURCES; > > > > - } > > > > - ConfigBlkTblAddrPtr->NumberOfBlocks =3D 0; > > > > - ConfigBlkTblAddrPtr->Header.GuidHob.Header.HobLength =3D > > > > TotalSize; > > > > - ConfigBlkTblAddrPtr->AvailableSize =3D TotalSize - > > > > ConfigBlkTblHdrSize; > > > > - > > > > - *ConfigBlockTableAddress =3D (VOID *)ConfigBlkTblAddrPtr; > > > > - > > > > - return EFI_SUCCESS; > > > > -} > > > > - > > > > -/** > > > > - Add config block into config block table structure > > > > - > > > > - @param[in] ConfigBlockTableAddress - A pointer to the b= eginning > > of > > > > Config Block Table Address > > > > - @param[out] ConfigBlockAddress - On return, points = to a pointer > > to > > > > the beginning of Config Block Address > > > > - > > > > - @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and > > > > cannot add new Config Block or > > > > - Config Block Offset Table is full= and cannot add new > > Config > > > > Block. > > > > - @retval EFI_SUCCESS - Successfully added Config Block > > > > -**/ > > > > -EFI_STATUS > > > > -EFIAPI > > > > -AddConfigBlock ( > > > > - IN VOID *ConfigBlockTableAddress, > > > > - OUT VOID **ConfigBlockAddress > > > > - ) > > > > -{ > > > > - CONFIG_BLOCK *TempConfigBlk; > > > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > > > - CONFIG_BLOCK *ConfigBlkAddrPtr; > > > > - UINT16 ConfigBlkSize; > > > > - > > > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER > > > > *)ConfigBlockTableAddress; > > > > - ConfigBlkAddrPtr =3D (CONFIG_BLOCK *)(*ConfigBlockAddress); > > > > - ConfigBlkSize =3D > > > > ConfigBlkAddrPtr->Header.GuidHob.Header.HobLength; > > > > - DEBUG ((DEBUG_INFO, "Config Block GUID: %g / Config Block Size: > > > > 0x%x bytes\n", &(ConfigBlkAddrPtr->Header.GuidHob.Name), > > > > ConfigBlkSize)); > > > > - if ((ConfigBlkSize % 4) !=3D 0) { > > > > - DEBUG ((DEBUG_ERROR, "Config Block must be multiples of 4 > > bytes\n")); > > > > - return EFI_INVALID_PARAMETER; > > > > - } > > > > - if (ConfigBlkTblAddrPtr->AvailableSize < ConfigBlkSize) { > > > > - DEBUG ((DEBUG_ERROR, "Config Block Table is full and cannot ad= d > > new > > > > Config Block.\n")); > > > > - DEBUG ((DEBUG_ERROR, "Available Config Block Size: 0x%x bytes = / > > > > Requested Config Block Size: 0x%x bytes\n", ConfigBlkTblAddrPtr- > > > > >AvailableSize, ConfigBlkSize)); > > > > - return EFI_OUT_OF_RESOURCES; > > > > - } > > > > - > > > > - TempConfigBlk =3D (CONFIG_BLOCK *)((UINTN)ConfigBlkTblAddrPtr + > > > > (UINTN)(ConfigBlkTblAddrPtr->Header.GuidHob.Header.HobLength - > > > > ConfigBlkTblAddrPtr->AvailableSize)); > > > > - CopyMem (&TempConfigBlk->Header, &ConfigBlkAddrPtr->Header, > > > > sizeof(CONFIG_BLOCK_HEADER)); > > > > - > > > > - ConfigBlkTblAddrPtr->NumberOfBlocks++; > > > > - ConfigBlkTblAddrPtr->AvailableSize =3D > > > > ConfigBlkTblAddrPtr->AvailableSize - ConfigBlkSize; > > > > - > > > > - *ConfigBlockAddress =3D (VOID *) TempConfigBlk; > > > > - DEBUG ((DEBUG_INFO, "Config Block Address: 0x%x / Available > > > > Config Block Size: 0x%x bytes\n", > > > > (UINT32)(UINTN)*ConfigBlockAddress, > > > > ConfigBlkTblAddrPtr->AvailableSize)); > > > > - return EFI_SUCCESS; > > > > -} > > > > - > > > > -/** > > > > - Retrieve a specific Config Block data by GUID > > > > - > > > > - @param[in] ConfigBlockTableAddress - A pointer to the = beginning > > of > > > > Config Block Table Address > > > > - @param[in] ConfigBlockGuid - A pointer to the = GUID uses to > > > > search specific Config Block > > > > - @param[out] ConfigBlockAddress - On return, points= to a > > pointer to > > > > the beginning of Config Block Address > > > > - > > > > - @retval EFI_NOT_FOUND - Could not find the Config Block > > > > - @retval EFI_SUCCESS - Config Block found and return > > > > -**/ > > > > -EFI_STATUS > > > > -EFIAPI > > > > -GetConfigBlock ( > > > > - IN VOID *ConfigBlockTableAddress, > > > > - IN EFI_GUID *ConfigBlockGuid, > > > > - OUT VOID **ConfigBlockAddress > > > > - ) > > > > -{ > > > > - UINT16 OffsetIndex; > > > > - CONFIG_BLOCK *TempConfigBlk; > > > > - CONFIG_BLOCK_TABLE_HEADER *ConfigBlkTblAddrPtr; > > > > - UINT32 ConfigBlkTblHdrSize; > > > > - UINT32 ConfigBlkOffset; > > > > - UINT16 NumOfBlocks; > > > > - > > > > - ConfigBlkTblHdrSize =3D (UINT32)(sizeof > > (CONFIG_BLOCK_TABLE_HEADER)); > > > > - ConfigBlkTblAddrPtr =3D (CONFIG_BLOCK_TABLE_HEADER > > > > *)ConfigBlockTableAddress; > > > > - NumOfBlocks =3D ConfigBlkTblAddrPtr->NumberOfBlocks; > > > > - > > > > - ConfigBlkOffset =3D 0; > > > > - for (OffsetIndex =3D 0; OffsetIndex < NumOfBlocks; OffsetIndex++= ) { > > > > - if ((ConfigBlkTblHdrSize + ConfigBlkOffset) > (ConfigBlkTblAdd= rPtr- > > > > >Header.GuidHob.Header.HobLength)) { > > > > - break; > > > > - } > > > > - TempConfigBlk =3D (CONFIG_BLOCK *)((UINTN)ConfigBlkTblAddrPtr = + > > > > (UINTN)ConfigBlkTblHdrSize + (UINTN)ConfigBlkOffset); > > > > - if (CompareGuid (&(TempConfigBlk->Header.GuidHob.Name), > > > > ConfigBlockGuid)) { > > > > - *ConfigBlockAddress =3D (VOID *)TempConfigBlk; > > > > - return EFI_SUCCESS; > > > > - } > > > > - ConfigBlkOffset =3D ConfigBlkOffset + TempConfigBlk- > > > > >Header.GuidHob.Header.HobLength; > > > > - } > > > > - DEBUG ((DEBUG_ERROR, "Could not find the config block.\n")); > > > > - return EFI_NOT_FOUND; > > > > -} > > > > diff --git > > > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfigB > > > > lockLib.inf > > > > b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfig > > > > BlockLib.inf > > > > deleted file mode 100644 > > > > index a7def2481d..0000000000 > > > > --- > > > > a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseConfigBlockLib/Ba > > > > seCo > > > > nfigB > > > > lockLib.inf > > > > +++ /dev/null > > > > @@ -1,29 +0,0 @@ > > > > -## @file > > > > -# Component INF file for the BaseConfigBlock library. > > > > -# > > > > -# Copyright (c) 2019 Intel Corporation. All rights reserved.
> > > > -# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -## > > > > - > > > > -[Defines] > > > > -INF_VERSION =3D 0x00010017 > > > > -BASE_NAME =3D BaseConfigBlockLib > > > > -FILE_GUID =3D 1EC07EA8-7808-4e06-9D79-309AE331D2D5 > > > > -VERSION_STRING =3D 1.0 > > > > -MODULE_TYPE =3D BASE > > > > -LIBRARY_CLASS =3D ConfigBlockLib > > > > - > > > > - > > > > -[Packages] > > > > -MdePkg/MdePkg.dec > > > > -CoffeelakeSiliconPkg/SiPkg.dec > > > > - > > > > -[Sources] > > > > -BaseConfigBlockLib.c > > > > - > > > > -[LibraryClasses] > > > > -DebugLib > > > > -BaseMemoryLib > > > > -MemoryAllocationLib > > > > diff --git > > > > a/Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/Base > > > > Conf > > > > igBlo > > > > ckLib.c > > > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseCon > > > > figB > > > > lockLi > > > > b.c > > > > similarity index 100% > > > > rename from > > > > Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > > > nfig > > > > Block > > > > Lib.c > > > > rename to > > > > Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > > > gBlo > > > > ckLib.c > > > > diff --git > > > > a/Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/Base > > > > Conf > > > > igBlo > > > > ckLib.inf > > > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseCon > > > > figB > > > > lockLi > > > > b.inf > > > > similarity index 100% > > > > rename from > > > > Silicon/Intel/KabylakeSiliconPkg/Library/BaseConfigBlockLib/BaseCo > > > > nfig > > > > Block > > > > Lib.inf > > > > rename to > > > > Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > > > > gBlo > > > > ckLib.i > > > > nf > > > > -- > > > > 2.16.2.windows.1 > > > > > >=20