From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.1247.1577181157819776948 for ; Tue, 24 Dec 2019 01:52:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=T0fbtMaO; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ethan.tsao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2019 01:52:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,351,1571727600"; d="scan'208";a="214140825" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 24 Dec 2019 01:52:37 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 01:52:37 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 01:52:36 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Dec 2019 01:52:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYfl2dllVznUM90laJfrW6bbhDnBv+XQ5zV/DuM8TMPAbGX9rid8putrZsoAaAmumVlTrtj4GUWkSx5v3yWw6Qqi6WMzmZOmx9lKNb06oO8mGZ64lDgCBiYLlILMZtjBK46M7QSohU9pk3CkvqpnFPnpJ/1E5bXyV/67zrIGtSpy++VfsDGKoX3zALqCUThCMrCbPFg4kn31hhgRkpN1UeRFQSNcrjJwxXtdlHK8Oq+JXxHktdRlSHV9Sf1fxiL62HSjT+InLhQmoYPnXVKSn/jUv0KGG5XAYgCJiHcZjiv2fyrD06ZezBGaUUaNtF3bPo2oseKrggz8hViM7QnU1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppdCvxOSqN5ytChJCPausfU6oxv2YYofdG/lUmDDPGc=; b=iwAKxcYhhSQJk4dWW0i4ifVQlLVrqwK3TwLBlIoUX8DBltgdaoFcu7HeWyyiUw5Y3thNLbYC5I/rla0s1YK1v3QwsBA/gzooxaHS7V2/YkwC8rm7EtzhJZtPN3qryyFFs2R3/Yhw7y0VoGelSx9lQshAqx5kDk4HZe3KH5N7vRy/XEUpCcnETDQJwuAjNpGWvVoIvSg4m/EUsyO7V/OAy/TqwFDJBR5FwYge+Ai5zIaYeH4zrrTYiHKoAiF5/FNjtPhv7IE3jcu+P4FmfO7gMrQIswg2Uw+Iw44y61PiJTLpLWtbdhVT7+g8xNDGdMecBlajFM38z9Z5P9kXGGa4NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppdCvxOSqN5ytChJCPausfU6oxv2YYofdG/lUmDDPGc=; b=T0fbtMaOe1fR+XS8CBGbFwjiEjwn/cdLEos1odJ2ZbTmRM+PXvjG0Aljh/AcRqpk+0+b10gE3Aak10dBfReweRig1p/KQuKWW6NwcbbtQf/lIOIJKSyaTcPmAbBwMiTsmoypnllvKyzJsR3X6acDSaSN8HX3r5oXd1YgvtIZqf0= Received: from MWHPR11MB1662.namprd11.prod.outlook.com (10.172.55.15) by MWHPR11MB1725.namprd11.prod.outlook.com (10.169.237.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Tue, 24 Dec 2019 09:52:08 +0000 Received: from MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::4125:6819:8819:2f1e]) by MWHPR11MB1662.namprd11.prod.outlook.com ([fe80::4125:6819:8819:2f1e%7]) with mapi id 15.20.2559.017; Tue, 24 Dec 2019 09:52:08 +0000 From: "Ethan Tsao" To: "devel@edk2.groups.io" , "Tsao, Ethan" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [Patch V3] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h Thread-Topic: [edk2-devel] [Patch V3] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h Thread-Index: AQHVuj4Qnh4n7xqIyUWwRVWOPuMj/KfJCjlA Date: Tue, 24 Dec 2019 09:52:08 +0000 Message-ID: References: <15E345288A3960F7.22537@groups.io> In-Reply-To: <15E345288A3960F7.22537@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTdhODQzM2QtZmNiYS00MzczLTlmYzItNTYzNGE2NDIxZDM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGlROEtYakNvRnhwSkRJcHowc0xMOVVOS25Ed0xRNnlmaHlIeVZBbDZ0eFc4bFVTREltT1h4SGpwZlQrZzFMaCJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=ethan.tsao@intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4af62fb4-989a-48b8-5524-08d78856f0b3 x-ms-traffictypediagnostic: MWHPR11MB1725: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0261CCEEDF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39860400002)(396003)(376002)(346002)(136003)(199004)(189003)(13464003)(316002)(5660300002)(2906002)(52536014)(54906003)(110136005)(71200400001)(4326008)(107886003)(966005)(81156014)(81166006)(8936002)(55016002)(9686003)(33656002)(7696005)(66476007)(66946007)(66556008)(64756008)(66446008)(76116006)(26005)(86362001)(8676002)(478600001)(186003)(6506007)(53546011);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB1725;H:MWHPR11MB1662.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e6UyR8114z2arT5foFWgu5+k9G0jsmRzMOY4kbyqpwG6RSe6o1pmEgFg8HdK1wmlrrvX52f6czvlm+CnvOMiEdyF7lVmUOroFKbM/KyS/YEONF8efKnQfVZFDhr7c/GCwgI2GU2TAU8ntHLqlvo6b7U58OK9vGsJdW4IVJ1RiE2iwyZNj8yKQjeFfj0y9nuESVUWLUMScza86qqb4lH0oulOCu3EHOTqBWDuztf7VVlEeSW/C9tF0pE9eri3r4BB3vLM2dpJCzkRiyLtVeh8oVaDPRoE+pofs++Crvok3Fo3SBvH3PwEVbMCKDRnsvY4NR6LpKxbP66+hJK8Z2o8wSzw4MaTzuxQmZuLB0CIE2wZtCYiVxuST7FQU5+MHwbYA50vFph1gAUMEFHYmOuGFtv/INXgsI/YB2iZTF3ofVLnAhnlPj5xKucQUKNyR9UYcYVBnydnHKO5lPqRNqLz8jKD7rNGtBZ0JOQhkX6kkHNVp6ZiygzKH6g2I6hytfQN1e2hWFy/7QpYk9EKlWDg+Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4af62fb4-989a-48b8-5524-08d78856f0b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2019 09:52:08.0415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SL+nSWC5noWLsbwl0PoFSwHOeWg6r2WXyn0+M0R+6AA7idXTlzaSzXS8Npn7pRJztGCASLjQt1kMzPUGY1c0Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1725 Return-Path: ethan.tsao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray and Sai, I found some issues during integration and then update patch. Please help to review again. Best Regards, Ethan > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ethan Tsa= o > Sent: Tuesday, December 24, 2019 5:39 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel] [Patch V3] IntelSiliconPkg/Include/Library:Add > ConfigBlockLib.h >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2318 >=20 > Move ConfigBlockLib.h and ConfigBlock.h to InstelSiliconPkg and remove a= ll > other ConfigBlockLib.h and ConfigBlock.h >=20 > Signed-off-by: Ethan Tsao > Cc: Ray Ni > Cc: Rangasai V Chaganty > --- > Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc = | 2 > +- > Silicon/Intel/{CoffeelakeSiliconPkg =3D> IntelSiliconPkg}/Include/Confi= gBlock.h > | 0 > Silicon/Intel/{CoffeelakeSiliconPkg =3D> > IntelSiliconPkg}/Include/Library/ConfigBlockLib.h | 0 > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = | 4 ++++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = | 1 + > Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBloc= kLib.inf > | 2 +- > Silicon/Intel/KabylakeSiliconPkg/Include/ConfigBlock.h = | 53 - > ---------------------------------------------------- > Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h = | > 64 ---------------------------------------------------------------- > 8 files changed, 7 insertions(+), 119 deletions(-) >=20 > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > index 37c77d8f63..702a833cc4 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc > @@ -147,7 +147,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0 > # Silicon Init Common Library > # > !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc > -ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBl > -ConfigBlockLib|ockLib.inf > +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo > +ConfigBlockLib|ckLib.inf >=20 > PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/BaseP= chTr > aceHubInitLib.inf >=20 > [LibraryClasses.IA32] > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/ConfigBlock.h > b/Silicon/Intel/IntelSiliconPkg/Include/ConfigBlock.h > similarity index 100% > rename from Silicon/Intel/CoffeelakeSiliconPkg/Include/ConfigBlock.h > rename to Silicon/Intel/IntelSiliconPkg/Include/ConfigBlock.h > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/ConfigBl= ockLib.h > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > similarity index 100% > rename from > Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/ConfigBlockLib.h > rename to Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index 22ebf19c4e..aad39f88ee 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -30,6 +30,10 @@ > # > PeiGetVtdPmrAlignmentLib|Include/Library/PeiGetVtdPmrAlignmentLib.h >=20 > + ## @libraryclass Provides services to access ConfigBlock # > + ConfigBlockLib|Include/Library/ConfigBlockLib.h > + > [Guids] > ## GUID for Package token space > # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735} > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > index 0a6509d8b3..d90202d0f3 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc > @@ -36,6 +36,7 @@ >=20 > MicrocodeFlashAccessLib|IntelSiliconPkg/Feature/Capsule/Library/Microcod= eFl > ashAccessLibNull/MicrocodeFlashAccessLibNull.inf >=20 > PeiGetVtdPmrAlignmentLib|IntelSiliconPkg/Library/PeiGetVtdPmrAlignmentLi= b/P > eiGetVtdPmrAlignmentLib.inf >=20 > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmM > easurementLibNull.inf > + > + ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBl > + ockLib.inf >=20 > [LibraryClasses.common.PEIM] > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLib.i > nf > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLib.i > nf > index 37b4faaf65..87e7e315b7 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo= ckLib.i > nf > +++ b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfi > +++ gBlockLib.inf > @@ -18,7 +18,7 @@ LIBRARY_CLASS =3D ConfigBlockLib >=20 > [Packages] > MdePkg/MdePkg.dec > -KabylakeSiliconPkg/SiPkg.dec > +IntelSiliconPkg/IntelSiliconPkg.dec >=20 > [Sources] > BaseConfigBlockLib.c > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Include/ConfigBlock.h > b/Silicon/Intel/KabylakeSiliconPkg/Include/ConfigBlock.h > deleted file mode 100644 > index dd91a55e79..0000000000 > --- a/Silicon/Intel/KabylakeSiliconPkg/Include/ConfigBlock.h > +++ /dev/null > @@ -1,53 +0,0 @@ > -/** @file > - Header file for Config Block Lib implementation > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _CONFIG_BLOCK_H_ > -#define _CONFIG_BLOCK_H_ > - > -#include > -#include > -#include > -#include > - > -#pragma pack (push,1) > - > -/// > -/// Config Block Header > -/// > -typedef struct _CONFIG_BLOCK_HEADER { > - EFI_HOB_GUID_TYPE GuidHob; ///< Offset 0-23 GUI= D extension > HOB header > - UINT8 Revision; ///< Offset 24 Rev= ision of this config block > - UINT8 Attributes; ///< Offset 25 The= main revision for config > block > - UINT8 Reserved[2]; ///< Offset 26-27 Res= erved for future use > -} CONFIG_BLOCK_HEADER; > - > -/// > -/// Config Block > -/// > -typedef struct _CONFIG_BLOCK { > - CONFIG_BLOCK_HEADER Header; ///< Offset 0-27 Hea= der of > config block > - // > - // Config Block Data > - // > -} CONFIG_BLOCK; > - > -/// > -/// Config Block Table Header > -/// > -typedef struct _CONFIG_BLOCK_TABLE_STRUCT { > - CONFIG_BLOCK_HEADER Header; ///< Offset 0-27 GUI= D number > for main entry of config block > - UINT8 Rsvd0[2]; ///< Offset 28-29 Res= erved for future use > - UINT16 NumberOfBlocks; ///< Offset 30-31 Num= ber of config > blocks (N) > - UINT32 AvailableSize; ///< Offset 32-35 Cur= rent config block > table size > -/// > -/// Individual Config Block Structures are added here in memory as part= of > AddConfigBlock() -/// -} CONFIG_BLOCK_TABLE_HEADER; -#pragma pack (pop) > - > -#endif // _CONFIG_BLOCK_H_ > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBloc= kLib.h > b/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > deleted file mode 100644 > index 04c8ec5cca..0000000000 > --- a/Silicon/Intel/KabylakeSiliconPkg/Include/Library/ConfigBlockLib.h > +++ /dev/null > @@ -1,64 +0,0 @@ > -/** @file > - Header file for Config Block Lib implementation > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _CONFIG_BLOCK_LIB_H_ > -#define _CONFIG_BLOCK_LIB_H_ > - > -/** > - Create config block table > - > - @param[in] TotalSize - Max size to be allocate= d for the Config > Block Table > - @param[out] ConfigBlockTableAddress - On return, points to a = pointer to > the beginning of Config Block Table Address > - > - @retval EFI_INVALID_PARAMETER - Invalid Parameter > - @retval EFI_OUT_OF_RESOURCES - Out of resources > - @retval EFI_SUCCESS - Successfully created Config Block Tab= le at > ConfigBlockTableAddress > -**/ > -EFI_STATUS > -EFIAPI > -CreateConfigBlockTable ( > - IN UINT16 TotalSize, > - OUT VOID **ConfigBlockTableAddress > - ); > - > -/** > - Add config block into config block table structure > - > - @param[in] ConfigBlockTableAddress - A pointer to the beginn= ing of > Config Block Table Address > - @param[out] ConfigBlockAddress - On return, points to a = pointer to > the beginning of Config Block Address > - > - @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and cannot = add > new Config Block or > - Config Block Offset Table is full and = cannot add new Config > Block. > - @retval EFI_SUCCESS - Successfully added Config Block > -**/ > -EFI_STATUS > -EFIAPI > -AddConfigBlock ( > - IN VOID *ConfigBlockTableAddress, > - OUT VOID **ConfigBlockAddress > - ); > - > -/** > - Retrieve a specific Config Block data by GUID > - > - @param[in] ConfigBlockTableAddress - A pointer to the begin= ning of > Config Block Table Address > - @param[in] ConfigBlockGuid - A pointer to the GUID = uses to search > specific Config Block > - @param[out] ConfigBlockAddress - On return, points to a= pointer to > the beginning of Config Block Address > - > - @retval EFI_NOT_FOUND - Could not find the Config Block > - @retval EFI_SUCCESS - Config Block found and return > -**/ > -EFI_STATUS > -EFIAPI > -GetConfigBlock ( > - IN VOID *ConfigBlockTableAddress, > - IN EFI_GUID *ConfigBlockGuid, > - OUT VOID **ConfigBlockAddress > - ); > - > -#endif // _CONFIG_BLOCK_LIB_H_ > -- > 2.16.2.windows.1 >=20 >=20 >=20