From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.5399.1602655136228087325 for ; Tue, 13 Oct 2020 22:58:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BE7PgKDy; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: Svb9CoqcP0zLVH1LGY4pboOWvkg36oV5Jjj/EO3shyWo4EGufO6ZR8f8RY6PeaC2pPg4jYH3DD S+GkdUpReCNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="145356327" X-IronPort-AV: E=Sophos;i="5.77,373,1596524400"; d="scan'208";a="145356327" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 22:58:55 -0700 IronPort-SDR: gAU+g+N/24/DUFOdxSkjsxAsx8XFsj7R1uQA11AMRe2qaxBl6A6cbQDp0SDIvOQx9lTCG/TQz5 mvLiattDze5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,373,1596524400"; d="scan'208";a="299830913" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 13 Oct 2020 22:58:55 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 13 Oct 2020 22:58:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 13 Oct 2020 22:58:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 13 Oct 2020 22:58:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCXj0HA5IXOr8lYarhQd89vHUj4UEF4BEd5e1uQvLymXz4yv07kihz9BWkfiB+Ph5YQzghcAPu5FKHcspcKNAGkpZq8iinVoyu4DHz7K0DZwu+OBgBnunZgrB/TbqNE8XLq6Xx2VHdpqM1O/zkzFz6YCzrEmSnLQmYR3g7WDXA1gBtwSpGdZc4GqqCCo/YKgk707tQCWNXYjX40qUEhCorVaM1+0ONf33KYqSgCmciRSzpoxQCq51/9W9uSDKTNeXXElGUK91rigwaeR+VFi2JcfKRVd1VQGNHmcaGz4peoFbqFhF8AKpQP4FlvCBqtVBUwE0FqbLnr+L6Mz1Sq3xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=274q1KTSFHJbALvRjljZc4jDlNc05Mx355OkyQX3hTE=; b=MAumq+PjDXhsNp5rBp9tYK2DtQftbW6oPUHtTqbLUc14AsLuMHKpN38UyUuxbkFjTrQzQj65p1T6xAwxqfGv7Cju3X9qJQDMO0sQFDHFAhQUytvOHVoGn5HvFxS3DjtBvZ+UAkzqnZXUgZ2uibFlTuqmmbn9MJO5DWYv5Wue9fIx6MYMBRCwO7PUWRGJfrC2LGzr39ht+F03rAk5B9EhSlvsW08nctMCey0l5A5OrXJD8qK4BEYQM4lltZAA5w1w4fnLiDj4sW2wE37BhsdkH5t03cnZqVFfF2xdO0w4lCJCvvkpLuBrScp7UkNwuXWnTgq8dJu88j0R1/kAS3MlQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=274q1KTSFHJbALvRjljZc4jDlNc05Mx355OkyQX3hTE=; b=BE7PgKDyvIrw5cF7euHFSTGe29+d/soNx7uEz4LoN+HtsMM5TrzGt0qJxEImZYfMWjBH/gZ1r04h4z7TkdtU4LoMlGTrl6g5ww5o2zMTtpe1tsX9F7GklZ9n1hJKW/77I9sZomZBbhXx9pth6TpW153OghQkmtrMieIkm9o1MdA= Received: from MWHPR11MB1696.namprd11.prod.outlook.com (2603:10b6:300:23::23) by MWHPR11MB1933.namprd11.prod.outlook.com (2603:10b6:300:110::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Wed, 14 Oct 2020 05:58:53 +0000 Received: from MWHPR11MB1696.namprd11.prod.outlook.com ([fe80::449a:93eb:c6d1:ce0f]) by MWHPR11MB1696.namprd11.prod.outlook.com ([fe80::449a:93eb:c6d1:ce0f%2]) with mapi id 15.20.3455.032; Wed, 14 Oct 2020 05:58:53 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Ni, Ray" , "Gao, Zhichao" CC: "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Thread-Index: AQHWoGiRMeaxTTE+pUyFWxkrcgulnqmU122AgAHFvtA= Date: Wed, 14 Oct 2020 05:58:52 +0000 Message-ID: References: <20201012072230.46152-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9142f48f-b025-4e7e-1e1f-08d870063ad5 x-ms-traffictypediagnostic: MWHPR11MB1933: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:489; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3sDk3vTL1/wwQ+CSICAIO0P54YO8I+5keRy1GDNmTsXgmwm6t8dfdjRQ5PgS3OSFfZRVQLBTaGMAn47KTUcNi44b40ougzfah0vsxqsyxFphZPvocVlB4b1MBTsxFfd2pZEsxe3z3VkKCBHO3zV8JLCVDkngzTxmHcCK8UDzRkm2BOPbaVG0F48ezhr8c9TFi8l7VSrUomAQ2TdyGipbGG5ryF2vkKpAQ5EQNjvdwdbdHZinYU3xkhwkWV7muSTjLnBy2QQVhJGhJ32snQGOfR7BhX5t1ulCdzxgjEacJcCxEM/T72AdHCCkTwmtnqJkq25oBxcsOJgNNCcHG58tMy4PDkE3MI74yRelWTlmgOns/IYEI2j745VRnuPy6fG0YOgm265IdrMeJsx9gtWa8Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(107886003)(64756008)(66446008)(76116006)(478600001)(66946007)(2906002)(7696005)(4326008)(86362001)(966005)(52536014)(71200400001)(55016002)(83380400001)(26005)(83080400001)(186003)(33656002)(6506007)(53546011)(9686003)(110136005)(66556008)(8676002)(66476007)(316002)(8936002)(6636002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ZlZ5rCmWahpBZJbYVbREoFat1ioAP8MZN5nRglSGrrxgzW6L+yFIwAtwPogHVv36ZE4lRBaqkGQLoSgVgOTCmqy5xOcbBKTWUCGKqWNCH3eMvl/C1s4mAxhyQ1Q/sGZ3bzX3TVhLRjq3z4cVgfHQ2y3PhGOEXcDVd5Xl0ZYSCmtrL9exMjgzxHw3vABJUK36nfoDCY4iovVzYtyDWgnhK2wQoH2VDItZVX3vhCVkYMwg0oxyrTSM4nlEMExS/RAv0HmHihN3ILRVykJVyYe5DuQ/WlJAiOogwiOpxLsrz7vy8aJyJnHoHmSFUDbPAv1pbjELNBuM5n4FRT0pC1t7y6oWNmVOSdFLzqmIfh6kskat96LuzpM1MDER135Kp+aa6Qg1CkStlfuUyGFUmPxjATqhUeompGZ47f1IO95+j/ep/XAwOtLsl7KW4qtU/1aytzInXsmHrSb1bGr1B0uuDXpM+X8Ysnonk2onA110xrzxEhNwbmEhBGu+aX3jTMQiknJkhRyB8WxoNAHWn46d+XbnxA0IKyq9titRew/lnqs7QsWgiqxSmZQmPKOiFCHcU9ayGXdb+ejcLQJjXXOOGmuyltOJsBzIkdb1GQGqgi8pb8MRX1vfgoomS6HsT17kOsx+sSltDpllEULEDAxvsw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9142f48f-b025-4e7e-1e1f-08d870063ad5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 05:58:53.0136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lwn4r8dg2p4jnEMGCv78EiM93zY+OdxcVxrZv6t4bsW3+z2Ixj/27vTZu0Wxjs1c+bBOaTByYLZUwmY1wF/9LA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1933 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Could you help merge this patch? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Tuesday, October 13, 2020 10:54 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wu, Hao A > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the > child handler blocksize change >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Monday, October 12, 2020 3:23 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Wu, Hao A > > Subject: [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler > > blocksize change > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2843 > > > > Revert the patch to change the block size in child handler. It would > > block the CD (Eltorito) Hard disk media type's sub partition being > > observed. > > The blocksize patch used to fix the CD image's MBR table issue. The CD > > MBR table would always be ignored because it would be handled by the > > Eltorito partition handler first and never go into the MBR handler. So > > directly revert it. > > > > Cc: Ray Ni > > Cc: Hao A Wu > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 12 > > +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > index f10ce7c65b..473e091320 100644 > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > @@ -1149,8 +1149,8 @@ PartitionInstallChildHandle ( > > > > Private->Signature =3D PARTITION_PRIVATE_DATA_SIGNATURE; > > > > - Private->Start =3D MultU64x32 (Start, BlockSize); > > - Private->End =3D MultU64x32 (End + 1, BlockSize); > > + Private->Start =3D MultU64x32 (Start, ParentBlockIo->Med= ia- > >BlockSize); > > + Private->End =3D MultU64x32 (End + 1, ParentBlockIo->M= edia- > >BlockSize); > > > > Private->BlockSize =3D BlockSize; > > Private->ParentBlockIo =3D ParentBlockIo; > > @@ -1187,7 +1187,13 @@ PartitionInstallChildHandle ( > > > > Private->Media.IoAlign =3D 0; > > Private->Media.LogicalPartition =3D TRUE; > > - Private->Media.LastBlock =3D End - Start; > > + Private->Media.LastBlock =3D DivU64x32 ( > > + MultU64x32 ( > > + End - Start + 1, > > + ParentBlockIo->Media->BlockSize > > + ), > > + BlockSize > > + ) - 1; > > > > Private->Media.BlockSize =3D (UINT32) BlockSize; > > > > -- > > 2.21.0.windows.1 >=20 >=20 >=20 >=20 >=20