* [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 @ 2023-01-31 5:45 Chen, Aryeh 2023-01-31 7:31 ` [edk2-devel] " Ard Biesheuvel 2023-01-31 19:00 ` Ankit Sinha 0 siblings, 2 replies; 5+ messages in thread From: Chen, Aryeh @ 2023-01-31 5:45 UTC (permalink / raw) To: devel Cc: Aryeh Chen, Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong From: Aryeh Chen <aryeh.chen@intel.com> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to \_SB.PC00 since Client ADL platform. Signed-off-by: Aryeh Chen <aryeh.chen@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Isaac Oram <isaac.w.oram@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Eric Dong <eric.dong@intel.com> --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ 3 files changed, 8 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl index 4efb8709ac..b7361b6d44 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl @@ -23,7 +23,11 @@ DefinitionBlock ( //--------------------------------------------------------------------------- // Begin PCI tree object scope //--------------------------------------------------------------------------- +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 + Device(PC00) { // PCI Bridge "Host Bridge" +#else Device(PCI0) { // PCI Bridge "Host Bridge" +#endif Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID Name(_SEG, 0) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf index 3437bc489c..b3b45039cc 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf @@ -40,6 +40,7 @@ [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 [Depex] gEfiAcpiTableProtocolGuid AND diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec index e6f714b181..68a76db4de 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -139,6 +139,9 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 + # The PCD controls MinDsdt PciBridge + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00010057 + # # FADT Duty Offset - The zero-based index of where the processor's duty cycle # setting is within the processor's P_CNT register. -- 2.26.2.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 2023-01-31 5:45 [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 Chen, Aryeh @ 2023-01-31 7:31 ` Ard Biesheuvel 2023-01-31 7:46 ` Chen, Aryeh 2023-01-31 19:00 ` Ankit Sinha 1 sibling, 1 reply; 5+ messages in thread From: Ard Biesheuvel @ 2023-01-31 7:31 UTC (permalink / raw) To: devel, aryeh.chen Cc: Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao, Eric Dong On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh <aryeh.chen@intel.com> wrote: > > From: Aryeh Chen <aryeh.chen@intel.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > on MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL platform. > > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Eric Dong <eric.dong@intel.com> Why is this needed? > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 4efb8709ac..b7361b6d44 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -23,7 +23,11 @@ DefinitionBlock ( > //--------------------------------------------------------------------------- > // Begin PCI tree object scope > //--------------------------------------------------------------------------- > +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 > + Device(PC00) { // PCI Bridge "Host Bridge" > +#else > Device(PCI0) { // PCI Bridge "Host Bridge" > +#endif > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > Name(_SEG, 0) > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > index 3437bc489c..b3b45039cc 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > @@ -40,6 +40,7 @@ > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 > > [Depex] > gEfiAcpiTableProtocolGuid AND > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..68a76db4de 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -139,6 +139,9 @@ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 > > + # The PCD controls MinDsdt PciBridge > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00010057 > + > # > # FADT Duty Offset - The zero-based index of where the processor's duty cycle > # setting is within the processor's P_CNT register. > -- > 2.26.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#99338): https://edk2.groups.io/g/devel/message/99338 > Mute This Topic: https://groups.io/mt/96647478/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 2023-01-31 7:31 ` [edk2-devel] " Ard Biesheuvel @ 2023-01-31 7:46 ` Chen, Aryeh 2023-01-31 12:55 ` Ard Biesheuvel 0 siblings, 1 reply; 5+ messages in thread From: Chen, Aryeh @ 2023-01-31 7:46 UTC (permalink / raw) To: Ard Biesheuvel, devel@edk2.groups.io Cc: Chiu, Chasel, Desimone, Nathaniel L, Oram, Isaac W, Gao, Liming, Dong, Eric Hi Biesheuvel, The platform which before ADL, like TGL uses \_SB.PCI0, but ADL and later uses \_SB.PC00. Minplatform should support all platform and Pcd PcdMinPciBridgePC00 can set on OpenBoard.dsc for PCI0 or PC00. Thanks, Aryeh -----Original Message----- From: Ard Biesheuvel <ardb@kernel.org> Sent: Tuesday, January 31, 2023 3:32 PM To: devel@edk2.groups.io; Chen, Aryeh <aryeh.chen@intel.com> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh <aryeh.chen@intel.com> wrote: > > From: Aryeh Chen <aryeh.chen@intel.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on > MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL platform. > > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Eric Dong <eric.dong@intel.com> Why is this needed? > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 4efb8709ac..b7361b6d44 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -23,7 +23,11 @@ DefinitionBlock ( > //--------------------------------------------------------------------------- > // Begin PCI tree object scope > > //-------------------------------------------------------------------- > ------- > +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 > + Device(PC00) { // PCI Bridge "Host Bridge" > +#else > Device(PCI0) { // PCI Bridge "Host Bridge" > +#endif > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > Name(_SEG, 0) > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > index 3437bc489c..b3b45039cc 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > @@ -40,6 +40,7 @@ > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 > > [Depex] > gEfiAcpiTableProtocolGuid AND > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..68a76db4de 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -139,6 +139,9 @@ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 > > + # The PCD controls MinDsdt PciBridge > + > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00 > + 010057 > + > # > # FADT Duty Offset - The zero-based index of where the processor's duty cycle > # setting is within the processor's P_CNT register. > -- > 2.26.2.windows.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#99338): > https://edk2.groups.io/g/devel/message/99338 > Mute This Topic: https://groups.io/mt/96647478/1131722 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > ------------ > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 2023-01-31 7:46 ` Chen, Aryeh @ 2023-01-31 12:55 ` Ard Biesheuvel 0 siblings, 0 replies; 5+ messages in thread From: Ard Biesheuvel @ 2023-01-31 12:55 UTC (permalink / raw) To: Chen, Aryeh Cc: devel@edk2.groups.io, Chiu, Chasel, Desimone, Nathaniel L, Oram, Isaac W, Gao, Liming, Dong, Eric On Tue, 31 Jan 2023 at 08:47, Chen, Aryeh <aryeh.chen@intel.com> wrote: > > Hi Biesheuvel, > > The platform which before ADL, like TGL uses \_SB.PCI0, but ADL and later uses \_SB.PC00. > Minplatform should support all platform and Pcd PcdMinPciBridgePC00 can set on OpenBoard.dsc for PCI0 or PC00. > Thanks for the explanation. I think this is a rather ugly hack, but I suppose it is really needed. > > -----Original Message----- > From: Ard Biesheuvel <ardb@kernel.org> > Sent: Tuesday, January 31, 2023 3:32 PM > To: devel@edk2.groups.io; Chen, Aryeh <aryeh.chen@intel.com> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com> > Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > > On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh <aryeh.chen@intel.com> wrote: > > > > From: Aryeh Chen <aryeh.chen@intel.com> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on > > MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > > \_SB.PC00 since Client ADL platform. > > > > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com> > > Cc: Chasel Chiu <chasel.chiu@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Cc: Isaac Oram <isaac.w.oram@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Eric Dong <eric.dong@intel.com> > > Why is this needed? > > > --- > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > index 4efb8709ac..b7361b6d44 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > @@ -23,7 +23,11 @@ DefinitionBlock ( > > //--------------------------------------------------------------------------- > > // Begin PCI tree object scope > > > > //-------------------------------------------------------------------- > > ------- > > +#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1 > > + Device(PC00) { // PCI Bridge "Host Bridge" > > +#else > > Device(PCI0) { // PCI Bridge "Host Bridge" > > +#endif > > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > > Name(_SEG, 0) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > index 3437bc489c..b3b45039cc 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > > @@ -40,6 +40,7 @@ > > [Pcd] > > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit > > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 > > > > [Depex] > > gEfiAcpiTableProtocolGuid AND > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > index e6f714b181..68a76db4de 100644 > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > @@ -139,6 +139,9 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|UINT8|0x00010056 > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x00010055 > > > > + # The PCD controls MinDsdt PciBridge > > + > > + gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x00 > > + 010057 > > + > > # > > # FADT Duty Offset - The zero-based index of where the processor's duty cycle > > # setting is within the processor's P_CNT register. > > -- > > 2.26.2.windows.1 > > > > > > > > ------------ > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#99338): > > https://edk2.groups.io/g/devel/message/99338 > > Mute This Topic: https://groups.io/mt/96647478/1131722 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] > > ------------ > > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 2023-01-31 5:45 [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 Chen, Aryeh 2023-01-31 7:31 ` [edk2-devel] " Ard Biesheuvel @ 2023-01-31 19:00 ` Ankit Sinha 1 sibling, 0 replies; 5+ messages in thread From: Ankit Sinha @ 2023-01-31 19:00 UTC (permalink / raw) To: devel@edk2.groups.io, Chen, Aryeh Cc: Chiu, Chasel, Desimone, Nathaniel L, Oram, Isaac W, Gao, Liming, Dong, Eric Hi Aryeh, Is it possible to use a FixedPCD for "PCI0"/"PC00" string itself? That way we don't have to keep adding conditional statements for future changes. It will scale better. Declare in MinPlatformPkg.dec and provide the value in <Platform>OpenBoardPkg.dsc. Thank you, Ankit > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chen, > Aryeh > Sent: Monday, January 30, 2023 9:45 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel > <chasel.chiu@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desimone@intel.com>; Oram, Isaac W > <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; > Dong, Eric <eric.dong@intel.com> > Subject: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD > PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > > From: Aryeh Chen <aryeh.chen@intel.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on > MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL platform. > > Signed-off-by: Aryeh Chen <aryeh.chen@intel.com> > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Isaac Oram <isaac.w.oram@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Eric Dong <eric.dong@intel.com> > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 4efb8709ac..b7361b6d44 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -23,7 +23,11 @@ DefinitionBlock ( > //--------------------------------------------------------------------------- // Begin PCI > tree object scope //------------------------------------------------------------------------- > --+#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1+ Device(PC00) { // PCI > Bridge "Host Bridge"+#else Device(PCI0) { // PCI Bridge "Host > Bridge"+#endif Name(_HID, EISAID("PNP0A08")) // Indicates PCI > Express/PCI-X Mode2 host hierarchy Name(_CID, EISAID("PNP0A03")) // > To support legacy OS that doesn't understand the new HID Name(_SEG, > 0)diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > index 3437bc489c..b3b45039cc 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > @@ -40,6 +40,7 @@ > [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit+ > gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 [Depex] > gEfiAcpiTableProtocolGuid ANDdiff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..68a76db4de 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -139,6 +139,9 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|U > INT8|0x00010056 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x0001 > 0055 + # The PCD controls MinDsdt PciBridge+ > gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x > 00010057+ # # FADT Duty Offset - The zero-based index of where the > processor's duty cycle # setting is within the processor's P_CNT register.-- > 2.26.2.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#99338): https://edk2.groups.io/g/devel/message/99338 > Mute This Topic: https://groups.io/mt/96647478/1772825 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com] > -=-=-=-=-=-= > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-31 19:00 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-31 5:45 [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 Chen, Aryeh 2023-01-31 7:31 ` [edk2-devel] " Ard Biesheuvel 2023-01-31 7:46 ` Chen, Aryeh 2023-01-31 12:55 ` Ard Biesheuvel 2023-01-31 19:00 ` Ankit Sinha
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox