From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.3726.1663745617056410039 for ; Wed, 21 Sep 2022 00:33:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZdL7ajDc; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: aryeh.chen@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663745617; x=1695281617; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z8WFwmJimPRCLVPjFmVRx9hlwOXV4PhIKuaFOzmI//w=; b=ZdL7ajDcAXRo4wFlOZBMACfT1cwyLOvEiKBP0F0XdkA9adZUaxJQhlVj uQDrGHiJHqhSgqYgthRgi6z6BBA/4GTn7j70uV1behwWlkcN3e9dpmjDD aVaKWHIEVbc35PZyQAEt5jvLC3sXfb3BG7LaLxMRPEYL3kBZYuS58/Bb3 2DxJokt/Gv8bRJjiByBsumGXYZ7NENkLrL0SUo44Pt9zZbqYmTHI5y3pO zfgHldkP9gHigTEAG1i+biuFV+ZMLcOQ9CStunSP8OkYqcOGjxPl4UDpa MlhS9Jd52pDsJ6zH1RMiRtSgn7h2wrWewcCNLX1oqwEgw8PyZRVMPkIYg g==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="386213260" X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="386213260" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2022 00:33:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="761644052" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2022 00:33:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 00:33:35 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 00:33:35 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 21 Sep 2022 00:33:35 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 21 Sep 2022 00:33:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOUSeDNB0uga/PCHadqp1n75+N8cFoySkUB9UTPA/ZD0ntuB7Y4oLcZPAEQwui0mRsnoVFVDNJXUF/R3ZsJK9CbV//fekUxM4DNu2E916IhnoTY1wbS6qpxRFOjpv6kgnh6tzEWClhUA1dZKS88GrZAKjvXdmIDrBbNioDeYb+XxbSYTLSM+WzPdCoygHp+SbOAurWUWEC/sklU8Kk9urhTdF25q0LXplrZQ1caGwlspkCRV0C4LcC6rHKqnPith/V/pAM8trKtMu3HXH3tZH7jLej01rSr6Sqp5zeCC/oqjawMkzC/lkCATHZB5DZuBPz2jaPT56Fwv0eZeu2jR5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+j2u2NOSItJr+iYXQahDdGxdiUSGHYkvBsYeDFsJUY=; b=iFSAyGaxYS4ZlminaUFCrf+bR0qLhkCCmh4py3zhRuZCuaOi0sje7KM53XsRM/i+9wTmi14/T5gP3rDDlEWZRAfQPwFgpuFbfA6qCfRFwM5/MKuRrAPmgleGcOm56LVQ1dEDrcqvkFktxGXLFHCefdlxy0fZqL59wW8zxX9BfYfjj0NQaUfj/gsrv5zha3Yx1Epe++uoIHuNXLIGpe8sWNAFY0704/zfmsAz11t1qFAtbf8Xc1ak3Jw4ZoowcgTZ85RAqsRayvI/dkaDogxW+2Fcg8XU/9+j1geXCmVI4ejWYWKZ7KepNBTF6/0lre6FF5HcY/smmqnT1vzhC5p5bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by CY5PR11MB6186.namprd11.prod.outlook.com (2603:10b6:930:26::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.18; Wed, 21 Sep 2022 07:33:33 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::78ec:5895:5ea4:a9dd]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::78ec:5895:5ea4:a9dd%4]) with mapi id 15.20.5632.021; Wed, 21 Sep 2022 07:33:33 +0000 From: aryeh.chen@intel.com To: "Sinha, Ankit" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Topic: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Index: AQHYxmcFPn449V/XUkivPEKewyt1wa3cRqmAgA0N04A= Date: Wed, 21 Sep 2022 07:33:32 +0000 Message-ID: References: <20220912051745.1539-1-aryeh.chen@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1775:EE_|CY5PR11MB6186:EE_ x-ms-office365-filtering-correlation-id: 14b03da8-180e-4b85-18a8-08da9ba39641 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ryyvK+Q6zyxOx3LkXEgzpqe9e3VD46OawG2tifGSlCPTEEdsWeVu8CxTyiTNUYarCraMbzRCbfflUKUKY4YimkLKhjLY+g4jVf2zcmIkEiIDLYK/oYdkXOxWvbLBpjsk6tNhgO3fppj/dIW0cuKvmZZjwAFV8am7c9jJxMO/y26PmirySslqmdV3xdt2WSRya8HoEC1g2euNqg0JokPJb6WZ1MHVPxy5/FtMChcYb2N2FHrF8cJmJarFMjkJg7tMM1el3XmB1qL1e6AS9RZWuH3RZynh+T6ZrMA6Xtce6F6CbUrj7sUX3De0/uIRRupsZ3gUO7ZtrJpNAjkbURqfK6TdBYsMWn8uD9XLudgEhF8yh/bfv8uivv7sYvI0rMYHx3lGrtvDdKXj+JO55jdN4iXaGqC5KNfLmiCezFWHH7Ik7defhj6b/REkH1Qtbrzq1EImn6qIjjOuBrQ//jcH/re5CtLUMUT9mcWzHv+jnElvUizszSVahTqFxjZ8PSd/s1pvDwkD33vyE6VNcBRD7UlwV7bVBIvX1w/3ND/8Rk5UQym1iaPK8zO+I73wYsOM5UlPAH+YSrWMf/loyU6DjP5hVIECOiIscWS9KYgWVXNPSslErzmGAIcNbHsQZCmHB+VU3wM/NwiDoFIf+lWtkjNHBUE20a7uLYOcybv6EIZr4aLQAwupPB4BmTe2NN5tkod1HneqgrA3EITfSFmpcgaDEnzOMlxr43JjRm+g6MfW/uKzyfwJ2vhLLZeYmVJvIZBhfu4OYIt7AiByKvAB+9/aooz7tGs04GaQkOW0W7o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(86362001)(26005)(55016003)(71200400001)(478600001)(8936002)(9686003)(7696005)(33656002)(38100700002)(82960400001)(186003)(41300700001)(6506007)(107886003)(53546011)(122000001)(38070700005)(83380400001)(966005)(66946007)(66446008)(64756008)(2906002)(52536014)(66476007)(5660300002)(76116006)(66556008)(8676002)(316002)(110136005)(54906003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/6p1po9n50R4MQ7Wtf+6lobzJR5EaQrO1gIGZB8uAVOFjh9tgPf6th7VHpzj?= =?us-ascii?Q?k6WllsoYGe+oWhN42nzbYD07ZOK4PyZoZ9bS2aV2VT+GTizmNm8WtHvqbj1A?= =?us-ascii?Q?/wRRSJuy4TQ4N4vu948DWzKrACL7XEbP2bz5IfMkA5rrrLexecVYR9kWN3Fq?= =?us-ascii?Q?+72tlJyprJvoGQmz5wkjPfMEfCBqamWL0ebtnG+0BkCrLXTghgRk2q+gZXce?= =?us-ascii?Q?Los1ErttYO5qqMOE7euJ87RSPqM8UiW6G3wvk7ayiIDeA8GJz8qoEAqM4gur?= =?us-ascii?Q?lZInTyWy2/RplORIURFsE10mQv+RO79Z+Dzr1tVIIYOGyjk0tglXMRlL/0eS?= =?us-ascii?Q?Xytz/7NekxaLM26xpkRXKHsACi3/nzAbE2KbAYkQeZja3MTqsuzNeO024U0L?= =?us-ascii?Q?xZEPBQpuRYPZ3DRVlInN4AXYJIAr4qeYjlk16JBiSw37rTEvYu3lKPf6V3Tp?= =?us-ascii?Q?ssEUUPftF9R2bQpgHPBsxXX1GWBGkX24WV2N0M+SfRUPIGhJd/wl8J7ZTBkw?= =?us-ascii?Q?kxrkedL84ivm617zzSRVf/1a6hqSOhZ/XKA/T8piC2EOQXz38SAg2ZugW5Xm?= =?us-ascii?Q?5HdZ19V/XmElqvHFiMHeiG+sHyWFaa7A1wXgJeyuImjAwq+Pu0jUfMj6DzWk?= =?us-ascii?Q?4SqCEAFDoKV+iUhOvnkEdAHmQjk/0lHoSpfNljWfmPjEMF0mXp+YH3B5VXrl?= =?us-ascii?Q?YBhaK3485NJlABSyaq/uH1uu+YHfifhymj6X6DnjqeHLynquP3hnkkbBlZsB?= =?us-ascii?Q?+XSS8dTOsDKOLz7td8FQktroZkIKtPZIaIY9ad68Tx9rhSGa42OYKt5eADcW?= =?us-ascii?Q?6rVrBIVSWOLN5Q2fRk/YXIu7bJRk+jeqlRjhRO0NwMYbq5LytWOSz35EkkfZ?= =?us-ascii?Q?jPSks7IeQTT6s4AJf2Mj1AQ0g65Ks0DWHb45DHnD95fJG+cnZUXoRT66FmNi?= =?us-ascii?Q?jBWbmTH2tJ+z1XQQXx+XzmPxpbFx7uql42JVcJyBBAI6L07qwna1pMYhC9lo?= =?us-ascii?Q?b01Ao6jX2kZ6VUkj2ehHU8XGmH5w/WgZwiMqfYMFFwAchOaAtwgG3M0PnX7j?= =?us-ascii?Q?a0Qj50dQ2ZoakBn+ntYDD2EX0gtqOkwJqWFYYnq3PYX3Pers7pXw1EBGp/q8?= =?us-ascii?Q?86+Pzm3emTcNnF4R5wLco0AETOkr/xFCh3fzSWnWdRBAKeFWBKjOFQbje3d9?= =?us-ascii?Q?CVhKKV+mdSDbvYSXy4YuXhav+LVzX1Xmvt3M5tQrVSP6ckrNkr3tv6evcM5y?= =?us-ascii?Q?9RtTbRIANmFXYF1kncHf/UPVGwa5P162TmwjVOKptq1lcmYFTpIbtou4Zv98?= =?us-ascii?Q?ijjxGgb2gfyUbiN2omD07aX3ivdJ21N67rnUgNIdf19exrc/N7kRv5kmtAgz?= =?us-ascii?Q?eXTeRRtmdAnbpGSPlRnmKALEGvv1QOa/nI4pTJBMT0kM5Du3L255kDsf0iM3?= =?us-ascii?Q?uwUleRSOwwbZYwEMglzcRZ9D68sLVkEKTvXRl0WH06moshIDrbBE63NMANFX?= =?us-ascii?Q?ipilDXYpgJn96qCGZsy+ioV6I2UhRLE53HZwMswuHG65WhUuP9Dpl0GrSBga?= =?us-ascii?Q?CyWL3HsgF2VilKQxpI8cajD/mPci0hFLAgKC1xts?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14b03da8-180e-4b85-18a8-08da9ba39641 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 07:33:32.9013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M4VWYXJcoKNPtmJC2H1ZXu1QfunQJXUIysq8FUdlJh776XtrUtvDYuXsAyvlLr0nk7+4LSf2TO6oqJBOvr2JjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6186 Return-Path: aryeh.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ankit, Add a change to remove Name(_ADR, 0x00000000) from edk2-platforms\Platform\= Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU openboard= bios. =3D=3D=3D Acpidump =3D=3D=3D Signature "DSDT" Length 0x000000FD (253) Revision 0x01 (1) Checksum 0x33 (51) OEM ID "INTEL " OEM Table ID "MIN " OEM Revision 0x00000000 (0) Creator ID "INTL" Creator Revision 0x20210930 (539035952) DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN ", 0x00000000= ) { Scope(_SB) { Device(PCI0) { Name(_HID, EISAID("PNP0A08")) Name(_CID, EISAID("PNP0A03")) Name(_SEG, Zero) Method(^BN00, 0, NotSerialized) { Return(Zero) } =3D=3D=3D Original mindsdt.asl =3D=3D=3D Scope(\_SB) { //-----------------------------------------------------------------------= ---- // Begin PCI tree object scope //-----------------------------------------------------------------------= ---- Device(PCI0) { // PCI Bridge "Host Bridge" Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 ho= st hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't un= derstand the new HID Name(_SEG, 0) Name(_ADR, 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns default Bus number for= Peer PCI busses. Name can be overriden with control method placed directly= under Device scope Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Roo= t PCI Bus Thanks, Aryeh -----Original Message----- From: Sinha, Ankit =20 Sent: Tuesday, September 13, 2022 4:54 AM To: Chen, Aryeh ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming = ; Dong, Eric Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Hi Aryeh, Can you please post the test results for this change. It would be good to n= ote that there is no change in behavior in the OS. Thank you, Ankit > -----Original Message----- > From: Chen, Aryeh > Sent: Sunday, September 11, 2022 10:18 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel=20 > ; Desimone, Nathaniel L=20 > ; Oram, Isaac W=20 > ; Sinha, Ankit ; Gao,=20 > Liming ; Dong, Eric > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl >=20 > From: Aryeh Chen >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 >=20 > According to ASL Coding Guidelines - Device Identifiers "A Device=20 > should contain either an _ADR or a _HID object, never both." > , so remove _ADR due to _HID exist. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Ankit Sinha > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 0d94472450..4efb8709ac 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -27,7 +27,6 @@ DefinitionBlock ( > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 > host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy O= S > that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR, > 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns default = Bus > number for Peer PCI busses. Name can be overriden with control method > placed directly under Device scope Method(_BBN, 0){ return(BN00()) = } // > Bus number, optional for the Root PCI Bus Name(_UID, 0x0000) // Un= ique > Bus ID, optional-- > 2.26.2.windows.1