From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.4004.1587690430377826732 for ; Thu, 23 Apr 2020 18:07:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=N0CFYQXP; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: heng.luo@intel.com) IronPort-SDR: qPpVFc4mrdgKLrCjeB9KOi+1edtodCu6q+1u+qhtP8Or/QVRBPgjyPTVFPVbqISNhdz/N5xHEB 50sbhYnTpJCw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 18:07:09 -0700 IronPort-SDR: 32c4mUNjBVOr155VSwbGYPWIkmqY31Uccv1VMdyN4QSOBS2kg7E0k2NWY7WOCBQSO49zdqcgKz 3ooUJhNyQPuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,309,1583222400"; d="scan'208";a="335178033" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 23 Apr 2020 18:07:09 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 18:07:01 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 18:06:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ncvIb71z63hzmjRTgN0t7BKdH9e8YH6FJZLt77AA8EXvJJ/LDT1H0cWpa7l+9xiB1ipGAmdEUVRKcx1gmhKGxjy68v4iC9dZf8xTX66tuz/KEVWP3Lul37uqWD5TeTZM59l0bbJoSQKo/+VviU5zqR+lDLdoJxoccHjCw1MtVjJJMBh5UQRQVmPGhQRAhFeDJVdZQf0dfZgmyydPADm2keLLpqf+3JSNXkzB26qNX5Gkkk3pm7M8yD3uDuNoNVwMS/COAzM2ImRyN0VkxQSEwGNxVbyB6TLi7oF76nLfYSWbwykbFQdPuUEdlrJuBwpvuJvg7Rl/YJGbETeDjryNeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bC6MFWeZuzikBRl8DKEc1kVl4XMu21X/IKD/OQXU/Hc=; b=WXkmasskwGJaTB0w0JtTJKkXL2vQNFPRX0wyhx7gPDQZ62zDsq6G8C85uAwt68YGSbnGT7nlhKBZLe2vJgWXKeQIRn6NJe4hT9zRbCBcgpOhPjeJaAlX4rdnooDWxWBtErOHJcRBC08yH0xqgor7fYpIBSN4bzPhSxXphHOrbll8KJpeiHml+S/kQP/IPqg+MsLrHMdwjy3pXLiaVA62HEHD6ZqsE34diT/TmxFIZymwfTLvpoz8DJCiOTBjMLvIiKcZRb3Pa2Xx1J9AVVFip6jFC5i2v6ub3HzI60uMwDOG5jPzd/2F+CGuPuqTjpFZhMuXUrmIiL4Db37uyH1tvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bC6MFWeZuzikBRl8DKEc1kVl4XMu21X/IKD/OQXU/Hc=; b=N0CFYQXPBMOBElru3yhT/J11mGOm1aMqdqxg0tELSnDqegp/AQCixeJ851TkiQvR+r/VB3nTRC3tVcLzCT+ViUGKpOzCCec+RnPihmIHRiuiAki2jdyI6lrQZ/0nigXeGiyububo4fABADFP7aotQ/gwHr2Zvcrzn3Ov1UPEDkM= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MWHPR11MB1328.namprd11.prod.outlook.com (2603:10b6:300:2b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27; Fri, 24 Apr 2020 01:05:46 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::9cd5:39ad:6a4d:34d3]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::9cd5:39ad:6a4d:34d3%12]) with mapi id 15.20.2921.033; Fri, 24 Apr 2020 01:05:46 +0000 From: "Heng Luo" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Michael Kubacki , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround Thread-Topic: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround Thread-Index: AQHWGUs/OTGi4bxsT0KXG4JV9EyKDqiGlfdQgADZ8EA= Date: Fri, 24 Apr 2020 01:05:46 +0000 Message-ID: References: <20200423084258.1100-1-heng.luo@intel.com> <20200423084258.1100-2-heng.luo@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C50A9E0@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C50A9E0@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=heng.luo@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ca67504-1062-475a-561b-08d7e7eb9f1e x-ms-traffictypediagnostic: MWHPR11MB1328: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1805.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(346002)(376002)(136003)(396003)(366004)(39860400002)(6506007)(26005)(2906002)(107886003)(71200400001)(54906003)(316002)(86362001)(53546011)(110136005)(33656002)(8676002)(478600001)(7696005)(8936002)(81156014)(966005)(30864003)(5660300002)(9686003)(66556008)(4326008)(66446008)(52536014)(19627235002)(186003)(55016002)(66476007)(66946007)(64756008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yy4pOf7TcEscSyiUvEGgLCEzW5Ybzw72v06TRf/0st9l74MPwDdaFP2equC9oH3tjF0ViMlMJCn371jFzfhPbUwoSf5YuuPDQ4LxEZMoXxGhEyK4cje6Zctn5jCOKY69aekdYX5U2sKosljwr12NoSimirGfMsiyaKFfzGWKGUXmASKL9T0ZmkcxsLlDAGRTb4ypwGU/jDKlAy835KYZUVwE2NRdQktHFKHz+C0GbipTCLvhMe172toLS9bR/wvFJyCLMd8ChT15abIarAnbOprx6NkVGUQFVBRXa2JWr9rT4XMa6kdSQh6XPVo2GguLkBwX9gZRn/mZ8H9diTxhPOEIzwK20IFZUGPttzGQxA5tS0d5qbFPs6Uid4KrzAp55vA0orrv7TL2rfGWL3AbA3rlHTrWg4wMLL0tfrQcH6LBA6DvnhZZ2ucmaKp/78jXeiWK0awPjeNNd4J+WeZlgMqo2+x9UIum1jfgXRYvOFTVbpKQQJ95Ou2J8FskjBZs7WtT1QYUw2C0I4yxZ3gmoA== x-ms-exchange-antispam-messagedata: tFE3FiStPfOhIdSDeM/eULffUzrZFBW5TPRnuatUeHDT76wOjSFWmiUn2Rl2RCT5LTUiAubmuNnmrEKjcoMIu9qxVDofp/Xj2dGjYYP5T9/gFPA5jyG8U190SIWCpUhFPTZEWXfOsd/WujrSPKtyEg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca67504-1062-475a-561b-08d7e7eb9f1e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 01:05:46.6432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6HncPBPpUIKB98gmom9r/UTn4RpWenp2Q+lPS1XvMeMQShqIIyQiKfFUr2Yf9WwcK7utt7QCpMkhv9xBGgWkZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1328 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Option 1, In current implement, the usage of AdvancedFeaturePkg in board DS= C is: !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc # invoke sectio= n "[Packages]", define default Feature PCD #option: [PcdsFeatureFlag], board can override default Feature PCD here, en= able specific feature. !include Include/AdvancedFeatures.dsc Option 2, if there is no AdvancedFeaturesPcd.dsc, we can move section "[Pac= kages]" to AdvancedFeatures.dsc, there is 2 concerns here: 1. there is no default Feature PCD now, we need to add [PcdsFeatureFlag] be= low in every OpenBoardPkg.dsc. if we add a new feature, we have to change a= ll OpenBoardPkg.dsc files, but in option 1, we just need to change Advance= dFeaturesPcd.dsc [PcdsFeatureFlag] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable |= FALSE gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable |= FALSE ..... 2. we define FeaturePCDs before section "[Packages]", it does work, but it = looks strange. So I would like option 1, but I also agree option2 if you think it is bette= r. Thanks, Heng > -----Original Message----- > From: Ni, Ray > Sent: Thursday, April 23, 2020 7:43 PM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Dong, Eric > Subject: RE: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove > temporary build workaround >=20 > Heng, > Any reason to create a separate Pcd.dsc file? >=20 > > -----Original Message----- > > From: Luo, Heng > > Sent: Thursday, April 23, 2020 4:43 PM > > To: devel@edk2.groups.io > > Cc: Michael Kubacki ; Gao, Liming > > ; Dong, Eric ; Ni, Ray > > > > Subject: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove > > temporary build workaround > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2688 > > > > Remove Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround, > > Add > Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > to support Feature PCDs. > > > > Cc: Michael Kubacki > > Cc: Liming Gao > > Cc: Eric Dong > > Cc: Ray Ni > > Signed-off-by: Heng Luo > > --- > > Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > | 2 +- > > Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > | 41 > > +++++++++++++++++++++++++++++++++++++++++ > > > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Temporar > yBuildWorkaround.c | 31 --------------------------- > > ---- > > > > > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Temporar > yBu > > ildWorkaround.dsc | 76 -------------------------- > > -------------------------------------------------- > > > > > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Temporar > yBu > > ildWorkaround.inf | 60 --------------------------- > > --------------------------------- > > 5 files changed, 42 insertions(+), 168 deletions(-) > > > > diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > > b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > > index ea879680ba..e509ef3e1b 100644 > > --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > > +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > > @@ -30,7 +30,7 @@ > > PEI_ARCH =3D IA32 > > > > DXE_ARCH =3D X64 > > > > > > > > -!include > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > und.d > > sc > > > > +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > > > > > > > > > > ################################################################ > ###### > > ########## > > > > # > > > > diff --git > > a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > > new file mode 100644 > > index 0000000000..2eacec18a0 > > --- /dev/null > > +++ > b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.ds > > +++ c > > @@ -0,0 +1,41 @@ > > +## @file > > > > +# DSC file for defining Pcd of advanced features. > > > > +# > > > > +# This file is intended to be included into another package so > > +advanced features > > > > +# can be conditionally built by enabling the respective feature via i= ts > FeaturePCD. > > > > +# > > > > +# Copyright (c) 2020, Intel Corporation. All rights reserved.
> > > > +# > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +# > > > > +## > > > > + > > > > +# > > > > +# The section references the package DEC files, > > > > +# it allow a FeaturePCD to be used in a conditional statement > > > > +# > > > > +[Packages] > > > > + MdePkg/MdePkg.dec > > > > + AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > > > > + Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec > > > > + NetworkFeaturePkg/NetworkFeaturePkg.dec > > > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > + S3FeaturePkg/S3FeaturePkg.dec > > > > + SmbiosFeaturePkg/SmbiosFeaturePkg.dec > > > > + UserAuthFeaturePkg/UserAuthFeaturePkg.dec > > > > + LogoFeaturePkg/LogoFeaturePkg.dec > > > > + > > > > +# > > > > +# The section below sets all PCDs to FALSE in this DSC file so the fea= ture is > not enabled by default. > > > > +# Board can set PCDs to TRUE in its DSC file to enable a subset of > > +advanced features > > > > +# > > > > +[PcdsFeatureFlag] > > > > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable > |FALSE > > > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable > |FALSE > > > > + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable > |FALSE > > > > + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE > > > > + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > |FALSE > > > > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > |FALSE > > > > + > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable > |FALSE > > > > + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > |FALSE > > > > + gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable = |FALSE > > > > diff --git > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.c > > > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.c > > deleted file mode 100644 > > index 2cd91b06f0..0000000000 > > --- > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.c > > +++ /dev/null > > @@ -1,31 +0,0 @@ > > -/** @file > > > > - Source code file for a temporary build workaround. > > > > - > > > > - The purpose of this workaround is described in the module INF file. > > > > - > > > > -Copyright (c) 2019, Intel Corporation. All rights reserved.
> > > > -SPDX-License-Identifier: BSD-2-Clause-Patent > > > > - > > > > -**/ > > > > - > > > > -#include > > > > -#include > > > > - > > > > -/** > > > > - An empty entry point function. > > > > - > > > > - @param FileHandle Handle of the file being invoked. > > > > - @param PeiServices Describes the list of possible PEI Services. > > > > - > > > > - @retval EFI_SUCCESS This function always returns EFI_SUCCESS. > > > > - > > > > -**/ > > > > -EFI_STATUS > > > > -EFIAPI > > > > -TemporaryBuildWorkaroundEntry ( > > > > - IN EFI_PEI_FILE_HANDLE FileHandle, > > > > - IN CONST EFI_PEI_SERVICES **PeiServices > > > > - ) > > > > -{ > > > > - return EFI_SUCCESS; > > > > -} > > > > diff --git > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.dsc > > > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.dsc > > deleted file mode 100644 > > index c62f9ecc6e..0000000000 > > --- > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.dsc > > +++ /dev/null > > @@ -1,76 +0,0 @@ > > -## @file > > > > -# Build description file for a temporary build workaround. > > > > -# > > > > -# The feature enable PCD for advanced features must be referenced in > > an INF > > > > -# to be referenced in DSC/FDF files. This DSC only exists in the > > build to > > > > -# allow the PCDs to be referenced. This workaround does not affect > > the final > > > > -# flash image or boot in any way. > > > > -# > > > > -# The request to update BaseTools to allow a PCD to be referenced in > > DSC/FDF > > > > -# files without requiring the PCD to be referenced in an INF file is > > tracked > > > > -# here: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2270 > > > > -# > > > > -# When the BaseTools update is complete, this file can entirely be > > removed > > > > -# from this package. > > > > -# > > > > -# Copyright (c) 2019 - 2020, Intel Corporation. All rights > > reserved.
> > > > -# > > > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > -# > > > > -## > > > > - > > > > -# > > > > -# BEGIN:Temporary Build Workaround (resolution: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2270) > > > > -# > > > > - > > > > -# THIS FILE IS TEMPORARY. PLEASE TRY TO LOOK PAST THE "HACKS" > ASSOCIATED WITH IT. > > > > -# > > > > -# With the BaseTools change requested, the changes needed to move to > the end state are simply: > > > > -# 1. Remove the !include for this file in AdvancedFeatures.dsc > > > > -# 2. Remove this directory > > > > - > > > > -!if $(PLATFORM_NAME) !=3D AdvancedFeaturePkg > > > > -# > > > > -# AdvancedFeaturePkg initializes all FeaturePCDs to TRUE so they can > conveniently be built in one package. > > > > -# Board packages will normally only enable (and therefore reference) > > a small subset of advanced features > > > > -# relative to the board. If an INF does not reference a package DEC > > file (which will be the case if the > > > > -# feature is not enabled) then the DSC must set ("define") the PCD > > for the conditional statements based > > > > -# on the PCD to work. > > > > -# > > > > -# AdvancedFeaturePkg has no problem as it naturally has a need to set = al > PCDs to TRUE for build. > > > > -# The section below sets all PCDs to FALSE in the DSC file so if the > > feature is not enabled by a board, > > > > -# the build will still be successful. > > > > -# > > > > -[PcdsFeatureFlag] > > > > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable > |FALSE > > > > - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable > |FALSE > > > > - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable > |FALSE > > > > - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE > > > > - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > |FALSE > > > > - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > |FALSE > > > > - > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable > |FALSE > > > > - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > |FALSE > > > > - gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable = |FALSE > > > > -!endif > > > > - > > > > -# > > > > -# The LibraryClasses required to build TemporaryBuildWorkaround.inf > > > > -# (mostly libraries requiring other libraries) > > > > -# > > > > -[LibraryClasses] > > > > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > > > - > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRe > pStr.i > > nf > > > > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > > > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > > > - PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > > > - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > > - > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId > > t/PeiServicesTablePointerLibIdt.inf > > > > - > > > > -# > > > > -# The driver that references all feature PCDs to satsify current > > build limitations > > > > -# > > > > -[Components] > > > > - > > > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > und.i > > nf > > > > -# > > > > -# END:Temporary Build Workaround (resolution: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2270) > > > > -# > > > > diff --git > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.inf > > > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.inf > > deleted file mode 100644 > > index 00818fbe0a..0000000000 > > --- > > > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempor > ary > > BuildWorkaround.inf > > +++ /dev/null > > @@ -1,60 +0,0 @@ > > -### @file > > > > -# Component information file for a temporary build workaround. > > > > -# > > > > -# The feature enable PCD for this package must be referenced in an > > INF to be > > > > -# referenced in DSC/FDF files. This driver is only included in the > > build to > > > > -# allow the PCD to be referenced. This driver is not included in the > > flash > > > > -# image and does not affect the boot in any way. > > > > -# > > > > -# The request to update BaseTools to allow a PCD to be referenced in > > DSC/FDF > > > > -# files without requiring the PCD to be referenced in an INF file is > > tracked > > > > -# here: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2270 > > > > -# > > > > -# When the BaseTools update is complete, this file can entirely be > > removed > > > > -# from this package. > > > > -# > > > > -# Copyright (c) 2019 - 2020, Intel Corporation. All rights > > reserved.
> > > > -# > > > > -# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > -# > > > > -### > > > > - > > > > -[Defines] > > > > - INF_VERSION =3D 0x00010017 > > > > - BASE_NAME =3D TemporaryBuildWorkaround > > > > - FILE_GUID =3D 8846A81E-F552-4917-81F5-80B62E4EFBAC > > > > - VERSION_STRING =3D 1.0 > > > > - MODULE_TYPE =3D PEIM > > > > - ENTRY_POINT =3D TemporaryBuildWorkaroundEntry > > > > - > > > > -[LibraryClasses] > > > > - BaseLib > > > > - PeimEntryPoint > > > > - > > > > -[Packages] > > > > - MdePkg/MdePkg.dec > > > > - Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > > > > - Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec > > > > - Network/NetworkFeaturePkg/NetworkFeaturePkg.dec > > > > - OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > - PowerManagement/S3FeaturePkg/S3FeaturePkg.dec > > > > - SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec > > > > - UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec > > > > - UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec > > > > - > > > > -[FeaturePcd] > > > > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable > > > > - gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable > > > > - gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable > > > > - gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable > > > > - gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > > > > - gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > > > > - > > > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable > > > > - gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > > > > - gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable > > > > - > > > > -[Sources] > > > > - TemporaryBuildWorkaround.c > > > > - > > > > -[Depex] > > > > - TRUE > > > > -- > > 2.24.0.windows.2