Re: [edk2-devel] [Patch V5 1/3] MinPlatformPkg: Add PCDs for Serial Terminal feature

["Heng Luo" <heng.luo@intel.com>]

Hi Liming,
Agree with you, I will send Patch V6.

Thanks,
heng

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Thursday, November 12, 2020 9:49 AM
> To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>
> Cc: Dong, Eric <eric.dong@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: 回复: [edk2-devel] [Patch V5 1/3] MinPlatformPkg: Add PCDs for
> Serial Terminal feature
> 
> Heng:
>   I see MdeModulePkg SerialDxe uses MdePkg UART PCDs. New added
> SerialPortTerminalLib should match it and use the same PCD. Right? If yes,
> you don't need to add new UART PCDs.
> 
>   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate         ## CONSUMES
>   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits         ## CONSUMES
>   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity           ## CONSUMES
>   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits         ## CONSUMES
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+67278+4905953+8761045@groups.io
> > <bounce+27952+67278+4905953+8761045@groups.io> 代表 Heng Luo
> > 发送时间: 2020年11月11日 14:16
> > 收件人: devel@edk2.groups.io
> > 抄送: Eric Dong <eric.dong@intel.com>; Chasel Chiu
> > <chasel.chiu@intel.com>; Nate DeSimone
> > <nathaniel.l.desimone@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>
> > 主题: [edk2-devel] [Patch V5 1/3] MinPlatformPkg: Add PCDs for Serial
> > Terminal feature
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3014
> >
> > 1. Add PcdSerialTerminalEnable to enable/disable Serial Terminal feature,
> >   this feature supports console redirect after the shell is loaded.
> > 2. Add PCDs to configure serial port.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > ---
> >  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 25
> > +++++++++++++++++++++++++
> >  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc |  3 ++-
> >  2 files changed, 27 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> > index 7ef189dac8..36050aa1a8 100644
> > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> > @@ -205,6 +205,30 @@
> >  [PcdsDynamic, PcdsDynamicEx]
> >
> >
> >
> gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0|UINT32|0x900000
> > 19
> >
> >
> >
> > +  # The baud rate setting for the UART style device. A value of 0
> >
> > +  # means that the device's default baud rate will be used.
> >
> > +
> >
> gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalBaudRate|115200|UINT6
> > 4|0x9000001A
> >
> > +
> >
> > +  # The number of data bits for the UART style device. A value
> >
> > +  # of 0 means that the device's default number of data bits will be
> used.
> >
> > +
> >
> gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalDataBits|0x8|UINT8|0x9
> > 000001B
> >
> > +
> >
> > +  # The parity setting for the UART style device.
> >
> > +  # Parity 0x00 - Default Parity.
> >
> > +  # Parity 0x01 - No Parity.
> >
> > +  # Parity 0x02 - Even Parity.
> >
> > +  # Parity 0x03 - Odd Parity.
> >
> > +  # Parity 0x04 - Mark Parity.
> >
> > +  # Parity 0x05 - Space Parity.
> >
> > +
> >
> gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalParity|0x1|UINT8|0x900
> > 0001C
> >
> > +
> >
> > +  # The number of stop bits for the UART style device.
> >
> > +  # Stop Bits 0x00 - Default Stop Bits.
> >
> > +  # Stop Bits 0x01 - 1 Stop Bit.
> >
> > +  # Stop Bits 0x02 - 1.5 Stop Bits.
> >
> > +  # Stop Bits 0x03 - 2 Stop Bits.
> >
> > +
> >
> gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalStopBits|0x1|UINT8|0x9
> > 000001D
> >
> > +
> >
> >  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> >
> >
> >
> >    ##
> >
> > @@ -318,3 +342,4 @@
> >    gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable
> > |FALSE|BOOLEAN|0xF00000A5
> >
> >
> >
> gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE|BOOLE
> > AN|0xF00000A6
> >
> >    gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable
> > |FALSE|BOOLEAN|0xF00000A7
> >
> > +  gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable
> > |FALSE|BOOLEAN|0xF00000B0
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > index 112ddff7d9..d0b5593817 100644
> > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > @@ -1,7 +1,7 @@
> >  ## @file
> >
> >  #  Platform description.
> >
> >  #
> >
> > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> > reserved.<BR>
> >
> > +# Copyright (c) 2017 - 2020, Intel Corporation. All rights
> > +reserved.<BR>
> >
> >  #
> >
> >  # SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  #
> >
> > @@ -44,6 +44,7 @@
> >      gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE
> >
> >      gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE
> >
> >      gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE
> >
> > +    gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE
> >
> >
> >
> >
> > ##############################################################
> > ##################
> >
> >  #
> >
> > --
> > 2.24.0.windows.2
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#67278):
> > https://edk2.groups.io/g/devel/message/67278
> > Mute This Topic: https://groups.io/mt/78177912/4905953
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaoliming@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
> 
> 
> 
> 
> 
> 
>