From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.28480.1607909483339182990 for ; Sun, 13 Dec 2020 17:31:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Oo6pXSVb; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: heng.luo@intel.com) IronPort-SDR: h9E10iot5lb+lYlFR+wggdapf40JRvB23Q3AvDkjc/aLY82T1mgkI+C6cRkZU1tP3mrCdKirOP rBwuDRYV/S5g== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="171132508" X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="171132508" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 17:31:22 -0800 IronPort-SDR: +oRgSy2pL0cn1lJiBMXWhrX52Givjbu6RawKRM/J12iuj5gqra87+MMfPu/LxVJU5PZmLHZwwG FKA9OpNaD4fQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="329301983" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 13 Dec 2020 17:31:21 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 13 Dec 2020 17:31:20 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 13 Dec 2020 17:31:20 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 13 Dec 2020 17:31:20 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 13 Dec 2020 17:31:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SCKnnvCI9OG8iq9kGSe8T5CfI6E1vvCkfiCXdeZkaJYMdrHuZ7yOJLg5uv97+78XQ39/TETgB4HjadqSnIIvETnqQvpd+vVNN1GkKL5xYjq1FHN3eNMXnZIeSgoLIdqasNCai1xpUDJaiKM8+fLGg/ePtr+12F+fk6Apr2EMweG3iEtf+6C+GgmkOMcpTsaFragPBGXCOoT1kAEmzgCMa3b287uR4eI8AsUTLgfwr5MUwdWVG96Suvz7Pt1RkOwG8c9FEJRHOG+p3UiV/GeA8wJk9DnwzyZOskR+yniyaW1EONpIGZ82g7VfiV3qr8DmP/Zsb4ah5iKaDUAMBpZX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3/+ApCs4brccwhLFfJfja3OFbsDaGstWQrbvcm0c14=; b=NSXJLjC23J0Y3oJIAJSy4nz5c8sLn0ih9q6G52WOw9U1E8acCG8dofLtt1lTPwl3kviUg7RKKv8QoOyy+p7p/6bMXQjYaVHDV5xg2NzK/4IdEOcpSF9MhWcDWpvZ4drISqkYnVc/U7gS4QCODTk0tFo51fQl/YxuFwDs1huGOXg1BnCOLxpDTBCp/JtwBligc/87tUBWUOjZ2esA516K/Z1GF0wqRj39fFYgj/WcZzHpTyRNcempm5xkY2+dJldXwY6D6ZbvFO39hfwlxR+8SuQmmqN11y1T5KIwtMGB6ZGypGJz3eh3IzIok7OgdRFFtSTPw6nb1S57gAPLJgx/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3/+ApCs4brccwhLFfJfja3OFbsDaGstWQrbvcm0c14=; b=Oo6pXSVbOpHNY9n6ySF4kppmpc1ZGsZATGaze+WlUmYnQVeaXaaeI8NYL7iGX2g+ytT2smY6ckk/LaMwmHkBG6LfuqSxGqCOCKJC8lpJuCnp+ZsSXqZYQL2RjsPoBiFSkkFCfyJ4VKLDtYjFdcd7dMGYsfF8CMDp+6M3srA4trA= Received: from MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) by MW3PR11MB4522.namprd11.prod.outlook.com (2603:10b6:303:2d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Mon, 14 Dec 2020 01:31:19 +0000 Received: from MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::bd78:5a79:d875:65e4]) by MWHPR11MB1805.namprd11.prod.outlook.com ([fe80::bd78:5a79:d875:65e4%12]) with mapi id 15.20.3654.024; Mon, 14 Dec 2020 01:31:19 +0000 From: "Heng Luo" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH] UpXtreme: Enable USB DCI debug Thread-Topic: [PATCH] UpXtreme: Enable USB DCI debug Thread-Index: AQHWvv1GdX6bBPxN1E++zIOc+k6Vn6nupnawgAdNCGA= Date: Mon, 14 Dec 2020 01:31:19 +0000 Message-ID: References: <20201120052316.3707-1-heng.luo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e1085d8-7332-4497-9a59-08d89fcff565 x-ms-traffictypediagnostic: MW3PR11MB4522: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2sA00BvKTGzo+oZlNfqarYQ/L7zEtdl9mxqYgtTnvuTmhWmHMSxf0DKuhatuw93dX4uLg8VlZaeZACh41YOPbTMQmmQ5kQquyuXp355aVnwEn/3+ZAdxaqJd3H8J7kogRSv+BL4Fk9QY30cC1hDKpMnBDWkuH+L2eXrgkol7FM9o5ucLRGZrm8JzPRtO73yzDSOCH1PsqG2zkOwset8FkyF/TzCg7jOc0O3vIw1MizgcNnQOR1jPzCaobMm4UrqAZrMO0Zdez/SQ4WuydxZbIqRop4Y4fIQ4Vo9IKcmAk2dw6/YY9+5Dgm/AkNhvci329/9gp1NR9r2LSQIIhmQ+64Pp23MZGvfbkNAHb2v6zU0KtVaLhdq9nkBDxvp+gbZBv5B1yH8yaa0bGd80zfKDQg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1805.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(346002)(376002)(366004)(66476007)(52536014)(966005)(508600001)(66446008)(66556008)(5660300002)(4326008)(107886003)(55016002)(66946007)(9686003)(26005)(64756008)(76116006)(19627235002)(71200400001)(8936002)(86362001)(53546011)(6506007)(110136005)(8676002)(33656002)(2906002)(83380400001)(186003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ETaWHDNaaJt4+y1cZpeafPN+/tlbiT77W8ERGAfYFNwLI3SbhxIAaKxulQA1?= =?us-ascii?Q?SyHD18OY0uFOOX2AclGUVBsL02aqv6ZVxzKGtsFkIVf9U8jEK77oPULblISs?= =?us-ascii?Q?8gtt+N3eled0dSa4cvZQifUdInH/QX4magRvEc1ENTrTT87TE1hycAvyhvOQ?= =?us-ascii?Q?VOIbCfvxGnIbhC68Uuj0zjM8GTSG4H/CNvSpkub8m26ugzLAK+UCQz/6eZXd?= =?us-ascii?Q?tWyDW8umgvwSwqRT4WIvs33J1nE1IGHtxv+auI77Q8xmvOOoXVQS+wPnJmDH?= =?us-ascii?Q?RcbAhINoGDGiyjpAUKIXkJpU8Qmh9OsgzRyDYsPYP0R9/NEo/pM4PwlF7IJt?= =?us-ascii?Q?IXs9c1ztEseQhJU5rRfzwU3w+ZoOhmLqe43wr/12H6FFv5LKgiLjVjKzIv2S?= =?us-ascii?Q?dzjYk0LXfhA0LQgvvEdYxQ3J7kttkQ1+pGKeQIshKL72KzUPD47GYFY8LWVW?= =?us-ascii?Q?ac0GsKMk+aSZsPcwPB6/d48ovLp8OwCtU487xm0tOs+Dq9gwl8HUCirpkeW7?= =?us-ascii?Q?1MPIFn3jgc8DPBSQ2el03b2LAP1OfFvLr6/J7MsGISQomBQQHAJFbZ87S24q?= =?us-ascii?Q?UeT7WRH6s8Ht5ig5IRmXN8qzYBA/QowrAv6+oU1Ba/n9F5XA2tNGLFyhQTIy?= =?us-ascii?Q?j9q9Ij3Frl44lu8uZOjC+i+Ryg/x0tEx28qqaLecMSAwc+0PZaYC3KCsBx1T?= =?us-ascii?Q?1Bc+ajQ0Fw1yr7rJIjtjpBzYyGrqc2vHmqFE6u7sga3su/FmM7T6VKZEOAM9?= =?us-ascii?Q?NObucqYVXwEQ+BjX8woSFNlpasdM+7PSj82/rdfFmFIt6yYP1+FKFavsYMMw?= =?us-ascii?Q?+t/AvtKmty04sei9N86TAHqEIi9gpWN2JGmqYaCMNtKtd6RBsRBESklzhClB?= =?us-ascii?Q?5jsr2SqE9Zj9LS+QCzC6Ht8WPwIHp0dEc1EWGG2UFmGmxyqV59/43vz4MKZ0?= =?us-ascii?Q?xjU0d6hLfCNLlU7dWvURyn4K+jKj0V3IQnqkgPARN/g=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1805.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e1085d8-7332-4497-9a59-08d89fcff565 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2020 01:31:19.6408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xyOZz0xEriRMmt2MQwQIE7PlhhOkHhnnSucDZ+bDhsZTahxkgAJmH4DCTgwt11odOw8wLZ3yvxc6GlOctWOdpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4522 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank Nate, I will send out patch V2 for review. > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, December 9, 2020 6:30 PM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: RE: [PATCH] UpXtreme: Enable USB DCI debug >=20 > Hi Heng, >=20 > Please add a DynamicEx PCD to control the enable/disable of DCI to > WhiskeyLakeOpenBoardPkg. It is probably not a good idea from a security > standpoint to have the default configuration leave JTAG enabled and open. > Other than that, look's good! >=20 > Thanks, > Nate >=20 > > -----Original Message----- > > From: Luo, Heng > > Sent: Thursday, November 19, 2020 9:23 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > > > Subject: [PATCH] UpXtreme: Enable USB DCI debug > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 > > > > Allow to debug BIOS via DCI cable. > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Signed-off-by: Heng Luo > > --- > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLi > > b/PeiPchPolicyUpdatePreMem.c | 1 - > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > > dConfigLib/PeiCpuPolicyBoardConfig.c | 5 +++++ > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > > dConfigLib/PeiPchPolicyBoardConfigPreMem.c | 7 +++++++ > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar > > dConfigLib/PeiPolicyBoardConfigLib.inf | 1 + > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol > > icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c | 6 ++++++ > > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol > > icyBoardConfigLib/PeiPolicyBoardConfigLib.inf | 1 + > > 6 files changed, 20 insertions(+), 1 deletion(-) > > > > diff --git > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > e > > Lib/PeiPchPolicyUpdatePreMem.c > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > e > > Lib/PeiPchPolicyUpdatePreMem.c > > index 2d48b09175..ac5b583f89 100644 > > --- > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > e > > Lib/PeiPchPolicyUpdatePreMem.c > > +++ > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > e > > Lib/PeiPchPolicyUpdatePreMem.c > > @@ -83,7 +83,6 @@ UpdatePeiPchPolicyPreMem ( > > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, > > &gIshPreMemConfigGuid, (VOID *) &IshPreMemConfig); > > > > ASSERT_EFI_ERROR (Status); > > > > > > > > - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; > > > > PchTraceHubPreMemConfig->MemReg0Size =3D 3; > > > > PchTraceHubPreMemConfig->MemReg1Size =3D 3; > > > > // > > > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiCpuPolicyBoardConfig.c > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiCpuPolicyBoardConfig.c > > index d1d1920823..d4c5136c0a 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiCpuPolicyBoardConfig.c > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiCpuPolicyBoardConfig.c > > @@ -44,6 +44,11 @@ UpdatePeiCpuPolicyBoardConfig ( > > Status =3D GetConfigBlock ((VOID *) SiPolicyPpi, &gCpuConfigGuid, > > (VOID *) &CpuConfig); > > > > ASSERT_EFI_ERROR (Status); > > > > > > > > + // > > > > + //Enable processor debug features > > > > + // > > > > + CpuConfig->DebugInterfaceEnable =3D 1; > > > > + > > > > return Status; > > > > } > > > > > > > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > index 01bb75525b..c79718f4ee 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > @@ -25,12 +25,19 @@ UpdatePeiPchPolicyBoardConfigPreMem ( { > > > > EFI_STATUS Status; > > > > PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; > > > > + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; > > > > > > > > DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre > > Mem\n")); > > > > > > > > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > > &gPchGeneralPreMemConfigGuid, (VOID *) &PchGeneralPreMemConfig); > > > > ASSERT_EFI_ERROR (Status); > > > > > > > > + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > > &gDciPreMemConfigGuid, (VOID *) &DciPreMemConfig); > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + DciPreMemConfig->PlatformDebugConsent =3D 3; > > > > + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1; > > > > + > > > > return Status; > > > > } > > > > > > > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPolicyBoardConfigLib.inf > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPolicyBoardConfigLib.inf > > index aaf0abbf04..affb322c59 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPolicyBoardConfigLib.inf > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBo > > ardConfigLib/PeiPolicyBoardConfigLib.inf > > @@ -54,6 +54,7 @@ > > gPchGeneralConfigGuid ## CONSUMES > > > > gEfiTpmDeviceInstanceTpm20DtpmGuid > > > > gEfiTpmDeviceInstanceTpm12Guid > > > > + gDciPreMemConfigGuid > > > > > > > > [Ppis] > > > > gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES > > > > diff --git > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > index 00cf73dfd9..5d75bc5e1c 100644 > > --- > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > +++ > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c > > @@ -25,12 +25,18 @@ UpdatePeiPchPolicyBoardConfigPreMem ( { > > > > EFI_STATUS Status; > > > > PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; > > > > + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; > > > > > > > > DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre > > Mem\n")); > > > > > > > > Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > > &gPchGeneralPreMemConfigGuid, (VOID *) &PchGeneralPreMemConfig); > > > > ASSERT_EFI_ERROR (Status); > > > > > > > > + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, > > &gDciPreMemConfigGuid, (VOID *) &DciPreMemConfig); > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; > > > > + > > > > return Status; > > > > } > > > > > > > > diff --git > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > > index 15ef223050..5de11d62e4 100644 > > --- > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > > +++ > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Pei > > PolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf > > @@ -54,6 +54,7 @@ > > gPchGeneralConfigGuid ## CONSUMES > > > > gEfiTpmDeviceInstanceTpm20DtpmGuid > > > > gEfiTpmDeviceInstanceTpm12Guid > > > > + gDciPreMemConfigGuid > > > > > > > > [Ppis] > > > > gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES > > > > -- > > 2.24.0.windows.2